Re: [Mesa-dev] [PATCH v6] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-17 Thread Kenneth Graunke
On Friday, February 06, 2015 04:00:10 PM Eric Anholt wrote: v2: Rebase on the nir_opcodes.h python code generation support. v3: Use SSA values, and set an appropriate writemask on dot products. v4: Make the arguments be SSA references as well. This lets you stack up expressions in the

Re: [Mesa-dev] [PATCH v6] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-17 Thread Connor Abbott
Ok, so I think there are two things left that I'm going to ask for: 1) Add a nir_builder_init(nir_builder *, nir_function_impl *), nir_builder_insert_after_cf_list(nir_builder *, exec_list *), and if you feel like it (you could use it in tgsi - nir) a helper function

Re: [Mesa-dev] [PATCH v6] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-17 Thread Olivier Galibert
Hi, I thought mesa was C++ by now? That API is really C-ish. OG. On Wed, Feb 18, 2015 at 2:12 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Friday, February 06, 2015 04:00:10 PM Eric Anholt wrote: v2: Rebase on the nir_opcodes.h python code generation support. v3: Use SSA values,

[Mesa-dev] [PATCH v6] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-06 Thread Eric Anholt
v2: Rebase on the nir_opcodes.h python code generation support. v3: Use SSA values, and set an appropriate writemask on dot products. v4: Make the arguments be SSA references as well. This lets you stack up expressions in the arguments of other expressions, at the cost of having to insert