Re: [Mesa-dev] [PATCH v6 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

2017-07-17 Thread Nicolai Hähnle
On 17.07.2017 04:32, Gert Wollny wrote: Just a few comments while updating the patch: One more comment about the debug_log: as written, it will getenv every time. It would be better to use the approach taken by e.g. should_clone_nir() in compiler/nir/nir.h. There's no reason to have a whole

Re: [Mesa-dev] [PATCH v6 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

2017-07-17 Thread Gert Wollny
Just a few comments while updating the patch: > One more comment about the debug_log: as written, it will getenv  > every time. It would be better to use the approach taken by e.g.  > should_clone_nir() in compiler/nir/nir.h. There's no reason to have  > a whole class for this. Actually, 

Re: [Mesa-dev] [PATCH v6 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

2017-07-16 Thread Nicolai Hähnle
On 04.07.2017 16:18, Gert Wollny wrote: This patch adds a class for tracking the life times of temporary registers in the glsl to tgsi translation. The algorithm runs in three steps: First, in order to minimize the number of needed memory allocations the program is scanned to evaluate the number

[Mesa-dev] [PATCH v6 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

2017-07-04 Thread Gert Wollny
This patch adds a class for tracking the life times of temporary registers in the glsl to tgsi translation. The algorithm runs in three steps: First, in order to minimize the number of needed memory allocations the program is scanned to evaluate the number of scopes. Then, the program is scanned