Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
I think it we should keep it in src/mapi/glapi/gen since there are all other generated glapi files. There's also glapi_x86.S, glapi_x86-64.S and glapi_sparc.S which are conditionally built too. Could you take a look at v2? It would be nice if you could test it on Darwin. Thanks, Andreas

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
2015-12-09 18:07 GMT+01:00 Emil Velikov : > On 9 December 2015 at 14:11, Andreas Boll wrote: >> Removes the public symbol _glapi_create_table_from_handle from >> libGL.so.1 on all plattforms except Darwin. >> > typo -> platforms > fixed in v2

[Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Andreas Boll
Removes the public symbol _glapi_create_table_from_handle from libGL.so.1 on all plattforms except Darwin. Since the symbol is not used on other plattforms it makes sense to build gl_gentable.c only on Darwin. A little bit of history: _glapi_create_table_from_handle was introduced in commit

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 14:11, Andreas Boll wrote: > Removes the public symbol _glapi_create_table_from_handle from > libGL.so.1 on all plattforms except Darwin. > typo -> platforms > Since the symbol is not used on other plattforms it makes sense to ditto > build

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Jeremy Huddleston Sequoia
The general concept of this change seems fine to me. Given the desire to keep glapi as similar as possible across platforms, would it be better to just move this into glx/apple rather than leaving it in glapi? > On Dec 9, 2015, at 09:07, Emil Velikov wrote: > > On 9