Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-28 Thread Hans de Goede
Hi, On 28-04-16 10:13, Pierre Moreau wrote: On 05:43 PM - Apr 27 2016, Samuel Pitoiset wrote: On 04/27/2016 05:24 PM, Ilia Mirkin wrote: On Wed, Apr 27, 2016 at 11:19 AM, Hans de Goede wrote: Hi, On 27-04-16 16:49, Ilia Mirkin wrote: Please add this semantic to

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-28 Thread Pierre Moreau
On 05:43 PM - Apr 27 2016, Samuel Pitoiset wrote: > > > On 04/27/2016 05:24 PM, Ilia Mirkin wrote: > >On Wed, Apr 27, 2016 at 11:19 AM, Hans de Goede wrote: > >>Hi, > >> > >>On 27-04-16 16:49, Ilia Mirkin wrote: > >>> > >>>Please add this semantic to src/gallium/docs and

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-27 Thread Samuel Pitoiset
On 04/27/2016 05:24 PM, Ilia Mirkin wrote: On Wed, Apr 27, 2016 at 11:19 AM, Hans de Goede wrote: Hi, On 27-04-16 16:49, Ilia Mirkin wrote: Please add this semantic to src/gallium/docs and explain what it means. Ah, I was under the impression these were not

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-27 Thread Ilia Mirkin
On Wed, Apr 27, 2016 at 11:19 AM, Hans de Goede wrote: > Hi, > > On 27-04-16 16:49, Ilia Mirkin wrote: >> >> Please add this semantic to src/gallium/docs and explain what it >> means. > > > Ah, I was under the impression these were not documented, but I > now see they are,

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-27 Thread Hans de Goede
Hi, On 27-04-16 16:49, Ilia Mirkin wrote: Please add this semantic to src/gallium/docs and explain what it means. Ah, I was under the impression these were not documented, but I now see they are, will fix. > (I'm not even sure what this is, and the easily-found opencl docs helpfully

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-27 Thread Ilia Mirkin
Please add this semantic to src/gallium/docs and explain what it means. (I'm not even sure what this is, and the easily-found opencl docs helpfully indicate that get_work_dim returns the work_dim...) This wasn't done for some of the other compute-specific semantics. Is this the equivalent of

[Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

2016-04-27 Thread Hans de Goede
Add a new WORK_DIM SV type, this is will return the grid dimensions (1-4) for compute (opencl) kernels. This is necessary to implement the opencl get_work_dim() function. Signed-off-by: Hans de Goede --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 +