Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-06 Thread Emil Velikov
Hi Rob, On 6 July 2018 at 09:58, Robert Foss wrote: >> >> You can trivially eliminate the goto statement here. >> > > As Tomasz noted this fallback is already implemented in egldriver.c, > so it can be removed entirely. > Right forgot about that one. Currently we have the fallback in

Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-06 Thread Robert Foss
Hey Emil, On 05/07/18 15:04, Emil Velikov wrote: Hi Rob, On 5 July 2018 at 11:07, Robert Foss wrote: Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also enabled as

Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-06 Thread Robert Foss
Hey Tomasz, On 05/07/18 16:26, Tomasz Figa wrote: Hi Rob, On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote: Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also

Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-05 Thread Tomasz Figa
Hi Rob, On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote: > > Add support for the ForceSoftware option, which is togglable > on the Android platform through setting the "drm.gpu.force_software" > property to a non-zero value. > > kms_swrast is also enabled as a fallback for when a driver is not

Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-05 Thread Emil Velikov
Hi Rob, On 5 July 2018 at 11:07, Robert Foss wrote: > Add support for the ForceSoftware option, which is togglable > on the Android platform through setting the "drm.gpu.force_software" > property to a non-zero value. > > kms_swrast is also enabled as a fallback for when a driver is not > able

[Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

2018-07-05 Thread Robert Foss
Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also enabled as a fallback for when a driver is not able to be loaded for for a drm node that was opened. Signed-off-by: