Re: [Mesa-dev] Adaptive Vsync

2015-09-09 Thread Lauri Kasanen
On Wed, 9 Sep 2015 09:11:50 -0400 Alex Deucher wrote: > > Oh, absolutely - I had no issues with "this needs changing". My issue > > was with the fact it took months to get that. Had I come up with a new > > patch, it would likely have taken a similar time, months again,

Re: [Mesa-dev] Adaptive Vsync

2015-09-09 Thread Alex Deucher
On Sun, Sep 6, 2015 at 4:28 AM, Lauri Kasanen wrote: > On Sat, 5 Sep 2015 23:29:05 + > Albert Freeman wrote: > >> The reply from Eric Anholt made two suggestions that should not be >> difficult to implement for someone who made the patch in the first

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Emil Velikov
On 7 September 2015 at 05:59, Albert Freeman wrote: > Correction, we just need someone to mark all the comitted patches in > patchwork... This is already done automatically. Sigh top posting :'(. -Emil ___ mesa-dev mailing

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Martin Peres
On 07/09/15 11:22, Emil Velikov wrote: On 7 September 2015 at 05:59, Albert Freeman wrote: Correction, we just need someone to mark all the comitted patches in patchwork... This is already done automatically. Sigh top posting :'(. -Emil I often have to help

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Albert Freeman
On 7 September 2015 at 08:22, Emil Velikov wrote: > On 7 September 2015 at 05:59, Albert Freeman > wrote: >> Correction, we just need someone to mark all the comitted patches in >> patchwork... > This is already done automatically. > > Sigh

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Albert Freeman
On 8 September 2015 at 01:16, Albert Freeman wrote: > On 7 September 2015 at 08:22, Emil Velikov wrote: >> On 7 September 2015 at 05:59, Albert Freeman >> wrote: >>> Correction, we just need someone to mark all the

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
Correction, we just need someone to mark all the comitted patches in patchwork so that we can easily pick out the ones with issues. On 7 September 2015 at 04:56, Albert Freeman wrote: > Oops, my "plan" focuses on patches that have nothing wrong with them, > instead of

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
Oops, my "plan" focuses on patches that have nothing wrong with them, instead of patches that have something wrong with them (which is the problem). It is lack of reviews, not lack of commits. I have no idea how I got so confused. Basically we need the inverse of patchwork. On 6 September 2015 at

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Lauri Kasanen
On Sat, 5 Sep 2015 23:29:05 + Albert Freeman wrote: > The reply from Eric Anholt made two suggestions that should not be > difficult to implement for someone who made the patch in the first > place. Why would code be committed when improvements could be easily >

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
Ah, okay. I see what you mean now (i.e. you had to wait three months for those suggestions I mentioned). I still haven't recieved a response at all for my first patch from almost a year ago (although it was insanely trivial). So it isn't just you :) Committers simply don't have the time to find

[Mesa-dev] Adaptive Vsync

2015-09-05 Thread Benjamin Bellec
Hello Lauri, I saw that your patch implementing adaptive vsync is not committed to mesa. Ref, http://lists.freedesktop.org/archives/mesa-dev/2013-December/050184.html Why not ? Is there any issue with it ? As a end user, adaptive vsync seems a nice feature. But maybe I'm not aware of drawbacks.

Re: [Mesa-dev] Adaptive Vsync

2015-09-05 Thread Lauri Kasanen
On Sat, 5 Sep 2015 15:41:00 +0200 Benjamin Bellec wrote: > Hello Lauri, > > I saw that your patch implementing adaptive vsync is not committed to mesa. > Ref, > http://lists.freedesktop.org/archives/mesa-dev/2013-December/050184.html > > Why not ? Is there any issue with it

Re: [Mesa-dev] Adaptive Vsync

2015-09-05 Thread Albert Freeman
The reply from Eric Anholt made two suggestions that should not be difficult to implement for someone who made the patch in the first place. Why would code be committed when improvements could be easily made? From what I have seen, this kind of thing happens even to experienced mesa developers who