Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-18 Thread Nicolai Hähnle
On 18.04.2017 18:57, Marek Olšák wrote: We also have asynchronous compilation for optimized shaders (linking separate shaders etc.) using the same threaded queue as the initial compilations, and we can't let apps suppress the optimized ones. Good point. I think if the app says it doesn't want p

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-18 Thread Marek Olšák
We also have asynchronous compilation for optimized shaders (linking separate shaders etc.) using the same threaded queue as the initial compilations, and we can't let apps suppress the optimized ones. Marek On Apr 18, 2017 1:08 PM, "Nicolai Hähnle" wrote: > On 17.04.2017 14:07, Edward O'Callag

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-18 Thread Nicolai Hähnle
On 17.04.2017 14:07, Edward O'Callaghan wrote: Hi folks, This is my early draft on the threaded shader compile "suggestion" thread. The requirements according the spec are rather weak as it is up to the implementation, which frankly can even just ignore the requested thread count. However, afaik

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Ilia Mirkin
On Mon, Apr 17, 2017 at 7:55 PM, Edward O'Callaghan wrote: > > > On 04/18/2017 12:22 AM, Ilia Mirkin wrote: >> The whole point of this extension is to allow applications to query >> compilation status without stalling, waiting for the compile. That >> means that glCompileShader/glLinkProgram shoul

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Edward O'Callaghan
On 04/18/2017 12:22 AM, Ilia Mirkin wrote: > The whole point of this extension is to allow applications to query > compilation status without stalling, waiting for the compile. That > means that glCompileShader/glLinkProgram should return immediately Right, my question though is, what happens if

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Ilia Mirkin
The whole point of this extension is to allow applications to query compilation status without stalling, waiting for the compile. That means that glCompileShader/glLinkProgram should return immediately while the real work proceeds in the background. I don't think you've done that here. As an aside

[Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Edward O'Callaghan
Hi folks, This is my early draft on the threaded shader compile "suggestion" thread. The requirements according the spec are rather weak as it is up to the implementation, which frankly can even just ignore the requested thread count. However, afaik in the case of radeonsi it is already threaded.