Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-23 Thread Brian Paul
On 05/23/2019 02:48 AM, Erik Faye-Lund wrote: On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: Hi Erik, Le 22 mai 2019 à 08:54, Erik Faye-Lund < erik.faye-l...@collabora.com> a écrit : I ended up reverting the change [from-%error-verbose to %define parse.error verbose] , and I can't

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-23 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: > Hi Erik, > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> a écrit : > > > > I ended up reverting the change [from-%error-verbose to %define > > parse.error verbose] , and I can't find an obcious way to > >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-23 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 20:41 +0200, Akim Demaille wrote: > > Le 22 mai 2019 à 18:06, Akim Demaille a écrit > > : > > > > Hi Erik, > > > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > > erik.faye-l...@collabora.com> a écrit : > > > The Android SDK also ships a pre-3.x version of Bison, so

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Akim Demaille
Hi Erik, > Le 22 mai 2019 à 08:54, Erik Faye-Lund a écrit > : > > I ended up reverting the change [from-%error-verbose to %define parse.error > verbose] , and I can't find an obcious way to > support both old and new versions with the same source file. Well, you just disable warnings about

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Akim Demaille
> Le 22 mai 2019 à 18:06, Akim Demaille a écrit : > > Hi Erik, > >> Le 22 mai 2019 à 08:54, Erik Faye-Lund a >> écrit : >> The Android SDK also ships a pre-3.x version of Bison, so you're not >> the only one affected. Also, Chocolatey doesn't provide a new enough >> version of Bison for

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 15:21 +0200, Hans Åberg wrote: > > On 22 May 2019, at 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> wrote: > > > > The problem is that Bison doesn't seem to have any mechanism for > > doing > > statements like these conditionally. The only way around that that >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Erik Faye-Lund
I ended up reverting the change, and I can't find an obcious way to support both old and new versions with the same source file. The Android SDK also ships a pre-3.x version of Bison, so you're not the only one affected. Also, Chocolatey doesn't provide a new enough version of Bison for Windows

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Erik Faye-Lund
Right. I guess with an old enough bison version, this can happen. I'll see if I can come up with something better.On May 21, 2019 15:47, Brian Paul wrote:I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Brian Paul
I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41 AM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a URL: