Re: [Mesa-dev] nir_opt_copy_prop_vars doing the wrong thing

2019-05-21 Thread Dave Airlie
https://gitlab.freedesktop.org/airlied/mesa/tree/nir-copy-props-cast-test Contains a unit test that triggers it for me. Dave. On Sat, 11 May 2019 at 09:54, Jason Ekstrand wrote: > > We have unit tests for that pass. Maybe you could write one which exercises > the issue? It'd help in

Re: [Mesa-dev] nir_opt_copy_prop_vars doing the wrong thing

2019-05-10 Thread Jason Ekstrand
We have unit tests for that pass. Maybe you could write one which exercises the issue? It'd help in debugging. On Thu, May 9, 2019 at 8:12 PM Dave Airlie wrote: > I've got a bunch of cases where copy prop vars is getting things wrong > around casts, it finds a store to an vec2 but ends up

[Mesa-dev] nir_opt_copy_prop_vars doing the wrong thing

2019-05-09 Thread Dave Airlie
I've got a bunch of cases where copy prop vars is getting things wrong around casts, it finds a store to an vec2 but ends up with the writemask staying at 0x3 but the item being store being a single 64-bit. Debug is attached below. Dave. nir_lower_memcpy_deref shader: MESA_SHADER_KERNEL