Re: [Mesa-dev] panfrost: Questions regarding pan_wallpaper.c (and the 'reload FB content' logic in general)

2019-05-03 Thread Alyssa Rosenzweig
> Actually, I tried several things, so I might have left it flipped at > some point, but it doesn't work with with src_factor=one and > dts_factor=zero. Hum. > Good question. I haven't dumped the buffers yet. Another thing to note: > the texture I'm reloading from is using

Re: [Mesa-dev] panfrost: Questions regarding pan_wallpaper.c (and the 'reload FB content' logic in general)

2019-05-03 Thread Boris Brezillon
On Fri, 3 May 2019 07:29:22 -0700 Alyssa Rosenzweig wrote: > > +else if (!(job->clear & PIPE_CLEAR_COLOR)) > > Make sure this is actually being called when you expect. I don't > remember if job->clear is being zeroed when we expect (hint: it might > not be due to a missing job_free

Re: [Mesa-dev] panfrost: Questions regarding pan_wallpaper.c (and the 'reload FB content' logic in general)

2019-05-03 Thread Alyssa Rosenzweig
> +else if (!(job->clear & PIPE_CLEAR_COLOR)) Make sure this is actually being called when you expect. I don't remember if job->clear is being zeroed when we expect (hint: it might not be due to a missing job_free routine somewhere, *blush*). > + .rt[0].rgb_func =

[Mesa-dev] panfrost: Questions regarding pan_wallpaper.c (and the 'reload FB content' logic in general)

2019-05-03 Thread Boris Brezillon
Hello Alyssa, This week I've tried to make the wallpapering logic to work on panfrost but I'm not quite there yet. I've done all my tests with weston that tries to use buffer_age and update only the parts that have changed (which I know is inefficient, but before implementing partial_update() I