Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Dully noted, thanks for the heads up. On July 25, 2017 12:50:22 PM EDT, "Marek Olšák" wrote: >Hi Jeremy, > >Note that addrlib is imported from our internal repository. Any >changes to addrlib in Mesa may make later updates from the internal >repository more difficult. It would

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Hi Jeremy, Note that addrlib is imported from our internal repository. Any changes to addrlib in Mesa may make later updates from the internal repository more difficult. It would be preferable to apply changes to the internal addrlib first and Mesa would get them on the next addrlib update. I

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Fair enough. Although from my tests with x86-64 GCC 6.3 (Fedora 25), it did produce a slightly smaller binary with this patch. With that said, I only used whatever the default optimization flags are, and I didn't do a diff on a disasm to see what actually changed. On Mon, Jul 24, 2017 at 1:03

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

On 23.07.2017 18:24, Mystro256 wrote: --- src/amd/addrlib/core/addrobject.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/addrlib/core/addrobject.cpp b/src/amd/addrlib/core/addrobject.cpp index dcdb1bf..ee2d9a9 100644 ---