Re: [Mesa-dev] [PATCH] docs: advice to resolve discussion on gitlab MR doc

On 16/5/19 13:35, Eric Engestrom wrote: On Thursday, 2019-05-16 13:14:46 +0200, Connor Abbott wrote: Some grammar nits: - "Resolve Discussion" goes before "button" as it modifies it. - It's either "This way..." or "In this manner...", not "In this way...", although the latter is a little too

Re: [Mesa-dev] [PATCH] docs: advice to resolve discussion on gitlab MR doc

On Thursday, 2019-05-16 13:14:46 +0200, Connor Abbott wrote: > Some grammar nits: > > - "Resolve Discussion" goes before "button" as it modifies it. > - It's either "This way..." or "In this manner...", not "In this > way...", although the latter is a little too stilted/over-formal here. > - This

Re: [Mesa-dev] [PATCH] docs: advice to resolve discussion on gitlab MR doc

Some grammar nits: - "Resolve Discussion" goes before "button" as it modifies it. - It's either "This way..." or "In this manner...", not "In this way...", although the latter is a little too stilted/over-formal here. - This isn't a hypothetical or another situation where "would know..." is