Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 Thread Chih-Wei Huang
2018-04-27 1:34 GMT+08:00 Rob Herring : > On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov > wrote: >> On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >>> 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Velikov wrote: > > On 24 Apr

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 Thread Chih-Wei Huang
2018-04-27 2:19 GMT+08:00 Robert Foss : > > I've spent some time today preparing a #ifdef version of what robher > submitted. > > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC > #define through the build tools. So a small simple patch adding the shared > library dependenc

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Tomasz Figa
Hi Rob, On Fri, Apr 27, 2018 at 12:43 PM Chih-Wei Huang wrote: > 2018-04-27 2:19 GMT+08:00 Robert Foss : > > > > I've spent some time today preparing a #ifdef version of what robher > > submitted. > > > > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC > > #define through

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Robert Foss
On 04/26/2018 07:43 PM, Emil Velikov wrote: On 26 April 2018 at 18:34, Rob Herring wrote: On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote: On 26 April 2018 at 03:30, Chih-Wei Huang wrote: 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Vel

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 18:34, Rob Herring wrote: > On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov > wrote: >> On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >>> 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Velikov wrote: > > On

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Rob Herring
On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote: > On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >> 2018-04-25 19:55 GMT+08:00 Robert Foss : >>> Hey Emil & Chih-Wei, >>> >>> On 04/24/2018 01:59 PM, Emil Velikov wrote: On 24 April 2018 at 12:28, Emil Velikov wrote: > On

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 03:30, Chih-Wei Huang wrote: > 2018-04-25 19:55 GMT+08:00 Robert Foss : >> Hey Emil & Chih-Wei, >> >> On 04/24/2018 01:59 PM, Emil Velikov wrote: >>> >>> On 24 April 2018 at 12:28, Emil Velikov wrote: >>> On the topic of keeping the old code behind a #define or just remov

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Chih-Wei Huang
2018-04-25 19:55 GMT+08:00 Robert Foss : > Hey Emil & Chih-Wei, > > On 04/24/2018 01:59 PM, Emil Velikov wrote: >> >> On 24 April 2018 at 12:28, Emil Velikov wrote: >> >>> On the topic of keeping the old code behind a #define or just removing >>> it, it'll be great if interested parties can reach

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-25 Thread Robert Foss
Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Velikov wrote: On 24 April 2018 at 12:28, Emil Velikov wrote: On the topic of keeping the old code behind a #define or just removing it, it'll be great if interested parties can reach a consensus. Actually one can simply drop this code and

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Emil Velikov
On 24 April 2018 at 12:28, Emil Velikov wrote: > On the topic of keeping the old code behind a #define or just removing > it, it'll be great if interested parties can reach a consensus. > Actually one can simply drop this code and drm_gralloc users can add a drm_ioctl_permit() hack. Namely: loose

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Emil Velikov
Hi Rob, Thanks for doing this. There's a couple of small nits, but the patch looks good IMHO. On the topic of keeping the old code behind a #define or just removing it, it'll be great if interested parties can reach a consensus. On 19 April 2018 at 22:09, Rob Herring wrote: > --- a/src/egl/dr

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Tomasz Figa
On Tue, Apr 24, 2018 at 4:26 PM Robert Foss wrote: > Hey Chih-Wei, > On 04/23/2018 04:17 AM, Chih-Wei Huang wrote: > > What's the impact to drm_gralloc? > I'm not terribly familiar with drm_gralloc, but as far as I understand it > depends on flink name support at the moment. > The overarching

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Robert Foss
Hey Chih-Wei, On 04/23/2018 04:17 AM, Chih-Wei Huang wrote: What's the impact to drm_gralloc? I'm not terribly familiar with drm_gralloc, but as far as I understand it depends on flink name support at the moment. The overarching idea here is to make mesa gralloc independent, but also at the

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-22 Thread Chih-Wei Huang
What's the impact to drm_gralloc? 2018-04-20 5:09 GMT+08:00 Rob Herring : > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header. > > This mostly remo

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-20 Thread Rob Herring
On Fri, Apr 20, 2018 at 6:29 AM, Robert Foss wrote: > Hey Rob, > > This looks good to me. > Do you mind if I carry this patch my series to get it all pushed upstream at > once? No, not at all. Rob ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-20 Thread Robert Foss
Hey Rob, This looks good to me. Do you mind if I carry this patch my series to get it all pushed upstream at once? Rob. On 04/19/2018 11:09 PM, Rob Herring wrote: Maintaining both flink names and prime fd support which are provided by 2 different gralloc implementations is problematic becaus

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-19 Thread Tomasz Figa
Hi Rob, On Fri, Apr 20, 2018 at 6:09 AM Rob Herring wrote: > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header. > This mostly removes the depende