Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Sure, I will. Thanks On Tue, Aug 23, 2016 at 11:39:52AM +0100, Emil Velikov wrote: > Hi Dongwon, > > On 15 August 2016 at 23:20, Dongwon Kim wrote: > > A new patch, "[PATCH] egl/dri2: remove error checks on return values from > > mtx_lock > > and cnd_wait" containing

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Hi Dongwon, On 15 August 2016 at 23:20, Dongwon Kim wrote: > A new patch, "[PATCH] egl/dri2: remove error checks on return values from > mtx_lock > and cnd_wait" containing additional clean-up has been submitted. Please > disregard > this one. > Thanks for the update.

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

A new patch, "[PATCH] egl/dri2: remove error checks on return values from mtx_lock and cnd_wait" containing additional clean-up has been submitted. Please disregard this one. On Thu, Jul 28, 2016 at 02:38:35PM -0700, Dongwon Kim wrote: > This removes unnecessary error checks on return result

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Emil, I just submitted a new patch "[PATCH] egl/dri2: remove error checks on return values from mtx_lock and cnd_wait" that replaces the old one. Please review the new one and disregard the original one, "egl/dri2: Do not need to check return value from mtx_lock". On Mon, Aug 15, 2016 at

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Yes, you are right. It is duplicate EGL_FALSE check and _eglError call in the end of the function.. Also, I don't see any good reason to check return value of cnd_wait (though we still need to check it in timedwait case.). I will prepare a new patch with all of these taken into acocunt. On Mon,

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Hi Kim, On 28 July 2016 at 22:38, Dongwon Kim wrote: > This removes unnecessary error checks on return result of mtx_lock > calls as in all other places in MESA source since there is no chance > that mtx_lock returns any of error codes in current implementation. > >