Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Ander Conselvan de Oliveira
I did a simple test here and the patch worked. I have just a couple of comments. On 05/02/2012 10:32 PM, Kristian Høgsberg wrote: This new gbm entry point allows writing data into a gbm bo. The bo has to be created with the GBM_BO_USE_WRITE flag, and it's only required to work for

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Jakob Bornecrantz
Hi Kristian, s/gbm_bo_write/gbm_bo_write_to_cursor/g and make fail on anything other then cursors and I'm happy. Not making it just happen to work on some hardware really sucks for those that it doesn't work on because people will expect it to work. Cheers, Jakob. - Original Message -

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Kristian Høgsberg
On Thu, May 3, 2012 at 7:05 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: I did a simple test here and the patch worked. I have just a couple of comments. Good points, patch updated. Kristian On 05/02/2012 10:32 PM, Kristian Høgsberg wrote: This new gbm entry point allows

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Kristian Høgsberg
On Thu, May 3, 2012 at 7:47 AM, Jakob Bornecrantz ja...@vmware.com wrote: Hi Kristian, s/gbm_bo_write/gbm_bo_write_to_cursor/g and make fail on anything other then cursors and I'm happy. Not making it just happen to work on some hardware really sucks for those that it doesn't work on because

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Jakob Bornecrantz
- Ursprungligt meddelande - On Thu, May 3, 2012 at 7:47 AM, Jakob Bornecrantz ja...@vmware.com wrote: Hi Kristian, s/gbm_bo_write/gbm_bo_write_to_cursor/g and make fail on anything other then cursors and I'm happy. Not making it just happen to work on some hardware really sucks

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Jakob Bornecrantz
- Ursprungligt meddelande - This new gbm entry point allows writing data into a gbm bo. The bo has to be created with the GBM_BO_USE_WRITE flag, and it's only required to work for GBM_BO_USE_CURSOR_64X64 bos. The gbm API is designed to be the glue layer between EGL and KMS, but

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Kristian Høgsberg
On Thu, May 3, 2012 at 5:08 PM, Mandeep Baines mandeep.bai...@gmail.com wrote: 2012/5/2 Kristian Høgsberg k...@bitplanet.net: This new gbm entry point allows writing data into a gbm bo.  The bo has to be created with the GBM_BO_USE_WRITE flag, and it's only required to work for