Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-10 Thread Eric Anholt
On Thu, 09 Feb 2012 17:27:14 -0800, Ian Romanick i...@freedesktop.org wrote: On 02/06/2012 03:08 PM, Eric Anholt wrote: On Fri, 03 Feb 2012 16:09:25 -0700, Ian Romanicki...@freedesktop.org wrote: On 02/03/2012 02:11 AM, Eric Anholt wrote: On Wed, 1 Feb 2012 12:29:39 -0700, Ian

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-09 Thread Ian Romanick
On 02/06/2012 03:08 PM, Eric Anholt wrote: On Fri, 03 Feb 2012 16:09:25 -0700, Ian Romanicki...@freedesktop.org wrote: On 02/03/2012 02:11 AM, Eric Anholt wrote: On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com A

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-06 Thread Eric Anholt
On Fri, 03 Feb 2012 16:09:25 -0700, Ian Romanick i...@freedesktop.org wrote: On 02/03/2012 02:11 AM, Eric Anholt wrote: On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com A similar check was removed in 05ab8fc. The

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-03 Thread Eric Anholt
On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com A similar check was removed in 05ab8fc. The check is not complete redundand because some paths, such as _mesa_meta_check_generate_mipmap_fallback, can get to

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-03 Thread Ian Romanick
On 02/03/2012 02:11 AM, Eric Anholt wrote: On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com A similar check was removed in 05ab8fc. The check is not complete redundand because some paths, such as

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-01 Thread Kenneth Graunke
On 02/01/2012 11:29 AM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com A similar check was removed in 05ab8fc. The check is not complete redundand because some paths, such as _mesa_meta_check_generate_mipmap_fallback, can get to intel_renderbuffer_update_wrapper but not get to