Re: [Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

2018-04-24 Thread Eric Anholt
Eric Anholt writes: > mesa/st decides whether to update samplers after a program change based on > whether num_textures is nonzero. By not counting samplers in a uniform > struct, we would segfault in > KHR-GLES3.shaders.struct.uniform.sampler_vertex if it was run in the same >

Re: [Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

2018-04-02 Thread Jason Ekstrand
Doesn't st/mesa have a pass for getting rid if the structs? On Mon, Apr 2, 2018 at 11:13 AM, Eric Anholt wrote: > mesa/st decides whether to update samplers after a program change based on > whether num_textures is nonzero. By not counting samplers in a uniform > struct, we