Re: [Mesa-dev] [PATCH 00/24] RadeonSI: Massive radeon_surf winsys interface cleanup and more

One small remark on #3 that I'll leave up to you what to do with it. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 25.10.2016 00:33, Marek Olšák wrote: Hi, Most of this series cleans up the radeon_surf-based winsys interface, and texture, fmask, and

Re: [Mesa-dev] [PATCH 00/24] RadeonSI: Massive radeon_surf winsys interface cleanup and more

I think there is a subtle but important SI fix in patch 20 that didn't occur to me: [PATCH 20/24] gallium/radeon: don't force the same tiling parameters for FMASK .. which makes FMASK parameters completely independent of the color surface. It fixes an incorrect value in the FMASK_BANK_HEIGHT