Re: [Mesa-dev] [PATCH 1/1] ac/nir: use ordered float comparisons except for not equal

2018-02-23 Thread Timothy Arceri
Using this on its own I believe will cause CTS regressions, which is what the other patches were about. Feel free to take on the feedback and come up with a proper solution. I'm not really sure how to progress this. On 24/02/18 00:21, Samuel Pitoiset wrote: Original patch from Timothy

Re: [Mesa-dev] [PATCH 1/1] ac/nir: use ordered float comparisons except for not equal

2018-02-23 Thread Connor Abbott
Yes, this is the right ordering for NIR (and GLSL) comparisons. Reviewed-by: Connor Abbott On Fri, Feb 23, 2018 at 8:21 AM, Samuel Pitoiset wrote: > Original patch from Timothy Arceri, I have just fixed the > not equal case locally. > > This