Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-04 Thread Marek Olšák
It should be very easy to move the compression and I/O to another thread using gallium/util/u_queue. It's a perfect match for this kind of thing. Marek On Mar 2, 2017 11:12 PM, "Grigori Goronzy" wrote: > On 2017-03-02 10:08, Timothy Arceri wrote: > >> On 02/03/17 18:45,

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-02 Thread Grigori Goronzy
On 2017-03-02 10:08, Timothy Arceri wrote: On 02/03/17 18:45, Tobias Droste wrote: Hi Timothy, if you plan to support multiple compression algorithms, shouldn't "struct cache_entry_file_data" contain some info about what compression algorithm was used to compress the data? Or is this

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-02 Thread Eero Tamminen
Hi, On 02.03.2017 00:19, Timothy Arceri wrote: ... 2) Do were care about compression ratio? Yes. We currently have a default 1GB limit for the cache (users can override this). As well as games like Deus Ex having a large footprint, the Dolphin devs have reported reaching multiple GBs

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-02 Thread Timothy Arceri
On 02/03/17 18:45, Tobias Droste wrote: Hi Timothy, if you plan to support multiple compression algorithms, shouldn't "struct cache_entry_file_data" contain some info about what compression algorithm was used to compress the data? Or is this already there and I missed it? I don't plan to

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Tobias Droste
Hi Timothy, if you plan to support multiple compression algorithms, shouldn't "struct cache_entry_file_data" contain some info about what compression algorithm was used to compress the data? Or is this already there and I missed it? Am Donnerstag, 2. März 2017, 03:20:05 CET schrieb Matt

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Matt Turner
On Wed, Mar 1, 2017 at 2:19 PM, Timothy Arceri wrote: > IMO we should go with zlib and people can provide future patches with > justifications/stats for using a different library over zlib just like we do > for any other performance based patch. Yes, agreed. "Which

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Timothy Arceri
On 01/03/17 23:58, Steven Newbury wrote: On Wed, 2017-03-01 at 12:38 +0200, Eero Tamminen wrote: Hi, On 01.03.2017 07:25, Timothy Arceri wrote: This reduces the cache size for Deus Ex from ~160M to ~30M for radeonsi. I'm also seeing the following improvements in minimum fps in the Shadow of

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Steven Newbury
On Wed, 2017-03-01 at 12:38 +0200, Eero Tamminen wrote: > Hi, > > On 01.03.2017 07:25, Timothy Arceri wrote: > > This reduces the cache size for Deus Ex from ~160M to ~30M for > > radeonsi. > > > > I'm also seeing the following improvements in minimum fps in the > > Shadow of Mordor benchmark: >

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Grazvydas Ignotas
On Wed, Mar 1, 2017 at 7:25 AM, Timothy Arceri wrote: > ... > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 2a0edca..03aae02 100644 > --- a/src/util/disk_cache.c > +++ b/src/util/disk_cache.c > @@ -30,20 +30,21 @@ > #include > #include > #include

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Eero Tamminen
Hi, On 01.03.2017 07:25, Timothy Arceri wrote: This reduces the cache size for Deus Ex from ~160M to ~30M for radeonsi. I'm also seeing the following improvements in minimum fps in the Shadow of Mordor benchmark: no-cache:~10fps with-cache-no-compression: ~15fps