Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Thu, Sep 8, 2016 at 3:56 AM, Michel Dänzer wrote: > On 07/09/16 11:01 PM, Nicolai Hähnle wrote: >> On 07.09.2016 12:23, Marek Olšák wrote: >>> On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer >>> wrote: On 07/09/16 06:02 PM, Marek Olšák wrote: >

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 07/09/16 11:01 PM, Nicolai Hähnle wrote: > On 07.09.2016 12:23, Marek Olšák wrote: >> On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer >> wrote: >>> On 07/09/16 06:02 PM, Marek Olšák wrote: Based on the comments so far, it looks like all annotations in the

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 07.09.2016 12:23, Marek Olšák wrote: On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer wrote: On 07/09/16 06:02 PM, Marek Olšák wrote: Based on the comments so far, it looks like all annotations in the patch are very well placed, so I don't know what the fuss is about.

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer wrote: > On 07/09/16 06:02 PM, Marek Olšák wrote: >> >> Based on the comments so far, it looks like all annotations in the >> patch are very well placed, so I don't know what the fuss is about. > > As I said, there's no question

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 07/09/16 06:02 PM, Marek Olšák wrote: > > Based on the comments so far, it looks like all annotations in the > patch are very well placed, so I don't know what the fuss is about. As I said, there's no question about the first three annotations, but for the last two we can't know whether they

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Wed, Sep 7, 2016 at 2:23 AM, Michel Dänzer wrote: > On 06/09/16 08:33 PM, Marek Olšák wrote: >> On Sep 6, 2016 12:03 PM, "Michel Dänzer" > > wrote: >>> On 06/09/16 06:04 PM, Marek Olšák wrote: >>> > On Tue, Sep 6, 2016 at 3:54

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Tue, Sep 6, 2016 at 8:23 PM, Michel Dänzer wrote: > On 06/09/16 08:33 PM, Marek Olšák wrote: >> On Sep 6, 2016 12:03 PM, "Michel Dänzer" > > wrote: >>> On 06/09/16 06:04 PM, Marek Olšák wrote: >>> > On Tue, Sep 6, 2016 at 3:54

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 06/09/16 08:33 PM, Marek Olšák wrote: > On Sep 6, 2016 12:03 PM, "Michel Dänzer" > wrote: >> On 06/09/16 06:04 PM, Marek Olšák wrote: >> > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer > wrote: >>

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Sep 6, 2016 12:03 PM, "Michel Dänzer" wrote: > > On 06/09/16 06:04 PM, Marek Olšák wrote: > > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: > >> On 06/09/16 07:46 AM, Marek Olšák wrote: > >>> From: Marek Olšák > >> > >> Did

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 06/09/16 06:04 PM, Marek Olšák wrote: > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: >> On 06/09/16 07:46 AM, Marek Olšák wrote: >>> From: Marek Olšák >> >> Did you measure any significant performance boost with this change? > > I didn't

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: > On 06/09/16 07:46 AM, Marek Olšák wrote: >> From: Marek Olšák > > Did you measure any significant performance boost with this change? I didn't measure anything. > Otherwise, using (un)likely can be

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 3:56 GMT+02:00 Ilia Mirkin : > On Mon, Sep 5, 2016 at 9:54 PM, Michel Dänzer wrote: >> On 06/09/16 07:46 AM, Marek Olšák wrote: >>> From: Marek Olšák >> >> Did you measure any significant performance boost with this

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Mon, Sep 5, 2016 at 9:54 PM, Michel Dänzer wrote: > On 06/09/16 07:46 AM, Marek Olšák wrote: >> From: Marek Olšák > > Did you measure any significant performance boost with this change? > Otherwise, using (un)likely can be bad because it can defeat the

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 06/09/16 07:46 AM, Marek Olšák wrote: > From: Marek Olšák Did you measure any significant performance boost with this change? Otherwise, using (un)likely can be bad because it can defeat the CPU's branch prediction, which tends to be pretty good these days. > - if