Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-24 Thread Mark Janes
Ian Romanick writes: > On 04/23/2018 09:19 AM, Mark Janes wrote: >> I enabled these tests, and could not make them fail in CI. > > Can I consider that a Tested-by? Sorry, I should have been more explicit. Yes, tested-by. >> This bug may also be related: >> >> https://bugs.freedesktop.org/show

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-24 Thread Ian Romanick
On 04/23/2018 09:19 AM, Mark Janes wrote: > I enabled these tests, and could not make them fail in CI. Can I consider that a Tested-by? > This bug may also be related: > > https://bugs.freedesktop.org/show_bug.cgi?id=95009 If none of these tests fail with this patch, I'm included to close them

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-23 Thread Mark Janes
I enabled these tests, and could not make them fail in CI. This bug may also be related: https://bugs.freedesktop.org/show_bug.cgi?id=95009 Ian Romanick writes: > From: Ian Romanick > > Otherwise the scheduler can move the writes after the reads. > > Signed-off-by: Ian Romanick > Bugzilla: h

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-20 Thread Jason Ekstrand
If Ken's good with duct tape then so am I. Rb. On April 20, 2018 17:54:00 Kenneth Graunke wrote: On Friday, April 20, 2018 5:01:17 PM PDT Jason Ekstrand wrote: > On Fri, Apr 20, 2018 at 4:30 PM, Ian Romanick wrote: > > > On 04/20/2018 11:56 AM, Jason Ekstrand wrote: > > > Ugh... I was actual

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-20 Thread Kenneth Graunke
On Friday, April 20, 2018 5:01:17 PM PDT Jason Ekstrand wrote: > On Fri, Apr 20, 2018 at 4:30 PM, Ian Romanick wrote: > > > On 04/20/2018 11:56 AM, Jason Ekstrand wrote: > > > Ugh... I was actually thinking about this the other day. How did you > > > come up with your list of instructions? Is t

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-20 Thread Jason Ekstrand
On Fri, Apr 20, 2018 at 4:30 PM, Ian Romanick wrote: > On 04/20/2018 11:56 AM, Jason Ekstrand wrote: > > Ugh... I was actually thinking about this the other day. How did you > > come up with your list of instructions? Is there some algorithmic way > > to determine it such as sends with no heade

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-20 Thread Ian Romanick
On 04/20/2018 11:56 AM, Jason Ekstrand wrote: > Ugh... I was actually thinking about this the other day.  How did you > come up with your list of instructions?  Is there some algorithmic way > to determine it such as sends with no header? I just looked through the generator for pseudo-ops that emi

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-20 Thread Jason Ekstrand
Ugh... I was actually thinking about this the other day. How did you come up with your list of instructions? Is there some algorithmic way to determine it such as sends with no header? On April 20, 2018 08:52:50 "Ian Romanick" wrote: From: Ian Romanick Otherwise the scheduler can move th