Re: [Mesa-dev] [PATCH mesa 2/2] mapi: add asserts to enforce ordering and uniqueness

On Sun, Sep 25, 2016 at 12:27 AM, Eric Engestrom wrote: > On Sat, Sep 24, 2016 at 11:39:39PM -0400, Ilia Mirkin wrote: >> Also note... the list is already sorted. You just picked a different sort >> order. One that I'm pretty sure is subject to locale settings. As I recall >> C

Re: [Mesa-dev] [PATCH mesa 2/2] mapi: add asserts to enforce ordering and uniqueness

On Sat, Sep 24, 2016 at 11:39:39PM -0400, Ilia Mirkin wrote: > Also note... the list is already sorted. You just picked a different sort > order. One that I'm pretty sure is subject to locale settings. As I recall > C and utf8 do things differently in a way relevant to this list but I > haven't

Re: [Mesa-dev] [PATCH mesa 2/2] mapi: add asserts to enforce ordering and uniqueness

On Sat, Sep 24, 2016 at 10:27:52PM -0400, Ilia Mirkin wrote: > On Sat, Sep 24, 2016 at 10:17 PM, Eric Engestrom wrote: > > Dylan Baker recently added functions to that list and had to try a couple > > times > > to avoid duplicates. He said [1] he ended up testing it using: > >

Re: [Mesa-dev] [PATCH mesa 2/2] mapi: add asserts to enforce ordering and uniqueness

Also note... the list is already sorted. You just picked a different sort order. One that I'm pretty sure is subject to locale settings. As I recall C and utf8 do things differently in a way relevant to this list but I haven't checked. On Sep 24, 2016 10:27 PM, "Ilia Mirkin"

Re: [Mesa-dev] [PATCH mesa 2/2] mapi: add asserts to enforce ordering and uniqueness

On Sat, Sep 24, 2016 at 10:17 PM, Eric Engestrom wrote: > Dylan Baker recently added functions to that list and had to try a couple > times > to avoid duplicates. He said [1] he ended up testing it using: > len(functions) == len(set(functions)) > which I thought should