Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-08-24 Thread Jason Ekstrand
On Fri, Aug 17, 2018 at 1:13 PM Jason Ekstrand wrote: > On Mon, Jul 23, 2018 at 3:03 AM Timothy Arceri > wrote: > >> Since we know what side of the branch we ended up on we can just >> replace the use with a constant. >> >> All the spill changes in shader-db are from Dolphin uber shaders, >>

Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-08-17 Thread Jason Ekstrand
On Mon, Jul 23, 2018 at 3:03 AM Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All the spill changes in shader-db are from Dolphin uber shaders, > despite some small regressions the change is clearly positive. > >

Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-07-26 Thread Timothy Arceri
On 26/07/18 14:04, Timothy Arceri wrote: On 23/07/18 18:02, Timothy Arceri wrote: Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is

Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-07-25 Thread Timothy Arceri
On 23/07/18 18:02, Timothy Arceri wrote: Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. shader-db results IVB: