Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

> I took another swing at it, and this one seems to make Jenkins happy: > > https://gitlab.freedesktop.org/jekstrand/mesa/commit/ad3cc9f301da3519d4f76767a6d9e98e5a5c118e Reviewed-by: Caio Marcelo de Oliveira Filho Thanks, Caio

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

On Mon, Apr 9, 2018 at 5:21 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hi, > > > >> Question: nir_deref_instr_get_variable will walk the deref instr > > >> chain, but does it even make sense if there's a array or struct in > > >> this deref chain? Should this be

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

Hi, > >> Question: nir_deref_instr_get_variable will walk the deref instr > >> chain, but does it even make sense if there's a array or struct in > >> this deref chain? Should this be asserted? > >> > > > > That's an interesting question. Certainly, at this point in the patch > > series, we

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

On Fri, Apr 6, 2018 at 10:37 PM, Jason Ekstrand wrote: > On Fri, Apr 6, 2018 at 2:47 PM, Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > >> On Tue, Apr 03, 2018 at 11:32:51AM -0700, Jason Ekstrand wrote: >> > --- >> >

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

On Fri, Apr 6, 2018 at 2:47 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Tue, Apr 03, 2018 at 11:32:51AM -0700, Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir_lower_system_values.c | 13 ++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > >

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

On Tue, Apr 03, 2018 at 11:32:51AM -0700, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_lower_system_values.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_system_values.c > b/src/compiler/nir/nir_lower_system_values.c >