Re: revenge of CALLOC_STRUCT

2022-01-07 Thread Michael Blumenkrantz
it. > > > > > > > > > Jose > > > > > > [1] > > > https://devblogs.microsoft.com/cppblog/asan-for-windows-x64-and-debug-build-support/ > > > [2] > > > https://stackoverflow.com/questions/67619314/cannot-use-fsanitize-address-i

Re: revenge of CALLOC_STRUCT

2022-01-07 Thread Kenneth Graunke
t; > ---------- > > *From:* Dave Airlie > > *Sent:* Wednesday, December 22, 2021 22:35 > > *To:* mesa-dev ; Jose Fonseca < > > jfons...@vmware.com>; Brian Paul > > *Subject:* revenge of CALLOC_STRUCT > > > > Hey, > > >

Re: revenge of CALLOC_STRUCT

2021-12-28 Thread Dave Airlie
On Sun, 26 Dec 2021 at 20:37, Jose Fonseca wrote: > > I believe that as long as the CALLOC_STRUCT continue to get paired with right > FREE call (or equivalent if these get renamed) either way should work for us. > Whatever option proposed gets followed, there's a risk these can get out of > ba

Re: revenge of CALLOC_STRUCT

2021-12-27 Thread Marek Olšák
Dave Airlie > *Sent:* Wednesday, December 22, 2021 22:35 > *To:* mesa-dev ; Jose Fonseca < > jfons...@vmware.com>; Brian Paul > *Subject:* revenge of CALLOC_STRUCT > > Hey, > > Happy holidays, and as though to consider over the break, > > We have the vmware use

Re: revenge of CALLOC_STRUCT

2021-12-27 Thread Eero Tamminen
itize-address-in-mingw-compiler> *From:* Dave Airlie *Sent:* Wednesday, December 22, 2021 22:35 *To:* mesa-dev ; Jose Fonseca ; Brian Paul *Subject:* revenge of CALLOC_STRUCT Hey, Happy holidays, and as though to consider

Re: revenge of CALLOC_STRUCT

2021-12-26 Thread Jose Fonseca
build-support/ [2] https://stackoverflow.com/questions/67619314/cannot-use-fsanitize-address-in-mingw-compiler From: Dave Airlie Sent: Wednesday, December 22, 2021 22:35 To: mesa-dev ; Jose Fonseca ; Brian Paul Subject: revenge of CALLOC_STRUCT Hey, Happy hol

Re: revenge of CALLOC_STRUCT

2021-12-24 Thread Alyssa Rosenzweig
Remind me the difference between MALLOC and malloc (etc)? Like, why don't we s/MALLOC/malloc/g the whole codebase and drop u_memory.h? I guess portability (?) even though this is presumably stdlib... On Thu, Dec 23, 2021 at 08:35:38AM +1000, Dave Airlie wrote: > Hey, > > Happy holidays, and as th

Re: revenge of CALLOC_STRUCT

2021-12-23 Thread Rob Clark
On Wed, Dec 22, 2021 at 2:36 PM Dave Airlie wrote: > > Hey, > > Happy holidays, and as though to consider over the break, > > We have the vmware used MALLOC/FREE/CALLOC/CALLOC_STRUCT wrappers used > throughout gallium. > > We have ST_CALLOC_STRUCT in use in the mesa state tracker, not used in > g

revenge of CALLOC_STRUCT

2021-12-22 Thread Dave Airlie
Hey, Happy holidays, and as though to consider over the break, We have the vmware used MALLOC/FREE/CALLOC/CALLOC_STRUCT wrappers used throughout gallium. We have ST_CALLOC_STRUCT in use in the mesa state tracker, not used in gallium. Merging the state tracker into mesa proper, and even prior to