Re: [Mesa-dev] [PATCH] i965: vs optimization fix: Check val.negate in accumulator_contains()
On Sat, 23 Jul 2011 09:38:05 -0700, Paul Berry stereotype...@gmail.com wrote: On 22 July 2011 18:17, Eric Anholt e...@anholt.net wrote: On Fri, 22 Jul 2011 15:07:57 -0700, Paul Berry stereotype...@gmail.com wrote: When emitting a MAC instruction in a vertex shader, brw_vs_emit() calls accumulator_contains() to determine whether the accumulator already contains the appropriate addend; if it does, then we can avoid emitting an unnecessary MOV instruction. However, accumulator_contains() wasn't checking the val.negate flag. As a result, if the accumulator contained the negation of the desired value, we would generate an incorrect shader. Fixes piglit test vs-refract-vec4-vec4-float. Tested on Gen5 and Gen6. Looks like val.abs doesn't currently need this treatement because we never generate regs with it where they'd appear as the arg to MAD. Oh, thanks for alerting me to the existence of val.abs. I believe your analysis is correct, but if it's all the same to you I think I'd rather switch to: if (val.negate || val.abs) return GL_FALSE; Since the efficiency cost of checking val.abs is negligible, and it takes less thinking to be certain that this is correct. Sounds good. pgpMfcUANNpzC.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 39219] libgl conflict with xbmc causes lock up on xbmc exit
https://bugs.freedesktop.org/show_bug.cgi?id=39219 Henri Verbeet hverb...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/vl: remove unused vertex shader inputs
Hi Marek, the unused vertex shader inputs where there to work around a bug in r600g, which I fixed a couple of hours ago. I have also noticed create_ref_vert_shader doesn't write the vertex position, which might lead to undefined rendering. The position should be calculated in calc_position, so the position declaration in create_ref_vert_shader isn't used any more. I will push a fix for this in a couple of minutes. Thanks for pointing this out, Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] g3dvl: check for existence of header/libs
Hi, sorry for the late reply, have been in Canada on a team meeting. Did you got it working Andy or do you need some more help? I think the overall situation with finding libraries in the mesa makefiles is not the best, but that's not prio 1 at the moment. It should work with a standard installation (pkgconf based), but I don't think that it will work if you try something unusual, like cross compiling or having multiple versions of a lib installed in different directories... Christian. Am Sonntag, den 17.07.2011, 07:56 -0700 schrieb Dan Nicholson: On Jul 15, 2011 12:06 PM, Andy Furniss andy...@ukfsn.org wrote: Andy Furniss wrote: I have another problem though, vdpau-softpipe is not using my LD_LIBRARY_PATH so fails to find where my lvdpau is. As you can see from below r600 does use it and adds -L/home/andy/Src/Xorg-git/modular/lib and links OK. Maybe this doesn't come from LD_LIBRARY_PATH and instead it works by luck as my libdrm is in the same place - I guess it comes from pkgconfig as the r600 Makefile has - DRIVER_LIBS = $(shell pkg-config libdrm --libs) -lXfixes Yeah, that's he reason. You want to use LDFLAGS at build time. LD_LIBRARY_PATH is used at run time. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 39307] vdpau advertises support for MPEG1, but it's unimplemented
https://bugs.freedesktop.org/show_bug.cgi?id=39307 Christian König deathsim...@vodafone.de changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Christian König deathsim...@vodafone.de 2011-07-24 17:14:31 PDT --- Mhm, Emeric you patch looks quite right to me. But honestly, I couldn't find an MPEG1 to test it.Emeric you patch looks quite right to me. But honestly, I couldn't find an MPEG1 to test it. So could anybody please confirm that it's right so we can push it? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 39307] vdpau advertises support for MPEG1, but it's unimplemented
https://bugs.freedesktop.org/show_bug.cgi?id=39307 Christian König deathsim...@vodafone.de changed: What|Removed |Added CC||deathsim...@vodafone.de -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 39515] New: FTBFS: libEGL depends on libgbm, but libEGL builds first
https://bugs.freedesktop.org/show_bug.cgi?id=39515 Summary: FTBFS: libEGL depends on libgbm, but libEGL builds first Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Other AssignedTo: mesa-dev@lists.freedesktop.org ReportedBy: dawit...@sbcglobal.net Created an attachment (id=49481) -- (https://bugs.freedesktop.org/attachment.cgi?id=49481) full build output demonstrating dependency error I am trying to update my old build system to produce DEB packages for Debian Sid. The last build from git I tried was May 2 (commit eb0a9e9a). Much has changed since then, and I found that I needed to update my debian/rules and add some new *.install files, etc. (Up until that time, my builds worked fine for over a year.) I had made an archive from git on July 18, but didn't get around to working with it until today. After making adjustments for the changed 'configure' options and the new 'libgbm' library, among other things, I found that my build failed reproducibly when trying to make libEGL: /bin/bash ../../../bin/mklib -o EGL -linker 'gcc' -ldflags '' \ -major 1 -minor 0 \ -install ../../../x86_64-linux-gnu \ -L../../../x86_64-linux-gnu -ldl -lpthread -lX11-xcb -lX11 \ -lxcb-dri2 -lxcb-xfixes -lxcb-render -lxcb-shape -lxcb \ -lgbm -ludev -lrt -ldl -ldrm-lX11 -ldl \ eglapi.o eglarray.o eglconfig.o eglcontext.o eglcurrent.o \ egldisplay.o egldriver.o eglfallbacks.o eglglobals.o \ eglimage.o egllog.o eglmisc.o eglmode.o eglscreen.o \ eglstring.o eglsurface.o eglsync.o \ ../../../src/egl/drivers/dri2/libegl_dri2.a \ ../../../src/egl/drivers/glx/libegl_glx.a mklib: Making Linux shared library: libEGL.so.1.0 /usr/bin/ld: cannot find -lgbm collect2: ld returned 1 exit status mklib: Installing libEGL.so.1.0 libEGL.so.1 libEGL.so in \ ../../../x86_64-linux-gnu mv: cannot stat `libEGL.so.1.0': No such file or directory make[4]: Leaving directory `/home/dawitbro/sandbox/xorg-local/mesa/ mesa-7.12.0+git110724.4d23c6df/src/egl/main' Later in the build this can be seen: /bin/bash ../../../bin/mklib -o gbm -linker 'gcc' -ldflags '' \ -major 1 -minor 0 \ -install ../../../x86_64-linux-gnu \ -L../../../x86_64-linux-gnu -ldl -ludev -lrt \ gbm.o backend.o common.o ../../../src/gbm/backends \ /dri/libgbm_dri.a mklib: Making Linux shared library: libgbm.so.1.0 mklib: Installing libgbm.so.1.0 libgbm.so.1 libgbm.so in ../../../x86_64-linux-gnu make[4]: Leaving directory `/home/dawitbro/sandbox/xorg-local/mesa/ mesa-7.12.0+git110724.4d23c6df/src/gbm/main' This looks like a dependency problem, but my skill set is insufficient for trying to solve the problem and submitting a patch. It could also be a problem with the set of options I have selected; I am only a user, not a developer, so I could easily be the weakest link in the chain here. Hoping that it is a problem that was addressed since July 18, I did a fresh git pull and tried again. Same failure. I am attaching the full output from my attempt to build from the latest version I have: 7.12-devel (July 24) at commit 4d23c6df. This output (obviously) shows the options used and the commands that were run. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
