Re: [Mesa-dev] [PATCH] intel: FBOs with texture border are unsupported

2012-02-03 Thread Eric Anholt
On Wed, 1 Feb 2012 10:31:23 -0700, Ian Romanick i...@freedesktop.org wrote: --- src/mesa/drivers/dri/intel/intel_fbo.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-03 Thread Eric Anholt
On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com A similar check was removed in 05ab8fc. The check is not complete redundand because some paths, such as _mesa_meta_check_generate_mipmap_fallback, can get to

Re: [Mesa-dev] Mesa (master): dri: make sure to build libdricommon.la

2012-02-03 Thread Eric Anholt
On Thu, 02 Feb 2012 10:54:22 +, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 27/01/2012 20:20, Matt Turner wrote: On Fri, Jan 27, 2012 at 8:11 PM, Jon TURNEY wrote: On 27/01/2012 08:03, Eric Anholt wrote: On Thu, 26 Jan 2012 16:32:24 -0800 (PST), matts...@kemper.freedesktop.org

Re: [Mesa-dev] [PATCH] intel: Avoid divide by zero for very small linear blits

2012-02-03 Thread Eric Anholt
On Thu, 2 Feb 2012 16:50:32 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com If size is small (such as 1), pitch = ROUND_DOWN_TO(MIN2(size, (1 15) - 1), 4); makes pitch = 0. Then height = size / pitch; causes a division-by-zero

Re: [Mesa-dev] Mesa (master): dri: make sure to build libdricommon.la

2012-02-03 Thread Jon TURNEY
On 03/02/2012 09:28, Eric Anholt wrote: On Thu, 02 Feb 2012 10:54:22 +, Jon TURNEY wrote: On 27/01/2012 20:20, Matt Turner wrote: On Fri, Jan 27, 2012 at 8:11 PM, Jon TURNEY wrote: On 27/01/2012 08:03, Eric Anholt wrote: On Thu, 26 Jan 2012 16:32:24 -0800 (PST), (Matt Turner) wrote:

[Mesa-dev] [Bug 45571] fatal error: program/symbol_table.h: No such file or directory

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45571 --- Comment #1 from Tom Stellard tstel...@gmail.com 2012-02-03 06:16:09 PST --- (In reply to comment #0) Building from latest git (8cbe699c0dd9b8d4accf1eaa570689f813aa3c2f) and it fails with the following error: In file included from

[Mesa-dev] [Bug 45577] main/image.c:1597: _mesa_convert_colors: Assertion `dstType == 0x1406' failed.

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45577 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 45578] main/image.c:1659: _mesa_convert_colors: Assertion `dstType == 0x1403' failed.

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45578 --- Comment #1 from Brian Paul bri...@vmware.com 2012-02-03 07:20:43 PST --- *** Bug 45577 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

[Mesa-dev] [Bug 45578] main/image.c:1659: _mesa_convert_colors: Assertion `dstType == 0x1403' failed.

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45578 --- Comment #2 from Brian Paul bri...@vmware.com 2012-02-03 07:21:36 PST --- Created attachment 56575 -- https://bugs.freedesktop.org/attachment.cgi?id=56575 don't use _mesa_format_to_type_and_comps() to choose color type Can you give this

[Mesa-dev] [Bug 45578] main/image.c:1659: _mesa_convert_colors: Assertion `dstType == 0x1403' failed.

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45578 Brian Paul bri...@vmware.com changed: What|Removed |Added CC||i...@freedesktop.org --

[Mesa-dev] [PATCH 1/5] mesa: new _mesa_error_check_format_and_type() function

2012-02-03 Thread Brian Paul
This replaces the _mesa_is_legal_format_and_type() function. According to the spec, some invalid format/type combinations to glDrawPixels, ReadPixels and glTexImage should generate GL_INVALID_ENUM but others should generate GL_INVALID_OPERATION. With the old function we didn't make that

[Mesa-dev] [PATCH 2/5] mesa: remove redundant format/type checks in glGetTexImage()

2012-02-03 Thread Brian Paul
The _mesa_error_check_format_and_type() function will catch all those cases now. --- src/mesa/main/texgetimage.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index

[Mesa-dev] [PATCH 3/5] mesa: remove redundant format/type checks in glReadPixels()

2012-02-03 Thread Brian Paul
These are done in _mesa_error_check_format_and_type(). --- src/mesa/main/readpix.c | 35 --- 1 files changed, 0 insertions(+), 35 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 6c64cbe..b753e40 100644 ---

[Mesa-dev] [PATCH 4/5] mesa: remove unneeded glReadPixels(GL_COLOR_INDEX) code

2012-02-03 Thread Brian Paul
--- src/mesa/main/readpix.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index b753e40..3882e09 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -643,17 +643,11 @@

[Mesa-dev] [PATCH 5/5] mesa: add error for glReadPixels(GL_DEPTH_COMPONENT) buffer

2012-02-03 Thread Brian Paul
Trying to read depth values from a non-existant depth buffer should generate GL_INVALID_OPERATION. --- src/mesa/main/readpix.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 3882e09..9193def 100644 ---

[Mesa-dev] [PATCH] mesa: Fix xcb-dri2 link flags leaking into LIBS.

2012-02-03 Thread Eric Anholt
Fixes the build of builtin_compiler on my 32-bit build where xcb-dri2 is in a custom prefix but the custom prefix flags weren't available. It shouldn't have been in LIBS anyway. --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac

[Mesa-dev] [Bug 45594] New: [r600g] Piglit: spec/EXT_texture_integer/fbo_integer_precision_clear crashes in u_vbuf_draw_begin()

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45594 Bug #: 45594 Summary: [r600g] Piglit: spec/EXT_texture_integer/fbo_integer_precision_clear crashes in u_vbuf_draw_begin() Classification: Unclassified Product: Mesa

[Mesa-dev] [PATCHv3] r600g: Use a fake reloc to sleep for fences

2012-02-03 Thread Simon Farnsworth
r300g is able to sleep until a fence completes rather than busywait because it creates a special buffer object and relocation that stays busy until the CS containing the fence is finished. Copy the idea into r600g, and use it to sleep if the user asked for an infinite wait, falling back to

[Mesa-dev] [Bug 45578] main/image.c:1659: _mesa_convert_colors: Assertion `dstType == 0x1403' failed.

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45578 --- Comment #3 from Ian Romanick i...@freedesktop.org 2012-02-03 10:03:00 PST --- (In reply to comment #2) Created attachment 56575 [details] [review] don't use _mesa_format_to_type_and_comps() to choose color type Can you give this patch a

[Mesa-dev] [Bug 45571] fatal error: program/symbol_table.h: No such file or directory

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45571 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] r600g tiling final

2012-02-03 Thread Jerome Glisse
Hi, So tiling work is i believe done. I have run piglit accross wide range of hw and sw combination. Bottom line is new mesa on top of either old kernel or old ddx won't regress anything. New mesa on top of proper kernel will get you 2D tiling for texture and anything allocated by mesa, and if

Re: [Mesa-dev] [PATCH] mesa: Fix xcb-dri2 link flags leaking into LIBS.

2012-02-03 Thread Kenneth Graunke
On 02/03/2012 03:10 AM, Eric Anholt wrote: Fixes the build of builtin_compiler on my 32-bit build where xcb-dri2 is in a custom prefix but the custom prefix flags weren't available. It shouldn't have been in LIBS anyway. --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Mesa-dev] [PATCH] intel: Also check renderability in intel_renderbuffer_update_wrapper

2012-02-03 Thread Ian Romanick
On 02/03/2012 02:11 AM, Eric Anholt wrote: On Wed, 1 Feb 2012 12:29:39 -0700, Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com A similar check was removed in 05ab8fc. The check is not complete redundand because some paths, such as

[Mesa-dev] [PATCH 1/3] mesa: stop using _mesa_error_check_format_type() in glDrawPixels

2012-02-03 Thread Brian Paul
The _mesa_error_check_format_type() function does two things: check that format/type is legal and check that the destination (or source buffer for glReadPixels) actually exists. Just move the relevant parts of that into _mesa_DrawPixels(). We'll do a similar change in glReadPixels then get rid

[Mesa-dev] [PATCH 2/3] mesa: stop using _mesa_error_check_format_type() in glReadPixels

2012-02-03 Thread Brian Paul
Basically the same story as the previous commit. But we were already calling _mesa_source_buffer_exists() in ReadPixels(). Yeah, we were calling it twice. --- src/mesa/main/readpix.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/readpix.c

[Mesa-dev] [PATCH 3/3] mesa: remove unused _mesa_error_check_format_type() function

2012-02-03 Thread Brian Paul
This was only used by glReadPixels and glDrawPixels. Now those functions do the corresponding error checks. --- src/mesa/main/readpix.c | 111 --- src/mesa/main/readpix.h |4 -- 2 files changed, 0 insertions(+), 115 deletions(-) diff --git

[Mesa-dev] Print error message when switching to indirect rendering

2012-02-03 Thread Carl Worth
I recently had a problem with a dri driver failing to load, (it turned out to be a case of the driver being built for 64-bit, but running a 32-bit application). At the time, mesa switched over to indirect rendering without me realizing it at all. This left me quite confused. Finally, a kind

[Mesa-dev] [PATCH 3/4] dri: Make reverting to indirect rendering a critical error.

2012-02-03 Thread Carl Worth
Something has gone wrong if we have to revert to indirect rendering, (such as a driver failing to load for some reason). The user really should be made aware of this, (and instructed to set LIBGL_DEBUG for more details). --- src/glx/drisw_glx.c |2 +- 1 files changed, 1 insertions(+), 1

[Mesa-dev] [PATCH 2/4] dri: Add a CriticalErrorMessageF macro.

2012-02-03 Thread Carl Worth
Sometimes an error is so sever that we want to print it even when the user hasn't specifically requested debugging by setting LIBGL_DEBUG. Add a CriticalErrorMessageF macro to be used for this case. (The error message can still be slienced with the existing LIBGL_DEBUG=quiet). For critical error

[Mesa-dev] [PATCH 1/4] dri: Clarify comments on InfoMessageF and ErrorMessageF macros.

2012-02-03 Thread Carl Worth
The description of ErrorMessageF was misleading in the case of LIBGL_DEBUG being unset, (the previous comment could be understood to mean the error should be printed, but the code does not print in this case). InfoMessageF previously had no comment at all. --- src/glx/dri_common.c |7 ++-

[Mesa-dev] [PATCH 4/4] dri: Make reverting to software direct rendering a critical error.

2012-02-03 Thread Carl Worth
Something has gone wrong if we have to revert to software rendering. The user really should be made aware of this, (and instructed to set LIBGL_DEBUG for more details). --- src/glx/dri_glx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glx/dri_glx.c

[Mesa-dev] [Bug 45571] fatal error: program/symbol_table.h: No such file or directory

2012-02-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45571 --- Comment #3 from Alexandre Demers alexandre.f.dem...@gmail.com 2012-02-03 19:24:26 UTC --- (In reply to comment #2) You should run `git clean -dfx` and rerun autogen.sh after changes to Mesa. I'll try it tomorrow. However, I'm suprised