[Mesa-dev] Redefinition error in glapitmp.h

2013-03-18 Thread Ritvik Sharma
Hi,  While compiling mesa, I am getting redefinition errors for the file glapitemp.h (already defined in gl.h ). Also in the file mapi_tmp.h I am getting  #include error for  MAPI_ABI_HEADER. Thanks and Regards- Ritvik Sharma Department of Computer Science Engineering National Institute Of

Re: [Mesa-dev] Redefinition error in glapitmp.h

2013-03-18 Thread Michel Dänzer
On Son, 2013-03-17 at 15:57 +0800, Ritvik Sharma wrote: While compiling mesa, Which version? I am getting redefinition errors for the file glapitemp.h (already defined in gl.h ). Also in the file mapi_tmp.h I am getting #include error for MAPI_ABI_HEADER. Please post the actual error

Re: [Mesa-dev] Fwd: [PATCH 5/6] st/mesa: implement blit-based ReadPixels

2013-03-18 Thread Michel Dänzer
On Mon, 2013-03-18 at 01:06 +0100, Marek Olšák wrote: ([rant]We should really have an unmappable portion of VRAM as a feature, because unmappable memory is cool: the memory can be reclaimed immediately after texture deletion even if the texture is busy, because the CPU can't access it, and

Re: [Mesa-dev] [PATCH 9/9] tgsi: add ArrayID documentation

2013-03-18 Thread Christian König
Am 17.03.2013 20:59, schrieb Christoph Bumiller: On 17.03.2013 18:04, Christoph Bumiller wrote: On 17.03.2013 16:30, Christian König wrote: Am 15.03.2013 18:58, schrieb Christoph Bumiller: On 15.03.2013 13:08, Christian König wrote: Am 14.03.2013 15:53, schrieb Christoph Bumiller: On

Re: [Mesa-dev] [PATCH 4/4] st/dri: don't create 24-bit depth, non-stencil visuals

2013-03-18 Thread Marek Olšák
On Thu, Mar 14, 2013 at 3:23 PM, Brian Paul bri...@vmware.com wrote: On 03/14/2013 08:18 AM, Marek Olšák wrote: Z24X8 actually does save memory, because Radeon HD 5000 and later cards don't support combined depth stencil formats, therefore Z24S8 is allocated internally as two separate buffers

[Mesa-dev] [PATCH 1/9] tgsi/ureg: cleanup local temporary emission v2

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com Instead of emitting each temporary separately, emit them in a chunk. v2: keep separate function for emitting temps Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 30

[Mesa-dev] [PATCH 2/9] tgsi/ureg: implement support for array temporaries

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com Don't bother with free temporaries, just allocate them at the end and also emit them in their own declaration. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 55

[Mesa-dev] [PATCH 3/9] glsl_to_tgsi: use get_temp for all allocations

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 6/9] tgsi: remove TGSI_FILE_(IMMEDIATE|TEMP)_ARRAY

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com Nobody seems to be using it, and only nv50 had a partial implementation. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_build.c| 19 - src/gallium/auxiliary/tgsi/tgsi_dump.c

[Mesa-dev] [PATCH 7/9] tgsi: add ArrayID to declarations

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com Remember which declarations are declared as arrays and so can be indirectly addressed. ArrayIDs start at 1, cause for compatibility reasons zero is treaded as no array present. Signed-off-by: Christian König christian.koe...@amd.com ---

[Mesa-dev] [PATCH 8/9] tgsi: use separate structure for indirect address v2

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com To further improve the optimization of source and destination indirect addressing we need the ability to store a reference to the declaration of the addressed operands. Since most of the fields in tgsi_src_register doesn't apply for an indirect

[Mesa-dev] [PATCH 9/9] tgsi: add ArrayID documentation v2

2013-03-18 Thread Christian König
From: Christian König christian.koe...@amd.com v2: further improve the text with comments from Christoph Bumiller. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/docs/source/tgsi.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git

[Mesa-dev] Error while compiling the MAPI directory

2013-03-18 Thread Ritvik_Sharma
Hi, I am receiving the following error while compiling the code in the mapi directory. I am using mesa 7.5. (On compiling glapi_dispatch.c) OpenGL\mapi/glapi/glapitemp.h(86) : error C2375: 'glNewList' : redefinition; different linkage c:\poc\edk2\AppPkg\Include\GL/gl.h(944) : see

Re: [Mesa-dev] [PATCH 8/9] tgsi: use separate structure for indirect address v2

2013-03-18 Thread Roland Scheidegger
Am 18.03.2013 14:36, schrieb Christian König: From: Christian König christian.koe...@amd.com To further improve the optimization of source and destination indirect addressing we need the ability to store a reference to the declaration of the addressed operands. Since most of the fields in

[Mesa-dev] [PATCH 1/2] build libgallium shared by default.

2013-03-18 Thread Maarten Lankhorst
This is one of the 2 patches used in ubuntu for decreasing size of mesa build. The other one is more hacky, and links libmesagallium into libgallium, and then links libgallium against libdricore too for minimal duplication. This might mess up with static llvm, iirc static llvm is built wrong and

Re: [Mesa-dev] [PATCH 8/9] tgsi: use separate structure for indirect address v2

2013-03-18 Thread Christian König
Am 18.03.2013 15:12, schrieb Roland Scheidegger: Am 18.03.2013 14:36, schrieb Christian König: From: Christian König christian.koe...@amd.com To further improve the optimization of source and destination indirect addressing we need the ability to store a reference to the declaration of the

Re: [Mesa-dev] [PATCH 1/2] build libgallium shared by default.

2013-03-18 Thread Andreas Boll
2013/3/18 Maarten Lankhorst maarten.lankho...@canonical.com: This is one of the 2 patches used in ubuntu for decreasing size of mesa build. The other one is more hacky, and links libmesagallium into libgallium, and then links libgallium against libdricore too for minimal duplication. This

Re: [Mesa-dev] [PATCH] gallivm: fix return opcode handling in main function of a shader

2013-03-18 Thread Jose Fonseca
Looks good to me.  Please add all necessary test cases to cover all these code paths. Good stuff guys. Very subtle code indeed. Jose - Original Message - From: Roland Scheidegger srol...@vmware.com If we're in some conditional or loop we must not return, or the code after the

Re: [Mesa-dev] glxgears is faster but 3D render is so slow

2013-03-18 Thread Brian Paul
On 03/15/2013 05:33 PM, jupiter wrote: Hi Brian, On 3/15/13, Brian Paulbri...@vmware.com wrote: On 03/15/2013 05:39 AM, jupiter wrote: Thanks Brian and Matt. On 3/15/13, Matt Turnermatts...@gmail.com wrote: On Thu, Mar 14, 2013 at 6:29 AM, Brian Paulbri...@vmware.com wrote: Hmm, I

[Mesa-dev] [Bug 61827] [softpipe] piglit fbo-clear-formats GL_ARB_depth_buffer_float stencil regression

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61827 Anuj Phogat anuj.pho...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 62482] New: [softpipe] piglit amd_seamless_cubemap_per_texture regression

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62482 Priority: medium Bug ID: 62482 Keywords: regression CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit amd_seamless_cubemap_per_texture

Re: [Mesa-dev] Error while compiling the MAPI directory

2013-03-18 Thread Jose Fonseca
- Original Message - Hi, I am receiving the following error while compiling the code in the mapi directory. I am using mesa 7.5. If you're compiling with MSVC I'd recommend using a recent Mesa release and save your self a world of trouble. It's known to build well there. If you

Re: [Mesa-dev] [PATCH 5/7] mesa: allow multisample texture targets in [Get]TexParameter*

2013-03-18 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: ARB_texture_storage_multisample allows texture parameters to be queried for TEXTURE_2D_MULTISAMPLE and TEXTURE_2D_MULTISAMPLE_ARRAY targets. Some parameters may also be set, with the following exceptions: - TEXTURE_BASE_LEVEL may not be set to a

[Mesa-dev] [PATCH] mesa: Disable validate_ir_tree() on release builds.

2013-03-18 Thread Eric Anholt
Since half of ir_validate uses asserts() (the other using printf() then abort()), there's not much use to calling it in a release build. Cuts 6.3% of the startup time of TF2. NOTE: This is a candidate for the stable branches. --- src/glsl/ir_validate.cpp |6 ++ src/glsl/linker.cpp

Re: [Mesa-dev] [PATCH v3] i965: Avoid unnecessary copy when depthstencil workaround invoked by clear.

2013-03-18 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: Since apps typically begin rendering with a call to glClear(), it is likely that when brw_workaround_depthstencil_alignment() moves a miplevel to a temporary buffer, it can avoid doing a blit, since the contents of the miplevel are about to be

Re: [Mesa-dev] [PATCH 1/7] mesa: add support for immutable textures to teximagemultisample()

2013-03-18 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: The new entrypoints will come later, but this adds the actual logic for supporting immutable multisample textures: - The immutability flag is set as desired. - Attempting to modify an immutable multisample texture produces INVALID_OPERATION. Note:

Re: [Mesa-dev] [PATCH 1/7] mesa: add support for immutable textures to teximagemultisample()

2013-03-18 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: The new entrypoints will come later, but this adds the actual logic for supporting immutable multisample textures: - The immutability flag is set as desired. - Attempting to modify an immutable multisample texture produces INVALID_OPERATION. Note:

Re: [Mesa-dev] [PATCH] R600: Use CONSTANT_BUFFER_0 address space for Implicit Parameters

2013-03-18 Thread Chad Rosier
Test case? Chad On Mar 16, 2013, at 9:45 AM, Vincent Lejeune v...@ovi.com wrote: It allows the backend to generate reads to constant cache which are faster that VTX_READ. --- lib/Target/R600/R600ISelLowering.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 61821] src/mesa/drivers/dri/common/xmlpool.h:96:29: fatal error: xmlpool/options.h

2013-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61821 --- Comment #7 from Mike Stroyan m...@lunarg.com --- Created attachment 76708 -- https://bugs.freedesktop.org/attachment.cgi?id=76708action=edit configure.ac: Build dricommon for gallium swrast The 07f2dee7 commit added setting HAVE_COMMON_DRI

Re: [Mesa-dev] Google Summer of Code ideas needed

2013-03-18 Thread Ian Romanick
On 03/13/2013 10:11 AM, Tom Stellard wrote: Hi, It's time again for Google Summer of Code, so we need to start updating the X.Org ideas page (http://www.x.org/wiki/SummerOfCodeIdeas) with new ideas. Since there have been a few issues with the wikis lately, if you have any ideas please respond

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-18 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: This partially fixes a performance regression since commit 33599433c7. More work is required to fully fix it in all cases. This at least helps Warsow. Thanks, Ken. Reviewed-by: Carl Worth cwo...@cworth.org -Carl pgpEBf6hWs_2H.pgp Description:

Re: [Mesa-dev] Google Summer of Code ideas needed

2013-03-18 Thread Jordan Justen
On Wed, Mar 13, 2013 at 10:11 AM, Tom Stellard t...@stellard.net wrote: - A brief description of the project - A difficulty rating (e.g. easy, medium, hard) - The skills / programming languages required GL/GLSL tests for GL 3.2, 3.3 in the piglit test suite Difficulty: Easy-Medium Skills

[Mesa-dev] [PATCH] i965: Align all depth miplevels to 8 in the X direction.

2013-03-18 Thread Eric Anholt
On an INTEL_DEBUG=perf piglit run on IVB, reduces the instances of HW workaround: blit (the printouts from the misaligned-depth workaround blits) from 725 to 684 It doesn't totally eliminate the workaround blit, because we still have problems with Y offsets that we can't fix (since texturing can

Re: [Mesa-dev] Redefinition error in glapitmp.h

2013-03-18 Thread Matt Turner
On Sun, Mar 17, 2013 at 12:57 AM, Ritvik Sharma ritviksharma.n...@yahoo.in wrote: Also in the file mapi_tmp.h I am getting #include error for MAPI_ABI_HEADER. Look at how the Makefiles define MAPI_ABI_HEADER (e.g., in src/mapi/es2api/Makefile.am).

[Mesa-dev] [PATCH v2 00/15] GLSL 1.50 interface blocks support

2013-03-18 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa interface-blocks-v2 v2: * 3 new patches added to series * Add support for interface block instance arrays * Add support for rejecting unmatched interface blocks during the linking phase. * Known issue: fails new piglit glsl-1.50 test:

[Mesa-dev] [PATCH v2 01/15] glsl: rename ast_uniform_block to ast_interface_block

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/ast.h |4 ++-- src/glsl/ast_to_hir.cpp |6 +++--- src/glsl/glsl_parser.yy | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index

[Mesa-dev] [PATCH v2 02/15] glsl parser: rename uniform block to interface block

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index cd33078..33b74ea 100644 --- a/src/glsl/glsl_parser.yy +++

[Mesa-dev] [PATCH v2 03/15] glsl: parse in/out types for interface blocks

2013-03-18 Thread Jordan Justen
Previously only 'uniform' was allowed for uniform blocks. Now, in/out can be parsed, but it will only be allowed for GLSL = 150. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 60 ++- 1 file changed, 49

[Mesa-dev] [PATCH v2 04/15] glsl parser: reject VS+in FS+out interface blocks

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 7adc06d..8e6b04d 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@

[Mesa-dev] [PATCH v2 05/15] glsl parser: on desktop GL require GLSL 150 for instance names

2013-03-18 Thread Jordan Justen
Interface blocks in GLSL 150 allow an instance name to be used. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index

[Mesa-dev] [PATCH v2 07/15] glsl parser: handle interface block member qualifier

2013-03-18 Thread Jordan Justen
An interface block member may specify the type: in { in vec4 in_var_with_qualifier; }; In this case it must match the interface block type. It can also omit the qualifier: uniform { vec4 uniform_var_without_qualifier; }; In this case, it should use the same type as the interface block.

[Mesa-dev] [PATCH v2 06/15] glsl parser: allow in out for interface block members

2013-03-18 Thread Jordan Justen
Previously uniform blocks allowed for the 'uniform' keyword to be used with members of a uniform blocks. With interface blocks 'in' can be used on 'in' interface block members and 'out' can be used on 'out' interface block members. The basic_interface_block rule will verify that the same

[Mesa-dev] [PATCH v2 08/15] glsl ast_to_hir: support in/out for interface blocks

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/ast_to_hir.cpp | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 40f3188..ee54c70 100644 --- a/src/glsl/ast_to_hir.cpp +++

[Mesa-dev] [PATCH v2 09/15] glsl ir: add as_dereference_record

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/ir.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index bbfec69..ee27dea 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -120,6 +120,7 @@ public: virtual class ir_dereference *

[Mesa-dev] [PATCH v2 11/15] glsl linker: remove interface block instance names

2013-03-18 Thread Jordan Justen
Convert interface blocks with instance names into flat interface blocks without an instance name. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/Makefile.sources |1 + src/glsl/ir_optimization.h|1 + src/glsl/linker.cpp

[Mesa-dev] [PATCH v2 10/15] glsl linker: cross validate interface block types between stages

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/linker.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 29856b0..acbdd2f 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -478,6 +478,7 @@

[Mesa-dev] [PATCH v2 12/15] glsl link_varyings: link interface blocks using the block name

2013-03-18 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/link_varyings.cpp | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 04c9fdd..b374049 100644 ---

[Mesa-dev] [PATCH v2 13/15] glsl linker: support arrays of interface block instances

2013-03-18 Thread Jordan Justen
With this change we now support interface block arrays. For example, cases like this: out block_name { float f; } block_instance[2]; This allows Mesa to pass the piglit glsl-1.50 test: * execution/interface-blocks-complex-vs-fs.shader_test Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH v2 14/15] glsl linker: compare interface blocks during intrastage linking

2013-03-18 Thread Jordan Justen
Verify that interface blocks match when combining compilation units at the same stage. (For example, when merging all vertex shaders.) Fixes piglit glsl-1.50 test: * linker/interface-blocks-multiple-vs-member-count-mismatch.shader_test Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

[Mesa-dev] [PATCH v2 15/15] glsl linker: compare interface blocks during interstage linking

2013-03-18 Thread Jordan Justen
Verify that interface blocks match when linking separate shader stages into a program. Fixes piglit glsl-1.50 tests: * linker/interface-blocks-vs-fs-member-count-mismatch.shader_test * linker/interface-blocks-vs-fs-member-order-mismatch.shader_test Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH] i965: Align all depth miplevels to 8 in the X direction.

2013-03-18 Thread Kenneth Graunke
On 03/18/2013 03:56 PM, Eric Anholt wrote: On an INTEL_DEBUG=perf piglit run on IVB, reduces the instances of HW workaround: blit (the printouts from the misaligned-depth workaround blits) from 725 to 684 It doesn't totally eliminate the workaround blit, because we still have problems with Y

Re: [Mesa-dev] [PATCH 2/3] Add dri image entry point for creating image from fd

2013-03-18 Thread Kristian Høgsberg
On Fri, Mar 01, 2013 at 02:03:20PM +0200, Ander Conselvan de Oliveira wrote: On 02/28/2013 03:52 AM, Kristian Høgsberg wrote: --- include/GL/internal/dri_interface.h| 14 +++- src/mesa/drivers/dri/intel/intel_regions.c | 33 +++

Re: [Mesa-dev] [PATCH 3/3] wayland: Add prime fd passing as a buffer sharing mechanism

2013-03-18 Thread Kristian Høgsberg
On Fri, Mar 01, 2013 at 02:06:03PM +0200, Ander Conselvan de Oliveira wrote: On 02/28/2013 03:52 AM, Kristian Høgsberg wrote: diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index b5cd04a..1b42a98 100644 ---

[Mesa-dev] Basic GLSL 1.50 support: new types built-in functions

2013-03-18 Thread Kenneth Graunke
This series improves our basic GLSL 1.50 support. First, it makes 1.50 shaders using built-in functions work. Secondly, it adds the new types and built-ins from the ARB_texture_multisample extension (which are now part of core). It also makes it possible to run Unigine Valley and Heaven 4.0

[Mesa-dev] [PATCH 1/3] glsl: Bump standalone compiler versions to 1.50.

2013-03-18 Thread Kenneth Graunke
The version bumps are necessary in order to compile built-ins for 1.50. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/builtins/tools/generate_builtins.py | 4 ++-- src/glsl/main.cpp| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 2/3] glsl: Add sampler2DMS/sampler2DMSArray types to GLSL 1.50.

2013-03-18 Thread Kenneth Graunke
GLSL 1.50 includes support for the new sampler types introduced by the ARB_texture_multisample extension. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/glsl_types.cpp | 12 +++- src/glsl/glsl_types.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 3/3] glsl: Add built-in functions for GLSL 1.50.

2013-03-18 Thread Kenneth Graunke
This makes basic built-in functions work in GLSL 1.50. It supports everything except the new Geometry Shader functions. The new 150.glsl file is 140.glsl plus ARB_texture_multisample.glsl; 150.frag is identical to 140.frag except for the #version bump. Signed-off-by: Kenneth Graunke