Re: [Mesa-dev] [PATCH v2] R600/SI: Add pattern for AMDGPUurecip

2013-04-11 Thread Tobias Grosser
On 04/10/2013 02:51 PM, Michel Dänzer wrote: On Mit, 2013-04-10 at 12:59 +0200, Christian König wrote: Am 10.04.2013 12:21, schrieb Michel Dänzer: On Mit, 2013-04-10 at 12:07 +0200, Christian König wrote: Am 10.04.2013 11:46, schrieb Michel Dänzer: But why the heck is multiplying with

Re: [Mesa-dev] EGL and glClear(): Nothing is drawn on screen

2013-04-11 Thread Ralf Jung
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I am not using GLES, but normal OpenGL through EGL. And I am pretty sure it's double-buffered - as far as I understood it, that's the default, and I did not attempt to override it in any way (like calling glDrawBuffer). Oh, our EGL

Re: [Mesa-dev] EGL and glClear(): Nothing is drawn on screen

2013-04-11 Thread Ralf Jung
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, OK, the presence of glDrawBuffer(GL_FRONT) in the linked code plus the glFinish()/glFlush()es made it look like you were. I did some experimenting with manual copying... also, the code will clearly show that I am very inexperienced at GL ;-)

Re: [Mesa-dev] [PATCH v2] R600/SI: Add pattern for AMDGPUurecip

2013-04-11 Thread Owen Anderson
On Apr 10, 2013, at 6:48 AM, Tobias Grosser tob...@grosser.es wrote: On 04/10/2013 02:51 PM, Michel Dänzer wrote: On Mit, 2013-04-10 at 12:59 +0200, Christian König wrote: Am 10.04.2013 12:21, schrieb Michel Dänzer: On Mit, 2013-04-10 at 12:07 +0200, Christian König wrote: Am 10.04.2013

[Mesa-dev] [PATCH 9.1] i965: Fix an inconsistency inb the VUE map with gl_ClipVertex on gen4/5.

2013-04-11 Thread Jordan Justen
From: Eric Anholt e...@anholt.net We are intentionally not allocating a slot for gl_ClipVertex. But by leaving the bit set in the slots_valid, the fragment shader's computation of where varyings are in urb entry coming out of the SF would be off by one. Fixes rendering in Freespace 2 SCP, and

[Mesa-dev] [Bug 44618] Cross-compilation broken by glsl builtin_compiler

2013-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44618 --- Comment #22 from Ilyes Gouta ilyes.go...@gmail.com --- Hi, (In reply to comment #20) Created attachment 77156 [details] [review] MesaLib-9.1.1-cross.patch Suggested fix. Has this fix landed? Ilyes -- You are receiving this mail

[Mesa-dev] gallium ARB_texture_multisample support

2013-04-11 Thread Dave Airlie
Hi guys, this hopefully addresses the issues pointed out in previous reviews, the main difference is the st/mesa max samples chooser is correct, which Ian pointed out. Also r600g sample positions are now valid, my last attempt missed some unsigned/signed issues. Dave.

[Mesa-dev] [PATCH 1/5] st/formats: split choose format into non-erroring internal version

2013-04-11 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This allows us to reuse this for choosing formats for MSAA limits. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_format.c | 24 +++- src/mesa/state_tracker/st_format.h | 5 + 2 files changed, 24

[Mesa-dev] [PATCH 2/5] gallium: add get_sample_position interface

2013-04-11 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This is to be used to implement glGet GL_SAMPLE_POSITION. Reviewed-by: Marek Olšák mar...@gmail.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/include/pipe/p_context.h | 13 + 1 file changed, 13 insertions(+) diff --git

[Mesa-dev] [PATCH 3/5] st/mesa: add support for get sample position

2013-04-11 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This just calls into the gallium interface. Reviewed-by: Marek Olšák mar...@gmail.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/sources.mak| 1 + src/mesa/state_tracker/st_cb_msaa.c | 54 +

[Mesa-dev] [PATCH 4/5] st/mesa: add support for ARB_texture_multisample (v2)

2013-04-11 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This adds support to the mesa state tracker for ARB_texture_multisample. hardware doesn't seem to use a different texture instructions, so I don't think we need to create one for TGSI at this time. Thanks to Marek for fixes to sample number picking. v2: idr

[Mesa-dev] [PATCH 5/5] r600g: add get_sample_position support (v3)

2013-04-11 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com v2: I rewrote this to use the sample positions properly. v3: rewrite properly to use bitfield to cast back to signed ints Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/r600/evergreen_state.c | 287 ++---

[Mesa-dev] [Bug 44618] Cross-compilation broken by glsl builtin_compiler

2013-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44618 --- Comment #23 from Matt Turner matts...@gmail.com --- (In reply to comment #22) Has this fix landed? No. See comment 21. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 05/12] sso: replace Shader binding point with _Shader

2013-04-11 Thread gregory hainaut
On Sat, 06 Apr 2013 08:52:35 -0600 Brian Paul bri...@vmware.com wrote: One more comment for now below. I may not get to review the rest for a few days. -Brian Thanks very much for the review. I redid properly my patch and rebase my work on a more recent mesa version. I want to do a piglit

Re: [Mesa-dev] [PATCH v3] R600/SI: Add pattern for AMDGPUurecip

2013-04-11 Thread Christian König
Am 10.04.2013 18:50, schrieb Tom Stellard: On Wed, Apr 10, 2013 at 05:59:48PM +0200, Michel Dänzer wrote: [SNIP] We should start using the updated pattern syntax for all new patterns. This means replacing register classes with types for the input patterns and omitting the type in the output

Re: [Mesa-dev] [PATCH 1/5] st/formats: split choose format into non-erroring internal version

2013-04-11 Thread Dave Airlie
This allows us to reuse this for choosing formats for MSAA limits. Self-review, this one has a bug, I've changed in the branch gallium-texture-multisample in my tree to take a problem boolean and only report the problem in that case, as PIPE_FORMAT_NONE wasn't always indicative of a problem.

[Mesa-dev] [PATCH 1/4] r600g: add a query returning the amount of time spent during bo_map sync.

2013-04-11 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c |1 + src/gallium/drivers/r600/r600_pipe.h |1 + src/gallium/drivers/r600/r600_query.c |9 + src/gallium/winsys/radeon/drm/radeon_drm_bo.c |5 +

[Mesa-dev] [PATCH 2/4] r600g: add a debug flag for printing virtual addresses of resources

2013-04-11 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_buffer.c |7 +++ src/gallium/drivers/r600/r600_pipe.c|1 + src/gallium/drivers/r600/r600_pipe.h|1 + src/gallium/drivers/r600/r600_texture.c |8 4 files changed, 17 insertions(+) diff --git

[Mesa-dev] [PATCH 3/4] winsys/radeon: use query_value for timestamp, remove query_timestamp

2013-04-11 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c |2 +- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 27 - src/gallium/winsys/radeon/drm/radeon_winsys.h | 10 ++-- 3 files changed, 13 insertions(+), 26 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] r600g: implement pipeline statistics query

2013-04-11 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c |2 +- src/gallium/drivers/r600/r600_pipe.h |1 + src/gallium/drivers/r600/r600_query.c | 95 + src/gallium/drivers/r600/r600d.h |3 ++ 4 files changed, 100 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/3] gallium/hud: remove pipeline-statistics- prefix in query names

2013-04-11 Thread Marek Olšák
for the env var string not to be awfully long --- src/gallium/auxiliary/hud/hud_context.c | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index

[Mesa-dev] [PATCH 2/3] gallium/hud: update the contents of GALLIUM_HUD=help

2013-04-11 Thread Marek Olšák
--- src/gallium/auxiliary/hud/hud_context.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 20115a5..4912b2a 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++

[Mesa-dev] [PATCH 3/3] gallium/hud: increase vertex buffer size for background black rectangles

2013-04-11 Thread Marek Olšák
--- src/gallium/auxiliary/hud/hud_context.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 4912b2a..eb7a67a 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++

[Mesa-dev] [PATCH 1/3] gallium/hud: remove pipeline-statistics- prefix in query names

2013-04-11 Thread Marek Olšák
for the env var string not to be awfully long v2: fix bug in indexing of name --- src/gallium/auxiliary/hud/hud_context.c | 43 --- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH] gallium/hud: fix FPS computation for framerate 4.2k

2013-04-11 Thread Marek Olšák
--- src/gallium/auxiliary/hud/hud_fps.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_fps.c b/src/gallium/auxiliary/hud/hud_fps.c index 71cdfd0..80381f5 100644 --- a/src/gallium/auxiliary/hud/hud_fps.c +++

Re: [Mesa-dev] [PATCH 2/2] tgsi/exec: geometry shaders are executed on a single primitive

2013-04-11 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - which means that our execution mask in GS is equal to 1 not 0xf. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 30 +- 1 file changed, 17 insertions(+), 13

[Mesa-dev] [PATCH 1/2] radeon/winsys: add uvd ring support to winsys v2

2013-04-11 Thread Christian König
From: Christian König christian.koe...@amd.com Separated from UVD patch for clarity. v2: sync with next tree for 3.10 http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.10-wip Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c

[Mesa-dev] [PATCH 0/2] initial UVD support

2013-04-11 Thread Christian König
Hopefully the last round for this patchset. Since we now have a stable kernel interface I'm going to commit it this evening if nobody objects. Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] radeon/winsys: add uvd ring support to winsys v2

2013-04-11 Thread Alex Deucher
On Thu, Apr 11, 2013 at 9:39 AM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Separated from UVD patch for clarity. v2: sync with next tree for 3.10 http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.10-wip Signed-off-by: Christian

Re: [Mesa-dev] [PATCH 1/2] radeon/winsys: add uvd ring support to winsys v2

2013-04-11 Thread Andreas Boll
2013/4/11 Christian König deathsim...@vodafone.de From: Christian König christian.koe...@amd.com Separated from UVD patch for clarity. v2: sync with next tree for 3.10 http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.10-wip Signed-off-by: Christian König

Re: [Mesa-dev] [PATCH 1/2] radeon/winsys: add uvd ring support to winsys v2

2013-04-11 Thread Christian König
Am 11.04.2013 15:54, schrieb Andreas Boll: 2013/4/11 Christian König deathsim...@vodafone.de From: Christian König christian.koe...@amd.com Separated from UVD patch for clarity. v2: sync with next tree for 3.10 http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.10-wip

Re: [Mesa-dev] [PATCH 2/3] R600: Export is emitted as a CF_NATIVE inst

2013-04-11 Thread Tom Stellard
On Wed, Apr 10, 2013 at 11:04:21PM +0200, Vincent Lejeune wrote: --- lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 15 +-- lib/Target/R600/R600Instructions.td| 8 2 files changed, 9 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] R600: Emit used GPRs count

2013-04-11 Thread Tom Stellard
On Wed, Apr 10, 2013 at 11:04:20PM +0200, Vincent Lejeune wrote: --- Reviewed-by: Tom Stellard thomas.stell...@amd.com lib/Target/R600/AMDGPUAsmPrinter.cpp | 35 +-- lib/Target/R600/AMDGPUAsmPrinter.h | 3 ++- 2 files changed, 35 insertions(+), 3

Re: [Mesa-dev] [PATCH 3/3] R600: Make Export Instruction not duplicable

2013-04-11 Thread Tom Stellard
On Wed, Apr 10, 2013 at 11:04:22PM +0200, Vincent Lejeune wrote: --- Could you add a comment explaining why export instructions are not duplicable. With that change: Reviewed-by: Tom Stellard thomas.stell...@amd.com lib/Target/R600/R600Instructions.td | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] r600g: Fix UMAD on Cayman

2013-04-11 Thread Vadim Girlin
On 04/11/2013 02:08 AM, Marek Olšák wrote: Here's the output: creating vs ... shader compilation status: OK creating fs ... shader compilation status: OK thread #0 (0;0) : ref = 16608 thread #1 (1;0) : ref = 27873 thread #2 (0;1) : ref = 16608 thread #3 (1;1) : ref = 27877 results: thread 0

[Mesa-dev] [Bug 63435] New: [Regression since 9.0] Flickering in EGL OpenGL full-screen window with swap interval 1

2013-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63435 Priority: medium Bug ID: 63435 Assignee: mesa-dev@lists.freedesktop.org Summary: [Regression since 9.0] Flickering in EGL OpenGL full-screen window with swap interval 1

[Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Zack Rusin
As implemented in tgsi_exec they both test src operands on the bit level and don't do floating point comperisons as some thought. This documents them as such to avoid future confusion and fixes their implementation in llvmpipe. Could gallium driver developers make sure that they're handling those

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Am 11.04.2013 05:20, schrieb Zack Rusin: As implemented in tgsi_exec they both test src operands on the bit level and don't do floating point comperisons as some thought. This documents them as such to avoid future confusion and fixes their implementation in llvmpipe. Could gallium driver

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Am 11.04.2013 05:20, schrieb Zack Rusin: As implemented in tgsi_exec they both test src operands on the bit level and don't do floating point comperisons as some thought. This documents them as such to avoid future confusion and fixes their implementation in llvmpipe. Could gallium driver

Re: [Mesa-dev] [PATCH] glsl: Fix (and validate) comment above glsl_type::name.

2013-04-11 Thread Paul Berry
On 10 April 2013 14:33, Ian Romanick i...@freedesktop.org wrote: On 04/10/2013 01:32 PM, Kenneth Graunke wrote: On 04/09/2013 09:01 PM, Paul Berry wrote: The comment above glsl_type::name claimed that it could sometimes be NULL. This was wrong--it is never NULL. Many error handling paths

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Am 11.04.2013 19:09, schrieb Zack Rusin: - Original Message - Am 11.04.2013 05:20, schrieb Zack Rusin: As implemented in tgsi_exec they both test src operands on the bit level and don't do floating point comperisons as some thought. This documents them as such to avoid future

[Mesa-dev] [PATCH v2 1/2] i965: NULL check prog on shader compilation failure.

2013-04-11 Thread Matt Turner
Also change if (shader) to if (prog) for consistency. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 12 +++- src/mesa/drivers/dri/i965/brw_vec4.cpp |8 +--- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH v2 2/2] i965/vs: Print error if vertex shader fails to compile.

2013-04-11 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_vec4.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 4f7b8c0..6a2ce35 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++

[Mesa-dev] intel: release build compile warnings cleanups

2013-04-11 Thread Eric Anholt
I got tired of freaking out a little every time I built my release tree because of compile warnings. All but the last 2 seemed like pretty clean fixes to me. And then there's the first patch, which is unrelated but I found while trying to figure out why register_coalesce() does something that

[Mesa-dev] [PATCH 02/12] i830: Move assert-only code into the assert.

2013-04-11 Thread Eric Anholt
The call has no side effects, and moving it into the assert cleans up a compile warning in the release build. --- src/mesa/drivers/dri/i915/i830_vtbl.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_vtbl.c

[Mesa-dev] [PATCH 01/12] i965/fs: Fix some untriggered optimization bugs with uncompressed/sechalf.

2013-04-11 Thread Eric Anholt
We have this support for firsthalf/sechalf instructions, which would be called in the !has_compr4 (aka original gen4) 16-wide case. We currently only support 16-wide for gen5+, so we weren't tripping over this, but it would have been a problem if we ever try to enable it. ---

[Mesa-dev] [PATCH 04/12] intel: Improve diagnostics for emit_linear_blit failure path.

2013-04-11 Thread Eric Anholt
This fixes unused variable warnings in the release build, and should be more useful if it ever triggers. --- src/mesa/drivers/dri/intel/intel_blit.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_blit.c

[Mesa-dev] [PATCH 03/12] i965: Fix error path for MCS allocation.

2013-04-11 Thread Eric Anholt
Asserts don't stop execution in release builds, so we would continue on to use an uninitialized format value. Just take the failure path, which appears to continue up the call stack for a while. --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 07/12] intel: Return failure properly in the texsubimage blit path.

2013-04-11 Thread Eric Anholt
We assert that failure doesn't happen, but it fixes a warning in the release build and it would at least give working behavior for a user by falling back to the normal texsubimage path. --- src/mesa/drivers/dri/intel/intel_tex_subimage.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 12/12] i965: Shut up the last release build warning.

2013-04-11 Thread Eric Anholt
I don't see a sensible value to use in this path, but we shouldn't ever hit this outside of developer new-texture-target enabling. --- src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp |1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 09/12] i965: Fix an unused variable warning in the release build.

2013-04-11 Thread Eric Anholt
I think this actually clarifies what's going on in the asserts a bit, given how many regions we've got floating around. --- src/mesa/drivers/dri/i965/brw_misc_state.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c

[Mesa-dev] [PATCH 08/12] i965: Fix an unused variable warning in the release build.

2013-04-11 Thread Eric Anholt
It's used in an assert, but we have this as a member of the class anyway. --- src/mesa/drivers/dri/i965/brw_fs.cpp |1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 88aa695..c945617 100644 ---

[Mesa-dev] [PATCH 05/12] intel: Fix an unused variable warning in the release build.

2013-04-11 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c b/src/mesa/drivers/dri/intel/intel_mipmap_tree.c index 772c393..f9768df 100644 ---

[Mesa-dev] [PATCH 10/12] i965: Fix a warning in the release build.

2013-04-11 Thread Eric Anholt
This was copy and pasted from can_reswizzle_dst(), and we can just fold it in instead to avoid the warning. --- src/mesa/drivers/dri/i965/brw_vec4.cpp |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 11/12] i965: Silence one more compile warning.

2013-04-11 Thread Eric Anholt
We don't want to store this thing in the class, and we do need the definition to be at the top of the function and held onto until the end here, so there's not much to do besides (void) reference it. --- src/mesa/drivers/dri/i965/brw_fs.cpp |1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] intel: release build compile warnings cleanups

2013-04-11 Thread Matt Turner
On Thu, Apr 11, 2013 at 11:06 AM, Eric Anholt e...@anholt.net wrote: I got tired of freaking out a little every time I built my release tree because of compile warnings. All but the last 2 seemed like pretty clean fixes to me. And then there's the first patch, which is unrelated but I found

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Marek Olšák
What about drivers without integer support? The IF instruction should have 2 definitions: one for the drivers which support PIPE_SHADER_CAP_INTEGERS, and the other one for those which don't. Obviously, there is no way to change the behavior of the IF opcode if you only have floats. Marek On

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Everything emitting those opcodes always assumed this is some sort of boolean until now, so treating them as floats always was sketchy. Note that the differences to treating them as uints or floats for comparisons to zero isn't large, it's the same for everything except -0.0 and NaNs, and I

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Zack Rusin
What about drivers without integer support? The IF instruction should have 2 definitions: one for the drivers which support PIPE_SHADER_CAP_INTEGERS, and the other one for those which don't. Obviously, there is no way to change the behavior of the IF opcode if you only have floats. I think in

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Jose Fonseca
Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof of it. We really should have two IF opcodes. And the state tracker should choose which one it wants. Jose

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Marek Olšák
SM3 hardware does have NaNs. Anyway, I'd like to have this SM3-specific behavior of TGSI_OPCODE_IF properly documented. We already generate different TGSI code for SM3 and SM4+ and there'll be much more differences in how things are done in the future (e.g. temporaries could be used in place of

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Zack Rusin
- Original Message - Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof of it. We really should have two IF opcodes. And the state tracker should choose

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Jose Fonseca
- Original Message - - Original Message - Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof of it. We really should have two IF

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Zack Rusin
- Original Message - - Original Message - Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof of it. We really should have two IF

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Actually our svga driver seems to think that the IF opcode works like that. Since it will translate it into a SVGA3DOP_IFC (which corresponds to shader model 2 if_comp which compares to sources and specifies a comparison function - my guess is this is what the unused TGSI_OPCODE_IFC was meant for,

Re: [Mesa-dev] [PATCH v2 1/2] i965: NULL check prog on shader compilation failure.

2013-04-11 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: Also change if (shader) to if (prog) for consistency. If the _mesa_problem is pulled out of the if (prog) in both patches (since it doesn't rely on the program, and you'd want to know), then: Reviewed-by: Eric Anholt e...@anholt.net pgpDwZqCAcTWE.pgp

[Mesa-dev] [PATCH 1/2] mesa: Add core support for the GL_AMD_performance_monitor extension.

2013-04-11 Thread Kenneth Graunke
This provides an interface for applications (and OpenGL-based tools) to access GPU performance counters. Since the exact performance counters available vary between vendors and hardware generations, the extension provides an API the application can use to get the names, types, and minimum/maximum

[Mesa-dev] [PATCH 2/2] i965: Add support for GL_AMD_performance_monitor on Ironlake.

2013-04-11 Thread Kenneth Graunke
Ironlake's counters are always enabled; userspace can simply send a MI_REPROT_PERF_COUNT packet to take a snapshot of them. This makes it easy to implement. The counters are documented in the source code for the intel-gpu-tools intel_perf_counters utility. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Jose Fonseca
- Original Message - - Original Message - - Original Message - Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof

[Mesa-dev] [Bug 63435] [Regression since 9.0] Flickering in EGL OpenGL full-screen window with swap interval 1

2013-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63435 --- Comment #1 from post+...@ralfj.de --- I totally forgot my software and hardware specs: I am using Debian testing with a self-compiled vanilla 3.8.5 kernel. Other than that, I use the distribution packages. My GPU is the one built-in my Core

Re: [Mesa-dev] [PATCH] tgsi: document and fixup IF and BREAKC instrunctions

2013-04-11 Thread Roland Scheidegger
Am 11.04.2013 22:52, schrieb Zack Rusin: - Original Message - - Original Message - Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I was against dual semantics. And the fact that this problem is again showing its ugly head is the proof of it.

Re: [Mesa-dev] [PATCH 1/2] mesa: Add core support for the GL_AMD_performance_monitor extension.

2013-04-11 Thread Matt Turner
On Thu, Apr 11, 2013 at 2:00 PM, Kenneth Graunke kenn...@whitecape.org wrote: This provides an interface for applications (and OpenGL-based tools) to access GPU performance counters. Since the exact performance counters available vary between vendors and hardware generations, the extension

[Mesa-dev] Restructure documents directory layout

2013-04-11 Thread Emil Velikov
As suggested by Jose, here is a short patchset that handles the initial stage of beating some structure into the docs directory * All the release notes (both text and html) have been moved to relnotes/, with filenames indicating the version only * Mesa/WL extensions have been moved to specs/,

[Mesa-dev] [PATCH 3/4] docs: Add some missing release notes

2013-04-11 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- docs/relnotes.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/relnotes.html b/docs/relnotes.html index 049a979..819d2ce 100644 --- a/docs/relnotes.html +++ b/docs/relnotes.html @@ -22,6 +22,7 @@ The release notes summarize

[Mesa-dev] [PATCH 4/4] docs: Update 'Making new mesa release'

2013-04-11 Thread Emil Velikov
Add a note to update PACKAGE_VERSION for Android and scons builds Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- docs/devinfo.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index 5c03344..7176824 100644 --- a/docs/devinfo.html +++

[Mesa-dev] Compile warnings cleanup

2013-04-11 Thread Emil Velikov
Here is a short patchset that handles most of the compile warnings for my gallium/nouveau 'release' build. The commit messages may be rather silly but I was running out of ideas what to put :) Anyway the first five patches are nv50,nvc0 related, whereas the last one changes a egl/wayland

[Mesa-dev] [PATCH 2/6] nvc0: compile nve4_cache_name() only in debug build

2013-04-11 Thread Emil Velikov
As otherwise it is unused - pointed out by gcc nve4_compute.c:586:20: warning: 'nve4_cache_split_name' defined but not used [-Wunused-function] static const char *nve4_cache_split_name(unsigned value) ^ Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

[Mesa-dev] [PATCH 3/6] nvc0: bail out early during nve4_compute_setup()

2013-04-11 Thread Emil Velikov
Exit gracefully rather than trying to create a random object, whenever the chipset is unknown Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/nvc0/nve4_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 4/6] nvc0: initialize variable

2013-04-11 Thread Emil Velikov
Pointed out by gcc nve4_compute.c: In function 'nve4_launch_grid': nve4_compute.c:511:7: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] if (ret) ^ Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/nvc0/nve4_compute.c | 2

[Mesa-dev] [PATCH 5/6] nv50, nvc0: make nv{50, c0} lookalike, kind of

2013-04-11 Thread Emil Velikov
Remove extra chipset check during nvc0_screen_create Set the class_3d after the object is created Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/nv50/nv50_screen.c | 2 +- src/gallium/drivers/nvc0/nvc0_screen.c | 12 +--- 2 files changed, 2 insertions(+),

[Mesa-dev] [PATCH 6/6] gallium-egl: Use native types rather than EGL ones

2013-04-11 Thread Emil Velikov
Change egl_g3d_wl_drm_common_query_buffer() to use boolean/int rather than EGLBoolean/EGLint, based on the interface in native_wayland_bufmgr.h, Resolves type conversion warnings spotted by gcc x11/native_dri2.c:892:1: warning: initialization from incompatible pointer type[enabled by default]

[Mesa-dev] [PATCH 01/12] build: Rename sources.mak - Makefile.sources

2013-04-11 Thread Matt Turner
For the sake of consistency. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- src/glx/apple/Makefile | 2 +- src/mapi/glapi/Makefile.am | 4 +- src/mapi/glapi/Makefile.sources | 19 ++

[Mesa-dev] [PATCH 03/12] build: Get rid of CORE_DIRS

2013-04-11 Thread Matt Turner
A step toward working make dist/distcheck. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac | 37 - src/Makefile.am | 30 +++---

[Mesa-dev] [PATCH 04/12] build: Get rid of SRC_DIRS

2013-04-11 Thread Matt Turner
Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- Since last time: - Stop building src/glx for xlib-glx, as noticed out by Eric and Andreas. (Relies on the fact that $enable_dri and $enable_xlib_glx are mutually

[Mesa-dev] [PATCH 05/12] build: Remove GALLIUM_DIRS

2013-04-11 Thread Matt Turner
It's always constant anyway. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac| 4 src/Makefile.am | 4 +++- src/gallium/Makefile.am | 22 -- 3 files changed, 3

[Mesa-dev] [PATCH 06/12] build: Stop AC_SUBST'ing DRI_DIRS and GALLIUM_DRIVERS_DIRS

2013-04-11 Thread Matt Turner
Neither are used in Makefile.ams. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 299007d..9eec334 100644 --- a/configure.ac

[Mesa-dev] [PATCH 07/12] build: Get rid of DRIVER_DIRS

2013-04-11 Thread Matt Turner
Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac | 9 ++--- src/mesa/Makefile.am | 14 +- src/mesa/drivers/Makefile.am | 22 -- 3 files changed, 15

[Mesa-dev] [PATCH 08/12] build: Stop using GALLIUM_STATE_TRACKERS_DIRS for SUBDIRS

2013-04-11 Thread Matt Turner
configure still uses it to print the enabled state trackers. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac | 45 +++ src/gallium/state_trackers/Makefile.am | 65

[Mesa-dev] [PATCH 09/12] build: Get rid of GALLIUM_MAKE_DIRS

2013-04-11 Thread Matt Turner
Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- Since last time: - Rebase and add freedreno. configure.ac| 31 +++ src/gallium/drivers/Makefile.am | 84

[Mesa-dev] [PATCH 10/12] build: Build pipe-loader before gallium tests

2013-04-11 Thread Matt Turner
And don't build it from other Makefiles. That's awful, and breaks distclean. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- configure.ac | 8 src/gallium/targets/opencl/Makefile.am | 3 ---

[Mesa-dev] [PATCH 11/12] build: Get rid of GALLIUM_TARGET_DIRS

2013-04-11 Thread Matt Turner
configure still uses it to print the enabled targets. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- Since last time: - Rebase and add freedreno. configure.ac| 2 +- src/gallium/targets/Makefile.am |

[Mesa-dev] [PATCH 12/12] build: Get rid of GALLIUM_WINSYS_DIRS

2013-04-11 Thread Matt Turner
configure still uses it to print the enabled winsys. Tested-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-and-Tested-by: Andreas Boll andreas.boll@gmail.com --- Since last time: - Rebase and add freedreno. configure.ac | 38 +-

[Mesa-dev] [PATCH 2/2] draw: implement pipeline statistics in the draw module

2013-04-11 Thread Zack Rusin
This is a basic implementation of the pipeline statistics in the draw module. The interface is similar to the stream output statistics and also requires that the callers explicitly enable it. Included is the implementation of the interface in llvmpipe and softpipe. Only softpipe enables the

[Mesa-dev] [PATCH 1/2] gallivm/gs: fix the end primitive calls

2013-04-11 Thread Zack Rusin
The issue with SOA execution and end_primitive opcode is that it can be executed both when we haven't emitted any vertices, in which case we don't want to emit an empty primitive, and when the execution mask is zero and the execution should be skipped. We handled only the latter of those