On Mon, Nov 18, 2013 at 01:38:55PM -0500, Jerome Glisse wrote:
On Mon, Nov 18, 2013 at 05:41:50PM +0100, Thierry Reding wrote:
On Mon, Nov 18, 2013 at 11:21:36AM -0500, Rob Clark wrote:
On Mon, Nov 18, 2013 at 10:23 AM, Thierry Reding
thierry.red...@gmail.com wrote:
On Mon, Nov 18,
Earlier comments suggest this was removed from GL core spec but it is
still there. Enabling makes 'texture_lod_bias_getter' Khronos
conformance tests pass, also removes some errors from Metro Last Light
game which is using this API.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
On 11/11/2013 22:06, Matt Turner wrote:
On Mon, Nov 11, 2013 at 12:18 PM, Rico Schüller kgbric...@web.de wrote:
Signed-off-by: Rico Schüller kgbric...@web.de
---
src/mapi/shared-glapi/tests/Makefile.am | 1 +
src/mesa/main/tests/Makefile.am | 1 +
2 Dateien geändert, 2 Zeilen
On Tue, Nov 19, 2013 at 11:05 AM, Christian König
deathsim...@vodafone.de wrote:
From: Christian König christian.koe...@amd.com
The alignment of a virtual memory area must always be at least 4096 bytes.
It only worked because size was aligned to 4096 outside of the function.
Signed-off-by:
Having patches on a mailing list is good enough, but generally if
people *trust* you that you will have an open userspace, that's good
enough too if you have people's trust.
In my opinion, the required kernel code must land in Linus's tree
first. If it's not there, it's like it didn't exist at
For merging the patches for new hardware and/or features I agree on the
process of merging things bottom up. (e.g kernel first, then libdrm,
mesa last). But to give reasons for the merge into Linus tree it's
usually better to have a big picture you can validate the code against.
So I think
Am 19.11.2013 14:41, schrieb Marek Olšák:
On Tue, Nov 19, 2013 at 11:05 AM, Christian König
deathsim...@vodafone.de wrote:
From: Christian König christian.koe...@amd.com
The alignment of a virtual memory area must always be at least 4096 bytes.
It only worked because size was aligned to 4096
On Tue, Nov 19, 2013 at 5:05 AM, Christian König
deathsim...@vodafone.de wrote:
From: Christian König christian.koe...@amd.com
The alignment of a virtual memory area must always be at least 4096 bytes.
It only worked because size was aligned to 4096 outside of the function.
Signed-off-by:
https://bugs.freedesktop.org/show_bug.cgi?id=71506
Jon TURNEY jon.tur...@dronecode.org.uk changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=70766
--- Comment #2 from Jan Vesely jano.ves...@gmail.com ---
did you use cmake to compile llvm?
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=70766
--- Comment #3 from Jan Vesely jano.ves...@gmail.com ---
(In reply to comment #2)
did you use cmake to compile llvm?
check this patch:
http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg45916.html
--
You are receiving this mail
This is basically a a respin of f1dfcf4bce35e6796f873d9a00103b280da81e4c
per Jose's suggestion.
Just set the SVGA3dSurfaceFormatCaps flags for 3D and cube textures
when checking the texture format capabilities. This will filter out
unsupported combinations like 3D+DXT.
---
On Sun, 17 Nov 2013 12:11:41 -0600
Alexander von Gluck IV kallis...@unixzen.com wrote:
* gl.h ensures gcc is 4.x or later before using
hidden visibility. This change matches that behaviour
and ensures better compatibility for older gcc versions.
---
src/mapi/glapi/glapi.h |2 +-
On 11/19/2013 01:16 AM, Erik Faye-Lund wrote:
On Mon, Nov 18, 2013 at 9:04 PM, Paul Berry stereotype...@gmail.com wrote:
On 17 November 2013 00:24, Victor Luchitz vluch...@gmail.com wrote:
If compiler actually attempted to unroll the loop above, it would notice
that the does compile correctly.
From: José Fonseca jfons...@vmware.com
It's not necessary to scale down cubemap texture coords when generating
mipmaps: we are doing a 2x minification therefore it's guaranteed that
the texture coords will always be at least 1 texel away of the edges.
Scaling down can actually be harmful, as it
https://bugs.freedesktop.org/show_bug.cgi?id=71506
--- Comment #14 from Emil Velikov emil.l.veli...@gmail.com ---
Might be a good idea to pick this up for the 10.0 branch ?
--
You are receiving this mail because:
You are the assignee for the bug.
___
On 11/19/2013 01:05 AM, Tapani Pälli wrote:
Earlier comments suggest this was removed from GL core spec but it is
still there. Enabling makes 'texture_lod_bias_getter' Khronos
conformance tests pass, also removes some errors from Metro Last Light
game which is using this API.
Signed-off-by:
On 11/12/2013 12:13 PM, Kenneth Graunke wrote:
On 11/09/2013 01:02 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec
contradicts itself on this, but the GL4.3 spec
On 11/09/2013 01:02 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
I assume 'make check' actually passes? :)
With the change below,
Reviewed-by: Ian Romanick ian.d.roman...@intel.com.
---
Patches 1, 3, and 4 are
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
I sent a separate reply to patch 2.
On 11/09/2013 01:02 AM, Chris Forbes wrote:
From: Christoph Bumiller e0425...@student.tuwien.ac.at
Split from patch implementing ARB_draw_indirect.
v2: Const-qualify the struct
On 11/09/2013 01:02 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec
contradicts itself on this, but the GL4.3 spec disallows it.
- Make it clear that the
OK, I'll go back to allowing zero. It's silly but harmless.
On Wed, Nov 20, 2013 at 8:29 AM, Ian Romanick i...@freedesktop.org wrote:
On 11/09/2013 01:02 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
V3: - Disallow primcount==0 for
Eric Anholt e...@anholt.net writes:
Keith Packard kei...@keithp.com writes:
libudev doesn't have a stable API/ABI, and if the application wants to use
one
version, we'd best not load another into libGL.
Signed-off-by: Keith Packard kei...@keithp.com
This looks so simple it's definitely
On 11/19/2013 11:54 AM, jfons...@vmware.com wrote:
From: José Fonseca jfons...@vmware.com
It's not necessary to scale down cubemap texture coords when generating
mipmaps: we are doing a 2x minification therefore it's guaranteed that
the texture coords will always be at least 1 texel away of the
We need to check the drawbuffer's orientation before inverting Y
coordinates. Fixes piglit feedback tests when running with the
-fbo option.
Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org
---
src/mesa/state_tracker/st_cb_feedback.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
With the issues below fixed,
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 11/09/2013 01:02 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/vbo/vbo_exec_array.c | 216
Kenneth Graunke kenn...@whitecape.org writes:
SEND can't deal with swizzles, source modifiers, and so on. This should
avoid problems with VS pull constant loads on Broadwell.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp |
Tapani Pälli tapani.pa...@intel.com writes:
Earlier comments suggest this was removed from GL core spec but it is
still there. Enabling makes 'texture_lod_bias_getter' Khronos
conformance tests pass, also removes some errors from Metro Last Light
game which is using this API.
Looks to me
Eric Anholt e...@anholt.net writes:
Tapani Pälli tapani.pa...@intel.com writes:
Earlier comments suggest this was removed from GL core spec but it is
still there. Enabling makes 'texture_lod_bias_getter' Khronos
conformance tests pass, also removes some errors from Metro Last Light
game
Reviewed-by: Marek Olšák marek.ol...@amd.com
Marek
On Tue, Nov 19, 2013 at 9:11 PM, Brian Paul bri...@vmware.com wrote:
We need to check the drawbuffer's orientation before inverting Y
coordinates. Fixes piglit feedback tests when running with the
-fbo option.
Cc: 9.2 10.0
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
Keith Packard kei...@keithp.com writes:
libudev doesn't have a stable API/ABI, and if the application wants to use
one
version, we'd best not load another into libGL.
Signed-off-by: Keith Packard
Other than the tiny nit below,
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 11/19/2013 03:13 AM, Timothy Arceri wrote:
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
On 11/19/2013 01:05 AM, Tapani Pälli wrote:
Earlier comments suggest this was removed from GL core spec but it is
still there. Enabling makes 'texture_lod_bias_getter' Khronos
conformance tests pass, also removes some errors from Metro Last Light
game which is using this API.
D'oh!
I've inherited a fair amount of sillyness from the original patches...
sorry, I'll clean that up.
On Wed, Nov 20, 2013 at 9:15 AM, Ian Romanick i...@freedesktop.org wrote:
With the issues below fixed,
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 11/09/2013 01:02 AM, Chris Forbes
On 17/11/13 18:11, Alexander von Gluck IV wrote:
* gl.h ensures gcc is 4.x or later before using
hidden visibility. This change matches that behaviour
and ensures better compatibility for older gcc versions.
Hi Alexander,
AFAICS there are, currently, 11 cases of such ifdef spaghetti in
https://bugs.freedesktop.org/show_bug.cgi?id=70920
--- Comment #3 from Ian Romanick i...@freedesktop.org ---
The cause has been known since the tests were added in 2010:
commit 656cc65b2d3782c078d36342d0deec9886514520
Author: Luca Barbieri l...@luca-barbieri.com
Date: Mon Sep 6 04:56:05 2010
On Tue, Nov 19, 2013 at 2:55 PM, Emil Velikov
emil.l.veli...@gmail.com wrote:
On 17/11/13 18:11, Alexander von Gluck IV wrote:
* gl.h ensures gcc is 4.x or later before using
hidden visibility. This change matches that behaviour
and ensures better compatibility for older gcc versions.
V2: Return after error to avoid cascading error messages and
removed redundant to from error message
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp
On 19/11/13 21:27, Alexander von Gluck IV wrote:
On Tue, Nov 19, 2013 at 2:55 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 17/11/13 18:11, Alexander von Gluck IV wrote:
* gl.h ensures gcc is 4.x or later before using
hidden visibility. This change matches that behaviour
and
Stub in glTextureView API call to go with the
glTextureView API xml definition.
Includes dispatch test for glTextureView
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mapi/glapi/gen/ARB_texture_view.xml | 23
src/mapi/glapi/gen/Makefile.am | 1 +
Add helper function to set texture_view state from TexStorage calls.
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/main/textureview.c | 59 +
src/mesa/main/textureview.h | 4 +++
2 files changed, 63 insertions(+)
diff
Add state needed by glTextureView to the gl_texture_object.
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/main/mtypes.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index f6ce6d0..82fcd61 100644
---
Add support for ARB_texture_view get parameters:
GL_TEXTURE_VIEW_MIN_LEVEL
GL_TEXTURE_VIEW_NUM_LEVELS
GL_TEXTURE_VIEW_MIN_LAYER
GL_TEXTURE_VIEW_NUM_LAYERS
Incorporate feedback regarding when to allow query of
GL_TEXTURE_IMMUTABLE_LEVELS.
Signed-off-by: Courtney Goeltzenleuchter
The following patches add the necessary functions to Mesa
to support ARB_texture_view. These patches do not include
the actual driver elements, just the device independent portion.
This extension requires ARB_texture_storage.
The extension supports one new API call, glTextureView and
a handful of
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/drivers/common/driverfuncs.c | 3 +++
src/mesa/main/dd.h| 5 +
2 files changed, 8 insertions(+)
diff --git a/src/mesa/drivers/common/driverfuncs.c
b/src/mesa/drivers/common/driverfuncs.c
index
Add Mesa TextureView logic.
Incorporate feedback on ARB_texture_view
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/main/textureview.c | 562 +++-
1 file changed, 561 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 104618c..b7da884 100644
---
Call TextureView helper function to set TextureView state
appropriately for the TexStorage calls.
Misc updates from review feedback.
Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com
---
src/mesa/main/teximage.c | 6 ++
src/mesa/main/texstorage.c | 5 +++--
2 files changed, 9
The Gallium state tracker has a st_viewport that it puts into
driver-Viewport function table.
It's not clear to me how _NEW_VIEWPORT replaces the function of the
Driver-Viewport call.
Is it really safe to remove the driver-Viewport call for Gallium?
Courtney
On Mon, Nov 4, 2013 at 12:31 PM,
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms
of storage on the device, so okay to use this optimized copy routine.
This series builds on work from Frank Henigman to optimize the
process of uploading a texture to the GPU. This series adds support for
MESA_XRGB_ and full
Support all levels of a supported texture format.
Using 1024x1024, RGBA source, mipmap
internal-format Before (MB/sec) mipmap (MB/sec)
GL_RGBA 627.15 615.90
GL_RGB 456.35 611.53
512x512
GL_RGBA 597.00 619.95
GL_RGB 440.62
My apologies, I was distracted by other maters - updated commit follows.
On Mon, Nov 11, 2013 at 2:21 PM, Chad Versace
chad.vers...@linux.intel.comwrote:
On 11/08/2013 08:13 AM, Courtney Goeltzenleuchter wrote:
Support all levels of a supported texture format.
Using 1024x1024, RGBA
On 11/19/2013 04:53 PM, Courtney Goeltzenleuchter wrote:
The Gallium state tracker has a st_viewport that it puts into
driver-Viewport function table.
It's not clear to me how _NEW_VIEWPORT replaces the function of the
Driver-Viewport call.
Is it really safe to remove the driver-Viewport call
st_viewport has nothing to do with the viewport. It's used if libGL doesn't
expose __DRI_USE_INVALIDATE, so I don't think it's safe to remove it. If
Driver::Viewport is about to removed, the code of st_viewport should be
moved somewhere else.
Marek
On Wed, Nov 20, 2013 at 12:53 AM, Courtney
On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote:
The following patch will begin the process of adding ARB_viewport_array
to Mesa. Next will be to extend the gl_context Scissor and Viewport
attributes to hold multiple viewport, scissor and scissor enables.
Then the DI side of
From section 7.1 (Built-In Language Variables) of the GLSL 4.10
spec:
Also, if a built-in interface block is redeclared, no member of
the built-in declaration can be redeclared outside the block
redeclaration.
We have been regarding this text as a clarification to the behaviour
From section 7.1 (Built-In Language Variables) of the GLSL 4.10
spec:
Also, if a built-in interface block is redeclared, no member of
the built-in declaration can be redeclared outside the block
redeclaration.
We have been regarding this text as a clarification to the behaviour
Previously, when attempting to link a vertex shader and a geometry
shader that use different GLSL versions, we would sometimes generate a
link error due to the implicit declaration of gl_PerVertex being
different between the two GLSL versions.
This patch fixes that problem by only requiring
From: Tom Stellard thomas.stell...@amd.com
https://bugs.freedesktop.org/show_bug.cgi?id=69321
CC: 10.0 mesa-sta...@lists.freedesktop.org
---
src/gallium/drivers/r600/evergreen_compute.c | 4
src/gallium/drivers/r600/r600_hw_context.c | 4 +++-
src/gallium/drivers/r600/r600_pipe.h
From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
When the Clear or ClearBuffer* commands are used to clear a
layered framebuffer attachment, all layers of the attachment are
cleared.
This patch fixes the fast depth clear path.
Fixes piglit test spec/!OpenGL
From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
When the Clear or ClearBuffer* commands are used to clear a
layered framebuffer attachment, all layers of the attachment are
cleared.
This patch fixes meta clears to properly clear all layers of a layered
framebuffer
From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
When the Clear or ClearBuffer* commands are used to clear a
layered framebuffer attachment, all layers of the attachment are
cleared.
Patch 1 adds logic to the framebuffer completeness check to record the
number of
In order to properly clear layered framebuffers, we need to know how
many layers they have. The easiest way to do this is to record it in
the gl_framebuffer struct when we check framebuffer completeness, just
like we do for the Layered boolean.
Cc: 10.0 mesa-sta...@lists.freedesktop.org
---
From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
When the Clear or ClearBuffer* commands are used to clear a
layered framebuffer attachment, all layers of the attachment are
cleared.
This patch fixes the blorp clear path for color buffers.
Fixes piglit test
Cc: 10.0 mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 119 ++
1 file changed, 66 insertions(+), 53 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
index
+ if (layer_count 0) {
+ fb-NumLayers = layer_count;
It seems like in the nonlayered case there will just be junk left in
fb-NumLayers, which might trip people up in future?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
Previously we were using the code path for validating
glFramebufferTextureLayer(). But glFramebufferTexture() allows
additional texture types.
Fixes piglit tests:
- spec/!OpenGL 3.2/layered-rendering/gl-layer-cube-map
- spec/!OpenGL 3.2/layered-rendering/framebuffertexture
Cc: 10.0
From section 6.1.18 (Renderbuffer Object Queries) of the GL 3.2 spec,
under the heading If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
is TEXTURE, then:
If pname is FRAMEBUFFER_ATTACHMENT_LAYERED, then params will
contain TRUE if an entire level of a three-dimesional texture,
cube
Fixes Uninitialized pointer read defect reported by Coverity.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
This patch fixes this build error with Oracle Solaris Studio.
libtool: link: /opt/solarisstudio12.3/bin/cc -g -o glcpp/glcpp glcpp.o
prog_hash_table.o ./.libs/libglcpp.a
Undefined first referenced
symbol in file
sqrt
This patch fixes this MinGW build error.
CC glapi_gentable.lo
glapi_gentable.c:47:19: fatal error: dlfcn.h: No such file or directory
Signed-off-by: Vinson Lee v...@freedesktop.org
---
src/mapi/glapi/gen/gl_gentable.py | 2 ++
1 file changed, 2 insertions(+)
diff --git
Fixes 'make check' on distros where bash is not at /bin/bash.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
src/glsl/tests/lower_jumps/create_test_cases.py | 2 +-
src/glsl/tests/lower_jumps/lower_breaks_1.opt_test | 2 +-
I recently made us try two different things that tried to reduce register
pressure so that we would be more likely to allocate successfully. But
now that we have the logic for trying two, we can make the first thing we
try be the normal, not-prioritizing-register-pressure heuristic.
This means
73 matches
Mail list logo
