Re: [Mesa-dev] [PATCH] st/vdpau: check that the format/bindings are valid

2014-01-17 Thread Ilia Mirkin
On Fri, Jan 17, 2014 at 3:19 AM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2014 04:19, schrieb Ilia Mirkin: It's a bit unreasonable to rely on applications doing the queries and then obeying their results. Apart from a minor style comment (see below) the patch looks good to

Re: [Mesa-dev] [PATCH] st/vdpau: check that the format/bindings are valid

2014-01-17 Thread Christian König
Am 17.01.2014 09:37, schrieb Ilia Mirkin: On Fri, Jan 17, 2014 at 3:19 AM, Christian König deathsim...@vodafone.de wrote: Am 17.01.2014 04:19, schrieb Ilia Mirkin: It's a bit unreasonable to rely on applications doing the queries and then obeying their results. Apart from a minor style

Re: [Mesa-dev] [V3 PATCH 0/8] mesa: Naming MESA_FORMATs to a specification

2014-01-17 Thread Erik Faye-Lund
On Fri, Jan 17, 2014 at 9:22 AM, Christian König deathsim...@vodafone.de wrote: But as a general note on writing patches: Please limit the subject line to a sane length! Something between 60 and 80 chars should be ok. Indeed. The regex patterns are nice to have. But please, put them in the

[Mesa-dev] [PATCH libdrm] modeprint: pretty print connector names

2014-01-17 Thread Lucas Stach
Use same names as the kernel, makes it easier to identify connectors in the common case. Signed-off-by: Lucas Stach l.st...@pengutronix.de --- tests/modeprint/modeprint.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/tests/modeprint/modeprint.c

[Mesa-dev] [V3 PATCH 7/8] mesa: Rename XBGR MESA_FORMATs

2014-01-17 Thread Mark Mueller
Remove/update related comments and rename MESA_FORMAT_XBGR A Type formats to match naming spec as follows: s/\bMESA_FORMAT_XBGR_SNORM\b/MESA_FORMAT_RGBX_SNORM8/g s/\bMESA_FORMAT_XBGR_SRGB\b/MESA_FORMAT_SRGBX_UNORM8/g s/\bMESA_FORMAT_XBGR_UINT\b/MESA_FORMAT_RGBX_UINT8/g

Re: [Mesa-dev] [V3 PATCH 0/8] mesa: Naming MESA_FORMATs to a specification

2014-01-17 Thread Mark Mueller
On Fri, Jan 17, 2014 at 2:43 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Fri, Jan 17, 2014 at 9:22 AM, Christian König deathsim...@vodafone.de wrote: But as a general note on writing patches: Please limit the subject line to a sane length! Something between 60 and 80 chars should be

Re: [Mesa-dev] [PATCH 2/2] svga: fix crash when clearing null color buffer

2014-01-17 Thread Jose Fonseca
- Original Message - Fixes regression since 9baa45f78b8ca7d66280e36009b6a685055d7cd6 but some of the piglit fbo-drawbuffers-none tests still don't pass. --- src/gallium/drivers/svga/svga_pipe_clear.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Calculate interference better in register_coalesce.

2014-01-17 Thread Pohjolainen, Topi
On Fri, Jan 10, 2014 at 02:29:04PM -0800, Matt Turner wrote: On Wed, Dec 25, 2013 at 2:11 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Thu, Dec 19, 2013 at 01:40:23PM -0800, Matt Turner wrote: Previously we simply considered two registers whose live ranges overlapped to

Re: [Mesa-dev] code de-duplication and non-pci support v2

2014-01-17 Thread Rob Clark
On Thu, Jan 16, 2014 at 6:55 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 16/01/14 23:29, Kristian Høgsberg wrote: On Sat, Jan 11, 2014 at 04:51:42PM -0500, Rob Clark wrote: On Sat, Jan 11, 2014 at 11:54 AM, Emil Velikov emil.l.veli...@gmail.com wrote: This is an updated series of

[Mesa-dev] [PATCH 1/2] trace: Re-license trace.xsl under MIT license.

2014-01-17 Thread jfonseca
From: José Fonseca jfons...@vmware.com I was the sole author, as Tungsten Graphics employee, which was since then acquired by VMware Inc. --- src/gallium/drivers/trace/trace.xsl | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] trace: Re-license trace.xsl under MIT license.

2014-01-17 Thread Brian Paul
On 01/17/2014 08:33 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com I was the sole author, as Tungsten Graphics employee, which was since then acquired by VMware Inc. --- src/gallium/drivers/trace/trace.xsl | 36 ++-- 1 file changed, 22

[Mesa-dev] [Bug 73746] New: Gallum HUD not always visible with Rust

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73746 Priority: medium Bug ID: 73746 Assignee: mesa-dev@lists.freedesktop.org Summary: Gallum HUD not always visible with Rust Severity: normal Classification: Unclassified OS:

Re: [Mesa-dev] [wip 9/9] mesa: OES_get_program_binary extension functionality

2014-01-17 Thread Paul Berry
On 16 January 2014 05:37, Tapani Pälli tapani.pa...@intel.com wrote: On 01/15/2014 06:13 PM, Paul Berry wrote: On 2 January 2014 03:58, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/shaderapi.c | 44

Re: [Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

2014-01-17 Thread Brian Paul
On 01/16/2014 10:13 PM, Mark Mueller wrote: This series encompases the much discussed specification and renaming of MESA_FORMATs, which now is packed into 8 patches Signed-off-by: Mark Mueller markkmuel...@gmail.com --- Well, our other enum typedefs (and structs) all use the gl_ prefix. But

Re: [Mesa-dev] [wip 8/9] glsl: functions to serialize gl_shader and gl_shader_program

2014-01-17 Thread Paul Berry
On 15 January 2014 02:46, Tapani tapani.pa...@intel.com wrote: On 01/14/2014 07:53 PM, Paul Berry wrote: On 2 January 2014 03:58, Tapani Pälli tapani.pa...@intel.com wrote: +static void +serialize_uniform_storage(gl_uniform_storage *uni, memory_writer blob) I don't think this is

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Brian Paul
On 01/17/2014 03:45 AM, Mark Mueller wrote: Change all 4 color component unsigned byte formats to meet spec: s/MESA_FORMAT_RGBA\b/MESA_FORMAT_ABGR_UNORM8/g s/MESA_FORMAT_RGBA_REV\b/MESA_FORMAT_RGBA_UNORM8/g s/MESA_FORMAT_ARGB\b/MESA_FORMAT_BGRA_UNORM8/g

Re: [Mesa-dev] [wip 1/9] glsl: memory_writer helper class for data serialization

2014-01-17 Thread Paul Berry
On 14 January 2014 02:35, Tapani Pälli tapani.pa...@intel.com wrote: On 01/13/2014 08:27 PM, Paul Berry wrote: On 2 January 2014 03:58, Tapani Pälli tapani.pa...@intel.com wrote: Class will be used by the shader binary cache implementation. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [wip 6/9] glsl: ir_deserializer class for the binary shader cache

2014-01-17 Thread Paul Berry
On 14 January 2014 03:35, Tapani Pälli tapani.pa...@intel.com wrote: On 01/14/2014 01:24 AM, Paul Berry wrote: On 2 January 2014 03:58, Tapani Pälli tapani.pa...@intel.com wrote: + var-state_slots = NULL; + + if (var-num_state_slots 0) { + var-state_slots = ralloc_array(var,

[Mesa-dev] [Bug 73746] Gallum HUD not always visible with Rust

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73746 --- Comment #1 from Marek Olšák mar...@gmail.com --- Did you compile Mesa with --enable-gallium-egl? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [PATCH] draw: clean up d3d style point clipping

2014-01-17 Thread sroland
From: Roland Scheidegger srol...@vmware.com Instead of skipping x/y clipping completely if there's point_tri_clip points use guard band clipping. This should be easier (previously we could not disable generating the x/y bits in the clip mask for llvm path, hence requiring custom clip path), and

[Mesa-dev] [Bug 73746] Gallum HUD not always visible with Rust

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73746 --- Comment #2 from Thomas Rohloff v10la...@myway.de --- (In reply to comment #1) Did you compile Mesa with --enable-gallium-egl? Yes. Also with other games (for example: Left 4 Dead 2) it works. -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add local value numbering optimization pass.

2014-01-17 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner matts...@gmail.com wrote: total instructions in shared programs: 1520829 - 1511991 (-0.58%) instructions in affected programs: 559725 - 550887 (-1.58%) GAINED:6 LOST: 9 ---

Re: [Mesa-dev] [PATCH 1/2] i965: Stop doing our optimization on a copy of the GLSL IR.

2014-01-17 Thread Ian Romanick
On 01/13/2014 10:28 PM, Eric Anholt wrote: The original intent was that we'd keep a driver-private copy, and there would be the normal copy for swrast to make use of without the tuning (or anything more invasive we might do) specific to i965. Only, we don't generate swrast code any more,

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Mark Mueller
On Fri, Jan 17, 2014 at 8:58 AM, Brian Paul bri...@vmware.com wrote: On 01/17/2014 03:45 AM, Mark Mueller wrote: Change all 4 color component unsigned byte formats to meet spec: s/MESA_FORMAT_RGBA\b/MESA_FORMAT_ABGR_UNORM8/g s/MESA_FORMAT_RGBA_REV\b/MESA_FORMAT_RGBA_UNORM8/g

[Mesa-dev] [PATCH V2 1/3] i965: Add an option to ignore sample qualifier

2014-01-17 Thread Anuj Phogat
This will be useful in my next patch which depends on a functionality of _mesa_get_min_invocations_per_fragment() to ignore the sample qualifier (prog-IsSample) based on a flag passed to it. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Chris Forbes chr...@ijw.co.nz Cc:

Re: [Mesa-dev] [PATCH 2/2] s/Tungsten Graphics/VMware/

2014-01-17 Thread Ian Romanick
On 01/17/2014 08:33 AM, jfons...@vmware.com wrote: diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/src/mesa/drivers/dri/r200/r200_context.c index f82424b..f613e56 100644 --- a/src/mesa/drivers/dri/r200/r200_context.c +++ b/src/mesa/drivers/dri/r200/r200_context.c @@ -29,7 +29,7 @@

Re: [Mesa-dev] [PATCH 2/2] s/Tungsten Graphics/VMware/

2014-01-17 Thread Brian Paul
On 01/17/2014 12:56 PM, Ian Romanick wrote: On 01/17/2014 08:33 AM, jfons...@vmware.com wrote: diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/src/mesa/drivers/dri/r200/r200_context.c index f82424b..f613e56 100644 --- a/src/mesa/drivers/dri/r200/r200_context.c +++

Re: [Mesa-dev] Fwd: munmap_chunk(): invalid pointer in libgl1-mesa-dri_9.2.1-1

2014-01-17 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/16/2014 10:42 PM, scarp wrote: Hi, I originally posted this to dri-users and got no response. I thought about it further and decided it's really a bug and deserves to be posted to dri-devel, after all it is a crash and crashes are

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add local value numbering optimization pass.

2014-01-17 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner matts...@gmail.com wrote: Could you add some commit message text? Maybe with a small example. total instructions in shared programs: 1520829 - 1511991 (-0.58%) instructions in affected programs: 559725 - 550887 (-1.58%) GAINED:

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Marek Olšák
The test seems to work correctly with 32 textures per stage. It tests that all textures return the correct color, but the sampler state is always the same. Marek On Thu, Jan 16, 2014 at 1:28 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 01/15/2014 12:56 PM, Chris Forbes wrote: Does this

Re: [Mesa-dev] [PATCH 0/2] code de-duplication and non-pci support

2014-01-17 Thread Ian Romanick
With Kristian's comment about keeping the original copyright notices intact addressed, patches 1, 2, 3, 4, 7, 8, and 10 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 12/14/2013 11:28 AM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org It seems that over time, code

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Ian Romanick
On 01/17/2014 01:08 PM, Marek Olšák wrote: The test seems to work correctly with 32 textures per stage. It tests that all textures return the correct color, but the sampler state is always the same. Which is the problem. The method we're using to access samplers works fine for up to 16, but

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Marek Olšák
Incorrect. You have to manually check if the pack and unpack functions access the components using bitwise operations or arrays. Consider char pix[]. The array formats use arrays for accessing, for example: char *p = pix[(y*width+x)*4]; p[0] = r; p[1] = g; p[2] = b; p[3] = a; Packed formats use

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Brian Paul
On 01/17/2014 12:41 PM, Mark Mueller wrote: On Fri, Jan 17, 2014 at 8:58 AM, Brian Paul bri...@vmware.com mailto:bri...@vmware.com wrote: On 01/17/2014 03:45 AM, Mark Mueller wrote: Change all 4 color component unsigned byte formats to meet spec:

Re: [Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

2014-01-17 Thread Chris Forbes
Ken, Assuming the caches don't completely derail things, you ought to be able to make this work with pretty minimal impact: - Keep the low four bits of the sampler index where they are - If the 5th bit is set: - Force message header on - Add 16*sizeof(sampler_state) to the copy of r0.3

Re: [Mesa-dev] [PATCH 13/16] i965/fs: Add a saturation propagation optimization pass.

2014-01-17 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner matts...@gmail.com wrote: Transforms, for example, mul vgrf3, vgrf2, vgrf1 mov.sat vgrf4, vgrf3 into mul.sat vgrf3, vgrf2, vgrf1 mov vgrf4, vgrf3 which gives register_coalescing an opportunity to remove the MOV instruction. total

Re: [Mesa-dev] [PATCH 2/2] s/Tungsten Graphics/VMware/

2014-01-17 Thread Jose Fonseca
- Original Message - On 01/17/2014 12:56 PM, Ian Romanick wrote: On 01/17/2014 08:33 AM, jfons...@vmware.com wrote: diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/src/mesa/drivers/dri/r200/r200_context.c index f82424b..f613e56 100644 ---

[Mesa-dev] [Bug 73631] es2tri fragment shader did not compile AMD ARUBA

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73631 --- Comment #1 from Ian Romanick i...@freedesktop.org --- It sounds like the shader is broken. Probably just add precision mediump float; at global scope before any float (or vec, or mat) types are used. -- You are receiving this mail

[Mesa-dev] [Bug 73631] es2tri fragment shader did not compile AMD ARUBA

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73631 --- Comment #2 from Emil Velikov emil.l.veli...@gmail.com --- Nice one Ian, adding precision mediump float; before the vec4 variable declaration in the fragment shader did the job. Running nouveau on a nv96, in case it matters. -- You are

[Mesa-dev] [PATCH] cl: Add support for OpenCV unit tests v2

2014-01-17 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This enables piglit to run and interpret the results from OpenCV's gtest based opencv_test_ocl program. This patch adds two new CMake configuration variables: OPENCL_OpenCVTestOCL_BINDIR: You can use this variable to enable the OpenCV tests by setting

Re: [Mesa-dev] [PATCH] i965: Modify some error messages to refer to vec4 instead of vs.

2014-01-17 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Modify some error messages to refer to vec4 instead of vs.

2014-01-17 Thread Ian Romanick
On 01/17/2014 02:14 PM, Paul Berry wrote: These messages are in code that is shared between the VS and GS back-ends, so use the terminology vec4 to avoid confusion. Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 8

[Mesa-dev] [PATCH] i965: Add GS support to INTEL_DEBUG=shader_time.

2014-01-17 Thread Paul Berry
Previously, time spent in geometry shaders would be counted as part of the vertex shader time. --- src/mesa/drivers/dri/i965/brw_context.h | 3 +++ src/mesa/drivers/dri/i965/brw_program.c | 10 +- src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [Bug 73100] Please use AC_PATH_TOOL instead of AC_PATH_PROG for llvm-config

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73100 Michał Górny mgo...@gentoo.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Mark Mueller
On Fri, Jan 17, 2014 at 1:24 PM, Marek Olšák mar...@gmail.com wrote: Incorrect. You have to manually check if the pack and unpack functions access the components using bitwise operations or arrays. Consider char pix[]. The array formats use arrays for accessing, for example: char *p =

Re: [Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

2014-01-17 Thread Marek Olšák
On Sat, Jan 18, 2014 at 12:45 AM, Mark Mueller markkmuel...@gmail.com wrote: On Fri, Jan 17, 2014 at 1:24 PM, Marek Olšák mar...@gmail.com wrote: Incorrect. You have to manually check if the pack and unpack functions access the components using bitwise operations or arrays. Consider char

[Mesa-dev] [PATCH 00/37] GL_ARB_viewport_array v2

2014-01-17 Thread Ian Romanick
This is the overall v2 of the GL_ARB_viewport_array series. It is mostly the same as the previous series, but there are some differences worth noting. Patch i965: Consider all scissor rectangles in noop_scissor in the original series was replaced by i965: Consider only the scissor rectangle for

[Mesa-dev] [PATCH 01/37] mesa: Add extension tracking bit for ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Split these changes out from the original patch. Only advertise GL_ARB_viewport_array in a core profile because it requires geometry shaders. Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 05/37] mesa: Allow glGet of values that are 2 doubles

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com This will be used when the viewport near and far plane are stored as doubles instead of as floats. v4 (idr): Split out from a single megapatch. Suggested by Ken. Also drop value_double_4. It's never used anywhere in the patch series.

[Mesa-dev] [PATCH 03/37] mesa: Update gl_scissor_attrib to support ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com Update Mesa and drivers to access updated gl_scissor_attrib. Now have an enable bitfield and array of gl_scissor_rects. Drivers have been updated to the new scissor enable state attribute (gl_context.scissor.EnableFlags) but still treat it as a

[Mesa-dev] [PATCH 06/37] mesa: Convert gl_viewport_attrib::Near and ::Far to double

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v4: Split out from a single megapatch. Suggested by Ken. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 5 + src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 2 +-

[Mesa-dev] [PATCH 15/37] mesa: Restore all the scissor rectangles in _mesa_PopAttrib

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/attrib.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/attrib.c

[Mesa-dev] [PATCH 22/37] mesa: Add custom get function for SCISSOR_TEST to _mesa_IsEnabledi

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com Now that the scissor enable state is a bitfield need a custom function to extract the correct value from gl_context. Modeled Scissor.EnableFlags after Color.BlendEnabled. Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com

[Mesa-dev] [PATCH 12/37] mesa: Refactor scissor rectangle setting even more

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Create an internal function that just writes data into the scissor rectangle. In future patches this will see more use because we only want to call dd_function_table::Scissor once after setting all of the scissor rectangles instead of once per scissor

[Mesa-dev] [PATCH 19/37] meta: Restore all scissor state

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously the restore code would enable all scissor rectangles if any scissor rectangles were enabled on entry to meta. When there is only one scissor rectangle, this is fine. As soon as a driver supports multiple viewports, this will be a problem.

[Mesa-dev] [PATCH 07/37] mesa: Converty gl_viewport_attrib::X, ::Y, ::Width, and ::Height to float

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v4: Split out from a single megapatch. Suggested by Ken. Also make meta's save_state::ViewportX, ::ViewportY, ::ViewportW, and ::ViewportH to match gl_viewport_attrib. Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com

[Mesa-dev] [PATCH 29/37] i965: Set the maximum VPIndex

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com At various stages the hardware clamps the gl_ViewportIndex to these values. Setting them to zero effectively makes gl_ViewportIndex be ignored. This is acutally useful in blorp (so that we don't have to modify all of the viewport / scissor state).

[Mesa-dev] [PATCH 08/37] mesa: Convert gl_context::Viewport to gl_context::ViewportArray

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com Only element 0 of the array is used anywhere at this time, so there should be no changes. v4: Split out from a single megapatch. Suggested by Ken. Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 04/37] mesa: Move parameter validation from _mesa_set_viewport to _mesa_Viewport

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Internal callers should do the right thing. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/viewport.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH 09/37] mesa: Add an index parameter to _mesa_set_viewport

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/common/meta.c | 14 +++--- src/mesa/main/context.c| 2 +- src/mesa/main/viewport.c | 24

[Mesa-dev] [PATCH 33/37] i965: Set all the supported scissor rectangles for GEN7

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Currently MaxViewports is still 1, so this won't affect any change. v2: Minor code reformatting suggested by Ken. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 23/37] mesa: Add new scissor entry points for GL_ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Use set_scissor_no_notify (and manually notify the driver) instead of calling _mesa_set_scissori. Refactory bodies of _mesa_ScissorIndexed and _mesa_ScissorIndexedv into a shared function. Perform parameter validation in the same

[Mesa-dev] [PATCH 21/37] mesa: Add new get entrypoints for ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Fix several comparison between signed and unsigned integer expressions warnings. Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH 17/37] mesa: Set all viewports from _mesa_Viewport and _mesa_DepthRange

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com In _mesa_Viewport and _mesa_DepthRange, make sure that ctx-Driver.Viewport is only called once instead of once per viewport or depth range. v2: Make _mesa_DepthRange actually set all of the depth ranges (instead of just index 0). Noticed by Ken.

[Mesa-dev] [PATCH 28/37] mesa: Add ARB_viewport_array plumbing

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com Define API connections to extension entry points added in previous commits. Update entry points to use floating point arguments as required by the extension. Add get tokens for ARB_viewport_array state. v2: Include review feedback. v3 (idr):

[Mesa-dev] [PATCH 11/37] mesa: Refactor viewport setting even more

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Create an internal function that just writes data into the viewport. In future patches this will see more use because we only want to call dd_function_table::Viewport once after setting all of the viewport instead of once per viewport. Signed-off-by:

[Mesa-dev] [PATCH 27/37] glsl: Add gl_ViewportIndex built-in variable

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Fix copy-and-paste bug... s/LAYER/VIEWPORT/ Signed-off-by: Courtney Goeltzenleuchter court...@lunarg.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 25/37] mesa: Add varying slot for viewport index

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/mtypes.h| 2 ++ src/mesa/program/prog_print.c | 10 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 02/37] mesa: Add new constants related to GL_ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com These limits will be queryable by GL_MAX_VIEWPORTS, GL_VIEWPORT_SUBPIXEL_BITS, and GL_VIEWPORT_BOUNDS_RANGE. Drivers that actually implement the extension must set values for these constants that comply with the minimum-maximums from the spec. Most of

[Mesa-dev] [PATCH 31/37] i965: Set all the supported viewports for GEN7

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Currently MaxViewports is still 1, so this won't affect any change. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_cc.c | 21 +

[Mesa-dev] [PATCH 24/37] mesa: Add new viewport and depth-range entry points for GL_ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Use set_viewport_no_notify / set_depth_range_no_notify (and manually notify the driver) instead of calling _mesa_set_viewporti / _mesa_set_depthrangei. Refactor bodies of _mesa_ViewportIndexed and _mesa_ViewportIndexedv into a shared

[Mesa-dev] [PATCH 14/37] mesa: Initialize all the viewports

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com v2: Use MAX_VIEWPORTS instead of ctx-Const.MaxViewports because the driver may not set ctx-Const.MaxViewports yet. v3: Handle all viewport entries in update_viewport_matrix and _mesa_copy_context too. This was previously in an earlier patch. Having

[Mesa-dev] [PATCH 37/37] docs: Note that GL_ARB_viewport_array is done on i965

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com At least for GEN7+, anyway. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- docs/GL3.txt| 2 +- docs/relnotes/10.1.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 26/37] glsl: Add extension infrastructure for ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++

[Mesa-dev] [PATCH 35/37] i965: Consider all viewports before enabling guardband clipping

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen6_clip_state.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 20/37] mesa: Change parameter to _mesa_set_viewport to float

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This matches the expectations of GL_ARB_viewport_array and the storage type where the values will land. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/viewport.c | 13

[Mesa-dev] [PATCH 32/37] mesa: Refactor bounding-box calculation out of _mesa_update_draw_buffer_bounds

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Drivers that currently use _Xmin and friends to set their scissor rectangle will need to use this code directly once they are updated for GL_ARB_viewport_array. v2: Use different bit-test idiom and fix mixed tabs and spaces. Both were suggested by

[Mesa-dev] [PATCH 18/37] mesa: Set all scissor rects

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com In _mesa_Scissor, make sure that ctx-Driver.Scissor is only called once instead of once per scissor rectangle. v2: Use MAX_VIEWPORTS instead of ctx-Const.MaxViewports because the driver may not set ctx-Const.MaxViewports yet. Signed-off-by: Ian

[Mesa-dev] [PATCH 10/37] mesa: Refactor depth range setting even more

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Create an internal function that just writes data into the depth range. In future patches this will see more use because we only want to call dd_function_table::DepthRange once after setting all of the depth ranges instead of once per depth range.

[Mesa-dev] [PATCH 13/37] mesa: Add an index parameter to _mesa_set_scissor

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/attrib.c | 2 +- src/mesa/main/context.c | 2 +- src/mesa/main/scissor.c | 6 +++--- src/mesa/main/scissor.h | 2 +- 4 files

[Mesa-dev] [PATCH 36/37] i965: Enable ARB_viewport_array

2014-01-17 Thread Ian Romanick
From: Courtney Goeltzenleuchter court...@lunarg.com v2 (idr): Only enable the extension on GEN7+ w/core profile because it requires geometry shaders. v3 (idr): Add some casting to fix setting of ViewportBounds.Min. Negating an unsigned value, then casting to float doesn't do what you might think

[Mesa-dev] [PATCH 30/37] i965: Emit writes to viewport index

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This variable is handled in a fashion identical to gl_Layer. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4

[Mesa-dev] [PATCH 34/37] i965: Consider only the scissor rectangle for viewport 0 for clears

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com noop_scissor (correctly) only examines the scissor rectangle for viewport 0. Therefore, it should only be called when that scissor rectangle is enabled. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_clear.c

[Mesa-dev] [PATCH 16/37] mesa: Restore all the viewports in _mesa_PopAttrib

2014-01-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/main/attrib.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/attrib.c

[Mesa-dev] [PATCH] i965: Only update renderbuffers on initial intelMakeCurrent

2014-01-17 Thread Kristian Høgsberg
We call intel_prepare_render() in intelMakeCurrent() to make sure we have renderbuffers before calling _mesa_make_current(). The only reason we do this is so that we can have valid defaults for width and height. If we already have buffers for the drawable we're making current, we don't need to do

Re: [Mesa-dev] [PATCH 34/37] i965: Consider only the scissor rectangle for viewport 0 for clears

2014-01-17 Thread Kenneth Graunke
On 01/17/2014 05:03 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com noop_scissor (correctly) only examines the scissor rectangle for viewport 0. Therefore, it should only be called when that scissor rectangle is enabled. Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH] i965: Only update renderbuffers on initial intelMakeCurrent

2014-01-17 Thread Matt Turner
On Fri, Jan 17, 2014 at 5:21 PM, Kristian Høgsberg k...@bitplanet.net wrote: We call intel_prepare_render() in intelMakeCurrent() to make sure we have renderbuffers before calling _mesa_make_current(). The only reason we do this is so that we can have valid defaults for width and height. If

[Mesa-dev] [Bug 73755] New: [softpipe] piglit fbo-missing-attachment-blit es2 from regression

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73755 Priority: medium Bug ID: 73755 Keywords: regression CC: bri...@vmware.com, mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit

[Mesa-dev] [Bug 73757] New: [swrast] SIGSEGV swrast/s_renderbuffer.c:559

2014-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73757 Priority: medium Bug ID: 73757 Assignee: mesa-dev@lists.freedesktop.org Summary: [swrast] SIGSEGV swrast/s_renderbuffer.c:559 Severity: normal Classification: Unclassified

Re: [Mesa-dev] [PATCH 4/9] glsl: Add array specifier to ast code

2014-01-17 Thread Timothy Arceri
diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 21dc3ab..92076b5 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -484,6 +484,7 @@ struct _mesa_glsl_extension { static const _mesa_glsl_extension

[Mesa-dev] [PATCH 3/3] st/vdpau: check surface params before creating resources

2014-01-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This seems like a function that should exist in gallium/util, but I didn't find it. I guess the mesa/st does these checks far enough away from actual resource creation. src/gallium/state_trackers/vdpau/bitmap.c| 4

[Mesa-dev] [PATCH 2/3] st/vdpau: fix bogus error handling in output/bitmap creation

2014-01-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- I can't say I'm happy about re-grabbing the mutex in the error path, but I assume it must be taken to delete a sampler view. I could move the AddDataHTAB thing inside the mutex, but I assumed it was like that for a reason -- could be a perf

[Mesa-dev] [PATCH 1/3] st/vdpau: don't return a device if the screen doesn't support NPOT

2014-01-17 Thread Ilia Mirkin
NV3x cards don't support NPOT textures. Technically this restriction could be worked around, but since it also doesn't expose any video decoding hw, just turn it off entirely. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.0 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH 3/3] st/vdpau: check surface params before creating resources

2014-01-17 Thread Ilia Mirkin
On Fri, Jan 17, 2014 at 11:58 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This seems like a function that should exist in gallium/util, but I didn't find it. I guess the mesa/st does these checks far enough away from actual resource

[Mesa-dev] [PATCH 1/5] glsl: Mark GLSL 4.40 as a known version.

2014-01-17 Thread Matt Turner
--- src/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 21dc3ab..e67988f 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -50,7 +50,7 @@

[Mesa-dev] [PATCH 2/5] glsl: Disable ARB_texture_rectangle in shader version 100.

2014-01-17 Thread Matt Turner
From: Anuj Phogat anuj.pho...@gmail.com OpenGL with ARB_ES2_compatibility allows shaders that specify #version 100. This fixes the Khronos OpenGL test(Texture_Rectangle_Samplers_frag.test) failure. Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Matt Turner matts...@gmail.com Signed-off-by:

[Mesa-dev] [PATCH 3/5] glcpp: Set extension defines after resolving the GLSL version.

2014-01-17 Thread Matt Turner
Instead of defining preprocessor macros in glcpp_parser_create based on the GL API, wait until the shader version has been resolved. Doing this allows us to correctly set (and not set) preprocessor macros for extensions allowed by the API but not the shader, as in the case of

[Mesa-dev] [PATCH 4/5] glcpp: Remove unused gl_api bits.

2014-01-17 Thread Matt Turner
--- src/glsl/glcpp/glcpp-parse.y | 1 - src/glsl/glcpp/glcpp.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index c774662..427fdec 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -30,7 +30,6

[Mesa-dev] [PATCH 5/5] glcpp: Define GL_EXT_shader_integer_mix in both GL and ES.

2014-01-17 Thread Matt Turner
Cc: mesa-sta...@lists.freedesktop.org --- src/glsl/glcpp/glcpp-parse.y | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 427fdec..995427a 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++

Re: [Mesa-dev] [PATCH] glsl: Set ARB_texture_rectangle_enable to false if version 100 shader

2014-01-17 Thread Matt Turner
On Mon, Dec 9, 2013 at 6:00 PM, Anuj Phogat anuj.pho...@gmail.com wrote: OpenGL with ARB_ES2_compatibility extension allows shaders that specify #version 100 and the shader is treated as targeting version 100 of the GLSL ES. state-es_shader flag might change during parsing based on the

  1   2   >