Re: [Mesa-dev] [PATCH 2/3] ra: Create a reg_belongs_to_class() helper function.

It's a bit picky as compilers are likely to detect this themselves, but an 'inline' might be nice. Nonetheless I'm in favor for everything that improves code readability, so: Reviewed-By: Christoph Brill egore...@gmail.com Am 17.03.2014 21:32 schrieb Kenneth Graunke kenn...@whitecape.org:

Re: [Mesa-dev] [PATCH] [RFC] include/pipe: all major Linux libc support endian.h

On Fri, Mar 14, 2014 at 7:57 PM, David Heidelberger david.heidelber...@ixit.cz wrote: --- src/gallium/include/pipe/p_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_config.h b/src/gallium/include/pipe/p_config.h index d603681..cd6f560

Re: [Mesa-dev] [PATCH] [RFC] include/pipe: all major Linux libc support endian.h

Dne 2014-03-18 13:43, Erik Faye-Lund napsal: On Fri, Mar 14, 2014 at 7:57 PM, David Heidelberger david.heidelber...@ixit.cz wrote: --- src/gallium/include/pipe/p_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_config.h

[Mesa-dev] [Bug 75919] LLVM changed output of llvm-config, again

https://bugs.freedesktop.org/show_bug.cgi?id=75919 --- Comment #5 from Dave Witbrodt dawit...@sbcglobal.net --- (In reply to comment #4) LLVM 3.5 packages for Debian at llvm.org/apt have been fixed for about a week. Looks like I need a patch from bug 70410 to build Mesa for RadeonSI, though. --

Re: [Mesa-dev] [PATCH] [RFC] include/pipe: all major Linux libc support endian.h

On Tue, Mar 18, 2014 at 3:18 PM, David Heidelberger david.heidelber...@ixit.cz wrote: Dne 2014-03-18 13:43, Erik Faye-Lund napsal: On Fri, Mar 14, 2014 at 7:57 PM, David Heidelberger david.heidelber...@ixit.cz wrote: --- src/gallium/include/pipe/p_config.h | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] i965: Drop some more dead code from the old CACHED_BATCH feature.

On Mon, Mar 17, 2014 at 02:53:33PM -0700, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 1 - src/mesa/drivers/dri/i965/brw_context.h | 9 - src/mesa/drivers/dri/i965/intel_batchbuffer.c | 27 ---

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

https://bugs.freedesktop.org/show_bug.cgi?id=70410 Dave Witbrodt dawit...@sbcglobal.net changed: What|Removed |Added CC|

[Mesa-dev] OpenCL Image Support

Hi, I am a student. I have experience in OpenCL for 3 years. I would like to know what need to be done exactly. Thank you -- Regards, *Atluri Aditya Avinash.* ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #22 from Tom Stellard tstel...@gmail.com --- (In reply to comment #21) I am not a developer, but try to test upstream code related to my GPU (RadeonSI) to catch problems early. It can be weeks (sometimes even months) between

[Mesa-dev] [PATCH 1/4] loader: use 0 instead of FALSE which isn't defined

Signed-off-by: Jonathan Gray j...@jsg.id.au --- src/loader/loader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git src/loader/loader.c src/loader/loader.c index 811f8a2..caeeebf 100644 --- src/loader/loader.c +++ src/loader/loader.c @@ -219,12 +219,12 @@

[Mesa-dev] [PATCH 3/4] glx/dri2: handle dri authenticating before calling the loader.

The loader may issue dri ioctls to determine the driver name. Signed-off-by: Jonathan Gray j...@jsg.id.au --- src/glx/dri2_glx.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git src/glx/dri2_glx.c src/glx/dri2_glx.c index 5a960b0..b61422f 100644 ---

[Mesa-dev] [PATCH 4/4] megadriver_stub.c: don't use _GNU_SOURCE to gate the compat code

_GNU_SOURCE is only set/required for linux*|*-gnu*|gnu*) and as the functionality is available on other systems check for RTLD_DEFAULT instead. Signed-off-by: Jonathan Gray j...@jsg.id.au --- src/mesa/drivers/dri/common/megadriver_stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

Signed-off-by: Jonathan Gray j...@jsg.id.au --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/loader/loader.c src/loader/loader.c index caeeebf..1744acb 100644 --- src/loader/loader.c +++ src/loader/loader.c @@ -202,7 +202,7 @@ out: return (*chip_id

[Mesa-dev] [PATCH] gallium glsl: Fix crash with piglit fs-deref-literal-array-of-structs.shader_test

Use the recursive copy from emit_block_mov to allow constant declarations to work. This allows the following code to work without a weird crash: struct Foo { int value[1]; }; int actual_value = Foo[2](Foo(int[1](100)), Foo(int[1](200)))[i].value[0]; Signed-off-by: Maarten Lankhorst

Re: [Mesa-dev] [PATCH] i965: Drop some more dead code from the old CACHED_BATCH feature.

On 03/17/2014 02:53 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 1 - src/mesa/drivers/dri/i965/brw_context.h | 9 - src/mesa/drivers/dri/i965/intel_batchbuffer.c | 27 --- src/mesa/drivers/dri/i965/intel_batchbuffer.h |

Re: [Mesa-dev] [PATCH] i965: Drop special case for edgeflag thanks to Marek's change to core.

On 03/17/2014 03:03 PM, Paul Berry wrote: On 17 March 2014 14:54, Eric Anholt e...@anholt.net mailto:e...@anholt.net wrote: --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 9 - 1 file changed, 9 deletions(-) For future cross-referencing it would be nice to

[Mesa-dev] [Bug 76331] New: register_allocate.h:67:1: error: unknown type name 'bool' bool ra_select(struct ra_graph *g);

https://bugs.freedesktop.org/show_bug.cgi?id=76331 Priority: medium Bug ID: 76331 Assignee: mesa-dev@lists.freedesktop.org Summary: register_allocate.h:67:1: error: unknown type name 'bool' bool ra_select(struct ra_graph *g);

[Mesa-dev] [Bug 76331] register_allocate.h:67:1: error: unknown type name 'bool' bool ra_select(struct ra_graph *g);

https://bugs.freedesktop.org/show_bug.cgi?id=76331 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #12 from Benjamin Bellec b.bel...@gmail.com --- I'm not able to reproduce it (tested with RV770 and CYPRESS) with current master Mesa 10.2.0-devel (git-f74cf5f). gl-320-primitive-sprite and gl-320-primitive-shading just run and close

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

On 18/03/14 14:59, Jonathan Gray wrote: Signed-off-by: Jonathan Gray j...@jsg.id.au --- Hi Jonathan While the summary covers what the patch does, the *ahem* commit message fails to explain why it's needed. AFAICS this will cause some very nasty breakage in some cases, which we want to avoid

Re: [Mesa-dev] [PATCH] i965: Avoid dependency hints on math opcodes

On 02/28/2014 02:35 PM, Mike Stroyan wrote: Matt, You haven't replied to my mail with an updated shader test that shows the math instructions alone causing trouble. I don't think Matt has time to do that. Could you please trim down your shader test to a smaller case which demonstrates the

[Mesa-dev] [PATCH 1/2] glsl: Expose pack/unpack built-ins for ARB_gpu_shader5.

ARB_gpu_shader5 and ES 3.0 expose different subsets of ARB_shading_language_packing. --- src/glsl/builtin_functions.cpp | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index

[Mesa-dev] [PATCH 2/2] glsl: Match whitespace changes from previous patch.

--- src/glsl/builtin_functions.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 3df2e3a..44c30c0 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@ -1000,15

Re: [Mesa-dev] [PATCH 1/2] glsl: Expose pack/unpack built-ins for ARB_gpu_shader5.

On Tue, Mar 18, 2014 at 4:00 PM, Matt Turner matts...@gmail.com wrote: ARB_gpu_shader5 and ES 3.0 expose different subsets of ARB_shading_language_packing. --- src/glsl/builtin_functions.cpp | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH] c11/threads: don't include assert.h if the assert macro is already defined

In the gallium code, the assert() macro could come from either the system's assert.h file (via c11/threads.h) or from gallium's u_debug.h. It looks like all known assert.h files unconditionally #undef assert before defining their own version. So the assert you get depends on whether threads.h or

Re: [Mesa-dev] [PATCH 1/2] glsl: Expose pack/unpack built-ins for ARB_gpu_shader5.

On 03/18/2014 04:00 PM, Matt Turner wrote: ARB_gpu_shader5 and ES 3.0 expose different subsets of ARB_shading_language_packing. --- src/glsl/builtin_functions.cpp | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH 03/40] mesa: Eliminate parameters to dd_function_table::Viewport

On 03/17/2014 10:15 AM, Brian Paul wrote: On 03/16/2014 02:52 PM, Alexander von Gluck IV wrote: On 01/10/2014 07:40 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com No driver uses them. They will just be annoying in future patches. Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: On 18/03/14 14:59, Jonathan Gray wrote: Signed-off-by: Jonathan Gray j...@jsg.id.au --- Hi Jonathan While the summary covers what the patch does, the *ahem* commit message fails to explain why it's needed. AFAICS this will

Re: [Mesa-dev] OpenCL Image Support

On Mon, Mar 17, 2014 at 10:50:18PM -0400, Aditya Avinash wrote: Hi, I am a student. I have experience in OpenCL for 3 years. I would like to know what need to be done exactly. Hi, The first thing you need to do is write a proposal. I would recommend writing a rough draft, uploading it to

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #13 from Dieter Nützel die...@nuetzel-hh.de --- (In reply to comment #12) I'm not able to reproduce it (tested with RV770 and CYPRESS) with current master Mesa 10.2.0-devel (git-f74cf5f). Both do NOT run with current master Mesa

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #14 from Dieter Nützel die...@nuetzel-hh.de --- Created attachment 96024 -- https://bugs.freedesktop.org/attachment.cgi?id=96024action=edit gl-320-primitive-sprite.png -- You are receiving this mail because: You are on the CC list

[Mesa-dev] [PATCH 02/12] i965/vec4: Add and use vec4_instruction::writes_flag().

To be consistent with the fs backend. Also the instruction scheduler incorrectly considered SEL with a conditional modifier to read the flag register. --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h| 5 + 2 files

[Mesa-dev] [PATCH 03/12] i965/vec4: Rename depends_on_flags() to reads_flag().

To be consistent with the fs backend. --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp

[Mesa-dev] [PATCH 00/12] i965/vec4: Better dead code elimination.

total instructions in shared programs: 811813 - 788004 (-2.93%) instructions in affected programs: 185685 - 161876 (-12.82%) (this is only the .shader_test files. Our .vert files are useless) This series improves the dead code elimination pass in i965 vec4 backend. A small overview of the

[Mesa-dev] [PATCH 06/12] i965/vec4: Preparatory clean up of dead_code_eliminate().

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 45 +- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 62c2314..cb87fec 100644 ---

[Mesa-dev] [PATCH 04/12] i965/vec4: Print the predicate in dump_instructions().

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 0245f40..702b182 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++

[Mesa-dev] [PATCH 11/12] i965/vec4: Eliminate writes that are never read.

With an awful O(n^2) algorithm that searches previous instructions for dead writes. total instructions in shared programs: 805582 - 788074 (-2.17%) instructions in affected programs: 144561 - 127053 (-12.11%) --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 46 ++

[Mesa-dev] [PATCH 01/12] i965/vec4: Add missing doxygen close brace.

--- src/mesa/drivers/dri/i965/brw_vec4.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index eb375e2..52cc058 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.h +++ b/src/mesa/drivers/dri/i965/brw_vec4.h @@ -261,6

[Mesa-dev] [PATCH 08/12] i965/vec4: Track live ranges per-channel, not per vgrf.

Will be squashed with the next patch. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 ++- .../drivers/dri/i965/brw_vec4_live_variables.cpp | 50 -- 2 files changed, 41 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 05/12] i965/vec4: Add is_null() method to dst_reg.

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 src/mesa/drivers/dri/i965/brw_vec4.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 702b182..62c2314 100644 ---

[Mesa-dev] [PATCH 10/12] i965/vec4: Factor code out of DCE into a separate function.

Will be reused in the next commit. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 73 ++ 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 673086d..4ad398a 100644 ---

[Mesa-dev] [PATCH 07/12] i965/vec4: Don't dead code eliminate instructions writing the flag.

A future patch adds support for removing dead writes to the flag register. This patch simplifies the logic until then. total instructions in shared programs: 811813 - 811869 (0.01%) instructions in affected programs: 3378 - 3434 (1.66%) --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 6 +-

[Mesa-dev] [PATCH 09/12] i965/vec4: Let dead code eliminate trim dead channels.

That is, modify mad dst, a, b, c to be mad dst.xyz, a, b, c if dst.w is never read. total instructions in shared programs: 811869 - 805582 (-0.77%) instructions in affected programs: 168287 - 162000 (-3.74%) --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 29

[Mesa-dev] [PATCH 12/12] i965/vec4: Eliminate dead writes to the flag register.

For each write, search previous instructions for unread writes to the flag register and remove them. Note that this will not eliminate the last unread write. total instructions in shared programs: 788074 - 788004 (-0.01%) instructions in affected programs: 4930 - 4860 (-1.42%) ---

[Mesa-dev] [Bug 76331] register_allocate.h:67:1: error: unknown type name 'bool' bool ra_select(struct ra_graph *g);

https://bugs.freedesktop.org/show_bug.cgi?id=76331 --- Comment #2 from Kenneth Graunke kenn...@whitecape.org --- Crud, sorry about this. Tom actually let me know a few minutes after I pushed it, and I wrote the patch, got it reviewed...and then forgot to push it. Thanks for fixing it, Brian.