[Mesa-dev] [Bug 79858] Artifacts/Glitches in Blender menu

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79858 Michel Dänzer mic...@daenzer.net changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-10 Thread Tapani Pälli
On 06/10/2014 08:28 AM, Tapani Pälli wrote: On 06/09/2014 09:40 PM, Matt Turner wrote: On Mon, Jun 9, 2014 at 4:29 AM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79724 ---

Re: [Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-10 Thread Matt Turner
On Mon, Jun 9, 2014 at 11:51 PM, Tapani Pälli tapani.pa...@intel.com wrote: On 06/10/2014 08:28 AM, Tapani Pälli wrote: On 06/09/2014 09:40 PM, Matt Turner wrote: On Mon, Jun 9, 2014 at 4:29 AM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com

[Mesa-dev] [PATCH] glx: Add an error message when a direct renderer's createScreen() routine fails because no matching fbConfigs or visuals could be found.

2014-06-10 Thread Jon TURNEY
Nearly all the error cases in *createScreen() issue an error message to diagnose the failure to initialize before branching to handle_error. The few remaining error cases which don't should probably do the same. (At the moment, it seems this can be triggered in drisw with an X server which

[Mesa-dev] [PATCH] configure: Don't special case Cygwin to use gnu99, define _XOPEN_SOURCE instead

2014-06-10 Thread Jon TURNEY
Revert build: Build on Cygwin with gnu99 instead of c99. and define _XOPEN_SOURCE appropriately. This reverts commit 53e36d333c9b619c1a5fe9a8d2d08665654b0234. Since Cygwin 1.7.18 (April 2013), it's headers correctly prototype strtoll() when using -std=c99, and correctly prototype strdup() when

Re: [Mesa-dev] [PATCH] Fix zero-division in llvmpipe_texture_layout()

2014-06-10 Thread Roland Scheidegger
Am 07.06.2014 20:38, schrieb Johannes Obermayr: From: Takashi Iwai ti...@suse.de Fix the crash of gnome-control-center info invocation on QEMU where zero height is passed at init. Fixes: https://bugzilla.novell.com/show_bug.cgi?id=879462 Signed-off-by: Takashi Iwai ti...@suse.de ---

Re: [Mesa-dev] [PATCH 1/8] softpipe: add depth clamping support.

2014-06-10 Thread Roland Scheidegger
Am 10.06.2014 07:57, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This passes the piglit depth clamp tests. this is required for GL 3.2. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/softpipe/sp_quad_depth_test.c | 37 ++-

[Mesa-dev] [Bug 79885] New: commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 Priority: medium Bug ID: 79885 Assignee: mesa-dev@lists.freedesktop.org Summary: commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

[Mesa-dev] [Bug 79885] commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 Marc Dietrich marvi...@gmx.de changed: What|Removed |Added Hardware|Other |x86-64 (AMD64)

Re: [Mesa-dev] [PATCH] configure: Only check for OpenCL without LLVM when the latter is certain

2014-06-10 Thread Emil Velikov
On 10/06/14 03:25, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com LLVM is enabled by default for some architectures, but the test was failing before that. Thanks for fixing my silly mistake Michel. Would you mind CC-ing stable, similar to the offending commit (93257a56b5b:

Re: [Mesa-dev] [PATCH 3/8] softpipe: add layered rendering support.

2014-06-10 Thread Roland Scheidegger
Am 10.06.2014 07:57, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This adds support for GL 3.2 layered rendering to softpipe. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/softpipe/sp_context.h | 3 ++ src/gallium/drivers/softpipe/sp_quad.h

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Roland Scheidegger
Am 10.06.2014 07:57, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This crashes on softpipe due to a lack of output memory allocated, it appears we allocate memory for enough primtives, but not vertices so convert to number of vertices. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 8/8] softpipe: enable AMD_vertex_shader_layer.

2014-06-10 Thread Roland Scheidegger
Am 10.06.2014 07:57, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This passes tests now on softpipe. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Zack Rusin
That looks wrong. The total number of verts per buffer is the maximum number of verts that can be output per invocation (primitive_boundary) times number of invocations of geometry shader (num_in_primitives). It's not maximum number of verts that can be output per invocation

Re: [Mesa-dev] [PATCH] softpipe: add depth clamping support.

2014-06-10 Thread Brian Paul
On 06/09/2014 06:58 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This passes the piglit depth clamp tests. this is required for GL 3.2. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/softpipe/sp_quad_depth_test.c | 37 ++-

[Mesa-dev] [PATCH] egl/gallium: Set defines for supported APIs when using automake

2014-06-10 Thread Niels Ole Salscheider
This fixes automake builds which are broken since b52a530ce2aada1967bc8fefa83ab53e6a737dae. Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de --- src/gallium/state_trackers/egl/Makefile.am | 20 1 file changed, 20 insertions(+) diff --git

[Mesa-dev] [Bug 79885] commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 --- Comment #2 from Emil Velikov emil.l.veli...@gmail.com --- This seems rather odd. I'm assuming that you've tried the parent commit and it works fine ? Are you building with scons by any change ? Set the variable EGL_LOG_LEVEL=debug and attach

[Mesa-dev] [Bug 79885] commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 --- Comment #3 from Niels Ole Salscheider niels_...@salscheider-online.de --- I have just sent a patch (egl/gallium: Set defines for supported APIs when using automake) to the list which should fix your problem, too. -- You are receiving this

Re: [Mesa-dev] [PATCH mesa] add EGL_TEXTURE_EXTERNAL_WL to WL_bind_wayland_display spec

2014-06-10 Thread Rob Clark
On Mon, Jun 9, 2014 at 5:53 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 16 Aug 2012 17:28:19 -0500 Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- docs/WL_bind_wayland_display.spec |5 + include/EGL/eglmesaext.h

[Mesa-dev] [Bug 79885] commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 --- Comment #4 from Marc Dietrich marvi...@gmx.de --- Patch from Niels fixed it. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] configure: Only check for OpenCL without LLVM when the latter is certain

2014-06-10 Thread Tom Stellard
On Tue, Jun 10, 2014 at 02:57:41PM +0100, Emil Velikov wrote: On 10/06/14 03:25, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com LLVM is enabled by default for some architectures, but the test was failing before that. Thanks for fixing my silly mistake Michel. Would

Re: [Mesa-dev] [PATCH] egl/gallium: Set defines for supported APIs when using automake

2014-06-10 Thread Emil Velikov
On 10/06/14 15:17, Niels Ole Salscheider wrote: This fixes automake builds which are broken since b52a530ce2aada1967bc8fefa83ab53e6a737dae. Not sure what I was smoking with the above mentioned patch. Seem like I've completely forgotten about automake :\ Niels can you please drop the FEATURE*

[Mesa-dev] [Bug 79885] commit b52a530 (gallium/egl: st_profiles are build time decision, treat them as such) broke egl

2014-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79885 --- Comment #5 from Emil Velikov emil.l.veli...@gmail.com --- Above I mentioned scons, yet completely missed out on our main build system - automake. Niels patch is the correct solution but I would appreciate if he can remove the feature defines

Re: [Mesa-dev] [PATCH] egl/gallium: Set defines for supported APIs when using automake

2014-06-10 Thread Niels Ole Salscheider
On Tuesday 10 June 2014, 16:18:56, Emil Velikov wrote: On 10/06/14 15:17, Niels Ole Salscheider wrote: This fixes automake builds which are broken since b52a530ce2aada1967bc8fefa83ab53e6a737dae. Not sure what I was smoking with the above mentioned patch. Seem like I've completely

Re: [Mesa-dev] [PATCH 1/2] glinfo_common: fix extension_supported() function

2014-06-10 Thread Ian Romanick
On 06/09/2014 05:26 AM, Brian Paul wrote: The code did not correctly handle super-string handling. For example, if we were searching for WGL_ARB_pixel_format but we found WGL_ARB_pixel_format_float we'd stop searching and return 0. Now we search past that initial, incorrect match. This

Re: [Mesa-dev] [PATCH 1/3] glsl: Rebalance expression trees that are reduction operations.

2014-06-10 Thread Ian Romanick
On 06/09/2014 02:11 PM, Matt Turner wrote: +/* Note that this function does not attempt to recognize that reduction trees + * are already balanced. + */ +static void +is_reduction(ir_instruction *ir, void *data) +{ + struct is_reduction_data *ird = (struct is_reduction_data *)data; +

Re: [Mesa-dev] [PATCH 3/3] glsl: Optimize (v.x + v.y) + (v.z + v.w) into dot(v, 1.0).

2014-06-10 Thread Ian Romanick
On 06/09/2014 02:11 PM, Matt Turner wrote: Cuts five instructions out of SynMark's Gl32VSInstancing benchmark. --- src/glsl/opt_algebraic.cpp | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-10 Thread Courtney Goeltzenleuchter
Hi Brian, I think I've pushed this patch. Could you verify that I haven't broken anything? Thanks! Courtney On Fri, Jun 6, 2014 at 7:20 PM, Brian Paul bri...@vmware.com wrote: Reviewed-by: Brian Paul bri...@vmware.com Do you need someone to commit/push this for you? -Brian On

Re: [Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-10 Thread Ian Romanick
On 06/09/2014 07:48 AM, Robert Bragg wrote: This makes sure to use a no-op swizzle while iteratively rendering each level of a mipmap otherwise we may loose components and effectively apply the swizzle twice by the time these levels are sampled. Right... the swizzle state shouldn't affect

Re: [Mesa-dev] [PATCH 3/3] glsl: Optimize (v.x + v.y) + (v.z + v.w) into dot(v, 1.0).

2014-06-10 Thread Matt Turner
On Tue, Jun 10, 2014 at 9:46 AM, Ian Romanick i...@freedesktop.org wrote: On 06/09/2014 02:11 PM, Matt Turner wrote: Cuts five instructions out of SynMark's Gl32VSInstancing benchmark. --- src/glsl/opt_algebraic.cpp | 46 ++ 1 file changed, 46

[Mesa-dev] [PATCH] mesa: glx: Reduce error log level

2014-06-10 Thread Courtney Goeltzenleuchter
The code that parses LIBGL_DRIVERS_PATH was printing an error for every attempted dlopen. It's not an error to have to check multiple items in the path, only an error if no suitable library is found. Reduced the load error to a warning to match behavior of dynamic linker. Signed-off-by: Courtney

Re: [Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-10 Thread Tom Stellard
On Tue, Jun 10, 2014 at 12:57:31AM +0200, thomashellan...@gmail.com wrote: From: Thomas Helland thomashellan...@gmail.com For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com Do these patches make any measurable improvement in compile time? -Tom This series removes some unused

[Mesa-dev] [PATCH 0/9] glsl: Add C API to exec_node/exec_list.

2014-06-10 Thread Matt Turner
Our most frequently used list implementation was only usable from C by manipulating the members of the structs. This series adds a C API, wraps the C API with the C++ member functions (so no change for C++ code), makes the foreach_list macros usable from C, and replaces an open-coded list in the

[Mesa-dev] [PATCH 9/9] i965: Replace open-coded linked list with exec_list.

2014-06-10 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 +++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- src/mesa/drivers/dri/i965/intel_resolve_map.c | 60 ++- src/mesa/drivers/dri/i965/intel_resolve_map.h | 16 +++ 4 files changed, 45

[Mesa-dev] [PATCH 6/9] glsl: Make exec_list members just wrap the C API.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 90 + 1 file changed, 13 insertions(+), 77 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index 49a9a5e..da81062 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -489,131 +489,67 @@

[Mesa-dev] [PATCH 1/9] glsl: Move definition of exec_node member functions out of the struct.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 145 1 file changed, 83 insertions(+), 62 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index 694b686..6216855 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -83,67 +83,29 @@ struct exec_node {

[Mesa-dev] [PATCH 4/9] glsl: Add C API for exec_list.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 141 1 file changed, 141 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index ce7f81f..a1200ac 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -360,6 +360,147 @@ struct exec_list { #endif };

[Mesa-dev] [PATCH 2/9] glsl: Move definition of exec_list member functions out of the struct.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 235 ++-- 1 file changed, 127 insertions(+), 108 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index 6216855..205dc91 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -242,75 +242,19 @@ struct exec_list

[Mesa-dev] [PATCH 3/9] glsl: Add C API for exec_node.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 82 + 1 file changed, 82 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 205dc91..ce7f81f 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -129,6 +129,88 @@ struct exec_node { #endif };

[Mesa-dev] [PATCH 8/9] glsl: Add an exec_node_init() function, usable from C.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 803aab5..576bc14 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -129,6 +129,13 @@ struct exec_node { #endif }; +static inline void +exec_node_init(struct exec_node *n)

[Mesa-dev] [PATCH 7/9] glsl: Make foreach macros usable from C by adding struct keyword.

2014-06-10 Thread Matt Turner
--- src/glsl/list.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index da81062..803aab5 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -556,13 +556,13 @@ inline void exec_node::insert_before(exec_list

Re: [Mesa-dev] GlassyMesa Announcement

2014-06-10 Thread Tom Stellard
On Sat, Jun 07, 2014 at 01:24:39PM -0700, Greg Fischer wrote: LunarG, with support from Valve, announces the GlassyMesa project, an effort to bring the LLVM compiler infrastructure to Mesa. This is very interesting. Have you done any testing with any of the Gallium drivers? How difficult

Re: [Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-10 Thread Matt Turner
On Mon, Jun 9, 2014 at 3:57 PM, thomashellan...@gmail.com wrote: From: Thomas Helland thomashellan...@gmail.com This series removes some unused includes in the glsl-directory. Thanks. A lot of people use ccache, so series like this cause them to have to rebuild (and not use ccache). I've

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Tom Stellard
On Fri, May 30, 2014 at 05:31:10PM +0200, Bruno Jiménez wrote: --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/include/pipe/p_defines.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Tom Stellard thomas.stell...@amd.com diff --git

Re: [Mesa-dev] [PATCH 3/3] clover: query driver for the max number of compute units

2014-06-10 Thread Tom Stellard
On Fri, May 30, 2014 at 05:31:12PM +0200, Bruno Jiménez wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Tom Stellard
On Thu, Jun 05, 2014 at 08:39:29PM +0200, Bruno Jimenez wrote: With a couple of changes, it applied cleanly to 3.14.5 (Arch's stable). And with the attached patch as #2 for my series I can get the correct number of compute units for my CEDAR. But I don't know how or where I should add this

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Bruno Jimenez
On Tue, 2014-06-10 at 14:10 -0400, Tom Stellard wrote: On Thu, Jun 05, 2014 at 08:39:29PM +0200, Bruno Jimenez wrote: With a couple of changes, it applied cleanly to 3.14.5 (Arch's stable). And with the attached patch as #2 for my series I can get the correct number of compute units for

Re: [Mesa-dev] [PATCH 0/9] glsl: Add C API to exec_node/exec_list.

2014-06-10 Thread Ian Romanick
On 06/10/2014 11:00 AM, Matt Turner wrote: Our most frequently used list implementation was only usable from C by manipulating the members of the structs. This series adds a C API, wraps the C API with the C++ member functions (so no change for C++ code), makes the foreach_list macros usable

Re: [Mesa-dev] [PATCH 7/9] glsl: Make foreach macros usable from C by adding struct keyword.

2014-06-10 Thread Ian Romanick
On 06/10/2014 11:00 AM, Matt Turner wrote: --- src/glsl/list.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index da81062..803aab5 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -556,13 +556,13 @@

Re: [Mesa-dev] Texture object locking

2014-06-10 Thread Neil Roberts
(I was trying to be too clever with git-sendmail and I accidentally sent this to the wrong list… sorry!) Jason wrote: Kristian and I were looking at this today, and there seems to be a substantial race in the way that we are doing texture locking. Yes, it does look like this is a problem. I

Re: [Mesa-dev] [PATCH] i965: Set the fast clear color value for texture surfaces

2014-06-10 Thread Ian Romanick
On 06/09/2014 09:43 AM, Neil Roberts wrote: When a multisampled texture is used for sampling the fast clear color value needs to be programmed into the surface state. This was being left as all zeroes so if the surface was cleared to a value other than black then it wouldn't work properly.

Re: [Mesa-dev] [PATCH] i965: Actually use the Mesa IR optimizer.

2014-06-10 Thread Ian Romanick
On 06/09/2014 12:36 AM, Kenneth Graunke wrote: We have this wonderful thing called an optimizer---maybe we should consider calling it? That's really weird. The *only* place this is called is in ir_to_mesa. It seems like the assember should just call it after assembling any program. Weird.

Re: [Mesa-dev] [PATCH 7/9] glsl: Make foreach macros usable from C by adding struct keyword.

2014-06-10 Thread Matt Turner
On Tue, Jun 10, 2014 at 11:38 AM, Ian Romanick i...@freedesktop.org wrote: On 06/10/2014 11:00 AM, Matt Turner wrote: --- src/glsl/list.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index da81062..803aab5

Re: [Mesa-dev] [PATCH 0/9] glsl: Add C API to exec_node/exec_list.

2014-06-10 Thread Matt Turner
On Tue, Jun 10, 2014 at 11:38 AM, Ian Romanick i...@freedesktop.org wrote: On 06/10/2014 11:00 AM, Matt Turner wrote: Our most frequently used list implementation was only usable from C by manipulating the members of the structs. This series adds a C API, wraps the C API with the C++ member

Re: [Mesa-dev] MaxAnisotropy with GL_NEAREST on i965

2014-06-10 Thread Ian Romanick
On 05/22/2014 02:45 PM, Cody Northrop wrote: Greetings, I ran into a problem with how Mesa on i965 handles MaxAnisotropy. The app I'm looking at sets sampler state min and mag filters to GL_NEAREST, but also sets GL_TEXTURE_MAX_ANISOTROPY_EXT, like so:

Re: [Mesa-dev] [PATCH] Add GPU BLIT of texture image to PBO in Intel driver

2014-06-10 Thread Ian Romanick
On 02/24/2014 02:55 PM, Matt Turner wrote: On Mon, Feb 24, 2014 at 2:04 PM, Jon Ashburn j...@lunarg.com wrote: Add Intel driver hook for glGetTexImage to accelerate the case of reading texture image into a PBO. This case gets huge performance gains by using GPU BLIT directly to PBO rather

Re: [Mesa-dev] [PATCH 7/9] glsl: Make foreach macros usable from C by adding struct keyword.

2014-06-10 Thread Patrick Baggett
Yep, no new warnings. I tried a little test program % cat t.cpp class asdf { int x; }; void f() { asdf a; struct asdf b; class asdf c; } C++ never ceases to amaze. and I can't make it generate warnings (other than unused variables) regardless of whether I define

Re: [Mesa-dev] [PATCH 7/9] glsl: Make foreach macros usable from C by adding struct keyword.

2014-06-10 Thread Ian Romanick
On 06/10/2014 12:06 PM, Matt Turner wrote: On Tue, Jun 10, 2014 at 11:38 AM, Ian Romanick i...@freedesktop.org wrote: On 06/10/2014 11:00 AM, Matt Turner wrote: --- src/glsl/list.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/list.h

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Tom Stellard
On Tue, Jun 10, 2014 at 08:36:05PM +0200, Bruno Jimenez wrote: On Tue, 2014-06-10 at 14:10 -0400, Tom Stellard wrote: On Thu, Jun 05, 2014 at 08:39:29PM +0200, Bruno Jimenez wrote: With a couple of changes, it applied cleanly to 3.14.5 (Arch's stable). And with the attached patch as

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Alex Deucher
On Tue, Jun 10, 2014 at 3:23 PM, Tom Stellard t...@stellard.net wrote: On Tue, Jun 10, 2014 at 08:36:05PM +0200, Bruno Jimenez wrote: On Tue, 2014-06-10 at 14:10 -0400, Tom Stellard wrote: On Thu, Jun 05, 2014 at 08:39:29PM +0200, Bruno Jimenez wrote: With a couple of changes, it applied

Re: [Mesa-dev] [PATCH] Add GPU BLIT of texture image to PBO in Intel driver

2014-06-10 Thread Jon Ashburn
See v2 of patch sent to mesa-dev list in early March: http://lists.freedesktop.org/archives/mesa-dev/2014-March/055350.html Or I can resend this v2 patch if needed. Jon On 06/10/2014 01:14 PM, Ian Romanick wrote: On 02/24/2014 02:55 PM, Matt Turner wrote: On Mon, Feb 24, 2014 at 2:04 PM, Jon

Re: [Mesa-dev] [PATCH 0/7] r600g/compute: Some cleanup patches

2014-06-10 Thread Tom Stellard
On Mon, May 19, 2014 at 06:14:50PM +0200, Bruno Jiménez wrote: Hi, Firstly, I shall introduce myself (at least more formally than just sending some patches). My name is Bruno Jiménez, I'm studying physics at Zaragoza's University (Spain) and I am participating in this year's Google Summer

Re: [Mesa-dev] [PATCH 00/19] i965/fs: load_payload on Gen7+.

2014-06-10 Thread Matt Turner
On Wed, May 28, 2014 at 4:44 PM, Connor Abbott cwabbo...@gmail.com wrote: On Tue, May 27, 2014 at 9:47 PM, Matt Turner matts...@gmail.com wrote: Here's a respin of my load_payload series from mid-April with some feedback from Ken addressed and some bugs fixed. This series is available in my

Re: [Mesa-dev] [PATCH 0/9] glsl: Add C API to exec_node/exec_list.

2014-06-10 Thread Ian Romanick
On 06/10/2014 12:10 PM, Matt Turner wrote: On Tue, Jun 10, 2014 at 11:38 AM, Ian Romanick i...@freedesktop.org wrote: On 06/10/2014 11:00 AM, Matt Turner wrote: Our most frequently used list implementation was only usable from C by manipulating the members of the structs. This series adds a C

Re: [Mesa-dev] [PATCH] Add GPU BLIT of texture image to PBO in Intel driver

2014-06-10 Thread Ian Romanick
On 06/10/2014 12:26 PM, Jon Ashburn wrote: See v2 of patch sent to mesa-dev list in early March: http://lists.freedesktop.org/archives/mesa-dev/2014-March/055350.html Or I can resend this v2 patch if needed. That's weird. I have v1 in my inbox, but I don't have v2. Anyway... Other than

Re: [Mesa-dev] [PATCH] i965: Set the fast clear color value for texture surfaces

2014-06-10 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Jun 11, 2014 at 6:51 AM, Ian Romanick i...@freedesktop.org wrote: On 06/09/2014 09:43 AM, Neil Roberts wrote: When a multisampled texture is used for sampling the fast clear color value needs to be programmed into the surface state. This was

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Dave Airlie
On 11 June 2014 00:02, Zack Rusin za...@vmware.com wrote: That looks wrong. The total number of verts per buffer is the maximum number of verts that can be output per invocation (primitive_boundary) times number of invocations of geometry shader (num_in_primitives). It's not maximum number

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Zack Rusin
I think the code is already correct and something else goes wrong. The tgsi geometry shader code was never done properly so it's more than likely that tgsi_exec is doing something wonky. Geometry shaders specify the maximum number of vertices that they can emit. That's what

Re: [Mesa-dev] Request for information on Radeon

2014-06-10 Thread Aditya Avinash
Hi, Thank you very much!! On Mon, Jun 9, 2014 at 10:19 AM, Marek Olšák mar...@gmail.com wrote: This is probably one of the most difficult tasks. You'll need to: 1) Add support to Mesa core - new shader stages and the new OpenGL functions and queries (src/mesa/main) Ya. This one is straight

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Fri, May 30, 2014 at 05:31:10PM +0200, Bruno Jiménez wrote: --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/include/pipe/p_defines.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Tom Stellard

Re: [Mesa-dev] [PATCH 3/3] clover: query driver for the max number of compute units

2014-06-10 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Fri, May 30, 2014 at 05:31:12PM +0200, Bruno Jiménez wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Reviewed-by: Francisco Jerez curroje...@riseup.net --- src/gallium/state_trackers/clover/api/device.cpp | 2 +-

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-10 Thread Marek Olšák
Well, we could just pull radeon_drm.h into Mesa to simplify the process since libdrm_radeon doesn't really need the updated header anymore. Marek On Tue, Jun 10, 2014 at 9:25 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Tue, Jun 10, 2014 at 3:23 PM, Tom Stellard t...@stellard.net wrote: On

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Dave Airlie
On 11 June 2014 06:23, Zack Rusin za...@vmware.com wrote: I think the code is already correct and something else goes wrong. The tgsi geometry shader code was never done properly so it's more than likely that tgsi_exec is doing something wonky. Geometry shaders specify the maximum number of

Re: [Mesa-dev] Request for information on Radeon

2014-06-10 Thread Chris Forbes
For the first two points, a partial implementation is already done here: https://github.com/fabe3k/mesa/commits/tessellation This predates the addition of ARB_separate_shader_objects, which has some interactions. There are probably also plenty of rough edges, but it should give you enough to get

Re: [Mesa-dev] Request for information on Radeon

2014-06-10 Thread Aditya Avinash
Hi, On Tue, Jun 10, 2014 at 5:06 PM, Chris Forbes chr...@ijw.co.nz wrote: For the first two points, a partial implementation is already done here: https://github.com/fabe3k/mesa/commits/tessellation This predates the addition of ARB_separate_shader_objects, which has some interactions.

Re: [Mesa-dev] Request for information on Radeon

2014-06-10 Thread Marek Olšák
On Tue, Jun 10, 2014 at 10:45 PM, Aditya Avinash adityaavina...@gmail.com wrote: Hi, Thank you very much!! On Mon, Jun 9, 2014 at 10:19 AM, Marek Olšák mar...@gmail.com wrote: This is probably one of the most difficult tasks. You'll need to: 1) Add support to Mesa core - new shader stages

Re: [Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-10 Thread Thomas Helland
Thanks for the review! These patches, along with 5 more I've put together, don't have any significant impact on compile time. But that's only 16 files, so it really shouldn't be expected I guess. A similar effort on firefox gave a 12.5% compile-time improvement though, so eventually we should be

Re: [Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-10 Thread Matt Turner
On Tue, Jun 10, 2014 at 3:39 PM, Thomas Helland thomashellan...@gmail.com wrote: Where I do see an impact though is recompiling after changes. Less object-files needs to be recompiled, so it's often a lot faster. I don't have any specific numbers here though. Oh, that's a good point that I

[Mesa-dev] [PATCH] glsl: remove unnecessary and incorrect check

2014-06-10 Thread Timothy Arceri
This code does nothing useful as the next recursive call on the array element will override any null values if the element is a record anyway. The code is also not doing what the comment says as its trying to set the record type pointer for only the first element of the array not the first leaf

Re: [Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-10 Thread Brian Paul
On 06/10/2014 04:39 PM, Thomas Helland wrote: Thanks for the review! These patches, along with 5 more I've put together, don't have any significant impact on compile time. But that's only 16 files, so it really shouldn't be expected I guess. A similar effort on firefox gave a 12.5% compile-time

[Mesa-dev] [PATCH] i965/fs: Copy propagate from load_payload.

2014-06-10 Thread Matt Turner
--- I'm planning to squash this in to make Abdiel's patches easier to merge. src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp

Re: [Mesa-dev] [PATCH 15/19] i965/fs: Support register coalescing on LOAD_PAYLOAD operands.

2014-06-10 Thread Matt Turner
On Sun, Jun 1, 2014 at 12:01 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Friday, April 18, 2014 11:56:51 AM Matt Turner wrote: --- .../drivers/dri/i965/brw_fs_register_coalesce.cpp | 59 ++ 1 file changed, 49 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH] i965/fs: Support register coalescing on LOAD_PAYLOAD operands.

2014-06-10 Thread Matt Turner
--- I'm planning to squash this in to address review comments. src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp

Re: [Mesa-dev] [PATCH 00/19] i965/fs: load_payload on Gen7+.

2014-06-10 Thread Matt Turner
On Tue, May 27, 2014 at 6:47 PM, Matt Turner matts...@gmail.com wrote: Here's a respin of my load_payload series from mid-April with some feedback from Ken addressed and some bugs fixed. git://people.freedesktop.org/~mattst88/mesa tex-sources I've force pushed an updated and rebased

[Mesa-dev] [PATCH] glsl: Rebalance expression trees that are reduction operations.

2014-06-10 Thread Matt Turner
--- Easiest thing for now seems to be to bail if we see these kinds of dereferences. I'll squash this in, adding a description of the things we don't handle. src/glsl/opt_rebalance_tree.cpp | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Zack Rusin
I'll revisit it today and see if I can spot something else wrong, it fails for triangle adj because there are 6 vertices per primitive and we have only malloced space for 4. It has to be something else because that's impossible, in fact it's 2x impossible ;) 1) It's illegal and impossible

Re: [Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-10 Thread Dave Airlie
On 11 June 2014 10:18, Zack Rusin za...@vmware.com wrote: I'll revisit it today and see if I can spot something else wrong, it fails for triangle adj because there are 6 vertices per primitive and we have only malloced space for 4. It has to be something else because that's impossible, in

[Mesa-dev] [PATCH] draw: avoid buffer overflows with bad geometry programs.

2014-06-10 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com One of the mismatched tests have a max output vertices of 3, but emits 6 vertices, this means the output buffer is undersized and causes problems down the line, so limit things later if we have a number of vertices lower than the number required to execute a

Re: [Mesa-dev] [PATCH] configure: Only check for OpenCL without LLVM when the latter is certain

2014-06-10 Thread Michel Dänzer
On 11.06.2014 00:07, Tom Stellard wrote: On Tue, Jun 10, 2014 at 02:57:41PM +0100, Emil Velikov wrote: On 10/06/14 03:25, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com LLVM is enabled by default for some architectures, but the test was failing before that. Thanks for

Re: [Mesa-dev] [PATCH] draw: avoid buffer overflows with bad geometry programs.

2014-06-10 Thread Zack Rusin
To be honest I still don't like it. While the tgsi_exec specific paths in draw_gs don't matter to me and can be as ugly as they need to be, they can't be polluting the draw_pt_emit code, in other words the primitive_lengths can't be bogus at that point - prim_info can't lie about the amount of

Re: [Mesa-dev] [PATCH v2] i965: Add GPU BLIT of texture image to PBO in Intel driver

2014-06-10 Thread Kenneth Graunke
On Tuesday, March 04, 2014 05:34:44 PM Jon Ashburn wrote: Add Intel driver hook for glGetTexImage to accelerate the case of reading texture image into a PBO. This case gets huge performance gains by using GPU BLIT directly to PBO rather than GPU BLIT to temporary texture followed by memcpy.

Re: [Mesa-dev] [PATCH] draw: avoid buffer overflows with bad geometry programs.

2014-06-10 Thread Dave Airlie
On 11 June 2014 10:48, Zack Rusin za...@vmware.com wrote: To be honest I still don't like it. While the tgsi_exec specific paths in draw_gs don't matter to me and can be as ugly as they need to be, they can't be polluting the draw_pt_emit code, in other words the primitive_lengths can't be

[Mesa-dev] [PATCH] tgsi/gs: bound max output vertices in shader

2014-06-10 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This limits the number of emitted vertices to the shaders max output vertices, and avoids us writing things into memory that isn't big enough for it. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8

Re: [Mesa-dev] [PATCH] tgsi/gs: bound max output vertices in shader

2014-06-10 Thread Zack Rusin
Looks great. If I was into diffs I'd make sweet and passionate love to this one. Reviewed-by: Zack Rusin za...@vmware.com - Original Message - From: Dave Airlie airl...@redhat.com This limits the number of emitted vertices to the shaders max output vertices, and avoids us writing

Re: [Mesa-dev] GlassyMesa Announcement

2014-06-10 Thread John Kessenich
Hi Tom, On 6/10/2014 12:03 PM, Tom Stellard wrote: On Sat, Jun 07, 2014 at 01:24:39PM -0700, Greg Fischer wrote: LunarG, with support from Valve, announces the GlassyMesa project, an effort to bring the LLVM compiler infrastructure to Mesa. This is very interesting. Have you done any testing

[Mesa-dev] [PATCH 1/2] i965: Silence a couple unused parameter warnings

2014-06-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com brw_vec4_visitor.cpp:2717:1: warning: unused parameter 'ir' [-Wunused-parameter] brw_vec4_visitor.cpp:2723:1: warning: unused parameter 'ir' [-Wunused-parameter] Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCH 2/2] i965: Emit smarter code for b2i of a comparison

2014-06-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously we would emit the comparison, emit an AND to mask off extra bits from the comparison result, then convert the result to float. Now, do the comparison, then use a cleverly constructed SEL to pick either 0.0f or 1.0f. No piglit regressions on

[Mesa-dev] [PATCH] glsl: Store gl_uniform_driver_storage::format as the actual type

2014-06-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com And delete the incorrect comment. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ir_uniform.h| 7 ++- src/mesa/main/uniforms.c | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/glsl/ir_uniform.h

[Mesa-dev] [PATCH 1/3] configure.ac: Remove single quotes to fix syntax highlighting.

2014-06-10 Thread Matt Turner
Please stop adding them. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eaca378..c6664b9 100644 --- a/configure.ac +++ b/configure.ac @@ -543,7 +543,7 @@ darwin*|mingw*) *) AC_CHECK_FUNCS([clock_gettime],

[Mesa-dev] [PATCH 3/3] configure.ac: Simplify DUSE_EXTERNAL_DXTN_LIB logic.

2014-06-10 Thread Matt Turner
--- configure.ac | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 17e9e9c..4b27455 100644 --- a/configure.ac +++ b/configure.ac @@ -149,7 +149,7 @@ _SAVE_LDFLAGS=$LDFLAGS _SAVE_CPPFLAGS=$CPPFLAGS dnl Compiler macros -DEFINES=

  1   2   >