Re: [Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:08 PM Matt Turner wrote: Otherwise we'll apply the conditional mod to only one of SIMD8 instructions and trigger an assertion. NoDDClr/NoDDChk have the same problem but we never apply those to these instructions, so I'm leaving them for a later time. ---

Re: [Mesa-dev] [PATCH 07/16] i965: Add is_3src() to backend_instruction.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:06 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_shader.cpp| 10 ++ src/mesa/drivers/dri/i965/brw_shader.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 6 +- 3 files changed, 12

Re: [Mesa-dev] [PATCH 05/16] i965: Add backend_instruction::can_do_cmod().

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:04 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_shader.cpp | 45 src/mesa/drivers/dri/i965/brw_shader.h | 1 + 2 files changed, 46 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp

Re: [Mesa-dev] [PATCH 08/16] i965/fs: Add a pass to fixup 3-src instructions that have a null dest.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:07 PM Matt Turner wrote: 3-src instructions can only have GRF/MRF destinations. It's really difficult to deal with that restriction in dead code elimination (that wants to give instructions null destinations to show that their result isn't used) while allowing

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #20 from Eero Tamminen eero.t.tammi...@intel.com --- Are you still getting INTEL_DEBUG=perf output from them? - if you're still getting recompile messages, re-check you have latest Mesa - if there are no perf warnings, check that: *

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

2015-01-20 Thread Erik Faye-Lund
On Tue, Jan 20, 2015 at 3:54 AM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 04:35 AM, Erik Faye-Lund wrote: On Mon, Jan 19, 2015 at 1:31 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: The manual page for

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp

[Mesa-dev] [Bug 88618] opengles2: fix building without X11

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88618 Bug ID: 88618 Summary: opengles2: fix building without X11 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ src/mesa/drivers/dri/i965/brw_eu.h | 1 + 2 files changed, 23 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c

Re: [Mesa-dev] [PATCH 07/11] glsl: error out on empty declarations

2015-01-20 Thread Iago Toral
On Mon, 2015-01-19 at 19:03 -0800, Ian Romanick wrote: On 01/19/2015 04:52 AM, Erik Faye-Lund wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com So far we have only been emitting a warning. Fixes the

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

2015-01-20 Thread Eduardo Lima Mitev
Thank you Erik and Ian for taking a look to the patch. On 01/20/2015 03:52 AM, Ian Romanick wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: The manual page for glGetAttachedShaders, glGetShaderSource, glGetActiveUniform and glGetActiveUniform state that a GL_INVALID_VALUE is

[Mesa-dev] [PATCH 09/11 v2] mesa: Allow querying for GL_PRIMITIVE_RESTART_FIXED_INDEX under GLES 3

2015-01-20 Thread Eduardo Lima Mitev
GLES 3.0.0 spec introduces context state PRIMITIVE_RESTART_FIXED_INDEX (2.8.1 Transferring Array Elements, page 26) which is not currently possible to query using glGet*() funcs. Fixes 4 dEQP tests: * dEQP-GLES3.functional.state_query.boolean.primitive_restart_fixed_index_getboolean *

Re: [Mesa-dev] [PATCH 08/11] glsl: GLSL ES identifiers cannot exceed 1024 characters

2015-01-20 Thread Iago Toral
On Mon, 2015-01-19 at 19:25 -0800, Ian Romanick wrote: On 01/19/2015 04:41 AM, Erik Faye-Lund wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com Fixes the following 2 dEQP tests:

Re: [Mesa-dev] [PATCH 10/11] glsl: Improve precision of mod(x,y)

2015-01-20 Thread Iago Toral
On Mon, 2015-01-19 at 19:10 -0800, Ian Romanick wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement mod(x,y) as y * fract(x/y). This implementation has a down side though:

Re: [Mesa-dev] [PATCH 02/11] glsl: Add link time checks for GLSL precision qualifiers

2015-01-20 Thread Iago Toral
On Mon, 2015-01-19 at 19:39 -0800, Ian Romanick wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com Currently, we only consider precision qualifiers at compile-time. This patch adds precision information to ir_variable so we can also do

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

2015-01-20 Thread Connor Abbott
Shouldn't the subject say exec_list: Add a foreach_in_list_reverse_safe macro.? On Mon, Jan 19, 2015 at 6:31 PM, Matt Turner matts...@gmail.com wrote: --- src/glsl/list.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 330c17e..85368a4

Re: [Mesa-dev] [PATCH] radeonsi: Enable VGPR spilling for all shader types v3

2015-01-20 Thread Marek Olšák
The problem with CPDMA (DMA_DATA and WRITE_DATA) is that the ordering of flushes must be correct. First, partial flushes must be done, so that the shaders are idle. Then you can use CP DMA to update the binary. After that, ICACHE should be invalidated. This is similar to how si_clear_buffer and

[Mesa-dev] [PATCH v2] glsl: GLSL ES identifiers cannot exceed 1024 characters

2015-01-20 Thread Iago Toral Quiroga
v2 (Ian Romanick) - Move the check to the lexer before rallocing a copy of the large string. Fixes the following 2 dEQP tests: dEQP-GLES3.functional.shaders.keywords.invalid_identifiers.max_length_vertex dEQP-GLES3.functional.shaders.keywords.invalid_identifiers.max_length_fragment ---

Re: [Mesa-dev] [xf86-video-ati] dri2: Enable BufferAge support

2015-01-20 Thread Alex Deucher
On Mon, Jan 19, 2015 at 6:00 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: For BufferAge support, we just have to guarrantee that we were not using the DRI2Buffer-flags field for anything else (i.e. it is always 0) and then to make sure that we exchange the flags field after buffer

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88275 Eugene ken20...@ukr.net changed: What|Removed |Added Summary|[865G] Intel OpenGL |[865G] Intel OpenGL

[Mesa-dev] [Bug 82668] Can't set int attributes to certain values on 32-bit

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82668 marius predut marius.pre...@intel.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH v2] glsl: Improve precision of mod(x,y)

2015-01-20 Thread Iago Toral Quiroga
Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement mod(x,y) as y * fract(x/y). This implementation has a down side though: it introduces precision errors due to the fract() operation. Even worse, since the result of fract() is multiplied by y, the larger y gets the larger the

[Mesa-dev] [Bug 67676] Transparent windows no longer work

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67676 Daniel Stone dan...@fooishbar.org changed: What|Removed |Added CC||e...@anholt.net ---

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Chris Forbes
Ian, That's what the -2 variation added by that commit does. - Chris On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani

Re: [Mesa-dev] [PATCH 11/11] mesa: fix error value in GetFramebufferAttachmentParameteriv for OpenGL ES 3.0

2015-01-20 Thread Ian Romanick
On 01/20/2015 10:57 AM, Anuj Phogat wrote: On Mon, Jan 19, 2015 at 7:23 PM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Section 6.1.13 Framebuffer Object Queries of OpenGL ES 3.0 spec: If

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Ian Romanick
On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/ast_to_hir.cpp | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 11/11] mesa: fix error value in GetFramebufferAttachmentParameteriv for OpenGL ES 3.0

2015-01-20 Thread Anuj Phogat
On Mon, Jan 19, 2015 at 7:23 PM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Section 6.1.13 Framebuffer Object Queries of OpenGL ES 3.0 spec: If the default framebuffer is bound to target,

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Ian Romanick
On 01/20/2015 10:42 AM, Chris Forbes wrote: Ian, That's what the -2 variation added by that commit does. Of course. :) Not sure how I overlooked that. - Chris On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes

Re: [Mesa-dev] [PATCH] nv50, nvc0: Report correct caps for pixel center integer

2015-01-20 Thread Tiziano Bacocco
I've done some tests, after being confirmed that the 0.5 subtraction done in gallium nine is correct, I've tried to set raster half_pixel_center to 1 , and this way , with the 0.5 subtraction is fine like it is on radeon With half_pixel_center set to 0 instead the default behavior on shaders seems

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 Alberto Salvia Novella es204904...@gmail.com changed: What|Removed |Added Component|Driver/AMDgpu |EGL

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 12:32 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, January 19, 2015 03:31:08 PM Matt Turner wrote: Otherwise we'll apply the conditional mod to only one of SIMD8 instructions and trigger an assertion. NoDDClr/NoDDChk have the same problem but we never

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #11 from Alberto Salvia Novella es204904...@gmail.com --- Does fglrx depend on Mesa? How can I figure out if this is a bug in Mesa? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 12:53 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 09/11 v2] mesa: Allow querying for GL_PRIMITIVE_RESTART_FIXED_INDEX under GLES 3

2015-01-20 Thread Ian Romanick
On 01/20/2015 04:58 AM, Eduardo Lima Mitev wrote: GLES 3.0.0 spec introduces context state PRIMITIVE_RESTART_FIXED_INDEX (2.8.1 Transferring Array Elements, page 26) which is not currently possible to query using glGet*() funcs. Fixes 4 dEQP tests: *

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 6:16 AM, Connor Abbott cwabbo...@gmail.com wrote: Shouldn't the subject say exec_list: Add a foreach_in_list_reverse_safe macro.? Meh? Shortlog on this file shows glsl2, exec_list, glsl, glsl/list. ___ mesa-dev mailing list

Re: [Mesa-dev] [mesa 8/9] glx/dri2: Move the wait after SwapBuffers into the next GetBuffers

2015-01-20 Thread Ian Romanick
On 01/19/2015 03:00 AM, Chris Wilson wrote: As the SBC from the reply from SwapBuffers is not used immediately and can be easily determined by counting the new of SwapBuffers requests made by the client, we can defer the synchronisation point to the pending GetBuffers round trip. (We force the

Re: [Mesa-dev] [PATCH 4/4] i965: Implemente a tiled fast-path for glReadPixels and glGetTexImage

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 10:44 AM, Chad Versace chad.vers...@intel.com wrote: On 01/12/2015 10:22 AM, Jason Ekstrand wrote: From: Sisinty Sasmita Patra sisinty.pa...@intel.com Added intel_readpixels_tiled_mempcpy and intel_gettexsubimage_tiled_mempcpy functions. These are the fast paths

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #13 from Alberto Salvia Novella es204904...@gmail.com --- So why is this happening also with the proprietary driver? And about upgrading using the PPA, I have just done it. If in three weeks the problem doesn't reproduce, I will

Re: [Mesa-dev] [PATCH 12/16] i965/fs: Add unit tests for cmod propagation pass.

2015-01-20 Thread Jason Ekstrand
I had comments on 11 and 15, but 12-14 are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/Makefile.am | 7 + .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 271

Re: [Mesa-dev] [PATCH 04/16] i965/cfg: Add a foreach_block_reverse macro.

2015-01-20 Thread Jason Ekstrand
Patches 1, 3, and 4 are also Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_cfg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h

[Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

2015-01-20 Thread Jason Ekstrand
--- src/glsl/nir/nir.c | 4 ++-- src/glsl/nir/nir.h | 3 +++ src/glsl/nir/nir_from_ssa.c| 4 ++-- src/glsl/nir/nir_live_variables.c | 2 +- src/glsl/nir/nir_opt_cse.c | 4 ++-- src/glsl/nir/nir_opt_peephole_select.c | 2 +-

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: For some reason, we occasionally write the flag register with a MOV.NZ

Re: [Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

2015-01-20 Thread Connor Abbott
Assuming you grepped for uses of foreach_list* with nir_phi_src and made sure there were no more, Reviewed-by: Connor Abbott cwabbott02gmail.com On Tue, Jan 20, 2015 at 7:34 PM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir.c | 4 ++-- src/glsl/nir/nir.h

Re: [Mesa-dev] [PATCH 0/5] NIR opcodes and constant folding

2015-01-20 Thread Jason Ekstrand
Connor, You mentioned commit access. I'll try and poke someone, but if you resend with changes, I can get it pushed. --Jason On Tue, Jan 20, 2015 at 11:45 AM, Jason Ekstrand ja...@jlekstrand.net wrote: There's still some cleanups needed for 2/5. The rest is Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 16/16] i965: Convert CMP.GE -(abs)reg 0 - CMP.Z reg 0.

2015-01-20 Thread Matt Turner
On Mon, Jan 19, 2015 at 8:08 PM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 03:31 PM, Matt Turner wrote: total instructions in shared programs: 5952059 - 5951603 (-0.01%) instructions in affected programs: 138812 - 138356 (-0.33%) GAINED:1 LOST:

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add pass to propagate conditional modifiers.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 2:56 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: + if (scan_inst-dst.file == GRF + scan_inst-dst.reg == inst-src[0].reg + scan_inst-dst.reg_offset ==

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

2015-01-20 Thread Connor Abbott
On Tue, Jan 20, 2015 at 1:15 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 6:16 AM, Connor Abbott cwabbo...@gmail.com wrote: Shouldn't the subject say exec_list: Add a foreach_in_list_reverse_safe macro.? Meh? Shortlog on this file shows glsl2, exec_list, glsl, glsl/list.

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #14 from Alberto Salvia Novella es204904...@gmail.com --- I can confirm upgrading from the PPA didn't solve the problem :) Graphics hanged again just after finishing the latest comment. -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: For some reason, we occasionally write the flag register with a MOV.NZ instruction: add(8) g251F -g60,1,0F g158,8,1F cmp.l.f0(8) g261D g258,8,1F 0F mov.nz.f0(8)null

Re: [Mesa-dev] [PATCH] egl/dri2: implement platform_null.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 2:25 PM, Haixia Shi h...@chromium.org wrote: diff --git a/src/egl/drivers/dri2/platform_null.c b/src/egl/drivers/dri2/platform_null.c new file mode 100644 index 000..9c59809 --- /dev/null +++ b/src/egl/drivers/dri2/platform_null.c @@ -0,0 +1,156 @@ +/* + *

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: For some reason, we occasionally write the flag register with a MOV.NZ instruction: add(8) g251F -g60,1,0F g158,8,1F

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

2015-01-20 Thread Connor Abbott
That makes sense. However, in the vec4 backend, we do emit scratch reads and writes prior to optimization - in move_grf_array_access_to_scratch(). I've been meaning to port that over to the scalar backend. At which point, SHADER_OPCODE_GEN4_SCRATCH_WRITE would be a problem. Sort of

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add pass to propagate conditional modifiers.

2015-01-20 Thread Jason Ekstrand
On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com wrote: total instructions in shared programs: 5974160 - 5959463 (-0.25%) instructions in affected programs: 1743737 - 1729040 (-0.84%) GAINED:0 LOST: 12 ---

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner matts...@gmail.com

[Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

2015-01-20 Thread Matt Turner
Otherwise we'll apply the conditional mod to only one of SIMD8 instructions and trigger an assertion. NoDDClr/NoDDChk have the same problem but we never apply those to these instructions, so I'm leaving them for a later time. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 24

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Except typeless... We need some sort of assurance that the result of a NIR comparison is always 0 or ~0. Help me understand how this is a different situation from what we have today? Let's take for instance a vec2 ==

[Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

2015-01-20 Thread marius . predut
From: Marius Predut marius.pre...@intel.com On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are written to memory). This fixes

Re: [Mesa-dev] [PATCH] radeonsi: Enable VGPR spilling for all shader types v3

2015-01-20 Thread Michel Dänzer
On 20.01.2015 22:39, Marek Olšák wrote: The problem with CPDMA (DMA_DATA and WRITE_DATA) is that the ordering of flushes must be correct. First, partial flushes must be done, so that the shaders are idle. That's only necessary when reusing a single BO for the shader code, not when allocating a

Re: [Mesa-dev] [PATCH 05/11] mesa: Validate internal format and format type first to provide accurate error code

2015-01-20 Thread Anuj Phogat
On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev el...@igalia.com wrote: The specification states that glTexImage2D and glTexImage3D should return GL_INVALID_VALUE if the internal format is invalid, and GL_INVALID_ENUM is the format type is invalid. However, current error check only

Re: [Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

2015-01-20 Thread Ian Romanick
On 01/20/2015 07:30 AM, marius.pre...@intel.com wrote: From: Marius Predut marius.pre...@intel.com On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are written

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 4:02 PM, Matt Turner matts...@gmail.com wrote: On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Except typeless... We need some sort of assurance that the result of a NIR comparison is always 0 or ~0. Help me understand how this is a

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #17 from Alberto Salvia Novella es204904...@gmail.com --- Wait, comment 2 says further steps are needed... I'm testing now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 03/11] i965: Fix negate with unsigned integers

2015-01-20 Thread Anuj Phogat
On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For code such as: uint tmp1 = uint(in0); uint tmp2 = -tmp1; float out0 = float(tmp2); We produce code like: mov(8)g51.xF-g94,4,1.xUD which does not produce

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #23 from Michel Dänzer mic...@daenzer.net --- (In reply to Stéphane Travostino from comment #21) I'm trying to reproduce the same thing with Intel, but it's V-synced and can't manage to have it run more than 59 FPS. Have you tried

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 Alberto Salvia Novella es204904...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO

Re: [Mesa-dev] [PATCH 4/5] radeonsi: Re-enable LLVM IR dumps

2015-01-20 Thread Michel Dänzer
On 16.01.2015 09:48, Tom Stellard wrote: This was inadvertently disabled by 761e36b4caab4e8e09a4c2b1409a825902fc7d2c. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #25 from Michel Dänzer mic...@daenzer.net --- (In reply to Stéphane Travostino from comment #24) yes I confirm I can reproduce the same FPS drops with glxgears, Intel and vsync disabled. So, it seems like something is causing the

Re: [Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 7:30 AM, marius.pre...@intel.com wrote: From: Marius Predut marius.pre...@intel.com On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #16 from Alberto Salvia Novella es204904...@gmail.com --- The Synaptic package manager says there isn't any fglrx package installed, and following instructions at

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #24 from Stéphane Travostino stephane.travost...@gmail.com --- Thanks Michel, yes I confirm I can reproduce the same FPS drops with glxgears, Intel and vsync disabled. No FPS HUD for Intel, but I can see the FPS numbers change

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Tapani
On 01/20/2015 08:29 PM, Ian Romanick wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/ast_to_hir.cpp | 17 - 1 file changed,

[Mesa-dev] [PATCH v2] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Tapani Pälli
Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert v2: combine var declaration with assignment (Ian) Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/ast_to_hir.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] Implement GLX_EXT_buffer_age for DRI2

2015-01-20 Thread Dave Airlie
On 19 January 2015 at 21:00, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to suport GLX_EXT_buffer_age in DRI2, we need to pass back the last swap buffer count that the back buffer was defined for. For simplicity, we can reuse an existing field in the DRI2GetBuffers reply that is not

[Mesa-dev] [PATCH] egl/dri2: implement platform_null.

2015-01-20 Thread Haixia Shi
Try the render node first and use it if available. Otherwise fall back to normal nodes. Signed-off-by: Haixia Shi h...@chromium.org --- src/egl/drivers/dri2/Makefile.am | 5 ++ src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 3 +

[Mesa-dev] [PATCH] egl/dri2: implement platform_null.

2015-01-20 Thread Haixia Shi
Try the render node first and use it if available. Otherwise fall back to normal nodes. Signed-off-by: Haixia Shi h...@chromium.org --- src/egl/drivers/dri2/Makefile.am | 5 + src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 3 +

Re: [Mesa-dev] [PATCH 03/11] i965: Fix negate with unsigned integers

2015-01-20 Thread Iago Toral
On Tue, 2015-01-20 at 19:06 -0800, Anuj Phogat wrote: On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For code such as: uint tmp1 = uint(in0); uint tmp2 = -tmp1; float out0 = float(tmp2); We produce code

[Mesa-dev] [Bug 88467] nir.c:140: error: ‘nir_src’ has no member named ‘ssa’

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88467 Vinson Lee v...@freedesktop.org changed: What|Removed |Added CC||airl...@freedesktop.org

Re: [Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 4:37 PM, Connor Abbott cwabbo...@gmail.com wrote: Assuming you grepped for uses of foreach_list* with nir_phi_src and made sure there were no more, I did Reviewed-by: Connor Abbott cwabbott02gmail.com thanks --Jason On Tue, Jan 20, 2015 at 7:34 PM, Jason

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #15 from Timothy Arceri t_arc...@yahoo.com.au --- The open and closed drivers currently don't play nice together. Hopefully one day that will change. But to me it looks like you haven't fully removed fglrx and this is causing you

Re: [Mesa-dev] [PATCH v2] glsl: Improve precision of mod(x,y)

2015-01-20 Thread Ian Romanick
On 01/20/2015 08:09 AM, Iago Toral Quiroga wrote: Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement mod(x,y) as y * fract(x/y). This implementation has a down side though: it introduces precision errors due to the fract() operation. Even worse, since the result of fract() is

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #21 from Stéphane Travostino stephane.travost...@gmail.com --- (In reply to Hohahiu from comment #19) Maybe a wild guess, but what are the temperatures of the GPUs in your laptop? Is this an overheating issue? No, but GOOD NEWS

Re: [Mesa-dev] [mesa 9/9] glx/dri2: Implement getBufferAge

2015-01-20 Thread Ian Romanick
On 01/19/2015 03:00 AM, Chris Wilson wrote: Within the DRI2GetBuffers return packet there is a 4-byte field that is currently unused by any driver, i.e. flags. With the co-operation of a suitably modified X server, we can pass the last SBC on which the buffer was defined (i.e. the last

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #22 from Stéphane Travostino stephane.travost...@gmail.com --- (In reply to Eero Tamminen from comment #20) Are you still getting INTEL_DEBUG=perf output from them? - if you're still getting recompile messages, re-check you have

Re: [Mesa-dev] [mesa 9/9] glx/dri2: Implement getBufferAge

2015-01-20 Thread Ian Romanick
On 01/20/2015 12:35 PM, Ian Romanick wrote: On 01/19/2015 03:00 AM, Chris Wilson wrote: + DRI2Buffer *buffers; + + for (i = 0; i priv-bufferCount; i++) + attachments[i] = priv-buffers[i].attachment; + + buffers = DRI2GetBuffers(priv-base.psc-dpy,

Re: [Mesa-dev] [xorg 1/3] dri2: Allow GetBuffers to match any format

2015-01-20 Thread Ian Romanick
On 01/19/2015 03:00 AM, Chris Wilson wrote: Since the introduction of DRI2GetBuffersWithFormat, the old DRI2GetBuffers interface would always recreate all buffers all the time as it was no longer agnostic to the format value being set by the DDXes. This causes an issue with clients intermixing

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

2015-01-20 Thread Kenneth Graunke
On Tuesday, January 20, 2015 10:13:09 AM Matt Turner wrote: On Tue, Jan 20, 2015 at 12:53 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ 1 file

Re: [Mesa-dev] [dri2proto] Declare DRI2ParamXHasBufferAge

2015-01-20 Thread Ian Romanick
On 01/19/2015 03:00 AM, Chris Wilson wrote: In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers reply, we need to declare the change in semantics. To indicate that the flags field now continues the last swap buffers count instead, we introduce the has-buffer-age

Re: [Mesa-dev] [mesa 7/9] glx/dri2: Add DRI2GetParam()

2015-01-20 Thread Ian Romanick
On 01/19/2015 03:00 AM, Chris Wilson wrote: Available since the inclusion of dri2proto 1.4 is a DRI2 request to query and set certain parameters about the X/DDX configuration. This implements the getter request. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk This patch is

Re: [Mesa-dev] [PATCH 3/5] nir: add new constant folding infrastructure

2015-01-20 Thread Jason Ekstrand
On Mon, Jan 19, 2015 at 5:01 PM, Connor Abbott cwabbo...@gmail.com wrote: On Mon, Jan 19, 2015 at 4:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: I've got some specific comments below, but I want to make some more general comments here. I like this in principle: having all the opcodes

Re: [Mesa-dev] [PATCH 0/5] NIR opcodes and constant folding

2015-01-20 Thread Jason Ekstrand
There's still some cleanups needed for 2/5. The rest is Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Fri, Jan 16, 2015 at 1:53 PM, Connor Abbott cwabbo...@gmail.com wrote: Oh, and I forgot... the series is also available at https://github.com/cwabbott0/mesa nir-opcodes-cleanup

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #12 from Timothy Arceri t_arc...@yahoo.com.au --- (In reply to Alberto Salvia Novella from comment #11) Does fglrx depend on Mesa? No How can I figure out if this is a bug in Mesa? Make sure you have completely removed fglrx