Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ian Romanick
On 04/04/2015 11:48 PM, Dave Airlie wrote: This was using the wrong extension, ARB_stencil_texturing doesn't mention any changes in this area. Right... that extension only enables reading the stencil value from a GL_DEPTH_STENCIL texture. This patch is Reviewed-by: Ian Romanick

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Mon, Apr 06, 2015 at 12:05:56PM -0400, Ilia Mirkin wrote: On Mon, Apr 6, 2015 at 11:33 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: On Sun,

Re: [Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-06 Thread Ian Romanick
On 04/02/2015 10:55 AM, Thomas Helland wrote: This reminds me of a patch Eric wrote that probably fell through the cracks when he migrated jobs: https://freedesktop.org/patch/26778/ Free the compiled shader IR after it has been linked There's a pretty significant bug triggered by that code.

[Mesa-dev] [Bug 89920] eglCreatePlatformWindowSurfaceEXT() should not dereference native_window

2015-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89920 Bug ID: 89920 Summary: eglCreatePlatformWindowSurfaceEXT() should not dereference native_window Product: Mesa Version: 10.5 Hardware: All OS: All

[Mesa-dev] [Bug 89920] eglCreatePlatformWindowSurfaceEXT() should not dereference native_window

2015-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89920 Daniel Stone dan...@fooishbar.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] gallium/ttn: fix for arrays vs regs

2015-04-06 Thread Eric Anholt
Rob Clark robdcl...@gmail.com writes: From: Rob Clark robcl...@freedesktop.org Just because there is array access, doesn't mean everything is an array. Reviewed-by: Eric Anholt e...@anholt.net signature.asc Description: PGP signature ___ mesa-dev

Re: [Mesa-dev] [PATCH 03/23] i965/fs: Use MOV.nz instead of AND.nz to generate flag on GEN6+

2015-04-06 Thread Matt Turner
On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com On SNB+, the Boolean result is always 0 or ~0, so MOV.nz produces the same effect as AND.nz. However, later cmod propagation passes can handle the MOV.nz, but they cannot

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ian Romanick
On 04/06/2015 08:33 AM, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: While this change is correct, the Intel guys will

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Mon, Apr 06, 2015 at 11:37:08AM -0700, Ian Romanick wrote: On 04/06/2015 08:33 AM, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia

Re: [Mesa-dev] [PATCH] nir: split out lower_sub from lower_negate

2015-04-06 Thread Eric Anholt
Rob Clark robdcl...@gmail.com writes: From: Rob Clark robcl...@freedesktop.org Originally you had to have one or the other. But actually I don't want either. (Or rather I want whatever is the minimum # of instructions.) TODO: not sure where the best place to insert a check that driver

Re: [Mesa-dev] [PATCH 03/23] i965/fs: Use MOV.nz instead of AND.nz to generate flag on GEN6+

2015-04-06 Thread Ian Romanick
On 04/06/2015 11:35 AM, Matt Turner wrote: On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com On SNB+, the Boolean result is always 0 or ~0, so MOV.nz produces the same effect as AND.nz. However, later cmod propagation passes

[Mesa-dev] [PATCH] i965/meta/hack: Prepare stencil blit for ARB_texture_stencil8

2015-04-06 Thread Topi Pohjolainen
This allows _mesa_base_tex_format() to be fixed to use correct extension when choosing format for stencil, ARB_texture_stencil8 and not ARB_stencil_texturing. No piglit regressions on BDW. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

[Mesa-dev] [PATCH] u_tile: fix stencil texturing tests under softpipe

2015-04-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com arb_stencil_texturing-draw failed under softpipe because we got a float back from the texturing function, and then tried to U2F it, stencil texturing returns ints, so we should fix the tiling to retrieve the stencil values as integers not floats.

Re: [Mesa-dev] [PATCH 3/3] i965: Make sure GS output streams 1-3 aren't rasterized on Haswell+.

2015-04-06 Thread Kenneth Graunke
On Monday, April 06, 2015 10:01:16 AM Matt Turner wrote: On Sat, Apr 4, 2015 at 3:46 AM, Kenneth Graunke kenn...@whitecape.org wrote: Presumably no one has noticed this breakage because ARB_transform_feedback3 isn't exposed on Haswell due to the ongoing command streamer shenanigans, and

[Mesa-dev] [PATCH] i965: Use SET_FIELD in 3DSTATE_STREAMOUT packets.

2015-04-06 Thread Kenneth Graunke
Suggested by Topi Pohjolainen. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 16 src/mesa/drivers/dri/i965/gen8_sol_state.c | 16 2 files changed, 16

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

2015-04-06 Thread Matt Turner
On Fri, Apr 3, 2015 at 2:06 PM, Jason Ekstrand ja...@jlekstrand.net wrote: SEL and MOV instructions, as long as they don't have source modifiers, are just copying bits around. This commit adds support to copy propagation to switch the type of a SEL or MOV instruction as needed so that it can

[Mesa-dev] [PATCH] i965: Add the ability to render to I8/L8 and I16/L16 UNORM formats.

2015-04-06 Thread Kenneth Graunke
This allows those formats to work with the meta PBO upload path. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c

[Mesa-dev] [PATCH] nir/lower_tex_projector: Don't use designated initializers

2015-04-06 Thread Jason Ekstrand
These don't work in MSVC or in older versions of GCC Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89899 Cc: Eric Anholt e...@anholt.net --- src/glsl/nir/nir_lower_tex_projector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2] r600g/sb: Enable SB for geometry shaders

2015-04-06 Thread Glenn Kennard
Add SV_GEOMETRY_EMIT special variable type to track the implicit dependencies between CUT/EMIT_VERTEX/MEM_RING instructions so GCM/scheduler doesn't reorder them. Mark emit instructions as unkillable so DCE doesn't eat them. Enable only for evergreen/cayman as there are a few unexplained GS

Re: [Mesa-dev] [PATCH v2] r600g/sb: Enable SB for geometry shaders

2015-04-06 Thread Dave Airlie
On 7 April 2015 at 11:00, Glenn Kennard glenn.kenn...@gmail.com wrote: Add SV_GEOMETRY_EMIT special variable type to track the implicit dependencies between CUT/EMIT_VERTEX/MEM_RING instructions so GCM/scheduler doesn't reorder them. Mark emit instructions as unkillable so DCE doesn't eat

Re: [Mesa-dev] [PATCH] u_tile: fix stencil texturing tests under softpipe

2015-04-06 Thread Roland Scheidegger
Am 07.04.2015 um 02:15 schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com arb_stencil_texturing-draw failed under softpipe because we got a float back from the texturing function, and then tried to U2F it, stencil texturing returns ints, so we should fix the tiling to retrieve the

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

2015-04-06 Thread Jason Ekstrand
On Mon, Apr 6, 2015 at 4:55 PM, Matt Turner matts...@gmail.com wrote: On Fri, Apr 3, 2015 at 2:06 PM, Jason Ekstrand ja...@jlekstrand.net wrote: SEL and MOV instructions, as long as they don't have source modifiers, are just copying bits around. This commit adds support to copy propagation to

Re: [Mesa-dev] [PATCH v2 1/3] i965/fs: Use the source type when looking for UD negations in copy prop

2015-04-06 Thread Jason Ekstrand
On Mon, Apr 6, 2015 at 4:50 PM, Matt Turner matts...@gmail.com wrote: On Fri, Apr 3, 2015 at 2:06 PM, Jason Ekstrand ja...@jlekstrand.net wrote: There can be problems with floats and conditional modifiers when copy-propagating a negated UD source. Previously, we checked the source to be

[Mesa-dev] [PATCH] i965: Fix depth field setting in surface state for raw buffer on Gen7/8

2015-04-06 Thread Zhenyu Wang
On Gen7/8 for RAW surface format, the depth field (surf[3]) in surface state means [30:21] bits of number of entries which is different from other surface format which uses [26:21] bits field. Signed-off-by: Zhenyu Wang zhen...@linux.intel.com ---

[Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Pushing this through a complete piglit run, but it seems to fix bin/arb-provoking-vertex-render on a3xx. Please take special care to double-check that I didn't mess up cw/ccw order or something. I'm especially weak on the quadstrip case.

Re: [Mesa-dev] [PATCH] wayland-drm: add a description for every item.

2015-04-06 Thread Pekka Paalanen
On Wed, 25 Mar 2015 13:10:24 +0100 Emmanuel Gil Peyrot linkma...@linkmauve.fr wrote: This makes the generated protocol headers a lot more readable. --- src/egl/wayland/wayland-drm/wayland-drm.xml | 159 +--- 1 file changed, 100 insertions(+), 59 deletions(-) diff

Re: [Mesa-dev] [PATCH 3/4] st/mesa: add ARB_texture_stencil8 support (v2)

2015-04-06 Thread Marek Olšák
Putting S8 last in the list is like not putting it there at all. Marek On Mon, Apr 6, 2015 at 5:07 AM, Dave Airlie airl...@gmail.com wrote: if we support stencil texturing, enable texture_stencil8 there is no requirement to support native S8 for this, the texture can be converted to x24s8

Re: [Mesa-dev] [PATCH] st/mesa: improve ARB_texture_stencil8 support

2015-04-06 Thread Marek Olšák
Evergreen and later chips support S8, but there are limitations: if you want to bind a separate depth buffer to it, it must have the same tiling parameters except for the tile split (that's the only one that can be different) and HTILE must be disabled. Not really worth implementing. S8 without a

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: implement platform_null (v2).

2015-04-06 Thread Daniel Stone
On 4 April 2015 at 08:46, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-04-03 19:18:35, Stéphane Marchesin wrote: Perhaps EGL_MESA_platform_surfaceless and platform_surfaceless.c? That's a very good name. As it happens, it also matches Chrome's naming. Chad made the point that this

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: While this change is correct, the Intel guys will yell at you, because they're somehow

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ilia Mirkin
On Mon, Apr 6, 2015 at 11:33 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: While this

[Mesa-dev] [PATCH] gallium/ttn: fix for arrays vs regs

2015-04-06 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org Just because there is array access, doesn't mean everything is an array. Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 3/3] i965: Make sure GS output streams 1-3 aren't rasterized on Haswell+.

2015-04-06 Thread Matt Turner
On Sat, Apr 4, 2015 at 3:46 AM, Kenneth Graunke kenn...@whitecape.org wrote: Presumably no one has noticed this breakage because ARB_transform_feedback3 isn't exposed on Haswell due to the ongoing command streamer shenanigans, and ARB_gpu_shader5 isn't exposed on Broadwell because we keep