Presumably Connor renamed the parameter, inverting the sense.
Update the comment accordingly.
Cc: Connor Abbott cwabbo...@gmail.com
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/nir/nir.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On Mon, Jul 06, 2015 at 09:34:10AM -0700, Kenneth Graunke wrote:
On Monday, July 06, 2015 11:33:08 AM Chris Wilson wrote:
Since the workaround bo is used strictly as a write-only buffer, we need
only allocate one per screen and use the same one from all contexts.
(The caveat here is
On Tue, Jul 07, 2015 at 10:03:09PM -0700, Kenneth Graunke wrote:
Hi Chris,
I made a genuine effort to review this patch, hoping to better understand
the various changes and what you were trying to accomplish. I spent many
hours reading and trying to enumerate changes - or potential changes
On 08/07/15 07:33, Matt Turner wrote:
Cc: 10.6 mesa-sta...@lists.freedesktop.org
Thanks for that I've completely forgot about this.
Seems like we never got to using mesa_sha. Can we just remove it for now
and revive it as a user comes along ?
Cheers,
Emil
On Mon, Jul 06, 2015 at 09:30:48AM -0700, Kenneth Graunke wrote:
On Monday, July 06, 2015 11:33:07 AM Chris Wilson wrote:
With the exception of gen8, the sole user of the workaround bo are for
emitting pipe controls. Move it out of the purview of the batchbuffer
and into the pipecontrol.
On Tue, Jul 07, 2015 at 08:40:12PM +0100, Emil Velikov wrote:
On 06/07/15 11:33, Chris Wilson wrote:
Since there was an ABI break and linking twice against libudev.so.0 and
libudev.so.1 causes the application to quickly crash, we first check if
the application is currently linked against
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #5 from Tomasz C. toma...@o2.pl ---
This confirmed yet by compiling 10.6.1 of reverse patch:
https://git.thm.de/tjkl80/mesa/commit/0e0e23ef537c9add672ff322f34e129a07edc55e.patch
It works correctly.
Do you expect the correction in the
On Mon, Jul 06, 2015 at 10:01:21AM -0700, Kenneth Graunke wrote:
On Monday, July 06, 2015 05:12:10 PM Chris Wilson wrote:
On Mon, Jul 06, 2015 at 04:19:36PM +0300, Martin Peres wrote:
On 06/07/15 16:15, Martin Peres wrote:
On 06/07/15 16:13, Chris Wilson wrote:
On Mon, Jul 06,
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #4 from Tomasz C. toma...@o2.pl ---
I made a test the bisection method, here's the result:
0e0e23ef537c9add672ff322f34e129a07edc55e is the first bad commit
commit 0e0e23ef537c9add672ff322f34e129a07edc55e
Author: Jordan Justen
Combining the multiple access checks into a few batches and a single
serialising read can reduce detection times from around 100us to 70us on
a fast Haswell system.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Kenneth Graunke kenn...@whitecape.org
---
Whoops!
Reviewed-by: Connor Abbott cwabbo...@gmail.com
On Wed, Jul 8, 2015 at 1:57 AM, Kenneth Graunke kenn...@whitecape.org wrote:
Presumably Connor renamed the parameter, inverting the sense.
Update the comment accordingly.
Cc: Connor Abbott cwabbo...@gmail.com
Signed-off-by: Kenneth
If we don't have pipelined register access (e.g. Haswell before kernel
v4.2), then we can only implement EXT_transform_feedback by reseting the
SO offsets *between* batches. However, if we do have pipelined access to
the SO registers on gen7, we can simply emit an inline reset of the SO
registers
Since the workaround bo is used strictly as a write-only buffer, we need
only allocate one per screen and use the same one from all contexts.
(The caveat here is during extension initialisation, where we write into
and read back register values from the buffer, but that is performed only
once for
Moving the test to the screen places it alongside the other global HW
feature tesst that want to be shared between contexts.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_context.c | 1 +
Similarly to the pipelined SO_OFFSET check, this moves the global HW
compatability check to the screen next to the other global checks.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
src/mesa/drivers/dri/i965/brw_context.c | 1 +
src/mesa/drivers/dri/i965/brw_context.h | 1
On 08/07/15 12:01, Chris Wilson wrote:
On Tue, Jul 07, 2015 at 01:42:47PM +0300, Martin Peres wrote:
On 06/07/15 19:43, Kenneth Graunke wrote:
On Monday, July 06, 2015 11:33:10 AM Chris Wilson wrote:
Rather than allocating a fresh page every time we clear a buffer, keep
that page around
On Wed, Jul 08, 2015 at 09:51:07AM +0100, Chris Wilson wrote:
On Tue, Jul 07, 2015 at 10:03:09PM -0700, Kenneth Graunke wrote:
* Gen4-5 structure changes.
Did you mean brw_structs.h?
diff --git a/src/mesa/drivers/dri/i965/brw_structs.h
b/src/mesa/drivers/dri/i965/brw_structs.h
index
https://bugs.freedesktop.org/show_bug.cgi?id=90264
--- Comment #33 from Jose P. lbdkm...@sharklasers.com ---
(In reply to Jose P. from comment #21)
This seems to have been fixed, I can't see the corruption anymore. I'm using
Chromium 43.0.2357.81 on Ubuntu 14.04 (64-bit) and Mesa 10.7.0-devel
On Tue, Jul 07, 2015 at 01:42:47PM +0300, Martin Peres wrote:
On 06/07/15 19:43, Kenneth Graunke wrote:
On Monday, July 06, 2015 11:33:10 AM Chris Wilson wrote:
Rather than allocating a fresh page every time we clear a buffer, keep
that page around between invocations by tracking the last used
On Wed, Jul 8, 2015 at 10:07 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/mesa/drivers/dri/i915/intel_context.c | 1 -
src/mesa/drivers/dri/i915/intel_context.h | 2 --
2 files changed, 3 deletions(-)
diff --git
Emil Velikov emil.l.veli...@gmail.com writes:
Hello all,
A recent patch by Chris, fixing some libudev fun in our loader, made
me think if we can clear it up a bit.
Having three different ways of retrieving the vendor/device ID does
feel a bit excessive. Plus as one gets fixed others are
Most of the data stored(duplicated) was unused, and for the one that is
follow the approach set by other drivers.
This eliminates the use of legacy (dri1) types.
XXX: The radeon code is the only user of __DRIscreen::drm_version (the
only __DRIversion outside of dri1 land). Should we move it into
On Wed, Jul 8, 2015 at 3:00 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
On 08/07/15 07:33, Matt Turner wrote:
Cc: 10.6 mesa-sta...@lists.freedesktop.org
Thanks for that I've completely forgot about this.
Seems like we never got to using mesa_sha. Can we just remove it for now
and revive
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac | 2 +-
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index d819bef..eb7180b 100644
--- a/configure.ac
No longer applicable since the cleanup of dri_interface.h.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/mesa/drivers/dri/swrast/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/swrast/Makefile.am
b/src/mesa/drivers/dri/swrast/Makefile.am
index
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
include/GL/internal/dri_interface.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_interface.h
index c827bb6..c0545b1 100644
---
Set the macro if we're not building swrast alone.
Cc: Chih-Wei Huang cwhu...@linux.org.tw
Cc: Eric Anholt e...@anholt.net
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/targets/dri/Android.mk | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
See previous commit message for details.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/mesa/drivers/dri/common/Android.mk | 13 ++---
src/mesa/drivers/dri/common/Makefile.am | 2 +-
src/mesa/drivers/dri/common/SConscript | 4
src/mesa/drivers/dri/common/dri_util.c
Same as previous commit - unused (gbm is not a thing outside the
autotools build).
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/SConscript| 1 -
src/gallium/state_trackers/dri/SConscript | 1 -
src/gallium/targets/dri/SConscript| 4
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/mesa/drivers/dri/i915/intel_context.c | 1 -
src/mesa/drivers/dri/i915/intel_context.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/intel_context.c
b/src/mesa/drivers/dri/i915/intel_context.c
index
These conditionals are used to guard both dri modules and loader(s).
Currently if we try to build the gallium swrast dri module (without glx)
on a system that's missing libdrm the build will fail.
Cc: 10.6 mesa-sta...@lists.freedesktop.org
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
GBM (the only user of kms-dri) is currently not available under Android.
Considering we have no way of testing/using this let's not bother
building it for now.
Cc: Chih-Wei Huang cwhu...@linux.org.tw
Cc: Eric Anholt e...@anholt.net
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
Double negatives in English language are normally avoided, plus the
former seems cleaner and more consistent.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/loader/Android.mk | 6 ++
src/loader/Makefile.am | 5 +
src/loader/SConscript | 2 --
With the dri_interface.h clean of the macro, we can remove the final
only st/dri specific use of the very same.
Seemingly it was incorrectly used, as the build-time presence of dri2 is
not libdrm specific. At run-time, the code is already limited to dri2
use-cases plus returning true, when the
Hi all,
As double-negatives are not too appealing in the English language I've
decided to nuke the common ifndef __NOT_HAVE_DRM_H.
The first three patches are trivial bugfix + cleanups which I've noticed
while browsing through, 04-09 remove all occurrences of the lastly macro
(HAVE_LIBDRM is
From: Rob Clark robcl...@freedesktop.org
XA was never unref'ing last_fence in the various call paths to
pipe-flush(). Add this to xa_context_flush() and update the other
open-coded calls to pipe-flush() to use xa_context_flush() instead.
This fixes a memory leak reported with
https://bugs.freedesktop.org/show_bug.cgi?id=91254
Ian Romanick i...@freedesktop.org changed:
What|Removed |Added
CC||i...@freedesktop.org
On Wed, Jul 08, 2015 at 10:49:24AM -0700, Kenneth Graunke wrote:
On Wednesday, July 08, 2015 03:17:35 PM Chris Wilson wrote:
On Wed, Jul 08, 2015 at 09:51:07AM +0100, Chris Wilson wrote:
On Tue, Jul 07, 2015 at 10:03:09PM -0700, Kenneth Graunke wrote:
* Gen4-5 structure changes.
Did
On Wednesday, July 08, 2015 03:17:35 PM Chris Wilson wrote:
On Wed, Jul 08, 2015 at 09:51:07AM +0100, Chris Wilson wrote:
On Tue, Jul 07, 2015 at 10:03:09PM -0700, Kenneth Graunke wrote:
* Gen4-5 structure changes.
Did you mean brw_structs.h?
diff --git
On 08/07/2015 00:15, Emil Velikov wrote :
Can anyone shed a light/cast their 2c ?
Thanks
Emil
___
The DRI3/Wayland/Gallium Nine DRI_PRIME path uses libudev,
and I'm not sure it could work without.
It is based on the ID_PATH_TAG advertised by
On 8 July 2015 at 17:47, Matt Turner matts...@gmail.com wrote:
On Wed, Jul 8, 2015 at 3:00 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
On 08/07/15 07:33, Matt Turner wrote:
Cc: 10.6 mesa-sta...@lists.freedesktop.org
Thanks for that I've completely forgot about this.
Seems like we never
From: Rob Clark robcl...@freedesktop.org
This isn't at all clear for pipe driver writers currently, since it
is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop
the ref on the **fence passed in to pipe-flush() (if *fence!=NULL).
Freedreno/ilo/vc4 where not doing this. Some
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
By keeping a pointer to the next available location, we reduce the
number of memory accesses needed to write to the batchbuffer.
A net ~7k reduction of .text size, 7.5k of which is from the change to
intel_batchbuffer_emit_dword().
text data bss dec hex filename
4943740
It's only used inside #ifdef DEBUG. Cuts ~1.7k of .text, and more
importantly prevents a larger code size regression in the next commit
when the .used field is replaced and calculated on demand.
text data bss dec hex filename
4945468 19515226192 5166812 4ed6dc
From: Rob Clark robcl...@freedesktop.org
No where was it spelled out that the state tracker may expect the pipe
driver to unref the old fence.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
src/gallium/include/pipe/p_context.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
On Thu, Jul 02, 2015 at 12:58:33PM -0700, Matt Turner wrote:
On Thu, Jul 2, 2015 at 12:57 PM, Matt Turner matts...@gmail.com wrote:
On Wed, Jul 1, 2015 at 4:03 PM, Ben Widawsky
benjamin.widaw...@intel.com wrote:
Certain compressed formats require this setting. The docs don't go into
much
On Wed, Jul 08, 2015 at 02:00:02PM -0700, Matt Turner wrote:
By keeping a pointer to the next available location, we reduce the
number of memory accesses needed to write to the batchbuffer.
A net ~7k reduction of .text size, 7.5k of which is from the change to
intel_batchbuffer_emit_dword().
WARNING: No perf data, please keep reading though)
This implements the suggestion provided by the paper, Fast USWC to WB Memory
Copy
(https://software.intel.com/en-us/articles/copying-accelerated-video-decode-frame-buffers).
This is described throughout the paper, but the sample code lives in
Bleh, assert(pipe_is_referenced(ptr)) in pipe_reference_described() is
non-pleased in debug builds about the trick of starting out the fences
w/ refcnt=0 (so that it doesn't end up getting upref'd to 2 in
pipe-flush().. so I'll have to re-work the fd/ilo/vc4 patches
slightly..
BR,
-R
On Wed, Jul
Cc: 10.6 mesa-sta...@lists.freedesktop.org
---
src/util/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/Makefile.am b/src/util/Makefile.am
index 2e7542e..1e087b4 100644
--- a/src/util/Makefile.am
+++ b/src/util/Makefile.am
@@ -46,9 +46,9 @@
On Tue, Jul 07, 2015 at 10:21:28PM +0300, Francisco Jerez wrote:
Instead of relying on hardware defaults the i915 kernel driver is
going program custom MOCS tables system-wide on Gen9 hardware. The
WT entry previously used for renderbuffers had a number of problems:
It disabled caching on
On Tuesday, July 07, 2015 11:33:57 PM Matt Turner wrote:
Cc: 10.6 mesa-sta...@lists.freedesktop.org
---
src/util/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/Makefile.am b/src/util/Makefile.am
index 2e7542e..1e087b4 100644
---
On 09.07.2015 02:07, Emil Velikov wrote:
Most of the data stored(duplicated) was unused, and for the one that is
follow the approach set by other drivers.
This eliminates the use of legacy (dri1) types.
The commentary below should have been after the --- separator, not in
the actual Git commit
https://bugs.freedesktop.org/show_bug.cgi?id=91259
Kenneth Graunke kenn...@whitecape.org changed:
What|Removed |Added
Component|Other |Drivers/DRI/i965
Rob Clark robdcl...@gmail.com writes:
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
On Wed, Jul 08, 2015 at 03:33:17PM -0700, Matt Turner wrote:
On Wed, Jul 8, 2015 at 2:07 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Wed, Jul 08, 2015 at 02:00:02PM -0700, Matt Turner wrote:
By keeping a pointer to the next available location, we reduce the
number of memory accesses
Certain compressed formats require this setting. The docs don't go into much
detail as to why it's needed exactly.
This patch introduces no piglit regressions on gen9 (bsw is untested). Note that
the SKL regressions are fixed tests, and the egl_khr_gl_colorspace tests are
WTF. The patch also
On Wed, Jul 8, 2015 at 2:07 PM, Ben Widawsky
benjamin.widaw...@intel.com wrote:
WARNING: No perf data, please keep reading though)
This implements the suggestion provided by the paper, Fast USWC to WB Memory
Copy
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
From: Rob Clark robcl...@freedesktop.org
Some, but not all, state trackers will explicitly unref (and set to
NULL) the previous *fence before calling pipe-flush(). So driver
should use fence_ref() which will unref the old fence if not NULL.
Signed-off-by: Rob Clark robcl...@freedesktop.org
---
On Wed, Jul 8, 2015 at 2:07 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Wed, Jul 08, 2015 at 02:00:02PM -0700, Matt Turner wrote:
By keeping a pointer to the next available location, we reduce the
number of memory accesses needed to write to the batchbuffer.
A net ~7k reduction of
On Thu, Jul 09, 2015 at 12:53:23AM +0100, Chris Wilson wrote:
This is what I expected to see
0x025e +62: movl $0x780d1c02,(%rcx)
0x0264 +68: mov0x22f08(%rdi),%rax
0x026b +75: mov0x24320(%rdi),%edx
0x0271 +81: mov
On Wed, Jul 8, 2015 at 4:53 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Wed, Jul 08, 2015 at 03:33:17PM -0700, Matt Turner wrote:
On Wed, Jul 8, 2015 at 2:07 PM, Chris Wilson ch...@chris-wilson.co.uk
wrote:
On Wed, Jul 08, 2015 at 02:00:02PM -0700, Matt Turner wrote:
By keeping a
On 09.07.2015 05:34, Rob Clark wrote:
From: Rob Clark robcl...@freedesktop.org
No where was it spelled out that the state tracker may expect the pipe
Nowhere?
driver to unref the old fence.
Signed-off-by: Rob Clark robcl...@freedesktop.org
Either way, the series is
Reviewed-by: Michel
https://bugs.freedesktop.org/show_bug.cgi?id=91222
Luke lukebe...@hotmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
From: Dave Airlie airl...@redhat.com
Cayman needs a different method to upload the CF IDX0/1
This fixes 31 piglits when ARB_gpu_shader5 is forced on
with cayman.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/gallium/drivers/r600/eg_asm.c | 17 +++--
NOP actually has no compact version, but we use it for instruction
alignment for compact kernel. Although it seems working on HW, it is
illegal and might not be valid for any future one.
This trys to get a temporary compact instruction with no effect for
alignment to replace compacted NOP. G45
71 matches
Mail list logo
