I had sightly different fix for this but on same lines;
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
On 07/29/2015 04:56 PM, Timothy Arceri wrote:
This fixes the remaining failing tests in:
ES31-CTS.program_interface_query.uniform-types
Reviewed-by: Samuel Iglesias Gonsálvez
On 30 July 2015 3:27:41 pm AEST, Tapani Pälli tapani.pa...@intel.com wrote:
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
See §7.19.6.1, paragraph 7 of the ISO C specification.
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com
---
src/mesa/main/bufferobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 9425b09..453b864
From: Dave Airlie airl...@redhat.com
The API can hit this, as the ogl confirm suite showed, I've
sent a piglit test to also demonstrate hitting it.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/state_tracker/st_cb_xformfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
valid_program_resource_index_name() that together with your patch glsl:
set stage flag for structs and arrays in resource list will fix all of
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
valid_program_resource_index_name() that together with your patch
glsl: set stage flag for structs
On 07/30/2015 08:50 AM, Timothy Arceri wrote:
On 30 July 2015 3:27:41 pm AEST, Tapani Pälli tapani.pa...@intel.com wrote:
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and
On 29 July 2015 at 15:16, Emil Velikov emil.l.veli...@gmail.com wrote:
This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
lookup over the server's.) from glx/dri2.
Cc: Eric Anholt e...@anholt.net
Reported-by: Julien Isorce julien.iso...@gmail.com
Signed-off-by: Emil Velikov
Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
Although it did not consider the (very unlikely) case where we might end
up with the valid fd == 0.
Fixes: 28dda47ae4d(winsys/radeon: Use dup fd as key in drm-winsys hash
table to fix ZaphodHeads.)
Cc: Mario Kleiner
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
---
src/glsl/link_varyings.cpp | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 1c52ff3..5f42f8c 100644
V2: move single dimensional array detection into a helper
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com
---
src/glsl/ast.h | 8
src/glsl/ast_to_hir.cpp | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
If useful the series is in the 'gles8' branch of the repo here:
https://github.com/tarceri/Mesa_arrays_of_arrays.git
Changes in v3:
- Rebased on the tessellation and subroutine changes
- Atomic counter AoA now working including indirect indexing (previously I had
broken piglit tests that were
This removes the need for multiple functions designed to validate an array
subscript and replaces them with a call to a single function.
The change also means that validation is now only done once and the index
is retrived at the same time, as a result the getUniformLocation code can
be
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/program_resource.c | 51 ---
src/mesa/main/shader_query.cpp | 57
2 files changed, 108 deletions(-)
diff --git a/src/mesa/main/program_resource.c
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniform_query.cpp | 75 -
src/mesa/main/uniforms.h| 4 ---
2 files changed, 79 deletions(-)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index
These changes are also needed to allow linking of
struct and interface arrays of arrays.
---
src/glsl/link_uniforms.cpp | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
index 254086d..42f75e9 100644
---
---
src/glsl/link_uniform_initializers.cpp | 68 --
1 file changed, 41 insertions(+), 27 deletions(-)
diff --git a/src/glsl/link_uniform_initializers.cpp
b/src/glsl/link_uniform_initializers.cpp
index 0cc79d9..d6a6ab7 100644
---
This fixes the remaining failing tests in:
ES31-CTS.program_interface_query.uniform-types
Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com
---
src/glsl/linker.cpp | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/glsl/linker.cpp
V2: Handle arrays of arrays in the same way structures are handled
The ARB_arrays_of_arrays spec doesn't give very many details on how
AoA uniforms are intended to be implemented. However in the
ARB_program_interface_query spec there are details that show AoA are
intended to be handled in a
---
src/glsl/nir/nir_lower_atomics.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c
index ce3615a..ea63474 100644
--- a/src/glsl/nir/nir_lower_atomics.c
+++
From: Iago Toral Quiroga ito...@igalia.com
Notice that the spec requires that a default precision has been set for every
type used by a shader that can use a precision qualifier and does not have a
predefined precision, however, at the moment, Mesa only checks this for floats
in the fragment
From: Antia Puentes apuen...@igalia.com
Commit 1ca25ab (glsl: Do not eliminate 'shared' or 'std140' blocks
or block members) considered as active 'shared' and 'std140' uniform
blocks and uniform block arrays, but did not include the block array
elements. Because of that, it was possible to have
From: Eduardo Lima Mitev el...@igalia.com
Page 161 of the OpenGL-ES 3.1 (PDF) spec, and page 207 of the OpenGL 4.5 (PDF),
both on section '8.6. ALTERNATE TEXTURE IMAGE SPECIFICATION COMMANDS', states:
An INVALID_ENUM error is generated if an invalid value is specified for
From: Iago Toral Quiroga ito...@igalia.com
We do this in two steps: first we clip the dst rect and adjust the src
rect accordingly. Then we do it the other way around. In both passes
the adjustment part involves multiplying by a scale factor that can lead
to a small precision loss. This is
From: Iago Toral Quiroga ito...@igalia.com
From section 9.2. Binding and Managing Framebuffer Objects:
Upon successful return from Get*FramebufferAttachmentParameteriv, if
pname is FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, then params will contain
one of NONE, FRAMEBUFFER_DEFAULT, TEXTURE, or
Hello,
This is an updated list of unreviewed dEQP fixes we have sent some time
ago. If you want to test them, they are available here:
https://github.com/Igalia/mesa/commits/deqp-fixes-batch8
If you want to clone it:
$ git clone -b deqp-fixes-batch8 https://github.com/Igalia/mesa.git
When a transform feedback object is bound and not active, the OpenGL ES
3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its
deletion. Only the deletion of the default framebuffer object is
forbidden.
This patch follows what it is done for glDeleteTextures(), i.e.
the binding
From: Iago Toral Quiroga ito...@igalia.com
We will need this later on when we implement proper support for precision
qualifiers in the drivers and also to do link time checks for uniforms as
indicated by the spec.
This patch also adds compile-time checks for variables without precision
From: Iago Toral Quiroga ito...@igalia.com
As the comment in precision_qualifier_allowed() says, they are only allowed
for float, integer and sampler types.
---
src/glsl/ast_to_hir.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index
From: Iago Toral Quiroga ito...@igalia.com
These have scoping rules that match the ones defined for other things such
as variables, so we want them in the symbol table.
---
src/glsl/glsl_symbol_table.cpp | 24
src/glsl/glsl_symbol_table.h | 2 ++
2 files changed, 26
From: Iago Toral Quiroga ito...@igalia.com
Currently, we only consider precision qualifiers at compile-time. This patch
adds precision information to ir_variable so we can also do link time checks.
Specifically, from the GLSL ES3 spec, 4.5.3 Precision Qualifiers:
The same uniform declared in
From: Iago Toral Quiroga ito...@igalia.com
So they can hide declarations with the same name in other scopes.
Otherwise we get a parsing error for things like:
struct S { int val; };
int func (int S) { return S; }
Fixes the following 2 dEQP tests:
From: Eduardo Lima Mitev el...@igalia.com
Currently, glTexSubImageXD attempt to resolve the texture object
(by calling _mesa_get_current_tex_object()) before validating the given
target. However, that method explicitly states that target must have been
validated before calling it, so it never
From: Eduardo Lima Mitev el...@igalia.com
Argument validation for glTexSubImageXD is missing a check of format and type
against texture object's internal format when profile is OpenGL-ES 3.0+.
This patch also groups together all format and type checks into a single
block of code for clarity.
From: Eduardo Lima Mitev el...@igalia.com
Page 68, section 7.2 'Shader Binaries of the of the OpenGL ES 3.1,
and page 88 of the OpenGL 4.5 specs state:
An INVALID_VALUE error is generated if count or length is negative.
An INVALID_ENUM error is generated if binaryformat is not a
From: Iago Toral Quiroga ito...@igalia.com
We were doing this for all variables in a declaration list, but not
when there was just a single declaration. As a consequence, when we
used a single variable declaration to redeclare a type that existed
in a previous scope we would get a parsing error,
From: Iago Toral Quiroga ito...@igalia.com
Shaders with excessive number of attributes (16) can produce a crash
due to buffer overflow in assign_attribute_or_color_locations. The
overflow can happen because we declare a fixed size array that can hold
up to 16 attributes and we don't check that we
From: Iago Toral Quiroga ito...@igalia.com
The GLSL ES spec specifies default precision qualifiers for certain types,
so populate the symbol table with these.
Notice that the desktop GLSL spec also indicates defaults for some types
but this is not really useful since precision qualifiers are
On Jul 29, 2015 3:12 AM, Francisco Jerez curroje...@riseup.net wrote:
Jason Ekstrand ja...@jlekstrand.net writes:
On Tue, Jul 28, 2015 at 1:23 AM, Francisco Jerez curroje...@riseup.net
wrote:
Instead of relying on the default one. This shouldn't lead to any
functional changes because
Jason Ekstrand ja...@jlekstrand.net writes:
On Jul 29, 2015 3:12 AM, Francisco Jerez curroje...@riseup.net wrote:
Jason Ekstrand ja...@jlekstrand.net writes:
On Tue, Jul 28, 2015 at 1:23 AM, Francisco Jerez curroje...@riseup.net
wrote:
Instead of relying on the default one. This
V2: return 0 if not array rather than -1
---
src/glsl/glsl_types.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h
index 52672b3..cd50d13 100644
--- a/src/glsl/glsl_types.h
+++ b/src/glsl/glsl_types.h
@@ -550,6 +550,25 @@
V2: add missing 's' to the extension name in error messages
and add decimal place in version string
---
src/glsl/ast_to_hir.cpp | 13 -
src/glsl/glsl_parser.yy | 22 ++
src/glsl/glsl_parser_extras.h | 5 +
3 files changed, 27 insertions(+), 13
Currently only one ir assignment is removed for each var in a single
dead code optimisation pass. This means if a var has more than one
assignment, then it requires all the glsl optimisations to be run again
for each additional assignment to be removed.
Another pass is also required to remove the
From Section 4.1.9 of the GLSL ES 3.10 spec:
Arrays are sized either at compile-time or at run-time.
To size an array at compile-time, either the size
must be specified within the brackets as above or
must be inferred from the type of the initializer.
---
src/glsl/ast.h | 21
Since commit c0cd5b var-data.binding was being used as a replacement
for atomic buffer index, but they don't have to be the same value they
just happen to end up the same when binding is 0.
Now that we store the atomic uniform location in var-data.location
we can use this to lookup the atomic
---
src/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 203ef34..4dae633 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2114,7 +2114,7 @@ validate_binding_qualifier(struct
V2: rebase on SSBO changes
---
src/glsl/ast_to_hir.cpp | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index e29b159..203ef34 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
index bf17fe6..384deef 100644
---
---
src/glsl/nir/nir_types.cpp | 6 ++
src/glsl/nir/nir_types.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp
index 62176f5..06f5b0a 100644
--- a/src/glsl/nir/nir_types.cpp
+++ b/src/glsl/nir/nir_types.cpp
@@ -106,6 +106,12 @@
This marks all counters in an AoA as active.
For AoA all but the innermost array are threated as separate
counters/uniforms. The Nvidia binary also goes further and
finds inactive counters in the AoA, in future we should do
this too, however this gets things working for the time being.
This
This patch is
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
On Wed, Jul 29, 2015 at 9:57 AM, Timothy Arceri t_arc...@yahoo.com.au wrote:
V2: add missing 's' to the extension name in error messages
and add decimal place in version string
---
src/glsl/ast_to_hir.cpp | 13 -
This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
lookup over the server's.) from glx/dri2.
Cc: Eric Anholt e...@anholt.net
Reported-by: Julien Isorce julien.iso...@gmail.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/egl/drivers/dri2/platform_x11.c | 12
On Wed, Jul 29, 2015 at 9:56 AM, Timothy Arceri t_arc...@yahoo.com.au wrote:
These changes are also needed to allow linking of
struct and interface arrays of arrays.
---
src/glsl/link_uniforms.cpp | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git
On Wed, Jul 29, 2015 at 09:54:05AM +0100, Jose Fonseca wrote:
On 23/07/15 17:06, Jose Fonseca wrote:
On 20/07/15 21:39, Jose Fonseca wrote:
On 20/07/15 18:35, Tom Stellard wrote:
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we
I think the reality is that all the drivers you're listing are
GL4.5-capable except nv50 (all but nv50 drive, in part, DX11/DX12
hardware). Use my GT21x list to figure out which exts nv50 will just
never be able to do.
On Wed, Jul 29, 2015 at 9:09 AM, Romain Failliot
romain.faill...@foolstep.com
101 - 155 of 155 matches
Mail list logo
