[Mesa-dev] [PATCH 31/47] nir/opt_dce: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_dce.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/src/compiler/nir/nir_opt_dce.c b/src/compiler/nir/nir_opt_dce.c index 32436c1..f3da307 100644 ---

[Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

Previously, these were functions which took a callback. This meant that the per-block code had to be in a separate function, and all the data that you wanted to pass in had to be a single void *. They walked the control flow tree recursively, doing a depth-first search, and called the callback in

[Mesa-dev] [PATCH 14/47] nir/lower_indirect_derefs: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_indirect_derefs.c | 39 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c index

[Mesa-dev] [PATCH 00/47] nir: rewrite nir_foreach_block() and friends

This is a series based on an idea I had a while ago. It gets one instance of an awful callback-based interface for iterating over things. The other instance, nir_foreach_source(), would be harder to fix since iterating over the sources actually needs state (in order to handle indirect sources).

[Mesa-dev] [PATCH 37/47] nir/phi_builder: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_phi_builder.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_phi_builder.c b/src/compiler/nir/nir_phi_builder.c index a39e360..9a96f84 100644 ---

[Mesa-dev] [PATCH 04/47] nir/inline_functions: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_inline_functions.c | 53 ++--- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/src/compiler/nir/nir_inline_functions.c b/src/compiler/nir/nir_inline_functions.c index

[Mesa-dev] [PATCH 30/47] nir/opt_gcm: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_gcm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_opt_gcm.c b/src/compiler/nir/nir_opt_gcm.c index a8779ce..bfc8763 100644 --- a/src/compiler/nir/nir_opt_gcm.c +++

[Mesa-dev] [PATCH 26/47] nir/lower_var_copies: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_var_copies.c | 34 +++-- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/src/compiler/nir/nir_lower_var_copies.c b/src/compiler/nir/nir_lower_var_copies.c index

[Mesa-dev] [PATCH 07/47] nir/lower_clip: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_clip.c | 50 --- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/src/compiler/nir/nir_lower_clip.c b/src/compiler/nir/nir_lower_clip.c index c711230..09a9022

[Mesa-dev] [PATCH 38/47] nir/opt_peephole_select: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_peephole_select.c | 37 +++--- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/src/compiler/nir/nir_opt_peephole_select.c b/src/compiler/nir/nir_opt_peephole_select.c index

[Mesa-dev] [PATCH 13/47] nir/nir_lower_global_vars: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_global_vars_to_local.c | 38 ++- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/src/compiler/nir/nir_lower_global_vars_to_local.c

[Mesa-dev] [PATCH 23/47] nir/lower_vars_to_ssa: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_vars_to_ssa.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/nir/nir_lower_vars_to_ssa.c index 9f9e454..4967837 100644 ---

[Mesa-dev] [PATCH 47/47] vc4: fixup for new nir_foreach_block()

Signed-off-by: Connor Abbott --- src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 9 - src/gallium/drivers/vc4/vc4_nir_lower_io.c | 20 +--- src/gallium/drivers/vc4/vc4_nir_lower_txf_ms.c | 24 +++-

[Mesa-dev] [PATCH 44/47] nir/algebraic: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_algebraic.py | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index d05564f..ef07505 100644

[Mesa-dev] [PATCH 02/47] nir/dominance: update to new foreach_block

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_dominance.c | 160 +++ 1 file changed, 59 insertions(+), 101 deletions(-) diff --git a/src/compiler/nir/nir_dominance.c b/src/compiler/nir/nir_dominance.c index d95f396..6b5e2c1 100644

[Mesa-dev] [PATCH 46/47] ir3: fixup for new nir_foreach_block()

Signed-off-by: Connor Abbott --- .../drivers/freedreno/ir3/ir3_nir_lower_if_else.c | 51 +- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_nir_lower_if_else.c

[Mesa-dev] [PATCH 34/47] nir/opt_remove_phis: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_remove_phis.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index 6461837..4158ee4 100644 ---

[Mesa-dev] [PATCH 25/47] nir/lower_two_sided_color: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_two_sided_color.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_two_sided_color.c b/src/compiler/nir/nir_lower_two_sided_color.c index c7fb67e..6494b5f

[Mesa-dev] [PATCH 16/47] nir/lower_system_values: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_system_values.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_lower_system_values.c b/src/compiler/nir/nir_lower_system_values.c index

[Mesa-dev] [PATCH 17/47] nir/lower_io: adapt to new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_io.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index d9af8bf..ef6a6ae 100644 --- a/src/compiler/nir/nir_lower_io.c

[Mesa-dev] [PATCH 03/47] nir/from_ssa: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_from_ssa.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c index 82317c2..7b27fda 100644

[Mesa-dev] [PATCH 33/47] nir/opt_undef: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_undef.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_opt_undef.c b/src/compiler/nir/nir_opt_undef.c index 374564d..3ceb120 100644 ---

[Mesa-dev] [PATCH 43/47] nir/validate: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_validate.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index 9f18d1c..af126f8 100644 ---

[Mesa-dev] [PATCH 05/47] nir/liveness: adapt to new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_liveness.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/compiler/nir/nir_liveness.c b/src/compiler/nir/nir_liveness.c index 05f79d7..7952751 100644 ---

[Mesa-dev] [PATCH 18/47] nir/lower_to_source_mods: fixup for new foreeach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_to_source_mods.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_lower_to_source_mods.c b/src/compiler/nir/nir_lower_to_source_mods.c index 6c4e1f0..eafab4e

[Mesa-dev] [PATCH 35/47] nir/opt_cp: use nir_block_get_following_if()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_copy_propagate.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_propagate.c b/src/compiler/nir/nir_opt_copy_propagate.c index d99f78d..c1a84c2 100644

[Mesa-dev] [PATCH 29/47] nir/opt_constant_folding: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_constant_folding.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_opt_constant_folding.c b/src/compiler/nir/nir_opt_constant_folding.c index

[Mesa-dev] [PATCH 11/47] nir/lower_load_const: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_load_const_to_scalar.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/compiler/nir/nir_lower_load_const_to_scalar.c b/src/compiler/nir/nir_lower_load_const_to_scalar.c

[Mesa-dev] [PATCH 27/47] nir/normalize_cubemap_coords: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_normalize_cubemap_coords.c | 26 +++-- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_normalize_cubemap_coords.c b/src/compiler/nir/nir_normalize_cubemap_coords.c

[Mesa-dev] [PATCH 10/47] nir/lower_locals_to_regs: fixup for new foreach_block

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_locals_to_regs.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_locals_to_regs.c b/src/compiler/nir/nir_lower_locals_to_regs.c index 0438802..270e9fe 100644

[Mesa-dev] [PATCH 36/47] nir/opt_cp: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_copy_propagate.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_propagate.c b/src/compiler/nir/nir_opt_copy_propagate.c index

[Mesa-dev] [PATCH 12/47] nir/lower_atomics: fixup for new foreach_block(

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_atomics.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/src/compiler/nir/nir_lower_atomics.c b/src/compiler/nir/nir_lower_atomics.c index

[Mesa-dev] [PATCH 08/47] nir/nir: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir.c | 42 ++ 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index ea8aa88..95d644a 100644 --- a/src/compiler/nir/nir.c

[Mesa-dev] [PATCH 15/47] nir/lower_phis_to_scalar: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_phis_to_scalar.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_phis_to_scalar.c b/src/compiler/nir/nir_lower_phis_to_scalar.c index 026c866..38f3dda 100644

[Mesa-dev] [PATCH 06/47] nir/lower_alu_to_scalar: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_alu_to_scalar.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/compiler/nir/nir_lower_alu_to_scalar.c b/src/compiler/nir/nir_lower_alu_to_scalar.c index e8ba640..f8e94c5

[Mesa-dev] [PATCH 19/47] nir/lower_outputs_to_temporaries: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- .../nir/nir_lower_outputs_to_temporaries.c | 28 ++ 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_lower_outputs_to_temporaries.c

[Mesa-dev] [PATCH 20/47] nir/lower_tex: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_tex.c | 58 +++- 1 file changed, 28 insertions(+), 30 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index 4999603..7eebd6b 100644

[Mesa-dev] [PATCH 24/47] nir/move_vec_src_uses_to_dest: fixup for new foreach_block()

Signed-off-by: Connor Abbott --- src/compiler/nir/nir_move_vec_src_uses_to_dest.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_move_vec_src_uses_to_dest.c b/src/compiler/nir/nir_move_vec_src_uses_to_dest.c index

Re: [Mesa-dev] [PATCH 02/13] nir/builder: Add bit_size info to nir_build_imm()

On 12/04/16 17:24, Jason Ekstrand wrote: > On Apr 12, 2016 1:06 AM, "Samuel Iglesias Gonsálvez" > wrote: >> >> Signed-off-by: Samuel Iglesias Gonsálvez >> --- >> src/compiler/nir/nir_builder.h | 15 --- >>

Re: [Mesa-dev] [PATCH 1/2] scons: Allow building with Address Sanitizer.

Am 12.04.2016 um 18:03 schrieb Jose Fonseca: > libasan is never linked to shared objects (which doesn't go well with > -z,defs). It must either be linked to the main executable, or (more > practically for OpenGL drivers) be pre-loaded via LD_PRELOAD. > > Otherwise works. > > I didn't find

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On 04/12/2016 09:39 AM, Marek Olšák wrote: > On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: >> On 04/12/2016 05:21 AM, Marek Olšák wrote: >>> On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: radeon and r200 have a driconf option that is

Re: [Mesa-dev] [PATCH 2/2] softpipe: Free tgsi.image elements on context destruction.

Am 12.04.2016 um 18:03 schrieb Jose Fonseca: > Courtesy of address sanitizer. > --- > src/gallium/drivers/softpipe/sp_context.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/softpipe/sp_context.c > b/src/gallium/drivers/softpipe/sp_context.c > index

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On Tue, Apr 12, 2016 at 11:39 AM, Jason Ekstrand wrote: > > On Apr 11, 2016 9:49 AM, "Ben Widawsky" wrote: >> >> This will fix the spurious error message: "Failed to query GPU >> properties." >> that was unintentionally added in cc01b63d730. >> >> This

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On 04/12/2016 05:21 AM, Marek Olšák wrote: > On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: >> radeon and r200 have a driconf option that is similar to this. It sets >> a default initial max anisotropy value. Maybe that would be better? > > If driconf didn't copy

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 18:26 schrieb Bas Nieuwenhuizen: > On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger > wrote: >> Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: >>> On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger >>> wrote: Am 12.04.2016 um

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

I'm not sure I'm so comfortable with this. For one, this is the sort of thing the backend can (and should) do. Why should be be adding stuff at the NIR level to help the backend's copy propagation pass? And perhaps more importantly, why should we be adding stuff at the NIR level to workaround the

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On 04/11/2016 09:49 AM, Ben Widawsky wrote: > This will fix the spurious error message: "Failed to query GPU properties." > that was unintentionally added in cc01b63d730. > > This patch changes the function to return an int so that the caller is able to > do stuff based on the return value. > >

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 --- Comment #6 from xdshot9...@gmail.com --- It also crashes on Intel graphics with the latest mesa from git. The patch fixes this problem though. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

Re: [Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 12, 2016 at 7:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This was triggered by > dEQP-GLES3.functional.vertex_array_objects.all_attributes > > Cc: "11.1 11.2"

[Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

From: Nicolai Hähnle This was triggered by dEQP-GLES3.functional.vertex_array_objects.all_attributes Cc: "11.1 11.2" --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

Looks good to me too. Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Jose Fonseca Sent: Tuesday, April 12, 2016 9:24 AM To: Brian Paul;

[Mesa-dev] [PATCH] build: Fix LLVM shared library detection on systems with libLLVM.so.

Arch Linux ships libLLVM.so.3.7.1 rather than libLLVM-3.7.1.so; Mesa's configure script failed to find LLVM shared libraries in this case. I believe they build LLVM with CMake, but there is still only one .so file. Signed-off-by: Kenneth Graunke --- configure.ac | 6

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

2016-04-12 19:27 GMT+02:00 Ian Romanick : > On 04/12/2016 09:39 AM, Marek Olšák wrote: >> On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: >>> On 04/12/2016 05:21 AM, Marek Olšák wrote: On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger wrote: > Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: >> On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger >> wrote: >>> Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: Signed-off-by: Bas

Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

On 12/04/16 16:15, Brian Paul wrote: If the glDrawPixels size changed, we leaked the previously cached texture, if there was one. This patch fixes the reference counting, adds a refcount assertion check, and better handles potential malloc() failures. Tested with a modified version of the

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: > On 04/12/2016 05:21 AM, Marek Olšák wrote: >> On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: >>> radeon and r200 have a driconf option that is similar to this. It sets >>> a default initial

[Mesa-dev] [PATCH] radeon/uvd: fix tonga feedback buffer size

This only applies to tonga Signed-off-by: Leo Liu Reviewed-by: Christian König Cc: "11.1 11.2" --- src/gallium/drivers/radeon/radeon_uvd.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [PATCH] xlib: fix memory leak on Display close

On Tue, Apr 12, 2016 at 11:53 AM, John Sheu wrote: > The XMesaVisual instances freed in the visuals table on display close > are being freed with a free() call, instead of XMesaDestroyVisual(), > causing a memory leak. > > Signed-off-by: John Sheu > --- >

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On Tue, Apr 12, 2016 at 7:59 PM, Ernst Sjöstrand wrote: > 2016-04-12 19:27 GMT+02:00 Ian Romanick : >> On 04/12/2016 09:39 AM, Marek Olšák wrote: >>> On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: On 04/12/2016 05:21 AM,

[Mesa-dev] (no subject)

Thanks for the heads-up. I only found one other place where a similar leak occurs -- and in the case of xm_api.c, I figure that XMesaDestroyVisual() is an "client-facing" call, so in the interest of maintaining layering I've just made the appropriate free() call.

Re: [Mesa-dev] [PATCH] xlib: fix memory leak on Display close

On 04/12/2016 12:53 PM, John Sheu wrote: The XMesaVisual instances freed in the visuals table on display close are being freed with a free() call, instead of XMesaDestroyVisual(), causing a memory leak. Signed-off-by: John Sheu --- src/mesa/drivers/x11/fakeglx.c | 2 +-

[Mesa-dev] [PATCH] mesa/st: Replace GLvoid with void

GLvoid was used before in OpenGL but it has changed to just using void. All GLvoids in mesa's state tracker has been changed to void in this patch. Tested this with piglit and no problems were found. No compiler warnings also. I also don't have push acces to the repository so someone that is

Re: [Mesa-dev] Newbie task to get started

On 2016-04-12 11:00, Timothy Arceri wrote: On Sun, 2016-04-10 at 21:45 +0200, Jakob Sinclair wrote: Hi! My name is Jakob Sinclair and I would like to start contributing to  mesa development. I was wondering if anyone has any easy tasks that I as  a newbie could start working on. I tried looking

Re: [Mesa-dev] [PATCH] swr: handle pci cap requests

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: handle pci

Re: [Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

Reviewed-by: Marek Olšák Marek On Tue, Apr 12, 2016 at 7:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This was triggered by > dEQP-GLES3.functional.vertex_array_objects.all_attributes > > Cc: "11.1 11.2"

Re: [Mesa-dev] [PATCH] mesa/st: Replace GLvoid with void

On 04/12/2016 12:48 PM, Jakob Sinclair wrote: GLvoid was used before in OpenGL but it has changed to just using void. All GLvoids in mesa's state tracker has been changed to void in this patch. Tested this with piglit and no problems were found. No compiler warnings also. I also don't have push

[Mesa-dev] [PATCH 2/2] meta: Don't botch color masks when changing drawbuffers.

Color clears should respect each drawbuffer's color mask state. Previously, we tried to leave the color mask untouched. However, _mesa_meta_drawbuffers_from_bitfield() ended up rebinding all the color drawbuffers in a different order, so we ended up pairing drawbuffers with the wrong color mask

[Mesa-dev] [PATCH 1/2] meta: Don't smash ColorMask when using MESA_META_COLOR_MASK save bit.

This allows meta operations to inspect the existing color mask, and then do their own smashing. BlitFramebuffer and Clear already override the color mask, so this was also redundant. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/common/meta.c | 7

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 18:45 schrieb Roland Scheidegger: > Am 12.04.2016 um 18:26 schrieb Bas Nieuwenhuizen: >> On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger >> wrote: >>> Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: On Tue, Apr 12, 2016 at 3:56 PM, Roland

Re: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: support

[Mesa-dev] [PATCH] xlib: fix memory leak on Display close

The XMesaVisual instances freed in the visuals table on display close are being freed with a free() call, instead of XMesaDestroyVisual(), causing a memory leak. Signed-off-by: John Sheu --- src/mesa/drivers/x11/fakeglx.c | 2 +- src/mesa/drivers/x11/xm_api.c | 1 + 2 files

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

On Apr 12, 2016 10:16 AM, "Connor Abbott" wrote: > > I'm not sure I'm so comfortable with this. For one, this is the sort > of thing the backend can (and should) do. Why should be be adding > stuff at the NIR level to help the backend's copy propagation pass? > And perhaps

[Mesa-dev] [Bug 94909] [llvmpipe] piglit fs-roundEven-float regression

https://bugs.freedesktop.org/show_bug.cgi?id=94909 Bug ID: 94909 Summary: [llvmpipe] piglit fs-roundEven-float regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 4/4] glsl/linker: Recurse on struct fields when adding shader variables

On Tue, Apr 12, 2016 at 3:20 PM, Matt Turner wrote: > On Tue, Apr 12, 2016 at 2:24 PM, Kristian Høgsberg wrote: >> From: Kristian Høgsberg Kristensen >> >> ARB_program_interface_query requires that we add struct fields >>

[Mesa-dev] [RFC 00/24] nvc0: ARB_shader_image_load_store/size on GK104

Hi, This series adds support for ARB_shader_image_load_store (GL 4.2) and ARB_shader_image_size (GL 4.3) on GK104 and will expose OpenGL 4.2 on this chipset. Other chipsets like Fermi, Kepler2 (ie. GK110) and Maxwell will be implemented later. Actually, I already have a series for Fermi (based

[Mesa-dev] [RFC 08/24] nvc0: enable RGB10_A2UI format on GK104

No clue why this was not enabled by default before, maybe because the SULDP conversion was wrong. Anyway, this helps in fixing all rgb10_a2ui piglit tests. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 6 +++--- 1 file changed, 3

[Mesa-dev] [RFC 03/24] nvc0: bind images on compute shaders for Kepler

Old surfaces validation code will be removed once images are completely done for Fermi/Kepler, that explains why I only disable it for now. set_surface_info() which sticks surfaces information into the driver constant buffer needs to be updated because now we are dealing with pipe_image_view

[Mesa-dev] [RFC 01/24] nvc0: add preliminary support for images

This implements set_shader_images() and resource invalidation for images. As OpenGL requires at least 8 images, we are going to expose this minimum value even if this might be raised for Kepler, but this limit is mainly for Fermi because the hardware only accepts 8 images. Based on original patch

Re: [Mesa-dev] [PATCH 1/4] glsl/linker: Add add_shader_variable() helper

On Tuesday, April 12, 2016 2:24:30 PM PDT Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > This consolidates the combination of create_shader_variable() and > add_program_resource() into a new helper function. No functional > difference, but

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On Tue, Apr 12, 2016 at 10:10:35AM +0200, Alejandro Piñeiro wrote: > > > On 11/04/16 18:49, Ben Widawsky wrote: > > This will fix the spurious error message: "Failed to query GPU properties." > > that was unintentionally added in cc01b63d730. > > > > This patch changes the function to return an

Re: [Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

On Apr 12, 2016 3:10 PM, "Mark Janes" wrote: > > Fixes intermittent Vulkan CTS failures within the test groups: > dEQP-VK.api.object_management.multithreaded_per_thread_device > dEQP-VK.api.object_management.multithreaded_per_thread_resources >

Re: [Mesa-dev] [PATCH] build: Fix LLVM shared library detection on systems with libLLVM.so.

On 12.04.2016 12:58, Kenneth Graunke wrote: Arch Linux ships libLLVM.so.3.7.1 rather than libLLVM-3.7.1.so; Mesa's configure script failed to find LLVM shared libraries in this case. I believe they build LLVM with CMake, but there is still only one .so file. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 1/2] meta: Don't smash ColorMask when using MESA_META_COLOR_MASK save bit.

On Tue, Apr 12, 2016 at 4:24 PM, Kenneth Graunke wrote: > On Tuesday, April 12, 2016 4:07:30 PM PDT Jason Ekstrand wrote: > > On Apr 12, 2016 1:41 PM, "Kenneth Graunke" > wrote: > > > > > > This allows meta operations to inspect the existing color

[Mesa-dev] [Bug 94907] codegen/nv50_ir_ra.cpp:1330:29: error: ‘isinf’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=94907 --- Comment #1 from Ilia Mirkin --- Should be fixed by https://patchwork.freedesktop.org/patch/79115/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] glsl: Don't copy propagate or tree graft precise values.

On Apr 12, 2016 2:08 PM, "Kenneth Graunke" wrote: > > This is kind of a hack. We currently track precise requirements > by decorating ir_variables. Propagating or grafting the RHS of an > assignment to a precise value into some other expression tree can > lose those

Re: [Mesa-dev] [PATCH 1/2] meta: Don't smash ColorMask when using MESA_META_COLOR_MASK save bit.

On Tuesday, April 12, 2016 4:07:30 PM PDT Jason Ekstrand wrote: > On Apr 12, 2016 1:41 PM, "Kenneth Graunke" wrote: > > > > This allows meta operations to inspect the existing color mask, and > > then do their own smashing. > > I don't like this. Part of the point of meta

Re: [Mesa-dev] [PATCH v3] va: check null context in vlVaDestroyContext

Reviewed-by: Julien Isorce I'll push it shortly. Thx On 12 April 2016 at 23:24, Iurie Salomov wrote: > From: iurie salomov > > Signed-off-by: Iurie Salomov > --- > src/gallium/state_trackers/va/context.c | 4 > 1 file changed, 4

Re: [Mesa-dev] [PATCH 4/4] glsl/linker: Recurse on struct fields when adding shader variables

On Tue, Apr 12, 2016 at 2:24 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > ARB_program_interface_query requires that we add struct fields > recursively down to basic types. > > Fixes 52 struct test cases in

[Mesa-dev] [PATCH 2/2] i965/tex_image: Flush certain subnormal ASTC channel values

From: Nanley Chery When uploading a linear, void-extent, ASTC LDR block on Skylake, we are required to flush to zero the UNORM16 channel values that would be denormalized. This is specifically required for the values: 1, 2, and 3. Fixes the 14 failing tests in:

[Mesa-dev] [PATCH 1/2] mesa/texstore: Use Driver.CompressedTexSubImage in the default CompressedTexImage

From: Nanley Chery Enable drivers to use their own implementation of this method instead of the mesa default. Since the drivers that currently overwrite dd_function_table::CompressedTexSubImage also overwrite ::CompressedTexImage, there should be no behavioral change.

Re: [Mesa-dev] [PATCH 4/4] glsl/linker: Recurse on struct fields when adding shader variables

On Tue, Apr 12, 2016 at 3:27 PM, Kristian Høgsberg wrote: > On Tue, Apr 12, 2016 at 3:20 PM, Matt Turner wrote: >> On Tue, Apr 12, 2016 at 2:24 PM, Kristian Høgsberg >> wrote: >>> From: Kristian Høgsberg Kristensen

Re: [Mesa-dev] [PATCH] i965/tiled_memcpy: Fix rgba8_copy_16_aligned_dst() typo

Oh, whoops. Thanks for catching that! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Rename "vertex_input_slots" -> "is_vertex_input"

On Tue, 2016-04-12 at 15:28 -0700, Matt Turner wrote: > vertex_input_slots would be an appropriate name for an integer, but > not > a bool. > > Also remove a cond ? true : false from a count_attribute_slots() call > site, noticed during the rename. Thats much better. Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 1/4] xlib: fix memory leak in glXChooseVisual/glXGetVisualFromFBConfig

Whoops. Patch updated on a different thread. -John Sheu On Sun, Apr 3, 2016 at 11:33 PM, Alejandro Piñeiro wrote: > On 04/04/16 08:11, Alejandro Piñeiro wrote: >> On 02/04/16 01:52, John Sheu wrote: >>> XMesaVisual.vishandle is being unconditionally overwritten every time

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

While the whole driconf thing is certainly worth addressing, in the meantime, this patch is Reviewed-by: Nicolai Hähnle On 11.04.2016 13:48, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c| 10

Re: [Mesa-dev] [PATCH 2/2] meta: Don't botch color masks when changing drawbuffers.

On Apr 12, 2016 1:42 PM, "Kenneth Graunke" wrote: > > Color clears should respect each drawbuffer's color mask state. > > Previously, we tried to leave the color mask untouched. However, > _mesa_meta_drawbuffers_from_bitfield() ended up rebinding all the > color

[Mesa-dev] [PATCH] mesa: Change an error code in glSamplerParameterI[iu]v().

This is supposed to be INVALID_OPERATION in ES. We already did this for the fv/iv variants, but not Iiv/Iuv, which are new in ES 3.2 (or extensions). Fixes: ES31-CTS.texture_border_clamp.samplerparameteri_non_gen_sampler_error Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 2/4] glsl/linker: Pass absolute location to add_shader_variable()

From: Kristian Høgsberg Kristensen This lets us pass in the absolution location of a variable instead of computing it in add_shader_variable() based on variable location and bias. This is in preparation for recursing into struct variables. Signed-off-by:

[Mesa-dev] [PATCH 4/4] glsl/linker: Recurse on struct fields when adding shader variables

From: Kristian Høgsberg Kristensen ARB_program_interface_query requires that we add struct fields recursively down to basic types. Fixes 52 struct test cases in dEQP-GLES31.functional.program_interface_query.* Signed-off-by: Kristian Høgsberg Kristensen

[Mesa-dev] [PATCH 3/4] glsl/linker: Pass name and type through to create_shader_variable()

From: Kristian Høgsberg Kristensen No functional change here, but this now lets us recurse throught structs in add_shader_variable(). Signed-off-by: Kristian Høgsberg Kristensen --- src/compiler/glsl/linker.cpp | 21

  1   2   3   >