Re: [Mesa-dev] [PATCH 3/3] i965/fs: Don't consider the stencil output to be a color output.

2016-08-23 Thread Kenneth Graunke
On Monday, August 22, 2016 6:59:45 PM PDT Francisco Jerez wrote: > This would cause gl_FragStencilRef to be counted as a color output > incorrectly during the precompile phase, which leads to unnecessary > recompilation on master and could trigger an assertion failure in >

[Mesa-dev] [PATCH 2/3] intel/isl: Pass the dim_layout into choose_alignment_el

2016-08-23 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: Chad Versace --- src/intel/isl/isl.c | 23 --- src/intel/isl/isl_gen4.c | 1 + src/intel/isl/isl_gen4.h | 1 + src/intel/isl/isl_gen6.c | 1 + src/intel/isl/isl_gen6.h | 1 +

[Mesa-dev] [PATCH 3/3] intel/isl/gen9: Only use the magic 1D alignment for GEN9_2D surfaces

2016-08-23 Thread Jason Ekstrand
If the surface has a layout of GEN4_2D then we need to compute a normal 2D alignment and not use the bogus 1D one. Signed-off-by: Jason Ekstrand Cc: Chad Versace --- src/intel/isl/isl_gen9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 1/3] intel/isl: Use DIM_LAYOUT_GEN4_2D for tiled 1-D surfaces on SKL

2016-08-23 Thread Jason Ekstrand
The Sky Lake 1D layout is only used if the surface is linear. For tiled surfaces such as depth and stenil the old gen4 2D layout is used. Signed-off-by: Jason Ekstrand Cc: Chad Versace --- src/intel/isl/isl.c | 28 +++- 1 file

Re: [Mesa-dev] [PATCH v2 0/2] *** Aubinator tool for Intel Gen platforms ***

2016-08-23 Thread Kenneth Graunke
On Friday, August 19, 2016 12:13:23 PM PDT Sirisha Gandikota wrote: > This is a patch series for adding the aubinator tool to the codebase. Hi Sirisha, I've pushed your patches to import the tool. I also pushed a third commit that fixes some minor style nitpicks - I figured it would be easier

[Mesa-dev] [PATCH] gallium/ttn: Remove duplicated TGSI_OPCODE_DP2A initialization

2016-08-23 Thread Rhys Kidd
Duplicate line is currently on 1535. Identified by Clang, when run through Eric Anholt's Travis harness. Signed-off-by: Rhys Kidd --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c

[Mesa-dev] [Bug 97456] Detect wrong driver on AMD r4 graphic gpu

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97456 --- Comment #1 from Michel Dänzer --- Please attach the full output containing the information you think is incorrect. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 97455] Detect wrong driver for AMD r3 graphic

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97455 BO-YI TSAI changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 97456] Detect wrong driver on AMD r4 graphic gpu

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97456 BO-YI TSAI changed: What|Removed |Added Hardware|Other |x86-64 (AMD64)

[Mesa-dev] [Bug 97456] Detect wrong driver on AMD r4 graphic gpu

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97456 Bug ID: 97456 Summary: Detect wrong driver on AMD r4 graphic gpu Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 97455] Detect wrong driver for AMD r3 graphic

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97455 Bug ID: 97455 Summary: Detect wrong driver for AMD r3 graphic Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 5:41 PM, Ilia Mirkin wrote: > On Fri, Aug 19, 2016 at 7:44 PM, Lionel Landwerlin > wrote: > > A few inline asserts in anv assume alignments are power of 2, but with > > formats like R8G8B8 we have odd alignments. > > > >

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 --- Comment #3 from Michel Dänzer --- Assuming you can reproduce the problem with Mesa Git + LLVM 3.9/3.8, you can stick to the latter for bisecting. If you run into any clang related issues, you can build Mesa with

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #27 from Michel Dänzer --- (In reply to Kai from comment #26) > (In reply to Alex Deucher from comment #25) > > Is anyone still having issues with vblank_mode=0? > > With or without Michel's patch >

Re: [Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-23 Thread Ilia Mirkin
On Fri, Aug 19, 2016 at 7:44 PM, Lionel Landwerlin wrote: > A few inline asserts in anv assume alignments are power of 2, but with > formats like R8G8B8 we have odd alignments. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/isl/isl.c

Re: [Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-23 Thread Jason Ekstrand
This seems perfectly reasonable. I don't think rounding up to a power of two can hurt. Reviewed-by: Jason Ekstrand On Mon, Aug 22, 2016 at 10:46 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > The one I actually wanted to Cc you on :) > > > On 20/08/16

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-23 Thread Roland Scheidegger
Am 22.08.2016 um 23:13 schrieb Marek Olšák: > On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: >> On 23 August 2016 at 06:14, Marek Olšák wrote: >>> On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: On 08/22/2016 08:38 AM, Marek

Re: [Mesa-dev] [PATCH 2/3] gallium: add a pipe_context parameter to resource_get_handle

2016-08-23 Thread Roland Scheidegger
I admit I'm not familiar with the interopability stuff. But how is the coherency stuff handled after you get the handle? Does this also work if you've got multiple users of resource_get_handle? Roland Am 22.08.2016 um 16:06 schrieb Marek Olšák: > From: Marek Olšák > >

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-23 Thread Roland Scheidegger
I don't really like this - I'd like to keep d3d10 semantics unless there's a good reason to change it. And I don't see such a reason - even with variable indexing you cannot use mixed int/uint/float textures since texturing results with using the wrong type of sampler are undefined anyway. Hence

Re: [Mesa-dev] [PATCH] isl/formats: Integer formats are not filterable

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 2:18 PM, Nanley Chery wrote: > On Tue, Aug 23, 2016 at 02:13:26PM -0700, Jason Ekstrand wrote: > > In ca2a8e56285, we updated the format table to add more formats (most of > > which are new on SKL) but accidentally marked some integer formats as > >

Re: [Mesa-dev] [PATCH 17/31] i965/blorp: Move the guts of brw_blorp_exec into genX_blorp_exec.c

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 8:50 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Aug 19, 2016 at 09:55:54AM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/blorp.c | 66 > - > > src/mesa/drivers/dri/i965/genX_blorp_exec.c

Re: [Mesa-dev] [PATCH 11/31] i965/blorp/genX: Add a blorp_surface_reloc helper

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 7:06 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Aug 19, 2016 at 09:55:48AM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 38 > - > > 1 file changed, 21 insertions(+), 17

Re: [Mesa-dev] [PATCH 18/31] i965/blorp: Add an "exec" function pointer to blorp_context

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 9:00 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Aug 19, 2016 at 09:55:55AM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/blorp.c | 27 > +-- > > src/mesa/drivers/dri/i965/blorp.h |

Re: [Mesa-dev] [PATCH v2] i965/vec4: make offset() operate in terms of channels instead of full registers

2016-08-23 Thread Michael Schellenberger Costa
Hi Iago, given that the idea here was to unify vec4 and fs you might want to adopt the names/function types accordingly. In brw_ir_fs.h there is byte_offset that returns a fs_reg while you have void add_byte_offset. --Michael Am 23.08.2016 um 10:24 schrieb Iago Toral Quiroga: > This will make

Re: [Mesa-dev] [PATCH 15/31] i965/blorp/exec: Refactor to use blorp_context and a void *batch

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 8:33 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Aug 19, 2016 at 09:55:52AM -0700, Jason Ekstrand wrote: > > This gets rid of brw_context throughout the core of the state setup code. > > --- > > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 332 >

Re: [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test

2016-08-23 Thread Eric Engestrom
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > This series implements the sw_sync test and the lib/sw_sync helper functions > for said test. > > Gustavo Padovans sw_sync series was just de-staged in >

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 22:56, Nicholas Miell wrote: > On 08/23/2016 02:45 PM, Emil Velikov wrote: >> >> On 23 August 2016 at 19:05, Nicholas Miell wrote: >>> >>> On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm

Re: [Mesa-dev] [PATCH v1 11/13] tests/sw_sync: Add subtest test_sync_random_merge

2016-08-23 Thread Eric Engestrom
On Tue, Aug 23, 2016 at 01:56:13PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > This subtest verifies that creating many timelines and merging random fences > from each timeline with eachother results in merged fences that are fully > functional. >

Re: [Mesa-dev] [PATCH] i965: report bound buffer size not underlying buffer size for image size (v2)

2016-08-23 Thread Dave Airlie
On 23 August 2016 at 19:28, Antía Puentes wrote: > Hi Dave, > > The "GL44-CTS.shader_image_size.advanced-nonMS-fs-int" test fails for > me with current master (which contains this patch), I have tested it > both in a Broadwell and a Skylake machine. > > I recall that you sent

Re: [Mesa-dev] [PATCH v1 02/13] tests/sw_sync: Add sw_sync test

2016-08-23 Thread Eric Engestrom
On Tue, Aug 23, 2016 at 01:56:04PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Add initial tests for sw_sync. > > Signed-off-by: Gustavo Padovan > Signed-off-by: Robert Foss > --- >

Re: [Mesa-dev] [PATCH v1 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-08-23 Thread Eric Engestrom
On Tue, Aug 23, 2016 at 01:56:03PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Base functions to help testing the Sync File Framework (explicit fencing > mechanism ported from Android). > These functions allow you to create, use and destroy

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Nicholas Miell
On 08/23/2016 02:45 PM, Emil Velikov wrote: On 23 August 2016 at 19:05, Nicholas Miell wrote: On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm not sure the above will be enough. Since the user is free to place json files in $HOME/.local

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 19:05, Nicholas Miell wrote: > On 08/23/2016 02:07 AM, Emil Velikov wrote: >> >> Skimmed through the discussion and I'm not sure the above will be enough. >> >> Since the user is free to place json files in $HOME/.local ... this >> implies that they may

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-08-23 Thread Eric Anholt
Michel Dänzer writes: > On 20/08/16 04:42 AM, Eric Anholt wrote: >> Michel Dänzer writes: >> >>> From: Michel Dänzer >>> >>> Always use 3 buffers when flipping. With only 2 buffers, we have to wait >>> for a flip to complete

Re: [Mesa-dev] [PATCH] isl/formats: Integer formats are not filterable

2016-08-23 Thread Nanley Chery
On Tue, Aug 23, 2016 at 02:13:26PM -0700, Jason Ekstrand wrote: > In ca2a8e56285, we updated the format table to add more formats (most of > which are new on SKL) but accidentally marked some integer formats as > filterable. You can't filter an integer format. > > Signed-off-by: Jason Ekstrand

[Mesa-dev] [PATCH] isl/formats: Integer formats are not filterable

2016-08-23 Thread Jason Ekstrand
In ca2a8e56285, we updated the format table to add more formats (most of which are new on SKL) but accidentally marked some integer formats as filterable. You can't filter an integer format. Signed-off-by: Jason Ekstrand --- src/intel/isl/isl_format.c | 16

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

2016-08-23 Thread Thomas Helland
12. aug. 2016 04.02 skrev "Timothy Arceri" : > > On Thu, 2016-08-11 at 20:54 +0200, Thomas Helland wrote: > > 2016-08-11 18:19 GMT+02:00 Ian Romanick : > > > > > > ping > > > > > > On 07/19/2016 10:37 PM, Ian Romanick wrote: > > > > > > > > From:

Re: [Mesa-dev] [PATCH] glsl: Mark tessellation qualifier maps static const.

2016-08-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Ah so that's why they weren't static const in my patch... coz I copied it :) Nice sleuth work. On Tue, Aug 23, 2016 at 4:39 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- >

[Mesa-dev] [PATCH] glsl: Mark tessellation qualifier maps static const.

2016-08-23 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_parser.yy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glsl_parser.yy b/src/compiler/glsl/glsl_parser.yy index 4f4a83c..5b65861 100644 ---

Re: [Mesa-dev] [PATCH 1/4] i965: move subreg_offset to backend_reg

2016-08-23 Thread Francisco Jerez
Iago Toral Quiroga writes: > So we can access it in the vec4 backend to handle byte offsets into > registers. This change has deep implications in the meaning of the vec4 register objects because the representation of register offsets is now split between 'reg_offset' and

[Mesa-dev] [Bug 95190] Tomb Raider with PostProcessing enable and Depth of Field set to Ultra has white stuff in the foreground

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95190 Karol Herbst changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] vl/rbsp: fix another three byte not detected

2016-08-23 Thread Christian König
Am 22.08.2016 um 18:27 schrieb Leo Liu: This happens when three byte "00 00 03" is partly loaded to vlc->buffer, and left bytes like "00 03" or "03" in the data, so that it will not be detected by three byte emulation check. Signed-off-by: Leo Liu I currently don't have the

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-23 Thread Francisco Jerez
Francisco Jerez writes: > Ilia Mirkin writes: > >> On Tue, Aug 23, 2016 at 12:18 AM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> On Tue, Aug 23, 2016 at 12:05 AM, Francisco Jerez

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-23 Thread Francisco Jerez
Ilia Mirkin writes: > On Tue, Aug 23, 2016 at 12:18 AM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> On Tue, Aug 23, 2016 at 12:05 AM, Francisco Jerez >>> wrote: Ilia Mirkin

[Mesa-dev] [PATCH] i965/blorp: Add a format parameter to blorp_fast_clear

2016-08-23 Thread Jason Ekstrand
We were inferring the format from the surface but that doesn't always work as the surface format is the texture format and we want the render format (which may be different on i965). Signed-off-by: Jason Ekstrand Cc: Topi Pohjolainen ---

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Nicholas Miell
On 08/23/2016 02:07 AM, Emil Velikov wrote: Skimmed through the discussion and I'm not sure the above will be enough. Since the user is free to place json files in $HOME/.local ... this implies that they may _not_ have access to /usr or /etc. Thus as they install the file (to say $HOME/foo/lib)

[Mesa-dev] [PATCH v1 04/13] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-08-23 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index

[Mesa-dev] [PATCH v1 03/13] tests/sw_sync: Add subtest test_alloc_fence

2016-08-23 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss --- tests/sw_sync.c | 16 1 file changed, 16 insertions(+) diff --git

[Mesa-dev] [PATCH v1 13/13] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer

2016-08-23 Thread robert . foss
From: Robert Foss This subtest runs a single consumer thread and multiple producer thread that are synchronized using multiple timelines. Signed-off-by: Robert Foss --- tests/sw_sync.c | 139

[Mesa-dev] [PATCH v1 11/13] tests/sw_sync: Add subtest test_sync_random_merge

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss --- tests/sw_sync.c | 73

[Mesa-dev] [PATCH v1 07/13] tests/sw_sync: Add subtest test_sync_merge

2016-08-23 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss --- tests/sw_sync.c | 67 + 1 file

[Mesa-dev] [PATCH v1 09/13] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss --- tests/sw_sync.c | 103 1 file changed, 103 insertions(+)

[Mesa-dev] [PATCH v1 10/13] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-08-23 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained.

[Mesa-dev] [PATCH v1 02/13] tests/sw_sync: Add sw_sync test

2016-08-23 Thread robert . foss
From: Robert Foss Add initial tests for sw_sync. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/sw_sync.c | 13 ++--- lib/sw_sync.h | 2 +-

[Mesa-dev] [PATCH v1 08/13] tests/sw_sync: Add subtest test_sync_merge_same

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies merging a fence with itself does not fail. Signed-off-by: Robert Foss --- tests/sw_sync.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/sw_sync.c

[Mesa-dev] [PATCH v1 06/13] tests/sw_sync: Add subtest test_sync_wait

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies that waiting on fences works properly. Signed-off-by: Robert Foss --- tests/sw_sync.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/sw_sync.c

[Mesa-dev] [PATCH v1 12/13] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss --- tests/sw_sync.c | 66 + 1

[Mesa-dev] [PATCH v1 05/13] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-08-23 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss --- tests/sw_sync.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/sw_sync.c

[Mesa-dev] [PATCH v1 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-08-23 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Gustavo Padovan

[Mesa-dev] [PATCH v1 00/13] Implement sw_sync test

2016-08-23 Thread robert . foss
From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. Gustavo Padovans sw_sync series was just de-staged in gregkh-staging/staging-next [1], and this test is targeted at verifying the functionality implemented in

Re: [Mesa-dev] [PATCH v2 12/16] glsl: Add a lowering pass to handle advanced blending modes.

2016-08-23 Thread Francisco Jerez
Kenneth Graunke writes: > On Monday, August 22, 2016 5:50:49 PM PDT Francisco Jerez wrote: >> Kenneth Graunke writes: >> >> > Many GPUs cannot handle GL_KHR_blend_equation_advanced natively, and >> > need to emulate it in the pixel shader. This

Re: [Mesa-dev] [PATCH v2] i965: don't fail to shift height images for levels.

2016-08-23 Thread Jason Ekstrand
On Aug 23, 2016 10:10 AM, "Ilia Mirkin" wrote: > > On Tue, Aug 23, 2016 at 12:34 PM, Jason Ekstrand wrote: > > On Tue, Aug 23, 2016 at 9:28 AM, Jason Ekstrand > > wrote: > >> > >> This smells like fish... I'm going to have a

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-23 Thread Marek Olšák
On Tue, Aug 23, 2016 at 4:46 PM, Kai Wasserbäch wrote: > Hey Dave, > Dave Airlie wrote on 23.08.2016 03:28: >> From: Dave Airlie >> >> This should be all that is required for cull distances to work >> on radeonsi. > > in case this is indeed enough

[Mesa-dev] [Bug 95190] Tomb Raider with PostProcessing enable and Depth of Field set to Ultra has white stuff in the foreground

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95190 --- Comment #10 from Samuel Pitoiset --- This has been recently fixed by Kenneth. At least, I can't reproduce that fog issue on gm107 (I did force GL4.3 because that game requires a 4.2 context though). Karol, can you

Re: [Mesa-dev] [PATCH v2] i965: don't fail to shift height images for levels.

2016-08-23 Thread Ilia Mirkin
On Tue, Aug 23, 2016 at 12:34 PM, Jason Ekstrand wrote: > On Tue, Aug 23, 2016 at 9:28 AM, Jason Ekstrand > wrote: >> >> This smells like fish... I'm going to have a look. > > > Ok, I looked... > >> >> On Tue, Aug 23, 2016 at 8:29 AM, Antia Puentes

[Mesa-dev] [Bug 97426] glScissor gives vertically inverted result

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97426 --- Comment #3 from Emil Velikov --- Classic xlib libGL.so (comment 1) vs classic swrast_dri.so this report ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 97426] glScissor gives vertically inverted result

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97426 --- Comment #2 from Ruslan Kabatsayev --- Hmm, a difference from mine is in GL_RENDERER: here's what I have: GL_RENDERER = Software Rasterizer GL_VERSION= 2.1 Mesa 12.1.0-devel (git-607ab6d) GL_VENDOR = Mesa

Re: [Mesa-dev] [PATCH] egl: reset 'ViewportInitialized' when unbinding current context

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 17:36, Dongwon Kim wrote: > I read that part in egl specification as well but I wasn't sure > if this statement covers the case when the context is unbound via > eglMakeCurrent call with NULL context then it is made current again. > The problem I saw

Re: [Mesa-dev] [PATCH] egl/wayland-egl: Fix for segfault in dri2_wl_destroy_surface.

2016-08-23 Thread Emil Velikov
On 22 August 2016 at 08:48, Stencel, Joanna wrote: > Segfault occurs when destroying EGL surface attached to already destroyed > Wayland window. The fix is to set to NULL the pointer of surface's > native window when wl_egl_destroy_window() is called. > Are you sure one

Re: [Mesa-dev] [PATCH] egl: reset 'ViewportInitialized' when unbinding current context

2016-08-23 Thread Dongwon Kim
I read that part in egl specification as well but I wasn't sure if this statement covers the case when the context is unbound via eglMakeCurrent call with NULL context then it is made current again. The problem I saw was when the context is made current again especially with a new surface with

Re: [Mesa-dev] [PATCH v2] i965: don't fail to shift height images for levels.

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 9:28 AM, Jason Ekstrand wrote: > This smells like fish... I'm going to have a look. > Ok, I looked... > On Tue, Aug 23, 2016 at 8:29 AM, Antia Puentes > wrote: > >> From: Dave Airlie >> >> This fixes one

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

2016-08-23 Thread Dongwon Kim
Sure, I will. Thanks On Tue, Aug 23, 2016 at 11:39:52AM +0100, Emil Velikov wrote: > Hi Dongwon, > > On 15 August 2016 at 23:20, Dongwon Kim wrote: > > A new patch, "[PATCH] egl/dri2: remove error checks on return values from > > mtx_lock > > and cnd_wait" containing

Re: [Mesa-dev] [PATCH v2] i965: don't fail to shift height images for levels.

2016-08-23 Thread Jason Ekstrand
This smells like fish... I'm going to have a look. On Tue, Aug 23, 2016 at 8:29 AM, Antia Puentes wrote: > From: Dave Airlie > > This fixes one subtest of: > GL44-CTS.shader_image_size.advanced-nonMS-fs-int > > I've no idea why this wouldn't be scaled

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #26 from Kai --- (In reply to Alex Deucher from comment #25) > Is anyone still having issues with vblank_mode=0? With or without Michel's patch (), which

Re: [Mesa-dev] [PATCH 18/31] i965/blorp: Add an "exec" function pointer to blorp_context

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:55AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/blorp.c | 27 +-- > src/mesa/drivers/dri/i965/blorp.h | 4 > src/mesa/drivers/dri/i965/blorp_blit.c | 2 +- >

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #25 from Alex Deucher --- Is anyone still having issues with vblank_mode=0? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 17/31] i965/blorp: Move the guts of brw_blorp_exec into genX_blorp_exec.c

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:54AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/blorp.c | 66 > - > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 66 > + > src/mesa/drivers/dri/i965/genX_blorp_exec.h | 8 ++-- >

[Mesa-dev] [PATCH] shaderapi: don't generate not linked error on GetProgramStage in general

2016-08-23 Thread Alejandro Piñeiro
Both ARB_shader_subroutine and the GL core spec doesn't list any error when the program is not linked. We left a error generation for the uniform location, in order to be consistent with other methods from the spec that generate them. --- On 23/08/16 10:14, Tapani Pälli wrote: > IMO it looks

Re: [Mesa-dev] [PATCH 15/31] i965/blorp/exec: Refactor to use blorp_context and a void *batch

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:52AM -0700, Jason Ekstrand wrote: > This gets rid of brw_context throughout the core of the state setup code. > --- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 332 > +++- > 1 file changed, 182 insertions(+), 150 deletions(-) > > diff

[Mesa-dev] [PATCH v2] program_resource: subroutine active uniforms should return NumSubroutineUniforms

2016-08-23 Thread Alejandro Piñeiro
Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES and all the _SUBROUTINE_UNIFORM programInterface were returning the count of resources on the shader program using that interface, instead of the num of uniform resources. This would get a wrong value (for example) if the shader

[Mesa-dev] [PATCH v2] i965: don't fail to shift height images for levels.

2016-08-23 Thread Antia Puentes
From: Dave Airlie This fixes one subtest of: GL44-CTS.shader_image_size.advanced-nonMS-fs-int I've no idea why this wouldn't be scaled up here, and I've no idea what else will break, but I might as well open for discussion. v2: Only shift height if the texture is not an

Re: [Mesa-dev] [PATCH 16/31] i965/blorp: Pull the guts of blorp_exec into a driver-agnostic header

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:53AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/Makefile.sources | 15 +- > src/mesa/drivers/dri/i965/blorp_priv.h |2 +- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 1113 +- >

Re: [Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 2:17 AM, Emil Velikov wrote: > On 23 August 2016 at 02:11, Jason Ekstrand wrote: > > The only reason we should throw INITIALIZATION_FAILED is if we have found > > useable intel hardware but have failed to bring it up for

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-23 Thread Kai Wasserbäch
Hey Dave, Dave Airlie wrote on 23.08.2016 03:28: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. in case this is indeed enough to enable ARB_cull_distance, mind adding that to GL3.txt and the release notes? >

Re: [Mesa-dev] [PATCH 14/31] i965/blorp: Add a helper for allocating binding tables and surface states

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:51AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 64 > +++-- Had to read some bits three or four times but looks correct in the end: Reviewed-by: Topi Pohjolainen > 1 file

Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-23 Thread Kai Wasserbäch
Hey Boyuan, hey Christian, Zhang, Boyuan wrote on 22.08.2016 22:52: > Thanks for cleaning up the codes. The duplicated end_frame and unused > variable are due to the new patch submitted last Friday. I have reviewed both > patches. thanks for your reviews! Just in case you missed my postscript

Re: [Mesa-dev] [PATCH] egl/wayland-egl: Fix for segfault in dri2_wl_destroy_surface.

2016-08-23 Thread Eric Engestrom
On Mon, Aug 22, 2016 at 09:48:50AM +0200, Stencel, Joanna wrote: > Segfault occurs when destroying EGL surface attached to already destroyed > Wayland window. The fix is to set to NULL the pointer of surface's > native window when wl_egl_destroy_window() is called. > > Signed-off-by: Stencel,

Re: [Mesa-dev] [PATCH 13/31] i965/blorp: Use BT_INDEX enums for setting up the binding table

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:50AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/blorp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patches 9, 12 and 13 are: Reviewed-by: Topi Pohjolainen > > diff --git

Re: [Mesa-dev] [PATCH 11/31] i965/blorp/genX: Add a blorp_surface_reloc helper

2016-08-23 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:48AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 38 > - > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c >

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 --- Comment #2 from Fabian Maurer --- I'd like to, but the older versions fail due to the wrong version of llvm/clang. Is there somewhere a tutorial how to compile both together? -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH] vbo: fix format string compiler warning for 32-bit machines

2016-08-23 Thread Brian Paul
On 08/22/2016 10:59 AM, ⚛ wrote: I am marking this patch as (de-facto) rejected at Patchwork. I gave you my R-b and I just pushed it to master. -Brian Reason: The patch moved from the 1st page to the 2nd page of https://patchwork.freedesktop.org/project/mesa/series/?ordering=-last_updated

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

2016-08-23 Thread Emil Velikov
On 22 August 2016 at 07:10, Nicolas Boichat wrote: > Hi Emil, > > On Tue, Aug 16, 2016 at 1:17 AM, Emil Velikov > wrote: >> Hi Nicolas, >> >> On 4 August 2016 at 02:51, Nicolas Boichat wrote: >>> On Thu, Aug 4, 2016 at

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-23 Thread Ilia Mirkin
On Tue, Aug 23, 2016 at 12:18 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Tue, Aug 23, 2016 at 12:05 AM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> On Mon, Aug 22, 2016 at

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-23 Thread Zhang, Boyuan
Hi Eric, Thanks for catching it. The patch is Reviewed-by: Boyuan Zhang Regards, Boyuan -Original Message- From: Eric Engestrom [mailto:eric.engest...@imgtec.com] Sent: August-22-16 12:17 PM To: Zhang, Boyuan Cc: mesa-dev@lists.freedesktop.org; Koenig,

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-23 Thread Julien Cristau
On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am > index ad0148d..9fef960 100644 > --- a/src/intel/vulkan/Makefile.am > +++ b/src/intel/vulkan/Makefile.am > @@ -141,7 +141,7 @@ anv_timestamp.h: >

Re: [Mesa-dev] [PATCH v2] i965/vec4: make offset() operate in terms of channels instead of full registers

2016-08-23 Thread Iago Toral
On Tue, 2016-08-23 at 11:21 +0200, Michael Schellenberger Costa wrote: > Hi Iago, > > given that the idea here was to unify vec4 and fs you might want to > adopt the names/function types accordingly. > > In brw_ir_fs.h there is byte_offset that returns a fs_reg while you > have > void

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

2016-08-23 Thread Dave Airlie
>> #include "main/mtypes.h" >> #include "program/prog_parameter.h" >> - >> +#include "main/shaderapi.h" > > Why the extra empty line? If so, I would put it after the new include. It actually removes the empty line, but I think it was there deliberately, so I'll put it back. Dave.

Re: [Mesa-dev] [PATCH] egl: reset 'ViewportInitialized' when unbinding current context

2016-08-23 Thread Emil Velikov
On 15 August 2016 at 23:58, Dongwon Kim wrote: > 'ViewportInitialized' flag in gl_context has to be reset to '0' > when the current context is unbound via a eglMakeCurrent call with > all of 'NULL' resources (surfaces and context). > > This is to make sure the viewport of

[Mesa-dev] [Bug 97420] "#version 0" crashes glsl_compiler

2016-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97420 Vinson Lee changed: What|Removed |Added Keywords||bisected, regression

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-23 Thread Francisco Jerez
Ilia Mirkin writes: > On Mon, Aug 22, 2016 at 10:55 PM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> On Mon, Aug 22, 2016 at 9:59 PM, Francisco Jerez >>> wrote: gl_SecondaryFragColorEXT

  1   2   >