[Mesa-dev] [PATCH v2 5/6] anv: Add a struct for storing a compiled shader

2016-08-26 Thread Jason Ekstrand
This new anv_shader_bin struct stores the compiled kernel (as an anv_state) as well as all of the metadata that is generated at shader compile time. The struct is very similar to the old cache_entry struct except that it is reference counted and stores the actual pipeline_bind_map. Similarly to

[Mesa-dev] [PATCH v2 6/6] anv: Rework pipeline caching

2016-08-26 Thread Jason Ekstrand
The original pipeline cache the Kristian wrote was based on a now-false premise that the shaders can be stored in the pipeline cache. The Vulkan 1.0 spec explicitly states that the pipeline cache object is transiant and you are allowed to delete it after using it to create a pipeline with no ill

[Mesa-dev] [PATCH v2 02/31] i965/blorp: Expose the shader cache through function pointers

2016-08-26 Thread Jason Ekstrand
This sanitizes blorp's access to the i965 driver's shader cache by patching it through the blorp_context. When we start using blorp in Vulkan, we will simply have to implement such a caching interface in the Vulkan driver. Note: In my first attempt at this, I simplified it down to a single

Re: [Mesa-dev] [PATCH] nir: Update shader info when adding discards

2016-08-26 Thread Jason Ekstrand
If you wanted to be extra spiffy, you could add a discard helper to nir_builder and make it do it automatically :) In any case, Reviewed-by: Jason Ekstrand On Fri, Aug 26, 2016 at 6:13 PM, Eric Anholt wrote: > vc4 is about to start using the shader info

[Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

2016-08-26 Thread Nicholas Bishop
Hi, I'd like to propose a conversion of Mesa's documentation to reStructuredText (RST) and hosting the result on readthedocs.org. The intent is to make Mesa's documentation more accessible, searchable, and easier to edit. I put together a quick proof-of-concept here:

[Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-08-26 Thread Kenneth Graunke
This fixes a numerical precision issue that was causing two CTS failures: ES31-CTS.blend_equation_advanced.blend_specific.GL_COLORBURN_KHR ES31-CTS.blend_equation_advanced.blend_all.GL_COLORBURN_KHR_all_qualifier When blending with GL_COLORDODGE_KHR and these colors: dst = <0.372549027,

[Mesa-dev] [PATCH] nir: Update shader info when adding discards

2016-08-26 Thread Eric Anholt
vc4 is about to start using the shader info field to set up discard handling. --- src/compiler/nir/nir_lower_bitmap.c | 2 ++ src/compiler/nir/nir_lower_clip.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_lower_bitmap.c b/src/compiler/nir/nir_lower_bitmap.c index

Re: [Mesa-dev] [PATCH 00/31] i965: Separate blorp from the rest of the driver

2016-08-26 Thread Jason Ekstrand
On Thu, Aug 25, 2016 at 10:15 PM, Jason Ekstrand wrote: > On Aug 25, 2016 9:41 PM, "Pohjolainen, Topi" > wrote: > > > > On Thu, Aug 25, 2016 at 02:34:37PM -0700, Jason Ekstrand wrote: > > >On Thu, Aug 25, 2016 at 1:10 AM, Pohjolainen, Topi >

[Mesa-dev] [PATCH] anv/allocator: Correctly set the number of buckets

2016-08-26 Thread Jason Ekstrand
The range from ANV_MIN_STATE_SIZE_LOG2 to ANV_MAX_STATE_SIZE_LOG2 should be inclusive and we have asserts that ensure that you never try to allocate a state larger than (1 << ANV_MAX_STATE_SIZE_LOG2). However, without adding 1 to the difference, we allocate 1 too few bucckts and so, even though

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Samuel, Samuel Pitoiset wrote on 26.08.2016 15:54: > On 08/26/2016 01:58 PM, Kai Wasserbäch wrote: >> [...] >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> b/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> index 4f4f87e..dc1a476 100644 >> ---

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Samuel Pitoiset
On 08/26/2016 01:58 PM, Kai Wasserbäch wrote: Cc: Brian Paul Signed-off-by: Kai Wasserbäch --- Hi Brian, is this what you had in mind? If so, I was wondering whether virgl_encode.c would need to be updated as well. Doesn't seem like it, since

Re: [Mesa-dev] [PATCH] vbo: set draw_id

2016-08-26 Thread Brian Paul
On 08/26/2016 06:48 AM, Miklós Máté wrote: Fixes conditional jump depending on uninitialized value in si_state_draw.c:593 Cc: Signed-off-by: Miklós Máté --- src/mesa/vbo/vbo_exec_array.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

2016-08-26 Thread Kai Wasserbäch
v1 → v2: - Fixed indentation (noted by Brian Paul) - Removed second assert from nouveau's switch statements (suggested by Brian Paul) Signed-off-by: Kai Wasserbäch --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 ---

Re: [Mesa-dev] [PATCH] configure.ac: add llvm inteljitevents component if enabled

2016-08-26 Thread Emil Velikov
On 2 August 2016 at 18:54, Tim Rowley wrote: > Needed to successfully link llvmpipe or swr when using shared llvm libs. > --- > configure.ac | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/configure.ac b/configure.ac > index fb4a12a..edbc95b 100644 > ---

[Mesa-dev] [PATCH] tgsi/scan: remember sampler view types

2016-08-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 0167e22..a3b0d9f 100644

Re: [Mesa-dev] [PATCH 8/8] gallium/radeon: derive buffer placement and flags only once per buffer

2016-08-26 Thread Marek Olšák
On Fri, Aug 26, 2016 at 12:42 PM, Bas Nieuwenhuizen wrote: > I would prefer it if the function could be split in two functions > instead of using the initialized flag. I think we know whether it is > an initialization or a reinitialization per call site. OK. The updated

[Mesa-dev] [PATCH] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

2016-08-26 Thread Tapani Pälli
From: Haixia Shi Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to hard-coded non-zero values. These two attributes are required on Android. v2: use _EGL_MAX_PBUFFER_WIDTH/HEIGHT from egldefines.h (based on discussion on the first version)

Re: [Mesa-dev] [PATCH 25/30] egl/dri2: use dri2_bind_extensions to manage the optional extensions

2016-08-26 Thread Emil Velikov
On 25 August 2016 at 18:16, Kristian Høgsberg wrote: > On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >>

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

2016-08-26 Thread Mauro Rossi
2016-08-26 12:27 GMT+02:00 Tapani Pälli : > Hi; > > This is patch is causing build issues for me, how was this tested? > Hi, thanks for highlighting the issue, My patch was tested and reviewed, the current android build breakage due to following commit, upstreamed 13

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-26 Thread Emil Velikov
On 26 August 2016 at 08:50, Tapani Pälli wrote: > Reviewed-by: Tapani Pälli > What happened with my suggestion about getting things fixed as opposed to adding tape over things, namely these thread [1] ? Can someone please look into that one instead

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Eric Engestrom
On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: > Hey Brian, > Brian Paul wrote on 26.08.2016 14:50: > > On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: > >> Cc: Brian Paul > >> Signed-off-by: Kai Wasserbäch > >> --- > >> > >> Hi

Re: [Mesa-dev] [PATCH] tgsi/scan: remember sampler view types

2016-08-26 Thread Brian Paul
On 08/26/2016 07:48 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Brian Paul
On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: Cc: Brian Paul Signed-off-by: Kai Wasserbäch --- Hi Brian, is this what you had in mind? If so, I was wondering whether virgl_encode.c would need to be updated as well. Doesn't seem like it, since

Re: [Mesa-dev] [PATCH] vbo: set draw_id

2016-08-26 Thread Miklós Máté
On 08/26/2016 02:53 PM, Brian Paul wrote: On 08/26/2016 06:48 AM, Miklós Máté wrote: Fixes conditional jump depending on uninitialized value in si_state_draw.c:593 Cc: Signed-off-by: Miklós Máté --- src/mesa/vbo/vbo_exec_array.c | 1 +

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Eric Engestrom
On Fri, Aug 26, 2016 at 06:50:52AM -0600, Brian Paul wrote: > On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: > > Cc: Brian Paul > > Signed-off-by: Kai Wasserbäch > > --- > > > > Hi Brian, > > is this what you had in mind? If so, I was wondering

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Eric, Eric Engestrom wrote on 26.08.2016 15:49: > On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: >> Brian Paul wrote on 26.08.2016 14:50: >>> On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: Cc: Brian Paul Signed-off-by: Kai Wasserbäch

[Mesa-dev] [PATCH] vbo: set draw_id

2016-08-26 Thread Miklós Máté
Fixes conditional jump depending on uninitialized value in si_state_draw.c:593 Cc: Signed-off-by: Miklós Máté --- src/mesa/vbo/vbo_exec_array.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/vbo/vbo_exec_array.c

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-26 Thread Emil Velikov
On 26 August 2016 at 12:27, Tapani Pälli wrote: > Android.mk files were referring to LOCAL_PATH instead of path > where wanted Makefile.sources was existing. Also minor cleanups. > This will break the automake build. Please port commit

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Brian, Brian Paul wrote on 26.08.2016 14:50: > On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: >> Cc: Brian Paul >> Signed-off-by: Kai Wasserbäch >> --- >> >> Hi Brian, >> is this what you had in mind? If so, I was wondering whether

[Mesa-dev] [AppVeyor] mesa master #2023 failed

2016-08-26 Thread AppVeyor
Build mesa 2023 failed Commit b9ac72b511 by Miklós Máté on 8/26/2016 12:48 PM: vbo: set draw_id\n\nFixes conditional jump depending on uninitialized value\nin si_state_draw.c:593\n\nCc: \nSigned-off-by: Miklós Máté

[Mesa-dev] [AppVeyor] mesa master #2025 completed

2016-08-26 Thread AppVeyor
Build mesa 2025 completed Commit 0035f7f136 by Charmaine Lee on 8/26/2016 1:58 PM: svga: add guest statistic gathering interface\n\nThis file was supposed to be added with the previous "svga: add guest\nstatistic gathering interface" patch but went MIA for

[Mesa-dev] [Bug 32946] piglit glx-make-current gives X error BadMatch

2016-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32946 --- Comment #4 from Rahul --- Hi Marek, But i am seeing this issue with same piglit test. Is it expected.. ? is there any suggestion what is causing it ? Thanks, Rahul -- You are receiving this mail because: You are the

Re: [Mesa-dev] simple gallium clean-up task

2016-08-26 Thread Eric Engestrom
On Thu, Aug 25, 2016 at 09:18:46PM -0400, Rob Clark wrote: > On Thu, Aug 25, 2016 at 8:00 PM, Brian Paul wrote: > > If someone is looking for a simple task in gallium... > > > > In commit 0135bd44 Marek introduced some new enum types in p_defines.h > > > > In p_context.h we

Re: [Mesa-dev] simple gallium clean-up task

2016-08-26 Thread Nayan Deshmukh
On Fri, Aug 26, 2016 at 6:48 AM, Rob Clark wrote: > On Thu, Aug 25, 2016 at 8:00 PM, Brian Paul wrote: >> If someone is looking for a simple task in gallium... >> >> In commit 0135bd44 Marek introduced some new enum types in p_defines.h >> >> In

Re: [Mesa-dev] [PATCH] st/vdpau: Revert "change the order in which filters are applied(v3)"

2016-08-26 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Fri, Aug 26, 2016 at 1:27 PM, Christian König wrote: > From: Christian König > > This reverts commit 09dff7ae2e179d5a3490481762c6bd3d50430c9f. > > Turned out this can cause some

Re: [Mesa-dev] [PATCH 21/30] egl/x11: don't crash if dri2_dpy->conn is NULL

2016-08-26 Thread Emil Velikov
On 25 August 2016 at 18:06, Kristian Høgsberg wrote: > On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4. >> >> CC:

Re: [Mesa-dev] [PATCH] i915: Check return value of screen->image.loader->getBuffers

2016-08-26 Thread Eric Engestrom
On Wed, Aug 24, 2016 at 12:50:33PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Ported from the i965 commit e7ab358e8186dd8651cf920d4db1500c60ccd2fc. > > Cc: 11.2 12.0 > Cc: Tomasz Figa > Signed-off-by:

Re: [Mesa-dev] [PATCH 00/30] egl: a ton of eglMakeCurrent inspired cleanups

2016-08-26 Thread Eric Engestrom
On Thu, Aug 25, 2016 at 05:18:22PM +0100, Emil Velikov wrote: > Hi all, > > With the resent noise in the egl area I decided to do some of the long > planned cleanup in the area. It spans across the following: > > - glapi missing glFlush and non-shared glapi are not an option > -

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

2016-08-26 Thread Tapani Pälli
On 08/26/2016 01:27 PM, Tapani Pälli wrote: Hi; This is patch is causing build issues for me, how was this tested? (I'll send a patch proposal to fix the issues I encountered in a sec) See below for 2 questions: On 05/31/2016 01:20 AM, Mauro Rossi wrote: isl library is needed to build

[Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-26 Thread Tapani Pälli
Android.mk files were referring to LOCAL_PATH instead of path where wanted Makefile.sources was existing. Also minor cleanups. Signed-off-by: Tapani Pälli --- src/intel/Makefile.sources | 62 ++--- src/intel/genxml/Android.mk | 4

[Mesa-dev] [Bug 32946] piglit glx-make-current gives X error BadMatch

2016-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32946 --- Comment #5 from Marek Olšák --- No idea. I only know indirect rendering doesn't work on my machine and the piglit test fails too. Direct rendering has always worked. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] docs: add links to clarify patch mailing section

2016-08-26 Thread Eric Engestrom
On Thu, Aug 25, 2016 at 07:49:05PM -0400, Nicholas Bishop wrote: > From: Nicholas Bishop > > - Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify > which list patches should be sent to > > - Added an explicit link to >

Re: [Mesa-dev] [PATCH 1/4] mapi/glapi: remove unused _glapi_check_table_not_null

2016-08-26 Thread Eric Engestrom
On Thu, Aug 25, 2016 at 04:58:58PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Function was never part of the API/ABI and the final user was removed > with commit a73c6540d9a7f6e26d8568ba2fc522cb865f0a6c, back in 2010. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 4/7] egl/surfaceless: tweak surfaceless_add_configs_for_visuals()

2016-08-26 Thread Emil Velikov
On 25 August 2016 at 18:53, Gurchetan Singh wrote: >>> unsigned int format_count[ARRAY_SIZE(visuals)] = {}; > > Isn't this invalid in C? > http://stackoverflow.com/questions/17589533/is-an-empty-initializer-list-valid-c-code > Since we have a bunch of these around

[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Cc: Brian Paul Signed-off-by: Kai Wasserbäch --- Hi Brian, is this what you had in mind? If so, I was wondering whether virgl_encode.c would need to be updated as well. Doesn't seem like it, since the functions there map everything to uint32_t or

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

2016-08-26 Thread Tapani Pälli
Hi; This is patch is causing build issues for me, how was this tested? See below for 2 questions: On 05/31/2016 01:20 AM, Mauro Rossi wrote: isl library is needed to build i965, libmesa_isl static library is added to fix related Android building errors. Any attempt to build libmesa_genxml

Re: [Mesa-dev] [PATCH 8/8] gallium/radeon: derive buffer placement and flags only once per buffer

2016-08-26 Thread Bas Nieuwenhuizen
I would prefer it if the function could be split in two functions instead of using the initialized flag. I think we know whether it is an initialization or a reinitialization per call site. - Bas On Thu, Aug 18, 2016 at 9:46 PM, Marek Olšák wrote: > From: Marek Olšák

[Mesa-dev] [PATCH] st/vdpau: Revert "change the order in which filters are applied(v3)"

2016-08-26 Thread Christian König
From: Christian König This reverts commit 09dff7ae2e179d5a3490481762c6bd3d50430c9f. Turned out this can cause some artifacts in the output. Let's revert it for now until we have sorted out all issues. Signed-off-by: Christian König ---

Re: [Mesa-dev] [PATCH 4/4] radeonsi: disable CE on SI + AMDGPU

2016-08-26 Thread Bas Nieuwenhuizen
Patch 3, 4 are Reviewed-by: Bas Nieuwenhuizen For patch 1 and 2 I'm not familiar with the difference between the SI and CIK+ tiling modes to be sure they are good, but the other parts of the patch look good to me. btw, I'm not sure what you tried wrt the CE hang, but

Re: [Mesa-dev] [PATCH 7/8] gallium/radeon: add a driver query for AMDGPU_INFO_NUM_EVICTIONS

2016-08-26 Thread Bas Nieuwenhuizen
Patch 1-7 of this series are Reviewed-by: Bas Nieuwenhuizen - Bas (Adding mesa-dev ML this time) On Thu, Aug 18, 2016 at 9:46 PM, Marek Olšák wrote: > From: Marek Olšák > > If the kernel driver doesn't support it, it returns

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-26 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/24/2016 08:39 AM, Nicolas Boichat wrote: platform_android.c needs to link with cutils, hardware, and sync libraries, as well as drm_gralloc libs. Also add appropriate tests in configure.ac. Signed-off-by: Nicolas Boichat

Re: [Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

2016-08-26 Thread Christian König
Am 26.08.2016 um 07:51 schrieb Nayan Deshmukh: We use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. Signed-off-by: Nayan Deshmukh Looks really good to me, can you rebase this on the

[Mesa-dev] [PATCH v2] st/vdpau: use temporary buffers while applying filters

2016-08-26 Thread Nayan Deshmukh
Use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. v2: rebase the patch against reverted change Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 75

Re: [Mesa-dev] [PATCH 4/4] radeonsi: disable CE on SI + AMDGPU

2016-08-26 Thread Marek Olšák
On Fri, Aug 26, 2016 at 12:22 PM, Bas Nieuwenhuizen wrote: > Patch 3, 4 are > > Reviewed-by: Bas Nieuwenhuizen Thanks. > > For patch 1 and 2 I'm not familiar with the difference between the SI > and CIK+ tiling modes to be sure they are good,

[Mesa-dev] [Bug 32946] piglit glx-make-current gives X error BadMatch

2016-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32946 --- Comment #3 from Marek Olšák --- It looks like this is indirect rendering. Generally, you shouldn't use indirect rendering, because it's slow and limited in everything, and it breaks from time to time. -- You are receiving

[Mesa-dev] [Bug 32946] piglit glx-make-current gives X error BadMatch

2016-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32946 --- Comment #6 from Rahul --- Thanks Marek, But i believe if we can debug it .. and fix it. I am still learning driver and will try to understand it. Rahul -- You are receiving this mail because: You are the assignee for

[Mesa-dev] [PATCH] i965/vec4: remove the generator hack for dual instanced GS

2016-08-26 Thread Iago Toral Quiroga
This hack was introduced in commit 03ac2c7223f7645e3: i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs Specifically to fixup the code we emitted to deal with gl_PointSize inputs in dual instance mode, where we were emitting a MOV to copy the point size from .w (where the

[Mesa-dev] [PATCH 14/14] svga: move some code in svga_propagate_surface()

2016-08-26 Thread Brian Paul
Move computation of zslice, layer inside the conditional where they're used. --- src/gallium/drivers/svga/svga_surface.c | 37 + 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/svga/svga_surface.c

[Mesa-dev] [PATCH 08/14] svga: minor code simplification in svga_texture_transfer_unmap()

2016-08-26 Thread Brian Paul
Use the tex variable instead of using svga_texture() again. --- src/gallium/drivers/svga/svga_resource_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c index

[Mesa-dev] [PATCH 04/14] svga: minor simplifications in svga_texture_transfer_map()

2016-08-26 Thread Brian Paul
Use local vars instead of jumping through a pointer. --- src/gallium/drivers/svga/svga_resource_texture.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c

[Mesa-dev] [PATCH 10/14] svga: add new svga_check_sampler_framebuffer_resource_collision()

2016-08-26 Thread Brian Paul
--- src/gallium/drivers/svga/svga_sampler_view.h | 4 src/gallium/drivers/svga/svga_state_sampler.c | 33 ++- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_sampler_view.h b/src/gallium/drivers/svga/svga_sampler_view.h

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Samuel Pitoiset
On 08/26/2016 04:17 PM, Kai Wasserbäch wrote: Hey Samuel, Samuel Pitoiset wrote on 26.08.2016 15:54: On 08/26/2016 01:58 PM, Kai Wasserbäch wrote: [...] diff --git a/src/gallium/drivers/nouveau/nv30/nv30_texture.c b/src/gallium/drivers/nouveau/nv30/nv30_texture.c index 4f4f87e..dc1a476

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Miklós Máté
On 08/26/2016 07:47 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb Raider 2013 uses #version 420 in compute shaders, and

Re: [Mesa-dev] [PATCH] r600: increase performance for DRI PRIME offloading if 2nd GPU is Evergreen+

2016-08-26 Thread Marek Olšák
Applied. Thanks! Marek On Fri, Aug 26, 2016 at 6:59 PM, Mario Kleiner wrote: > This is a direct port of Marek Olšáks patch > "radeonsi: increase performance for DRI PRIME > offloading if 2nd GPU is CIK or VI" to r600. > > It uses SDMA for the detiling blit from

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

2016-08-26 Thread Ryan Houdek
Most of the Tegra devices (K1 and above) provide desktop GL, except for the Nexus devices which cut out that functionality. Not sure how front buffers differ there, never checked. Dolphin relies on a large amount of extensions, both for performance and proper emulation standpoint.. For

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Ilia Mirkin
On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: > On 08/26/2016 06:46 PM, Ilia Mirkin wrote: >> >> On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: >>> >>> Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa >>> rejects them,

[Mesa-dev] [PATCH v2] configure.ac: add llvm inteljitevents component if enabled

2016-08-26 Thread Tim Rowley
Needed to successfully link llvmpipe or swr when using shared llvm libs built with inteljitevents enabled. v2: Make adding inteljitevents component global rather than just llvmpipe/swr, since libgallium will have a symbol dependency. --- configure.ac | 4 1 file changed, 4 insertions(+)

Re: [Mesa-dev] [PATCH] nv50/ir: always emit the NDV bit for OP_QUADOP

2016-08-26 Thread Samuel Pitoiset
On 08/26/2016 01:06 AM, Ilia Mirkin wrote: Although "silences" is more accurate than "fixes". Yes, I will slightly improve the description before pushing. Thanks. On Thu, Aug 25, 2016 at 7:05 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

2016-08-26 Thread Ilia Mirkin
On Fri, Aug 26, 2016 at 3:01 PM, Ryan Houdek wrote: > Most of the Tegra devices (K1 and above) provide desktop GL, except for the > Nexus devices which cut out that functionality. > Not sure how front buffers differ there, never checked. > Dolphin relies on a large amount

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Eric Engestrom
On Fri, Aug 26, 2016 at 04:21:14PM +0200, Kai Wasserbäch wrote: > Hey Eric, > Eric Engestrom wrote on 26.08.2016 15:49: > > On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: > >> Brian Paul wrote on 26.08.2016 14:50: > >>> On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: > Cc:

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Ilia Mirkin
On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: > Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa > rejects them, because the local size qualifiers require 430. > > Signed-off-by: Miklós Máté > --- >

Re: [Mesa-dev] [PATCH] configure.ac: add llvm inteljitevents component if enabled

2016-08-26 Thread Rowley, Timothy O
> On Aug 26, 2016, at 8:30 AM, Emil Velikov wrote: > > On 2 August 2016 at 18:54, Tim Rowley wrote: >> Needed to successfully link llvmpipe or swr when using shared llvm libs. >> --- >> configure.ac | 5 + >> 1 file changed, 5

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Miklós Máté
On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa rejects them, because the local size qualifiers require 430. Signed-off-by: Miklós Máté

Re: [Mesa-dev] [PATCH 14/14] svga: move some code in svga_propagate_surface()

2016-08-26 Thread Neha Bhende
Series looks good me. Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Friday, August 26, 2016 8:27:18 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Jose Fonseca Subject: [PATCH 14/14] svga: move

[Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Miklós Máté
Tomb Raider 2013 uses #version 420 in compute shaders, and current Mesa rejects them, because the local size qualifiers require 430. Signed-off-by: Miklós Máté --- src/compiler/glsl/glsl_parser.yy | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH] r600: increase performance for DRI PRIME offloading if 2nd GPU is Evergreen+

2016-08-26 Thread Mario Kleiner
This is a direct port of Marek Olšáks patch "radeonsi: increase performance for DRI PRIME offloading if 2nd GPU is CIK or VI" to r600. It uses SDMA for the detiling blit from renderoffload VRAM to GTT, as SDMA is much faster for tiled->linear blits from VRAM to GTT. Testing on a dual Radeon

[Mesa-dev] [PATCH 02/14] svga: rewrite svga_buffer() cast wrapper

2016-08-26 Thread Brian Paul
To make it symmetric with the svga_texture() cast wrapper. --- src/gallium/drivers/svga/svga_resource_buffer.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_buffer.h b/src/gallium/drivers/svga/svga_resource_buffer.h index

[Mesa-dev] [PATCH 03/14] svga: minor reformatting of svga_texture() cast wrapper

2016-08-26 Thread Brian Paul
--- src/gallium/drivers/svga/svga_resource_texture.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.h b/src/gallium/drivers/svga/svga_resource_texture.h index e779f19..ffd5fea 100644 ---

[Mesa-dev] [PATCH 06/14] svga: remove duplicated variable in svga_texture_transfer_map()

2016-08-26 Thread Brian Paul
tex was already declared at the function body scope. --- src/gallium/drivers/svga/svga_resource_texture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c index 9104b0a..450ed2b 100644 ---

[Mesa-dev] [PATCH 05/14] svga: move some assignments in svga_texture_transfer_map()

2016-08-26 Thread Brian Paul
Put near other assignments to the svga_transfer variable. --- src/gallium/drivers/svga/svga_resource_texture.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c index

[Mesa-dev] [PATCH 11/14] svga: use new svga_check_sampler_framebuffer_resource_collision()

2016-08-26 Thread Brian Paul
--- src/gallium/drivers/svga/svga_pipe_sampler.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_sampler.c b/src/gallium/drivers/svga/svga_pipe_sampler.c index 59609b8..42e4fa5 100644 ---

[Mesa-dev] [PATCH 09/14] svga: remove assertions in svga_surface cast wrappers

2016-08-26 Thread Brian Paul
We don't do this for other cast wrappers. And this will simplify some code at call sites. --- src/gallium/drivers/svga/svga_surface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_surface.h b/src/gallium/drivers/svga/svga_surface.h index 0e5794b..c166791

[Mesa-dev] [PATCH 12/14] svga: add some comments in the svga_surface struct

2016-08-26 Thread Brian Paul
Give more info about backing resources/surfaces. --- src/gallium/drivers/svga/svga_surface.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/svga/svga_surface.h b/src/gallium/drivers/svga/svga_surface.h index c166791..2f003b2 100644 ---

[Mesa-dev] [PATCH 01/14] svga: remove local variable in create_backed_surface_view()

2016-08-26 Thread Brian Paul
To simplify the code a bit. --- src/gallium/drivers/svga/svga_surface.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/svga/svga_surface.c b/src/gallium/drivers/svga/svga_surface.c index 43a00c3..4b0b56c 100644 ---

[Mesa-dev] [PATCH 07/14] svga: reformat some expressions in svga_texture_transfer_map()

2016-08-26 Thread Brian Paul
--- src/gallium/drivers/svga/svga_resource_texture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c index 450ed2b..aff6fb1 100644 ---

[Mesa-dev] [PATCH 13/14] svga: simplify surface propagation code in svga_set_framebuffer_state()

2016-08-26 Thread Brian Paul
Rewrite the comment too. --- src/gallium/drivers/svga/svga_pipe_misc.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_misc.c b/src/gallium/drivers/svga/svga_pipe_misc.c index a26e577..7160154 100644 ---

[Mesa-dev] [PATCH] radeonsi: Don't use global variables for tess lds

2016-08-26 Thread Tom Stellard
We were allocating global variables for the maximum LDS size which made the compiler think we were using all of LDS, which isn't the case. --- src/gallium/drivers/radeonsi/si_shader.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] isl: Finish tiling filtering for Gen6.

2016-08-26 Thread Chad Versace
On Fri 26 Aug 2016, Kenneth Graunke wrote: > Gen6 only has one additional restriction over Gen7+, so we just add it > to the existing gen7 function (which actually covers later gens too). > > This should stop FINISHME spew when running GL on Sandybridge. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 14/14] svga: move some code in svga_propagate_surface()

2016-08-26 Thread Jose Fonseca
On 26/08/16 16:27, Brian Paul wrote: Move computation of zslice, layer inside the conditional where they're used. --- src/gallium/drivers/svga/svga_surface.c | 37 + 1 file changed, 19 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH] isl: Finish tiling filtering for Gen6.

2016-08-26 Thread Kenneth Graunke
Gen6 only has one additional restriction over Gen7+, so we just add it to the existing gen7 function (which actually covers later gens too). This should stop FINISHME spew when running GL on Sandybridge. Signed-off-by: Kenneth Graunke --- src/intel/isl/isl.c | 2 +-

Re: [Mesa-dev] [PATCH] docs: add links to clarify patch mailing section

2016-08-26 Thread Chad Versace
On Fri 26 Aug 2016, Nicholas Bishop wrote: > From: Nicholas Bishop > > * Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify > which list patches should be sent to > > * Added an explicit link to >

[Mesa-dev] [PATCH] docs: add links to clarify patch mailing section

2016-08-26 Thread Nicholas Bishop
From: Nicholas Bishop * Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify which list patches should be sent to * Added an explicit link to https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show where to subscribe to the list * Added a

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-08-26 Thread Ilia Mirkin
On Fri, Aug 26, 2016 at 3:08 PM, Miklós Máté wrote: > On 08/26/2016 07:47 PM, Ilia Mirkin wrote: >> >> On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: >>> >>> On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

2016-08-26 Thread Michael Schellenberger
Hi Kai, Am 26.08.2016 um 15:23 schrieb Kai Wasserbäch: > v1 → v2: > - Fixed indentation (noted by Brian Paul) > - Removed second assert from nouveau's switch statements (suggested by >Brian Paul) > > Signed-off-by: Kai Wasserbäch > --- >

Re: [Mesa-dev] [PATCH] i965/vec4: remove the generator hack for dual instanced GS

2016-08-26 Thread Francisco Jerez
Iago Toral Quiroga writes: > This hack was introduced in commit 03ac2c7223f7645e3: > i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs > > Specifically to fixup the code we emitted to deal with gl_PointSize inputs > in dual instance mode, where we were

Re: [Mesa-dev] [PATCH] isl: Allow multisampled array textures

2016-08-26 Thread Chad Versace
On Fri 26 Aug 2016, Pohjolainen, Topi wrote: > On Thu, Aug 25, 2016 at 03:58:24PM -0700, Jason Ekstrand wrote: > > This probably isn't the only thing that needs to be done to get > > multisampled array textures working in Vulkan but I think this is all that > > ISL really needs and it does fix 8

Re: [Mesa-dev] [PATCH 03/13] docs: Rename GL3.txt to features.txt

2016-08-26 Thread Chad Versace
Patches 2, 3 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] isl: Finish tiling filtering for Gen6.

2016-08-26 Thread Jason Ekstrand
On Aug 26, 2016 2:47 PM, "Chad Versace" wrote: > > On Fri 26 Aug 2016, Kenneth Graunke wrote: > > Gen6 only has one additional restriction over Gen7+, so we just add it > > to the existing gen7 function (which actually covers later gens too). > > > > This should stop

Re: [Mesa-dev] [PATCH v2 0/2] *** Aubinator tool for Intel Gen platforms ***

2016-08-26 Thread Chad Versace
On Fri 19 Aug 2016, Sirisha Gandikota wrote: > From: Sirisha Gandikota > > This is a patch series for adding the aubinator tool to the codebase. > > The aubinator tool is designed to help the driver developers to debug > the driver functionality by decoding the data

Re: [Mesa-dev] [PATCH] mesa/main: missing return in a non-void function

2016-08-26 Thread Alejandro Piñeiro
On 25/08/16 22:38, Ian Romanick wrote: > On 08/25/2016 08:19 AM, Emil Velikov wrote: >> On 25 August 2016 at 13:24, Francesco Ansanelli wrote: >>> Signed-off-by: Francesco Ansanelli >>> --- >>> src/mesa/main/program_resource.c |1 + >>> 1 file

  1   2   >