Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

Ping for review. Thanks. -Original Message- From: Weng, Chuanbo Sent: Wednesday, September 14, 2016 1:07 AM To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com Cc: Weng, Chuanbo Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding

Re: [Mesa-dev] [PATCH 08/14] winsys/amdgpu: enable buffer allocation from slabs

On Tue, Sep 13, 2016 at 11:56 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 165 > ++ > src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 18 +++ >

Re: [Mesa-dev] [PATCH] st/mesa: only enable MSAA coverage options when we have a MSAA buffer

On Fri, Sep 16, 2016 at 4:42 PM, Brian Paul wrote: > On 09/16/2016 08:07 AM, Marek Olšák wrote: >> >> On Thu, Sep 15, 2016 at 11:20 PM, Brian Paul wrote: >>> >>> Regardless of whether GL_MULTISAMPLE is enabled (it's enabled by default) >>> we should not set

[Mesa-dev] [PATCH] gk110/ir: fix wrong emission of OP_NOT

This should emit src0 instead of src1. Found by inspection. Signed-off-by: Samuel Pitoiset Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 02/14] gallium/pipebuffer: add pb_slab utility

Please add comments explaining all members of structures and all non-trivial functions. For example, it's not really clear why deinit calls reclaim. Thanks, Marek On Tue, Sep 13, 2016 at 11:56 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > >

Re: [Mesa-dev] [PATCH 08/14] winsys/amdgpu: enable buffer allocation from slabs

Apart from some minor comments, patches 1-8 are: Reviewed-by: Marek Olšák BTW, I think queries can start using smaller buffers too. If I understand it correctly, the minimum allocation size is 512 bytes, right? radeon_info::min_alloc_size can be added for the queries.

[Mesa-dev] [PATCH] nv50/ir: optimize SUB(a, b) to MOV(a - b)

This helps shaders in UE4 demos, especially with Elemental (+1% perf). This optimization reduces spilling usage in one shader which explains the little gain. GF100/GK104: total instructions in shared programs :2838551 -> 2838045 (-0.02%) total gprs used in shared programs:396706 -> 396684

Re: [Mesa-dev] [PATCH] nv50/ir: optimize SUB(a, b) to MOV(a - b)

Reviewed-by: Ilia Mirkin On Sun, Sep 18, 2016 at 6:33 AM, Samuel Pitoiset wrote: > This helps shaders in UE4 demos, especially with Elemental > (+1% perf). This optimization reduces spilling usage in one > shader which explains the little gain. >

[Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v4.1

v2: avoid dividing by zero when calculating lanczos v4 (chk): rebase on master v4.1: fix the indexing in temp array Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 445

[Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. Nayan Deshmukh (2): vl: add a lanczos interpolation filter v4.1 st/vdapu: use lanczos filter for scaling v4

[Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L7 uses lanczos filter with number representing the size of the sinc window. v3: avoid L8 and L9 to allow for other scaling algrithms v4 (chk): rebased on master Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH] gk110/ir: fix wrong emission of OP_NOT

Wow! I wonder how that happened... and went undetected for so long. Probably a copy-paste from emitForm_21 or something. Reviewed-by: Ilia Mirkin On Sun, Sep 18, 2016 at 8:42 AM, Samuel Pitoiset wrote: > This should emit src0 instead of src1. >

Re: [Mesa-dev] [PATCH 2/2] nvc0: get rid of nvc0_stage_sampler_states_bind_range()

Series is Reviewed-by: Ilia Mirkin On Sun, Sep 18, 2016 at 5:48 PM, Samuel Pitoiset wrote: > Same thing as nvc0_stage_set_sampler_views_range(). > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Nayan Deshmukh wrote: This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. The artifacts are still there. In addition 5,6 and 7 take an increasing time to start. It could be

[Mesa-dev] [PATCH 2/3] st/va: Save surface chroma format in config

--- We need this stored somewhere to be able to return useful information from vaQuerySurfaceAttributes() in the following patch. src/gallium/state_trackers/va/config.c | 23 +-- src/gallium/state_trackers/va/va_private.h | 1 + 2 files changed, 22 insertions(+), 2

[Mesa-dev] [PATCH 1/3] st/va: Return more useful config attributes

--- More chroma formats might be supportable, I've kept this to YUV420 + RGB for now. Also, B-frames might be supported in some configurations? That could be conditional on the GPU being used somehow if necessary. src/gallium/state_trackers/va/config.c | 53

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: Nayan Deshmukh wrote: This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. The artifacts are still there. To be a bit more precise 2 and 4 seem to be

[Mesa-dev] [PATCH] aubinator: add a custom handler for immediate register load

Transforming this : 0x00c77084: 0x1101: MI_LOAD_REGISTER_IMM 0x00c77088: 0xb020 : Dword 1 Register Offset: 0xb020 0x00c7708c: 0x00880038 : Dword 2 Data DWord: 8912952 Into this: 0x007880f0: 0x1101: MI_LOAD_REGISTER_IMM 0x007880f4: 0xb020 : Dword 1

[Mesa-dev] [PATCH 2/2] nvc0: get rid of nvc0_stage_sampler_states_bind_range()

Same thing as nvc0_stage_set_sampler_views_range(). Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 83 +++ 1 file changed, 9 insertions(+), 74 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] nvc0: get rid of nvc0_stage_set_sampler_views_range()

This function was quite similar to nvc0_stage_set_sampler_views() and I don't see any reasons to not remove it. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 104 -- 1 file changed, 15 insertions(+), 89

[Mesa-dev] [PATCH 3/3] st/va: return surface formats depending on config chroma format

Also allows NV12 to be returned as a supported format for video processing. --- The useful change is that we can now see that NV12 is supported by the video processor, so things like decode-scale-encode are known to be possible. Again, there might be more supported things here which could be

Re: [Mesa-dev] [RFC 1/2] glsl/list: Add an iteration helper that starts after the given node

On Sun, Sep 18, 2016 at 10:27 PM, Kenneth Graunke wrote: > On Thursday, September 15, 2016 9:00:35 PM PDT Jason Ekstrand wrote: > > --- > > src/compiler/glsl/list.h | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/compiler/glsl/list.h

Re: [Mesa-dev] [RFC 1/2] glsl/list: Add an iteration helper that starts after the given node

On Thursday, September 15, 2016 9:00:35 PM PDT Jason Ekstrand wrote: > --- > src/compiler/glsl/list.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/compiler/glsl/list.h b/src/compiler/glsl/list.h > index b5b5b36..8371519 100644 > --- a/src/compiler/glsl/list.h > +++

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Hi Andy, Thanks for testing the patches!! On Mon, Sep 19, 2016 at 5:24 AM, Andy Furniss wrote: > Andy Furniss wrote: > >> Nayan Deshmukh wrote: >> >>> This series implements lanczos interpolation filter. >>> >>> Andy, I have made some changes to the code. Can you test the

Re: [Mesa-dev] [PATCH] nir/spirv: Bring back the spirv2nir helper binary

On Thursday, September 15, 2016 8:59:30 PM PDT Jason Ekstrand wrote: > This was something that I wrote in the early days of the spirv_to_nir code > but deleted once we had a real driver. However, in the absence of a > shader_runner equivalent, it's extremely useful for debugging the >

Re: [Mesa-dev] [PATCH 01/15] glsl: Fix cut-and-paste bug in hierarchical visitor ir_expression::accept

On Thursday, September 15, 2016 3:12:34 PM PDT Ian Romanick wrote: > From: Ian Romanick > > At this point in the code, s must be visit_continue. If the child > returned visit_stop, visit_stop is the only correct thing to return. > > Found by inspection. > >