Re: [Mesa-dev] [PATCH 2/7] glsl/glcpp: use ralloc_sprint_rewrite_tail to avoid slow vsprintf

2016-12-31 Thread Kenneth Graunke
On Sunday, January 1, 2017 1:34:27 AM PST Marek Olšák wrote: > From: Marek Olšák > > This reduces compile times by 4.5% with the Gallium noop driver and > gl_constants::GLSLOptimizeConservatively == true. Compile times of...what exactly? Do you have any statistics for this

Re: [Mesa-dev] [PATCH 1/7] ralloc: add a new printing helper ralloc_sprint_rewrite_tail

2016-12-31 Thread Kenneth Graunke
On Sunday, January 1, 2017 1:34:26 AM PST Marek Olšák wrote: > From: Marek Olšák > > This one is much faster when you don't need vsprintf. > --- > src/util/ralloc.c | 25 + > src/util/ralloc.h | 24 > 2 files changed, 49

[Mesa-dev] [PATCH 6/7] glsl_to_tgsi: do fewer optimizations with GLSLOptimizeConservatively

2016-12-31 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 76 ++ 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

[Mesa-dev] [PATCH 5/7] mesa: add gl_constants::GLSLOptimizeConservatively

2016-12-31 Thread Marek Olšák
From: Marek Olšák to reduce the amount of GLSL optimizations for drivers that can do better. --- src/compiler/glsl/glsl_parser_extras.cpp | 14 +++--- src/compiler/glsl/linker.cpp | 16 src/mesa/main/ff_fragment_shader.cpp | 10

[Mesa-dev] [PATCH 7/7] st/mesa: enable GLSLOptimizeConservatively for drivers that want it

2016-12-31 Thread Marek Olšák
From: Marek Olšák GLSL compilation now takes 24% less time with the Gallium noop driver. I used my shader-db for the measurement. The difference for the whole radeonsi driver can be ~10%. The generated TGSI is mostly the same. For example, the compilation success rate with

[Mesa-dev] [PATCH 3/7] glsl: run do_lower_jumps properly in do_common_optimizations

2016-12-31 Thread Marek Olšák
From: Marek Olšák so that backends don't have to run it manually --- src/compiler/glsl/glsl_parser_extras.cpp | 3 ++- src/mesa/program/ir_to_mesa.cpp| 2 -- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 8 +--- 3 files changed, 3 insertions(+), 10

[Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY

2016-12-31 Thread Marek Olšák
From: Marek Olšák Drivers with good compilers don't need aggressive optimizations before TGSI. --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 +

[Mesa-dev] [PATCH 2/7] glsl/glcpp: use ralloc_sprint_rewrite_tail to avoid slow vsprintf

2016-12-31 Thread Marek Olšák
From: Marek Olšák This reduces compile times by 4.5% with the Gallium noop driver and gl_constants::GLSLOptimizeConservatively == true. --- src/compiler/glsl/glcpp/glcpp-parse.y | 39 +++ 1 file changed, 21 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 1/7] ralloc: add a new printing helper ralloc_sprint_rewrite_tail

2016-12-31 Thread Marek Olšák
From: Marek Olšák This one is much faster when you don't need vsprintf. --- src/util/ralloc.c | 25 + src/util/ralloc.h | 24 2 files changed, 49 insertions(+) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index

[Mesa-dev] [PATCH 0/7] Faster GLSL compilation (for Gallium)

2016-12-31 Thread Marek Olšák
Hi, The first 2 patches make the GLSL preprocessor a little faster. The others add an optional CAP/Const flag to Mesa and Gallium that decreases the amount of GLSL optimizations that are executed by tweaking the do_common_optimizations call sites. I've not seen a drop in the quality of the

Re: [Mesa-dev] [PATCH 5/5] gallium: remove TGSI_OPCODE_SUB

2016-12-31 Thread Ilia Mirkin
On Sat, Dec 31, 2016 at 7:04 PM, Marek Olšák wrote: > +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > @@ -1695,21 +1695,22 @@ glsl_to_tgsi_visitor::visit_expression(ir_expression* > ir, st_src_reg *op) > * driver. > */ >emit_asm(ir, TGSI_OPCODE_MOV,

[Mesa-dev] [PATCH 3/5] gallium/hud: add an option to reset the color counter

2016-12-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 21 ++--- src/gallium/auxiliary/hud/hud_private.h | 1 + 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH 2/5] gallium/hud: allow more data sources per pane

2016-12-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 4c65af3..9e17d9b 100644

[Mesa-dev] [PATCH 4/5] gallium/hud: add an option to sort items below graphs

2016-12-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 37 - src/gallium/auxiliary/hud/hud_private.h | 1 + 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH 5/5] gallium/hud: increase the vertex buffer size for text

2016-12-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 6892289..50c2f80 100644 ---

[Mesa-dev] [PATCH 1/5] gallium/hud: add an option to rename each data source

2016-12-31 Thread Marek Olšák
From: Marek Olšák useful for radeonsi performance counters --- src/gallium/auxiliary/hud/hud_context.c | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH 4/5] gallium: remove TGSI_OPCODE_ABS

2016-12-31 Thread Marek Olšák
From: Marek Olšák It's redundant with the source modifier. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 2 +- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 16 +- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 2 +-

[Mesa-dev] [PATCH 5/5] gallium: remove TGSI_OPCODE_SUB

2016-12-31 Thread Marek Olšák
From: Marek Olšák It's redundant with the source modifier. --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 20 ++-- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 38 +++---

[Mesa-dev] [PATCH 3/5] st/nine: Remove all usage of ureg_SUB in nine_shader

2016-12-31 Thread Marek Olšák
From: Axel Davy This is required to drop gallium SUB. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 1/5] st/nine: Do not map SUB and ABS to their gallium equivalent.

2016-12-31 Thread Marek Olšák
From: Axel Davy This is required for gallium SUB and ABS to be removed. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] st/nine: Remove all usage of ureg_SUB in nine_ff

2016-12-31 Thread Marek Olšák
From: Axel Davy This is required to remove gallium SUB. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [Bug 99125] Log to a file all GALLIUM_HUD infos

2016-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99125 --- Comment #2 from Edmondo Tommasina --- FYI: Marek pushed the series of patches to mesa git master. https://cgit.freedesktop.org/mesa/mesa/commit/?id=3f5fba8a7be61bfc0f46a5ea058108f6e0e1c268 -- You are receiving this

Re: [Mesa-dev] [AppVeyor] mesa master #3012 failed

2016-12-31 Thread Ilia Mirkin
src\gallium\auxiliary\hud\hud_context.c(874) : warning C4013: 'access' undefined; assuming extern returning int src\gallium\auxiliary\hud\hud_context.c(874) : error C2065: 'W_OK' : undeclared identifier scons: *** [build\windows-x86-debug\gallium\auxiliary\hud\hud_context.obj] Error 2 On Sat, Dec

[Mesa-dev] [AppVeyor] mesa master #3012 failed

2016-12-31 Thread AppVeyor
Build mesa 3012 failed Commit 3f5fba8a7b by Edmondo Tommasina on 12/21/2016 9:58 PM: docs: document GALLIUM_HUD_DUMP_DIR envvar\n\nSigned-off-by: Marek Olšák Configure your notification preferences

Re: [Mesa-dev] [PATCH 1/6] gallium/hud: dump hud_driver_query values to files

2016-12-31 Thread Marek Olšák
FYI, I've pushed the series and squashed the first 2 patches. Thanks, Marek On Sat, Dec 31, 2016 at 10:15 PM, Marek Olšák wrote: > On Wed, Dec 21, 2016 at 10:58 PM, Edmondo Tommasina > wrote: >> Dump values for every selected data source in

Re: [Mesa-dev] [PATCH 2/6] gallium/hud: add dump directory enviroment variable

2016-12-31 Thread Marek Olšák
Ignore my comment on patch 1. This patch can be merged with the first one. Marek On Wed, Dec 21, 2016 at 10:58 PM, Edmondo Tommasina wrote: > Set GALLIUM_HUD_DUMP_DIR to dump values to files in this directory. > > No values are dumped if the environment variable is

Re: [Mesa-dev] [PATCH 18/27] i965/miptree: Add a return for updating of winsys

2016-12-31 Thread Ben Widawsky
On 16-12-31 14:40:42, Ben Widawsky wrote: On 16-12-10 15:39:12, Pohjolainen, Topi wrote: On Thu, Dec 01, 2016 at 02:09:59PM -0800, Ben Widawsky wrote: [snip] We don't seem to use "zero for success"-style at least in i965. Could you change this to bool and flip the check earlier for

Re: [Mesa-dev] [PATCH 18/27] i965/miptree: Add a return for updating of winsys

2016-12-31 Thread Ben Widawsky
On 16-12-10 15:39:12, Pohjolainen, Topi wrote: On Thu, Dec 01, 2016 at 02:09:59PM -0800, Ben Widawsky wrote: From: Ben Widawsky There is nothing particularly useful to do currently if the update fails, but there is no point carrying on either. As a result, this has a

Re: [Mesa-dev] [PATCH 1/6] gallium/hud: dump hud_driver_query values to files

2016-12-31 Thread Marek Olšák
On Wed, Dec 21, 2016 at 10:58 PM, Edmondo Tommasina wrote: > Dump values for every selected data source in GALLIUM_HUD. > > Every data source has its own file and the filename is > equal to the data source identifier. > --- > src/gallium/auxiliary/hud/hud_context.c

Re: [Mesa-dev] [PATCH 17/27] i965: Create correctly sized mcs for an image

2016-12-31 Thread Ben Widawsky
On 16-12-10 15:36:06, Pohjolainen, Topi wrote: On Thu, Dec 01, 2016 at 02:09:58PM -0800, Ben Widawsky wrote: From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 37 1 file

Re: [Mesa-dev] [PATCH 00/27] Renderbuffer Decompression (and GBM modifiers)

2016-12-31 Thread Ben Widawsky
On 16-12-29 17:34:19, Ben Widawsky wrote: On 16-12-06 13:34:02, Paulo Zanoni wrote: 2016-12-01 20:09 GMT-02:00 Ben Widawsky : From: Ben Widawsky This patch series ultimately adds support within the i965 driver for Renderbuffer Decompression

[Mesa-dev] [AMD] Screen flickering with 4K and RX 480, would be glad to help debugging

2016-12-31 Thread Romain Failliot
Hi! I've recently bought a 4K display and an RX 480, but I've got some troubles with Dota when using high settings. I've created a thread on Phoronix forum (because maybe other people have the same problem...):

Re: [Mesa-dev] Patch for freedreno features

2016-12-31 Thread Romain Failliot
I tried to use git send-email but it doesn't seem to work (although the output says otherwise). So eventually it's simpler to just copy/paste the patch generated by git format-patch: --- docs/features.txt | 38 +++--- 1 file changed, 19 insertions(+), 19

Re: [Mesa-dev] Patch for freedreno features

2016-12-31 Thread Romain Failliot
I'll try to do the git patch! I know features.txt isn't the official support source and it is more for the devs to follow on their work, so it's really up to up if you want to add freedreno in features.txt. I simply don't have a device for each driver, that's why I'm parsing features.txt in

Re: [Mesa-dev] Patch for freedreno features

2016-12-31 Thread Rob Clark
hey, I don't suppose you could send a git patch? I can push (although tbh glxinfo is the authoritative source when it comes to which extensions are supported on which generations of adreno) BR, -R On Fri, Dec 30, 2016 at 2:09 PM, Romain Failliot wrote: > Hi! > >

[Mesa-dev] [Bug 99237] Impossible to create transparent X11/EGL windows while respecting EGL_NATIVE_VISUAL_ID

2016-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99237 --- Comment #1 from nfx...@gmail.com --- > Second it has some code that explicitly excludes RGBA X visuals, Looking at the code I linked again, this is wrong. But if xcb_depth_iterator_t returns the RGB visual before the RGBA one, the RGBA one

[Mesa-dev] [Bug 99237] Impossible to create transparent X11/EGL windows while respecting EGL_NATIVE_VISUAL_ID

2016-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99237 Bug ID: 99237 Summary: Impossible to create transparent X11/EGL windows while respecting EGL_NATIVE_VISUAL_ID Product: Mesa Version: 13.0 Hardware: Other

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 Jonathan Gray changed: What|Removed |Added CC||j...@openbsd.org --