[Mesa-dev] [PATCH 3/3] r600g: get rid of dummy pixel shader

The idea is taken from radeonsi. The code mostly was already checking for null pixel shader, so little checks had to be added. Interestingly, acc. to testing with GTAⅣ, though binding of null shader happens a lot at the start (then just stops), but draw_vbo() never actually sees null ps.

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 3 ++-

[Mesa-dev] [PATCH 1/3] r600g: skip repeating vs, gs, and tes shader binds

The idea is taken from radeonsi. The code lacks some checks for null vs, and I'm unsure about some changes against that, so I left it in place. Some statistics for GTAⅣ: Average tesselation shaders bind skip per frame: ≈350 Average geometric shaders bind skip per frame: ≈260 Skip of binding

[Mesa-dev] [PATCH 0/3] r600g: shader logic improvements

Although I didn't see a staticstically significant change in GTAⅣ benchmark, it seem to have reduced stall for opening the door from a house to the outer world at the first savepoint. No changes in gpu.py tests of piglit in gbm mode. Constantine Kharlamov (3): r600g: skip repeating vs, gs, and

[Mesa-dev] [PATCH v2] r600g: skip repeating vs, gs, and tes shader binds

The idea is taken from radeonsi. The code lacks some checks for null vs, and I'm unsure about some changes against that, so I left it in place. Some statistics for GTAⅣ: Average tesselation bind skip per frame: ≈350 Average geometric shaders bind skip per frame: ≈260 Skip of binding vertex ones

[Mesa-dev] [Bug 100629] No mans sky renders white screen under wine in linux

https://bugs.freedesktop.org/show_bug.cgi?id=100629 --- Comment #2 from Giovanni ongaro --- those errors are displayed multiple times Mesa: User error: GL_INVALID_ENUM in glDrawElements(mode=) Mesa: User error: GL_INVALID_ENUM in

Re: [Mesa-dev] [PATCH 2/2] genxml: Make BLEND_STATE command support variable length array.

On April 9, 2017 8:48:31 AM Lionel Landwerlin wrote: I have one suggestion at the bottom of the patch, otherwise : Reviewed-by: Lionel Landwerlin On 07/04/17 17:52, Rafael Antognolli wrote: We need to emit BLEND_STATE, which

[Mesa-dev] [PATCH] mesa: fix memory leak in arb_fragment_program

--- src/mesa/program/arbprogparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/program/arbprogparse.c b/src/mesa/program/arbprogparse.c index 07bdf1603e..83a501eea6 100644 --- a/src/mesa/program/arbprogparse.c +++ b/src/mesa/program/arbprogparse.c @@ -78,6 +78,7 @@

Re: [Mesa-dev] [PATCH v2 1/3] nv50/ir: fix AlgebraicOpt for slcts with mods

On Mon, Apr 3, 2017 at 11:58 AM, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [Bug 100627] EGL fails to fall back to DRI2 when DRI3 is enabled but not available

https://bugs.freedesktop.org/show_bug.cgi?id=100627 Bug ID: 100627 Summary: EGL fails to fall back to DRI2 when DRI3 is enabled but not available Product: Mesa Version: 17.0 Hardware: All OS: FreeBSD

[Mesa-dev] [PATCH] mesa: use single memcpy when strides matches

--- src/mesa/main/readpix.c | 15 ++- src/mesa/main/texstore.c | 15 +++ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 25823230d6..14568de497 100644 --- a/src/mesa/main/readpix.c +++

Re: [Mesa-dev] [PATCH 2/2] genxml: Make BLEND_STATE command support variable length array.

I have one suggestion at the bottom of the patch, otherwise : Reviewed-by: Lionel Landwerlin On 07/04/17 17:52, Rafael Antognolli wrote: We need to emit BLEND_STATE, which size is 1 + 2 * nr_draw_buffers dwords (on gen8+), but the BLEND_STATE struct length is

Re: [Mesa-dev] [PATCH v2 2/3] nv50/ir: handle logops with NOT in AlgebraicOpt

On Mon, Apr 3, 2017 at 11:58 AM, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #2 from Stefan Dirsch --- Roland, thanks a lot for your prompt reply! Very much appreciated! Seems Richard meanwhile switched companies from IBM to ARM meanwhile. I found him on Linkedin. Possibly he's now

[Mesa-dev] [Bug 100629] No mans sky renders white screen under wine in linux

https://bugs.freedesktop.org/show_bug.cgi?id=100629 Bug ID: 100629 Summary: No mans sky renders white screen under wine in linux Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 100629] No mans sky renders white screen under wine in linux

https://bugs.freedesktop.org/show_bug.cgi?id=100629 --- Comment #1 from Giovanni ongaro --- Upon starting no man sky under wine (no man sky need OGL4.5 ) ingame only a white screen is displayed -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH 1/3 v3] r600g: skip repeating vs, gs, and tes shader binds

The idea is taken from radeonsi. The code lacks some checks for null vs, and I'm unsure about some changes against that, so I left it in place. Some statistics for GTAⅣ: Average tesselation bind skip per frame: ≈350 Average geometric shaders bind skip per frame: ≈260 Skip of binding vertex ones

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 3 ++-

[Mesa-dev] [PATCH 1/3 v2] r600g: skip repeating vs, gs, and tes shader binds

The idea is taken from radeonsi. The code lacks some checks for null vs, and I'm unsure about some changes against that, so I left it in place. Some statistics for GTAⅣ: Average tesselation bind skip per frame: ≈350 Average geometric shaders bind skip per frame: ≈260 Skip of binding vertex ones

[Mesa-dev] [PATCH 0/9] nvc0: ARB_shader_ballot for Kepler+ (v2)

This is v2 series of my ARB_shader_ballot enablement. I added some fixes based on Samuel Pitoiset's feedback, which mainly include adapting existing OP_SHFL usage to the new form in gm107's lowering and addition of several assertion checks. It is also rebased against current master. Boyan Ding

[Mesa-dev] [PATCH v2 8/9] nvc0/ir: Implement TGSI_OPCODE_BALLOT and TGSI_OPCODE_READ_*

--- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 28 ++ 1 file changed, 28 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index 1bd01a9a32..2ce6f29905 100644 ---

[Mesa-dev] [PATCH v2 7/9] nvc0/ir: Implement TGSI_SEMANTIC_SUBGROUP_*

--- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 ++ 1 file changed, 27 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index 3ed7d345c4..1bd01a9a32 100644 ---

[Mesa-dev] [PATCH v2 3/9] nvc0/ir: Emit OP_SHFL

v2: (Samuel Pitoiset) Add an assertion to check if the target is Kepler Make sure that asImm() is not NULL --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 59 ++ 1 file changed, 59 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp

[Mesa-dev] [PATCH v2 4/9] gk110/ir: Emit OP_SHFL

v2: Make sure that asImm() is not NULL (Samuel Pitoiset) --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

[Mesa-dev] [PATCH v2 1/9] gm107/ir: Emit third src 'bound' and optional predicate output of SHFL

v2: Emit the original hard-coded 0x1c03 when OP_SHFL is used in gm107's lowering (Samuel Pitoiset) --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 23 ++ .../nouveau/codegen/nv50_ir_lowering_gm107.cpp | 15 +- 2 files changed, 29 insertions(+), 9

[Mesa-dev] [PATCH v2 6/9] nvc0/ir: Add SV_LANEMASK_* system values.

--- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 5 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 + 4 files

[Mesa-dev] [PATCH v2 5/9] nvc0/ir: Allow 0/1 immediate value as source of OP_VOTE

Implementation of readFirstInvocationARB() on nvidia hardware needs a ballotARB(true) used to decide the first active thread. This expressed in gm107 asm as (supposing output is $r0): vote any $r0 0x1 0x1 To model the always true input, which corresponds to the second 0x1 above, we make

[Mesa-dev] [PATCH v2 2/9] nvc0/ir: Properly handle a "split form" of predicate destination

GF100's ISA encoding has a weird form of predicate destination where its 3 bits are split across whole the instruction. Use a dedicated setPDSTL function instead of original defId which is incorrect in this case. --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 13 +++-- 1

[Mesa-dev] [PATCH v2 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

readInvocationARB() and readFirstInvocationARB() need SHFL.IDX instruction which is introduced in Kepler. --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 ++- 3 files changed, 4

Re: [Mesa-dev] [PATCH v2 2/9] nvc0/ir: Properly handle a "split form" of predicate destination

Wow, great find! On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > GF100's ISA encoding has a weird form of predicate destination where its > 3 bits are split across whole the instruction. Use a dedicated setPDSTL > function instead of original defId which is incorrect

Re: [Mesa-dev] [PATCH v2 3/9] nvc0/ir: Emit OP_SHFL

On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > v2: (Samuel Pitoiset) > Add an assertion to check if the target is Kepler > Make sure that asImm() is not NULL > --- > .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 59 > ++ > 1 file changed,

Re: [Mesa-dev] [PATCH v2 6/9] nvc0/ir: Add SV_LANEMASK_* system values.

Please add these to nv50_ir_print.cpp's list of names too. On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 + >

Re: [Mesa-dev] [PATCH v2 5/9] nvc0/ir: Allow 0/1 immediate value as source of OP_VOTE

On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > Implementation of readFirstInvocationARB() on nvidia hardware needs a > ballotARB(true) used to decide the first active thread. This expressed > in gm107 asm as (supposing output is $r0): > vote any $r0 0x1 0x1 >

Re: [Mesa-dev] [PATCH v2 7/9] nvc0/ir: Implement TGSI_SEMANTIC_SUBGROUP_*

Reviewed-by: Ilia Mirkin On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 > ++ > 1 file changed, 27 insertions(+) > > diff --git

[Mesa-dev] [PATCH V2 1/2] glsl: delay optimisations on individual shaders when cache is available

Due to a max limit of 65,536 entries on the index table that we use to decide if we can skip compiling individual shaders, it is very likely we will have collisions. To avoid doing too much work when the linked program may be in the cache this patch delays calling the optimisations until link

[Mesa-dev] [PATCH V3 2/2] glsl: don't run the GLSL pre-processor when we are skipping compilation

Improves Deus Ex start-up times with a warm cache from ~30 seconds to ~22 seconds. Also fixes the leaking of state. V2: fix indentation v3: add the value of MESA_EXTENSION_OVERRIDE to the hash of the shader. Tested-by (v2): Grazvydas Ignotas ---

Re: [Mesa-dev] [PATCH v2 2/9] nvc0/ir: Properly handle a "split form" of predicate destination

2017-04-10 9:31 GMT+08:00 Ilia Mirkin : > Wow, great find! > > On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: >> GF100's ISA encoding has a weird form of predicate destination where its >> 3 bits are split across whole the instruction. Use a

Re: [Mesa-dev] [PATCH v2 8/9] nvc0/ir: Implement TGSI_OPCODE_BALLOT and TGSI_OPCODE_READ_*

On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 28 > ++ > 1 file changed, 28 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp >

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #3 from Roland Scheidegger --- (In reply to Stefan Dirsch from comment #2) > Roland, thanks a lot for your prompt reply! Very much appreciated! > > Seems Richard meanwhile switched companies from IBM to ARM

Re: [Mesa-dev] [PATCH v2 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

Reviewed-by: Ilia Mirkin On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > readInvocationARB() and readFirstInvocationARB() need SHFL.IDX > instruction which is introduced in Kepler. > --- > docs/features.txt | 2 +- >

Re: [Mesa-dev] [PATCH v2 8/9] nvc0/ir: Implement TGSI_OPCODE_BALLOT and TGSI_OPCODE_READ_*

2017-04-10 9:54 GMT+08:00 Ilia Mirkin : > On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: >> --- >> .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 28 >> ++ >> 1 file changed, 28 insertions(+) >> >> diff --git

Re: [Mesa-dev] [PATCH] mesa: fix memory leak in arb_fragment_program

Thanks. Reviewed-by: Timothy Arceri On 10/04/17 02:37, Bartosz Tomczyk wrote: --- src/mesa/program/arbprogparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/program/arbprogparse.c b/src/mesa/program/arbprogparse.c index 07bdf1603e..83a501eea6 100644

Re: [Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

On Sun, Apr 9, 2017 at 8:25 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek Thanks. I do not have commit access, so will need someone to push it for me. > On Sat, Apr 8, 2017 at 8:36 AM, Thomas Hindoe Paaboel Andersen >

Re: [Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

On 04/10/2017 12:31 PM, Thomas H.P. Andersen wrote: > On Sun, Apr 9, 2017 at 8:25 PM, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Marek > > Thanks. I do not have commit access, so will need someone to push it for me. Done, thanks for the fix!

Re: [Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

One trivial comment but otherwise 1&2 are, Reviewed-by: Edward O'Callaghan On 04/10/2017 09:34 AM, Bas Nieuwenhuizen wrote: > Adds a shader for writing occlusion query results to a buffer, as the > CP packet isn't support on SI or secondary buffers, and doesn't

Re: [Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

Reviewed-by: Marek Olšák Marek On Sat, Apr 8, 2017 at 8:36 AM, Thomas Hindoe Paaboel Andersen wrote: > Since the inclusion in 7f160efcde41b52ad78e562316384373dab419e3 > the header used x_biased, while the implementation used y_biased. > This changes the

Re: [Mesa-dev] [PATCH 1/3] amd: fix distcheck

Reviewed-by: Marek Olšák Marek On Wed, Apr 5, 2017 at 1:00 PM, Juan A. Suarez Romero wrote: > Add missing GFX9 files in the EXTRA_DIST. > --- > src/amd/Makefile.sources | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [PATCH 2/2] radv: Use a shader for occlusion CmdCopyQueryPoolResults.

Use the new occlusion query copy shader. We don't use the shader for the waiting as a polling loop ineracts badly with having caching enabled. I noticed on my GPU (Tonga) that the values are written out in order, so I just use a WAIT_REG_MEM on the last value. If it turns out other chips don't

[Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

Adds a shader for writing occlusion query results to a buffer, as the CP packet isn't support on SI or secondary buffers, and doesn't handle the availability bit (or partial results) nor truncation to 32-bit. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta.c|

Re: [Mesa-dev] [PATCH 2/2] genxml: Make BLEND_STATE command support variable length array.

On 09/04/17 17:23, Jason Ekstrand wrote: On April 9, 2017 8:48:31 AM Lionel Landwerlin wrote: I have one suggestion at the bottom of the patch, otherwise : Reviewed-by: Lionel Landwerlin On 07/04/17 17:52, Rafael Antognolli

[Mesa-dev] [PATCH 0/3 v2] r600g: shader logic improvements

Although I didn't see a statistically significant change in GTAⅣ benchmark, it seem to have reduced stall for opening the door from a house to the outer world at the first savepoint. No changes in gpu.py tests of piglit in gbm mode. v2: In the 1-st patch was occasionally removed empty line.

[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

The idea is taken from radeonsi. The code mostly was already checking for null pixel shader, so little checks had to be added. Interestingly, acc. to testing with GTAⅣ, though binding of null shader happens a lot at the start (then just stops), but draw_vbo() never actually sees null ps. v2:

Re: [Mesa-dev] [PATCH shader-db] Add ".so" shared objects to .gitignore

Reviewed-by: Marek Olšák Marek On Sat, Apr 8, 2017 at 9:59 PM, Rhys Kidd wrote: > For intel_stubs.so > > Signed-off-by: Rhys Kidd > --- > > I don't have commit access, so I would appreciate a reviewer pushing this to > master. > >