[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 John changed: What|Removed |Added CC||airl...@freedesktop.org

Re: [Mesa-dev] [PATCH 2/3] i965/miptree: Separate src and dst slice specifiers in slice copy

2017-06-09 Thread Jason Ekstrand
The existence of this software fallback makes me sad . On June 9, 2017 7:05:33 AM Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 60 --- 1 file

Re: [Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

2017-06-09 Thread Bas Nieuwenhuizen
Merge this with patch 14? On Sat, Jun 10, 2017 at 1:47 AM, Connor Abbott wrote: > From: Connor Abbott > > To match si_shader_context. > > Signed-off-by: Connor Abbott > --- > src/amd/common/ac_llvm_build.c | 2 ++ >

[Mesa-dev] [PATCH 00/17] radv: Support for subgroup_vote and shader_ballot

2017-06-09 Thread Connor Abbott
From: Connor Abbott This series adds all the bits to enable EXT_shader_subgroup_vote and EXT_shader_subgroup_ballot for radv. It's based on my previous series to fix some 64-bit bugs in radv and anv, since nothing would work without them. Patches 1-4 are a resend of my

[Mesa-dev] [PATCH 01/17] nir: introduce new convergent and cross-thread attributes

2017-06-09 Thread Connor Abbott
From: Connor Abbott These are properties of the instruction that must be respected when moving it around, in addition to the usual SSA dominance guarantee. Previously, we only had special handling for fddx and fddy, in a very ad-hoc way. But with arb_shader_ballot and

[Mesa-dev] [PATCH 04/17] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

2017-06-09 Thread Connor Abbott
From: Connor Abbott v2: make every instruction an intrinsic, add missing subgroup_size, also add system value translation stuff Signed-off-by: Connor Abbott --- src/compiler/nir/nir.c| 28

[Mesa-dev] [PATCH 02/17] nir/gcm: use the new cross-thread attribute

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_gcm.c | 72 ++ 1 file changed, 23 insertions(+), 49 deletions(-) diff --git a/src/compiler/nir/nir_opt_gcm.c

[Mesa-dev] [PATCH 03/17] nir: take cross-thread operations into account into a few places

2017-06-09 Thread Connor Abbott
From: Connor Abbott These optimizations happened to work with derivatives, but they won't with upcoming shader_ballot and group_vote instructions. Signed-off-by: Connor Abbott --- src/compiler/nir/nir_instr_set.c | 22 ++

Re: [Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

2017-06-09 Thread Connor Abbott
Sure. On Fri, Jun 9, 2017 at 5:04 PM, Bas Nieuwenhuizen wrote: > Merge this with patch 14? > > On Sat, Jun 10, 2017 at 1:47 AM, Connor Abbott > wrote: >> From: Connor Abbott >> >> To match si_shader_context. >> >>

[Mesa-dev] [PATCH 3/3] mesa/st: glsl_to_tgsi: tie in the new register renaming approach

2017-06-09 Thread Gert Wollny
This patch replaces the old register livetime estimation with the new approach. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 2/3] mesa/st: glsl_to_tgsi Implement a new lifetime tracker for temporaries

2017-06-09 Thread Gert Wollny
This patch adds new classes and tests to implement a tracker for the life time of temporary registers for the register renaming stage of glsl_to_tgsi. The tracker aims at estimating the shortest possible life time for each register. The code base requires c++11, the flag is propagated from the

[Mesa-dev] [PATCH 1/3] mesa/st: glsl_to_tgsi move some helper classes to extra files

2017-06-09 Thread Gert Wollny
To prepare the implementation of a temp register lifetime tracker some of the classes are moved into seperate header/implementation files to make them accessible from other files. --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

[Mesa-dev] [PATCH 0/3] [RFC] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-09 Thread Gert Wollny
Dear all, as I wrote before, I was looking into the temporary register renaming. This series of patches implements a new approach that achieves a tigher estimation of the life time of the temporaries, and as a result the Piano and Voloplosion benchmarks implemented in gputest [1] now work.

[Mesa-dev] [PATCH 12/17] ac: add i64 type to ac_llvm_context

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 13/17] radeonsi: move si_emit_ballot() to ac

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 26 ++ src/amd/common/ac_llvm_build.h | 4 src/gallium/drivers/radeonsi/si_shader.c | 38

[Mesa-dev] [PATCH 11/17] radeonsi: move emit_optimization_barrier() to ac

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 43 ++ src/amd/common/ac_llvm_build.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 45

[Mesa-dev] [PATCH 14/17] ac: add i32_1 convenience member to ac_llvm_context

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 10/17] radeonsi: move llvm_get_type_size() to ac

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 24 +++ src/amd/common/ac_llvm_build.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 41 +++- 3

[Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

2017-06-09 Thread Connor Abbott
From: Connor Abbott To match si_shader_context. Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 2 ++ src/amd/common/ac_llvm_build.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH 06/17] compiler: add new system values for SPV_KHR_shader_ballot

2017-06-09 Thread Connor Abbott
From: Connor Abbott For SPIR-V, Khronos decided to make the SubGroup*Mask system values consist of 4 32-bit components rather than one 64-bit component. Although we'll lower away the difference in nir_lower_system_values so drivers won't have to deal with them, adding these

[Mesa-dev] [PATCH 05/17] mesa: fix 64-bit issues with system_values_read

2017-06-09 Thread Connor Abbott
From: Connor Abbott We're about to bump the number of system values above 32. The system_values_read bitfield itself is 64 bits, but some users weren't taking that into account. Fix the ones I could find by grepping for "system_values_read". This prevents regressions at

[Mesa-dev] [PATCH 07/17] nir/lower_system_values: handle SPIR-V shader_ballot system values

2017-06-09 Thread Connor Abbott
From: Connor Abbott Lower them to the GL version. Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_system_values.c | 38 ++ 1 file changed, 38 insertions(+) diff --git

[Mesa-dev] [PATCH 08/17] nir/spirv: add plumbing for KHR_shader_ballot and KHR_subgroup_vote

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/compiler/spirv/nir_spirv.h | 2 + src/compiler/spirv/spirv_to_nir.c | 80 ++ src/compiler/spirv/vtn_variables.c | 28 + 3 files changed, 110

Re: [Mesa-dev] [PATCH 1/2] i965: include gen4_blorp_exec.h into EXTRA_DIST

2017-06-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On June 9, 2017 9:01:38 AM "Juan A. Suarez Romero" wrote: Otherwise, `make distcheck` will fail. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 16/17] ac: enable the AMDGPU asm parser

2017-06-09 Thread Connor Abbott
From: Connor Abbott Ported from radeonsi. Needed for emitting optimization barriers, which contain inline asm. Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_util.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_nir_to_llvm.c | 75 + src/amd/vulkan/radv_device.c| 8 + src/amd/vulkan/radv_pipeline.c | 2 ++ 3 files changed, 85 insertions(+)

[Mesa-dev] [PATCH 15/17] radeonsi: move the guts of ARB_shader_group_vote emission to ac

2017-06-09 Thread Connor Abbott
From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 30 ++ src/amd/common/ac_llvm_build.h | 6 ++ src/gallium/drivers/radeonsi/si_shader.c | 24

Re: [Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

2017-06-09 Thread Bas Nieuwenhuizen
On Sat, Jun 10, 2017 at 1:50 AM, Connor Abbott wrote: > From: Connor Abbott > > Signed-off-by: Connor Abbott > --- > src/amd/common/ac_nir_to_llvm.c | 75 > + >

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

2017-06-09 Thread Anuj Phogat
On Thu, Jun 8, 2017 at 5:07 PM, Jason Ekstrand wrote: > On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat wrote: >> >> >> >> On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand >> wrote: >>> >>> On May 12, 2017 4:41:36 PM Anuj Phogat

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

2017-06-09 Thread Jason Ekstrand
On June 9, 2017 2:41:46 PM Anuj Phogat wrote: On Thu, Jun 8, 2017 at 5:07 PM, Jason Ekstrand wrote: On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat wrote: On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand

[Mesa-dev] [PATCH] i965: Call intel_prepare_render() from intel_update_state()

2017-06-09 Thread Kenneth Graunke
The resolve code looks at the current color draw buffers. These are not valid until intel_prepare_render() is called. You can end up with one color buffer bound, but where the renderbuffer has zero width/height and no miptree allocated. You can get a call chain like: _mesa_Clear ->

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #4 from John --- Alright, after bisecting here's the problematic commit: https://cgit.freedesktop.org/mesa/mesa/commit/?id=bcae3274692954ad2cd6dfc253579ec98d50856f Thanks! -- You are receiving this mail

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

2017-06-09 Thread Anuj Phogat
On Thu, Jun 8, 2017 at 5:23 PM, Jason Ekstrand wrote: > I think I've now reviewed everything except 2 patches. For the "Update a > few assertions" patch, you said you would run a test but never reported back > the results. The other is the patch for re-enabling sRGB

Re: [Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

2017-06-09 Thread Connor Abbott
On Fri, Jun 9, 2017 at 5:04 PM, Bas Nieuwenhuizen wrote: > On Sat, Jun 10, 2017 at 1:50 AM, Connor Abbott > wrote: >> From: Connor Abbott >> >> Signed-off-by: Connor Abbott >> --- >>

[Mesa-dev] i965: disable_throttling

2017-06-09 Thread Marathe, Yogesh
Hi, I'm looking forward to set this brw->disable_throttling to true, I'm actually observing adverse effect on performance benchmarks after I force set that to true. What's the expectation from disable_throttling here? BTW, this is on android. Regards, Yogesh.

[Mesa-dev] [libdrm 1/4] etnaviv: submit full struct drm_etnaviv_gem_submit

2017-06-09 Thread Christian Gmeiner
It is safe to submit the full struct even on older kernels as such kernels do not process the full struct. Without this change it becomes quite challenging to extned the submit struct. Freedreno has no special treatment too. See git commits - freedreno: sync uapi header - freedreno: add fence fd

[Mesa-dev] [libdrm 2/4] etnaviv: sync uapi header

2017-06-09 Thread Christian Gmeiner
Import the etnaviv header changes from kernel commits x The drm_etnaviv_gem_submit structure was extended to include performance monitor requests. Also two new ioctls got added to readout performance monitor domains and their signals. Signed-off-by: Christian Gmeiner

[Mesa-dev] [libdrm 4/4] etnaviv: support performance monitor requests

2017-06-09 Thread Christian Gmeiner
Add etna_cmd_stream_perf(..) to submit perform requests. Userspace can submit pmrs via submit ioctl to sample perfmon signals. Signed-off-by: Christian Gmeiner --- etnaviv/etnaviv-symbol-check | 1 + etnaviv/etnaviv_cmd_stream.c | 20

[Mesa-dev] [libdrm 0/4] etnaviv: performance counter support

2017-06-09 Thread Christian Gmeiner
This series depends on the kernel patches not found its way into mainline due current review process. I did not mark this series as RFC to really get some review feedback :) In this series add an api to work work with performance domains and signals (etna_perfmon_xxx). Also it adds a new api

Re: [Mesa-dev] [PATCH] radv: set fmask state to all 0s when no fmask. (v2)

2017-06-09 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Jun 9, 2017 at 3:40 AM, Dave Airlie wrote: > From: Dave Airlie > > The shader reads the descriptor to decide if it should take the > fmask value, however we weren't initing it always, which meant >

Re: [Mesa-dev] [RFC 3/3] egl: remove EGL_NOK_swap_region

2017-06-09 Thread Tapani Pälli
On 06/05/2017 03:21 PM, Emil Velikov wrote: On 5 June 2017 at 09:32, Tapani Pälli wrote: On 06/05/2017 02:52 AM, Emil Velikov wrote: From: Emil Velikov Analogous to previous commit - only one platform (of 6?) implements this, and

Re: [Mesa-dev] [PATCH 00/10] Convert a couple more states to genxml.

2017-06-09 Thread Lionel Landwerlin
Patches 1-5 are : Reviewed-by: Lionel Landwerlin On 06/06/17 17:23, Rafael Antognolli wrote: This series converts SF_STATE, COLOR_CALC_STATE adn BLEND_CONSTANT_COLOR state to use genxml. It has to be applied on top of this series from Ken:

[Mesa-dev] [PATCH] etnaviv: add rs-operations sw query

2017-06-09 Thread Christian Gmeiner
It could be useful to get the number of emited resolve operations when doing driver optimizations. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c | 2 ++

Re: [Mesa-dev] [PATCH 1/3] mesa: add gl_driver_flags::NewScissor{Rect, Test}

2017-06-09 Thread Samuel Pitoiset
On 06/09/2017 12:00 AM, Ian Romanick wrote: Is there any particular application that these series should help? Was a performance improvement measured? This series doesn't target any particular applications. It can help apps that update scissor boxes often because pipe_rasterizer is no

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-09 Thread Marius Gräfe
I can fix the remaining integer div/mod opcodes, no problem. I think a consistent error value would be beneficial, would opt for ~0u for 32-bit values and ~0ull for 64 bit values to keep it consistent with the only existing requirement (that is d3d10). Should I just submit another patch based

[Mesa-dev] [Bug 101360] Assertion failure comparing result of ballotARB

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101360 Bug ID: 101360 Summary: Assertion failure comparing result of ballotARB Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [libdrm 3/4] etnaviv: add permon support

2017-06-09 Thread Christian Gmeiner
Query all domains and their signals and provide it this information via struct etna_perfmon and the corresponding api functions. Signed-off-by: Christian Gmeiner --- etnaviv/Makefile.sources | 1 + etnaviv/etnaviv-symbol-check | 4 + etnaviv/etnaviv_drmif.h

Re: [Mesa-dev] [PATCH v2 45/64] st/mesa: disable per-context seamless cubemap when using texture handles

2017-06-09 Thread Nicolai Hähnle
On 30.05.2017 22:36, Samuel Pitoiset wrote: The ARB_bindless_texture spec say: "If ARB_seamless_cubemap (or OpenGL 4.0, which includes it) is supported, the per-context seamless cubemap enable is ignored and treated as disabled when using texture handles." "If

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

2017-06-09 Thread Tapani Pälli
With the suggestions from Emil and Eric, this is: Reviewed-by: Tapani Pälli On 06/07/2017 07:11 PM, Harish Krupo wrote: This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1

Re: [Mesa-dev] [PATCH v2 52/64] radeonsi: implement ARB_bindless_texture

2017-06-09 Thread Nicolai Hähnle
On 30.05.2017 22:36, Samuel Pitoiset wrote: This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. v2: - fix a memleak related to util_copy_image_view() - remove "texture" parameter from create_texture_handle() - store

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

2017-06-09 Thread Tapani Pälli
On 06/08/2017 04:53 PM, Emil Velikov wrote: Hi all, On 8 June 2017 at 13:06, Harish Krupo wrote: Hi Tapani, On 06/08/2017 04:32 PM, Tapani Pälli wrote: Harish, please find small addition below. I noticed we still have one crasher in tests when this extension

Re: [Mesa-dev] [PATCH 1/3] spirv: fix OpBitcast when the src and dst bitsize are different

2017-06-09 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 08/06/17 23:05, Connor Abbott wrote: From: Connor Abbott Before, we were just implementing it with a move, which is incorrect when the source and destination have different bitsizes. To implement it

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

2017-06-09 Thread Tapani Pälli
On 06/08/2017 09:27 PM, Chad Versace wrote: On Thu 08 Jun 2017, Tomasz Figa wrote: On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli wrote: On 06/08/2017 09:36 AM, Tapani Pälli wrote: On 06/08/2017 06:05 AM, Tomasz Figa wrote: On Wed, Jun 7, 2017 at 5:36 AM, Chad

[Mesa-dev] [PATCH v3 62/63] radeonsi: add support for loading bindless images

2017-06-09 Thread Samuel Pitoiset
v2: - removed use of the Bindless flags after rebasing - make use of tgsi_is_bindless_image_file() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 28 +--

[Mesa-dev] [PATCH v3 63/63] radeonsi: enable ARB_bindless_texture

2017-06-09 Thread Samuel Pitoiset
This has only been tested on RX480. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- docs/features.txt | 2 +- docs/relnotes/17.2.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 3

[Mesa-dev] [PATCH v3 46/63] st/mesa: disable per-context seamless cubemap when using texture handles

2017-06-09 Thread Samuel Pitoiset
The ARB_bindless_texture spec say: "If ARB_seamless_cubemap (or OpenGL 4.0, which includes it) is supported, the per-context seamless cubemap enable is ignored and treated as disabled when using texture handles." "If AMD_seamless_cubemap_per_texture is supported, the seamless

[Mesa-dev] [PATCH v3 56/63] radeonsi: decompress resident textures/images before graphics/compute

2017-06-09 Thread Samuel Pitoiset
Similar to the existing decompression code path except that it loops over the list of resident textures/images. v3: - move the blitter check back to si_decompress_textures() - decompress resident textures directly in si_decompress_textures() - depth_texture -> needs_depth_decompress -

[Mesa-dev] [PATCH v3 54/63] radeonsi: only add descriptors in presence of resident handles

2017-06-09 Thread Samuel Pitoiset
This won't help much except for applications that use a ton of resident handles. Though, this will reduce the winsys overhead a little bit. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) ---

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101326 --- Comment #3 from Brian Paul --- Thanks for the info. The patch looks good. I'll push it soon with minor reformatting. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

2017-06-09 Thread Marek Olšák
On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset wrote: > > > On 06/09/2017 03:49 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >>

Re: [Mesa-dev] [PATCH 24.5/24] i965/cnl: Add a preliminary device for Cannonlake

2017-06-09 Thread Anuj Phogat
On Thu, Jun 8, 2017 at 5:19 PM, Jason Ekstrand wrote: > I sent out a Vulkan patch (and CCd you) that needs to land before this one > so that we don't accidentally start advertising Vulkan support once the PCI > IDs land. > I'll land the vulkan patch before this one. Thanks.

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

2017-06-09 Thread Gurchetan Singh
Actually, these are the only patches that are required. We're trying to run the Android Studio emulator using the host's GLES implementation. The emulator uses the image extension in that case: https://android.googlesource.com/platform/sdk/+/emu-2.4-

Re: [Mesa-dev] [PATCH 2/2] RFC: radeon/compute: Limit allocations for VRAM-based chips to 3/4 VRAM

2017-06-09 Thread Aaron Watry
On Wed, Jun 7, 2017 at 11:12 PM, Aaron Watry wrote: > On Wed, Jun 7, 2017 at 9:15 PM, Michel Dänzer wrote: >> On 08/06/17 03:42 AM, Marek Olšák wrote: >>> On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote: On Mon, Jun 5, 2017 at 3:07

[Mesa-dev] [PATCH 2/2] r600/eg: distribute egd_tables.py in the dist file

2017-06-09 Thread Juan A. Suarez Romero
Otherwise, `make distcheck` will fail. --- src/gallium/drivers/r600/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/Makefile.am b/src/gallium/drivers/r600/Makefile.am index 44fd51d..2b1ffb5 100644 --- a/src/gallium/drivers/r600/Makefile.am +++

[Mesa-dev] [PATCH 1/2] i965: include gen4_blorp_exec.h into EXTRA_DIST

2017-06-09 Thread Juan A. Suarez Romero
Otherwise, `make distcheck` will fail. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 762aefc..e2d5992 100644 --- a/src/mesa/drivers/dri/i965/Makefile.am +++

Re: [Mesa-dev] [PATCH v3 52/63] radeonsi: implement ARB_bindless_texture

2017-06-09 Thread Marek Olšák
On Fri, Jun 9, 2017 at 3:35 PM, Samuel Pitoiset wrote: > This implements the Gallium interface. Decompression of resident > textures/images will follow in the next patches. > > v3: - do not unmap bindless descriptors > - remove unnecessary util_copy_image_view() >

Re: [Mesa-dev] [PATCH] tgsi: clarify TGSI_SEMANTIC_SAMPLEMASK documentation

2017-06-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 9, 2017 at 3:56 PM, Brian Paul wrote: > --- > src/gallium/docs/source/tgsi.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/docs/source/tgsi.rst >

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

2017-06-09 Thread Samuel Pitoiset
On 06/09/2017 04:26 PM, Marek Olšák wrote: On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset wrote: On 06/09/2017 03:49 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 2/3] radeonsi: fix missing num_L2_invalidates increment

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 8508259..ec564c1 100644 ---

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

2017-06-09 Thread Samuel Pitoiset
On 06/09/2017 03:49 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

[Mesa-dev] [PATCH 3/3] i965/gen4: Add support for single layer in alignment workaround

2017-06-09 Thread Topi Pohjolainen
On gen < 6 one doesn't have level or layer specifiers available for render and depth targets. In order to support rendering to specific level/layer, driver needs to manually offset the surface to the desired slice. There are, however, alignment restrictions to respect as well and in come cases the

[Mesa-dev] [PATCH 2/3] i965/miptree: Separate src and dst slice specifiers in slice copy

2017-06-09 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 60 --- 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH 1/3] i965/miptree: Clarify face/level/layer in slice copy

2017-06-09 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 39 ++- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101326 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH v3 61/63] radeonsi: add support for loading bindless samplers

2017-06-09 Thread Samuel Pitoiset
v2: - removed use of the Bindless flags after rebasing Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH v3 60/63] radeonsi: invalidate buffers which are made resident if needed

2017-06-09 Thread Samuel Pitoiset
When a buffer becomes resident, check if it has been invalidated, if so update the descriptor and the dirty flag. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_descriptors.c | 34

[Mesa-dev] [PATCH v3 48/63] radeonsi: add si_init_descriptor_list() helper

2017-06-09 Thread Samuel Pitoiset
This will be used in order to initialize resident descriptors for bindless textures/images. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++ 1 file changed, 15

[Mesa-dev] [PATCH 1/3] radeonsi: get rid of more compressed_colortex_mask names

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 4 ++-- src/gallium/drivers/radeonsi/si_descriptors.c | 28 +-- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_state.h | 2 +- 4

[Mesa-dev] [PATCH] st/mesa: call check_program_state only when needed

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index cbac762..bcfbcf8 100644 --- a/src/mesa/state_tracker/st_atom.c +++

[Mesa-dev] [PATCH 2/2] gallium/noop: fix sampler views

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/noop/noop_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/noop/noop_state.c b/src/gallium/drivers/noop/noop_state.c index 46d99ab..80cfae8 100644 --- a/src/gallium/drivers/noop/noop_state.c +++

[Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 53f66ac..a8255f2 100644 ---

[Mesa-dev] [PATCH 1/2] gallium/docs: clarify gen_name/get_vendor/get_device_vendor behavior

2017-06-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index 852c31b..288fb5c 100644 --- a/src/gallium/docs/source/screen.rst +++

[Mesa-dev] [PATCH] tgsi: clarify TGSI_SEMANTIC_SAMPLEMASK documentation

2017-06-09 Thread Brian Paul
--- src/gallium/docs/source/tgsi.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index eceaa6d..7fb963f 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -3298,8

Re: [Mesa-dev] [PATCH v3 57/63] radeonsi: track use of bindless samplers/images from tgsi_shader_info

2017-06-09 Thread Marek Olšák
On Fri, Jun 9, 2017 at 3:35 PM, Samuel Pitoiset wrote: > This adds some new helper functions to know if the current draw > call (or dispatch compute) is using bindless samplers/images, > based on TGSI analysis. > > v3: - add si_context::uses_bindless_{samplers,images} >

[Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

2017-06-09 Thread Harish Krupo
This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add fallback for eglSetDamageRegionKHR (Tapani) v3: The native_window_set_surface_damage call is available only from

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-09 Thread Brian Paul
Let's not impose behavior that would burden drivers (for example: "idiv by zero must result in ~0u"). Just updating the docs to say the results of div/mod by zero is undefined (unless we know something specific is needed) would be fine. As it is now, some div/mod operations are documented to

Re: [Mesa-dev] [PATCH] anv: Don't advertise support on anything above gen9

2017-06-09 Thread Anuj Phogat
On Thu, Jun 8, 2017 at 5:10 PM, Jason Ekstrand wrote: > This will prevent the driver from even trying to work on Cannon Lake > until we get actual support added. > > Cc: Anuj Phogat > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [Mesa-stable] [PATCH] Reduce zlib requirement from 1.2.8 to 1.2.3.

2017-06-09 Thread Chuck Atkins
Hi Emil, Did you test the upstream versions or the distribution ones which tend > to be patched? > Both. I build 17.1.1 against the system supplied zlib-devel packages for 1.2.3 in EL6 and 1.2.7 on EL7. I then swapped out the zlib version at runtime via LD_LIBRARY_PATH with ones build from the

Re: [Mesa-dev] [PATCH 2/4] configure.ac: remove explicit -lpthread link

2017-06-09 Thread Emil Velikov
On 9 June 2017 at 14:16, Rowley, Timothy O wrote: > With this patch series applied, the build fails for me on ubuntu 16.04. > Thanks Tim - I can see what's going wrong. I'll double-check things and send v2 in a bit. Emil ___

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

2017-06-09 Thread Marek Olšák
On Fri, Jun 9, 2017 at 4:31 PM, Samuel Pitoiset wrote: > > > On 06/09/2017 04:26 PM, Marek Olšák wrote: >> >> On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 06/09/2017 03:49 PM, Marek Olšák wrote:

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101338 --- Comment #3 from Brian Paul --- I don't have a Raspberry Pi to test with. I installed geomview/savi on my Intel deskside system and tested with both NVIDIA's driver and llvmpipe. With both I see a shaded blue sphere with

Re: [Mesa-dev] [PATCH 3/2] r600g, compute: provide local copy of ac_binary.{h, c}

2017-06-09 Thread Aaron Watry
On Fri, Jun 9, 2017 at 8:20 AM, Jan Vesely wrote: > This is a verbatim copy of the code. The functions can be cleaned up since > r600 does not use all the stuff that gcn does. > The symbol names have been changed since we still use ac_binary.h header > (for struct

Re: [Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

2017-06-09 Thread Eric Engestrom
On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote: > This patch adds support for the EGL_KHR_partial_update extension for > android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. > 1 test not supported. > > v2: add fallback for eglSetDamageRegionKHR (Tapani) > > v3:

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-09 Thread Grazvydas Ignotas
Ping. Boring patch, should be easy to review or NAK. On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #3 from Eric Engestrom --- (In reply to John from comment #2) > Would anything else help? It would be really helpful if you could bisect the issue. This means picking an app (game) that was working and

[Mesa-dev] [PATCH v2 3/3] r600g, compute: provide local copy of functions from ac_binary.c

2017-06-09 Thread Jan Vesely
This is a verbatim copy of the code. The functions can be cleaned up since r600 does not use all the stuff that gcn does. The symbol names have been changed since we still use ac_binary.h header (for struct definition) v2: Add ifdef guard around r600_binary_clean call (Aaron) Remove stray

Re: [Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

2017-06-09 Thread Harish Krupo
Hi Eric, On 06/09/2017 08:59 PM, Eric Engestrom wrote: On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote: This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add

[Mesa-dev] [RFC PATCH] st/mesa: skip texture validation logic when nothing has changed

2017-06-09 Thread Timothy Arceri
Based on the same logic in the i965 driver 2f225f61451abd51 and 16060c5adcd4. perf reports st_finalize_texture() going from 0.60% -> 0.16% with this change when running the Xonotic benchmark from PTS. --- A full run of piglit on radeonsi produced no regressions. No other drivers have been

[Mesa-dev] [PATCH] st/mesa: unmap the stream_uploader buffer before drawing

2017-06-09 Thread Brian Paul
Some drivers require that the vertex buffers be unmapped prior to drawing. This change unmaps the stream_uploader buffer after we've uploaded the zero-stride attributes (unless the driver supports rendering with mapped buffers). This fixes a regression in the VMware driver since

[Mesa-dev] [PATCH] gallium/util: whitespace, formatting fixes in u_upload_mgr.c

2017-06-09 Thread Brian Paul
--- src/gallium/auxiliary/util/u_upload_mgr.c | 54 +-- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index 9528495..4bb14d6 100644 ---

  1   2   >