[Mesa-dev] [PATCH] gallium/util: remove unused util_{begin, end}_pipestat_query() helpers

Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/util/u_helpers.c | 50 -- src/gallium/auxiliary/util/u_helpers.h | 7 - 2 files changed, 57 deletions(-) diff --git a/src/gallium/auxiliary/util/u_helpers.c

[Mesa-dev] [PATCH] swr/rast: Correctly allocate SWR_STATS memory as cacheline aligned

Cacheline alignment of SWR_STATS to prevent sharing of cachelines between threads (performance). Gets rid of gcc-7.1 warning about using c++17's over-aligned new feature. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 6 +++---

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-06 20:52 GMT+02:00 Robert Foss : > On Wed, 2017-07-05 at 08:46 -0600, Brian Paul wrote: >> On 07/05/2017 12:57 AM, Robert Foss wrote: >> > Add local strlcpy implementation. >> > >> > Signed-off-by: Robert Foss >> > --- >> > Changes

Re: [Mesa-dev] [PATCH 1/3] swr/rast: _mm*_undefined_* implementations for gcc<4.9

Reviewed-by: Bruce Cherniak > On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote: > > Define these in terms of setzero for ancient gcc versions which don't > have the undefined intrinsics. > > Cc: mesa-sta...@lists.freedesktop.org > --- >

Re: [Mesa-dev] [PATCH 3/3] swr/rast: remove unused variables

Reviewed-by: Bruce Cherniak > On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 -- > src/gallium/drivers/swr/rasterizer/jitter/streamout_jit.cpp | 2 -- > 2 files

[Mesa-dev] [PATCH 6/6] radv: don't lower indirect derefs

From: Connor Abbott Radeonsi doesn't either. As of the last commit, these should be handled properly as long as LLVM has scratch support. We also should use nir_lower_io_to_temporaries() for inputs instead of generating an if-ladder, since that should be more efficient. ---

[Mesa-dev] [PATCH 5/6] radv: reorder and add passes to match i965

From: Connor Abbott This makes the radv shader pipeline much closer to brw_preprocess_nir(). The main changes are: - Now we call nir_split_var_copies(), which is necessary for nir_lower_var_copies() to work correctly. The SPIR-V frontend never generates variable copies, so

[Mesa-dev] [PATCH 4/6] ac/nir: rewrite shared variable handling

From: Connor Abbott Similar to before, do the direct NIR->LLVM translation instead of lowering to an array then back to a variable. This should fix indirect dereferences, make shared variables more tightly packed, and make LLVM's alias analysis more precise. ---

Re: [Mesa-dev] [PATCH 1/8] mesa: check for allocation failures in _mesa_new_texture_object()

It looks like we could want patches 1 and 3-8 from this series into -stable (?) On Wed, 2017-06-21 at 11:04 +0200, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/texobj.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

On Wed, 2017-07-05 at 08:46 -0600, Brian Paul wrote: > On 07/05/2017 12:57 AM, Robert Foss wrote: > > Add local strlcpy implementation. > > > > Signed-off-by: Robert Foss > > --- > > Changes since v5: > >    Actually include changes from v5 in patch > > > > Changes

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

On Thu, Jul 6, 2017 at 2:37 PM, Andres Gomez wrote: > It looks like we could want this into -stable (?) Yes, I think so. Alex > > On Thu, 2017-07-06 at 21:10 +0300, Andres Gomez wrote: >> On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: >> > From: Chandu Babu N

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

> On Jul 5, 2017, at 19:09, Dave Airlie wrote: > > From: Dave Airlie > > Use family, but only set xnack+ for gfx9. > The driver shouldn’t be explicitly setting this. This should be set as part of the subtarget chosen -Matt

[Mesa-dev] [PATCH] radv: don't overallocate depth/stencil formats

From: Dave Airlie For depth/stencil formats the surface layer allocates the stencil separately, so we don't need to include it in the bpe. This reduces the side of d32s8 allocates to something closer to pro. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: > From: Chandu Babu N > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures >   > sampler view allocated in vaAssociateSubpicture is not cleared > in vaiDeassociateSubpicture. >   > Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH 1/4] radeonsi: fix DCC fast clear for luminance and alpha formats

Marek, would we want this series in -stable or we shouldn't bother ? On Tue, 2017-06-20 at 19:06 +0200, Marek Olšák wrote: > From: Marek Olšák > > I reproduced this bug on Polaris11 and Raven. > > I can't get this bug on Fiji. The reason might be that Fiji doesn't use > 2D

Re: [Mesa-dev] [PATCH 2/3] swr/rast: don't use _mm256_fmsub_ps in AVX code

Reviewed-by: Bruce Cherniak > On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] swr/rast: Correctly allocate SWR_STATS memory as cacheline aligned

Reviewed-by: Bruce Cherniak > On Jul 6, 2017, at 1:55 PM, Tim Rowley wrote: > > Cacheline alignment of SWR_STATS to prevent sharing of cachelines > between threads (performance). > > Gets rid of gcc-7.1 warning about using c++17's

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: > From: Dave Airlie > > Use family, but only set xnack+ for gfx9. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_llvm_util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

It looks like we could want this into -stable (?) On Thu, 2017-07-06 at 21:10 +0300, Andres Gomez wrote: > On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: > > From: Chandu Babu N > > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures > >   > > sampler view

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

> On Jul 6, 2017, at 13:08, Dave Airlie wrote: > > On 7 July 2017 at 05:07, Matt Arsenault wrote: >> >>> On Jul 5, 2017, at 19:09, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> Use family, but only set

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] mesa/main: Move NULL pointer check.

On 6 July 2017 at 15:35, Andres Gomez wrote: > It looks like we could want this into -stable (?) > _mesa_update_draw_buffer_bounds is a no-op if the buffer pointer is NULL. There's no issue to fix, but making Coverity happy is not a bad idea either ;-) -Emil

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On Thu, Jul 6, 2017 at 1:13 PM, Jan Vesely wrote: > On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> Use family, but only set xnack+ for gfx9. >> >> Signed-off-by: Dave Airlie >> --- >>

[Mesa-dev] [PATCH mesa] build systems: move git_sha1_gen.sh to bin/

There was no reason for this script to live outside the scripts directory. Suggested-by: Brian Paul Signed-off-by: Eric Engestrom --- Makefile.am| 2 +- git_sha1_gen.sh => bin/git_sha1_gen.sh | 2 +- src/Makefile.am

[Mesa-dev] [PATCH 0/6] radv: Rewrite local & shared variable handling

From: Connor Abbott This series grew out of trying to get rid of the copy-n-pasted index calculation code in radv's NIR-to-LLVM path, in particular in radv_get_deref_offset(). I realized for IO it's probably better to switch to using nir_lower_io after Nicolai's series, but

[Mesa-dev] [PATCH 1/6] nir: don't segfault when printing variables with no name

From: Connor Abbott While normally we give variables whose name field is NULL a temporary name when called from nir_print_shader(), when we were calling from nir_print_instr() we never bothered, meaning that we just segfaulted when trying to print out instructions with such

[Mesa-dev] [PATCH 3/6] ac/nir: rewrite local variable handling

From: Connor Abbott The old way was very TGSI-based, and couldn't handle indirect dereferences at all. Instead, pass through the type information NIR has about local variables to LLVM, and translate NIR dereferences directly into the equivalent GEP instructions in LLVM. ---

[Mesa-dev] [PATCH 2/6] nir/lower_io_to_temporaries: don't set compact on shadow vars

From: Connor Abbott The compact flag doesn't make sense on local variables, since the packing on them is up to the driver. This fixes nir_validate assertions in some cases, particularly when lower_io_to_temporaries is used on per-vertex inputs/outputs. ---

Re: [Mesa-dev] [PATCH 1/3] st/mesa: find proper mipmap level in st_ClearTexSubImage()

>From: Brian Paul >To: >CC: Neha Bhende >The Piglit arb_clear_texture-error test creates a texture with only >a 1x1 image at level=1, then tries to clear level 0 (non-existant) s/non-existant/non-existent/ >and level 1

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On 7 July 2017 at 05:07, Matt Arsenault wrote: > >> On Jul 5, 2017, at 19:09, Dave Airlie wrote: >> >> From: Dave Airlie >> >> Use family, but only set xnack+ for gfx9. >> > > The driver shouldn’t be explicitly setting this. This should

[Mesa-dev] [PATCH] st/dri: always initialize 'opencl_func_mutex' in struct dri_screen

The 'opencl_func_mutex' is destroyed in dri_destroy_screen_helper() unconditionally, so make sure it is always initialized to avoid any undefined behaviour. Signed-off-by: Aleksander Morgado --- src/gallium/state_trackers/dri/dri2.c | 1 +

Re: [Mesa-dev] [PATCH 3/6] ac/nir: rewrite local variable handling

On Thu, Jul 6, 2017 at 9:48 PM, Connor Abbott wrote: > From: Connor Abbott > > The old way was very TGSI-based, and couldn't handle indirect > dereferences at all. Instead, pass through the type information NIR has I think the old code should

[Mesa-dev] [PATCH] radv/ac: drop setting xnack

From: Dave Airlie Since radv uses compute rings and we can't know when we are setting up the shaders what ring they are to be used on, we should just use the default xnack setting. This may be suboptimal in some places, but if we hit a problem, we likely should try and

Re: [Mesa-dev] [PATCH 0/6] radv: Rewrite local & shared variable handling

On 6 July 2017 at 22:20, Connor Abbott wrote: > On Thu, Jul 6, 2017 at 12:48 PM, Connor Abbott > wrote: >> From: Connor Abbott >> >> This series grew out of trying to get rid of the copy-n-pasted index >> calculation code in

Re: [Mesa-dev] [PATCH] radv/ac: drop setting xnack

Reviewed-by: Bas Nieuwenhuizen On Fri, Jul 7, 2017 at 12:10 AM, Dave Airlie wrote: > From: Dave Airlie > > Since radv uses compute rings and we can't know when we are setting > up the shaders what ring they are to be used on, we

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On Thu, Jul 6, 2017 at 8:12 PM, Alex Deucher wrote: > On Thu, Jul 6, 2017 at 1:13 PM, Jan Vesely wrote: >> On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> Use family, but only set xnack+ for

Re: [Mesa-dev] [PATCH 1/4] radeonsi: fix DCC fast clear for luminance and alpha formats

On Thu, Jul 6, 2017 at 8:24 PM, Andres Gomez wrote: > Marek, would we want this series in -stable or we shouldn't bother ? Don't bother. Patch 1 isn't that important. Other patches are for features not enabled in 17.1. Marek ___

Re: [Mesa-dev] [PATCH 6/6] radv: don't lower indirect derefs

On Thu, Jul 6, 2017 at 9:50 PM, Connor Abbott wrote: > From: Connor Abbott > > Radeonsi doesn't either. As of the last commit, these should be handled > properly as long as LLVM has scratch support. We also should use >

Re: [Mesa-dev] [PATCH mesa] build systems: move git_sha1_gen.sh to bin/

LGTM. Reviewed-by: Brian Paul On 07/06/2017 02:08 PM, Eric Engestrom wrote: There was no reason for this script to live outside the scripts directory. Suggested-by: Brian Paul Signed-off-by: Eric Engestrom --- Makefile.am

Re: [Mesa-dev] [PATCH 0/6] radv: Rewrite local & shared variable handling

On Thu, Jul 6, 2017 at 12:48 PM, Connor Abbott wrote: > From: Connor Abbott > > This series grew out of trying to get rid of the copy-n-pasted index > calculation code in radv's NIR-to-LLVM path, in particular in > radv_get_deref_offset(). I

Re: [Mesa-dev] [PATCH 09/19] radeonsi: add basic memory object support

On 2017-07-04 12:39 PM, Andres Rodriguez wrote: On 2017-07-04 09:30 AM, Christian König wrote: Am 04.07.2017 um 15:13 schrieb Nicolai Hähnle: On 01.07.2017 01:03, Andres Rodriguez wrote: From: Dave Airlie Signed-off-by: Andres Rodriguez ---

Re: [Mesa-dev] [PATCH 2/6] nir/lower_io_to_temporaries: don't set compact on shadow vars

Reviewed-by: Jason Ekstrand On Thu, Jul 6, 2017 at 12:48 PM, Connor Abbott wrote: > From: Connor Abbott > > The compact flag doesn't make sense on local variables, since the > packing on them is up to the driver. This fixes

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On Thu, Jul 6, 2017 at 10:14 PM, Matt Arsenault wrote: > >> On Jul 6, 2017, at 13:08, Dave Airlie wrote: >> >> On 7 July 2017 at 05:07, Matt Arsenault wrote: >>> On Jul 5, 2017, at 19:09, Dave Airlie wrote:

Re: [Mesa-dev] [PATCH 1/6] nir: don't segfault when printing variables with no name

Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 9:48 PM, Connor Abbott wrote: > From: Connor Abbott > > While normally we give variables whose name field is NULL a temporary > name when called from

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

On Thu, Jul 6, 2017 at 4:56 PM, Marek Olšák wrote: > On Thu, Jul 6, 2017 at 8:12 PM, Alex Deucher wrote: >> On Thu, Jul 6, 2017 at 1:13 PM, Jan Vesely wrote: >>> On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: From:

Re: [Mesa-dev] [PATCH 3/6] ac/nir: rewrite local variable handling

On Thu, Jul 6, 2017 at 2:01 PM, Bas Nieuwenhuizen wrote: > On Thu, Jul 6, 2017 at 9:48 PM, Connor Abbott > wrote: >> From: Connor Abbott >> >> The old way was very TGSI-based, and couldn't handle indirect >> dereferences

Re: [Mesa-dev] [PATCH 5/6] radv: reorder and add passes to match i965

Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 9:50 PM, Connor Abbott wrote: > From: Connor Abbott > > This makes the radv shader pipeline much closer to brw_preprocess_nir(). > The main changes are: > > - Now we

Re: [Mesa-dev] [PATCH 4/6] ac/nir: rewrite shared variable handling

Patches 3-4 look technically correct to me, so for just using it for shared vars Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 9:48 PM, Connor Abbott wrote: > From: Connor Abbott > > Similar to before, do the direct

[Mesa-dev] [PATCH] etnaviv: fix refcnt initialization in etna_screen

Despite being a member of the etna_screen struct, 'refcnt' is used by the winsys-specific logic to track the reference count of the object managed in a hash table. When the count reaches zero, the pipe screen is removed from the table and destroyed. Fix the logic by initializing the refcnt to 1

[Mesa-dev] [PATCH] radv: don't overallocate 5 bpe formats (d32/s8)

From: Dave Airlie This was getting passed into the ac_surface code, and used to calculate bpp for the surface, however in this case the bpe is really only 4, the surface code will allocate stencil separately. This reduces the side of d32s8 allocates to something closer to

[Mesa-dev] [Bug 101703] No stencil buffer allocated when requested by GLUT

https://bugs.freedesktop.org/show_bug.cgi?id=101703 Bug ID: 101703 Summary: No stencil buffer allocated when requested by GLUT Product: Mesa Version: 17.0 Hardware: All OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 1/4] ac/radv: change api to create target machine

Series is Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 4:09 AM, Dave Airlie wrote: > From: Dave Airlie > > This just modifies the API to make it easier to add other flags > to target machine creation. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] scons: Check for xlocale.h before defining HAVE_XLOCALE_H.

On 5 July 2017 at 22:25, Vinson Lee wrote: > glibc 2.26 removed xlocale.h. > https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27 > > Fix this build error with glibc 2.26. > > Compiling src/util/strtod.c ... > src/util/strtod.c:32:10: fatal error:

Re: [Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

On 6 July 2017 at 02:18, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 2:49 AM, Emil Velikov wrote: >> Hi Tomasz, >> >> On 5 July 2017 at 15:58, Tomasz Figa wrote: >>> Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.")

[Mesa-dev] [PATCH 2/2] i965: perf: use new subslices numbers from device info

Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 49 --- 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c

[Mesa-dev] [PATCH 1/2] intel: add number of subslices to device info

We could have used a single integer to store that value, but Cannonlake has different number of subslices per slice depending on the GT. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 54 --

Re: [Mesa-dev] [PATCH] etnaviv: don't dereference etna_resource pointer if allocation fails

2017-07-06 11:35 GMT+02:00 Aleksander Morgado : > The check for the pointer being non-NULL was being done too late. > > Signed-off-by: Aleksander Morgado Reviewed-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH 01/10] egl: move eglCreateDRMImageMESA's malloc later

On 30 June 2017 at 12:56, Daniel Stone wrote: > Hi Emil, > > On 30 June 2017 at 12:15, Emil Velikov wrote: >> Kristian can you shed some light? The extension seems quite sparse. >> >> Weston used the extension back in 2011. While the Glamor bit

Re: [Mesa-dev] [RFC] travis: lower SWR requirement to GCC 4.8, aka std=c++11

On 5 July 2017 at 19:28, Rowley, Timothy O wrote: > >> On Jul 4, 2017, at 12:01 PM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> With ealier commit we relaxed the requirement from C++14 to C++11. >> Update

Re: [Mesa-dev] [PATCH 5/7] i965: Assert that we don't use CPU write maps to non-coherent buffers.

Quoting Kenneth Graunke (2017-07-05 21:56:52) > Using CPU maps of non-coherent buffers can get us in a lot of trouble, > and WC maps are a reasonable alternative anyway. Guard against shooting > ourselves in the foot by adding an assert, and comment. Reviewed-by: Chris Wilson

Re: [Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

Quoting Kenneth Graunke (2017-07-05 21:56:53) > diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > b/src/mesa/drivers/dri/i965/intel_buffer_objects.c > index a9ac29a6a81..2b0f7b9a698 100644 > --- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > +++

[Mesa-dev] [Bug 101703] No stencil buffer allocated when requested by GLUT

https://bugs.freedesktop.org/show_bug.cgi?id=101703 Eric Engestrom changed: What|Removed |Added Attachment #132472|0 |1 is

[Mesa-dev] [PATCH] etnaviv: don't dereference etna_resource pointer if allocation fails

The check for the pointer being non-NULL was being done too late. Signed-off-by: Aleksander Morgado --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

Check if shaders have transform feedback varyings also after the post-link step. This fixes: KHR-GL45.enhanced_layouts.xfb_vertex_streams piglit/spec/arb_enhanced_layouts/gs-stream-location-aliasing --- src/compiler/glsl/glsl_to_nir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 01/10] egl: move eglCreateDRMImageMESA's malloc later

On Friday, 2017-06-30 12:15:11 +0100, Emil Velikov wrote: > From: Emil Velikov > > Don't bother allocating any memory until we're finished parsing and > sanitising all the attributes. > > As a nice side effect we now consistently set eglError when any of > the

Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

It looks like we could want this into -stable (?) On Fri, 2017-06-16 at 12:05 +0200, Iago Toral Quiroga wrote: > The current implementation assumed that these were replaced in GLSL >= 4.10 > by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both > built-ins should be produced

Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

Yes, I think so, thanks Andres. Iago On Thu, 2017-07-06 at 16:45 +0300, Andres Gomez wrote: > It looks like we could want this into -stable (?) > > On Fri, 2017-06-16 at 12:05 +0200, Iago Toral Quiroga wrote: > > The current implementation assumed that these were replaced in GLSL > > >= 4.10 >

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

Hello, On Tue, Jun 27, 2017 at 5:47 PM, Christian Gmeiner wrote: > 2017-06-27 17:39 GMT+02:00 Wladimir J. van der Laan : >> On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: >> >>> > sure if we should advertise the broken

Re: [Mesa-dev] [PATCH 1/3] mesa/main: Move NULL pointer check.

It looks like we could want this into -stable (?) On Wed, 2017-06-14 at 19:33 +0300, Plamena Manolova wrote: > In blit_framebuffer we're already doing a NULL > pointer check for readFb and drawFb so it makes > sense to do it before we actually use the pointers. > > CID: 1412569 > Signed-off-by:

[Mesa-dev] [PATCH 2/2] gallium: Implement wglUseFontBitmaps.

wglUseFontBitmaps is currently a noop. This patch implements this function for Windows. Signed-off-by: Olivier Lauffenburger --- src/gallium/state_trackers/wgl/stw_wgl.c | 50 1 file changed, 44 insertions(+), 6 deletions(-) diff

Re: [Mesa-dev] [PATCH] scons: Check for xlocale.h before defining HAVE_XLOCALE_H.

On Wednesday, 2017-07-05 21:25:12 +, Vinson Lee wrote: > glibc 2.26 removed xlocale.h. > https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27 > > Fix this build error with glibc 2.26. > > Compiling src/util/strtod.c ... > src/util/strtod.c:32:10: fatal error:

[Mesa-dev] [PATCH 3/3] mesa: fix glPrimitiveRestartNV crash inside a render list.

glPrimitiveRestartNV crashes when it is called during the compilation of a render list. There are two reasons: - ctx->Driver.CurrentSavePrimitive is not set to the current primitive - save_PrimitiveRestartNV() calls _save_Begin() which only sets an OpenGL error, instead of calling

[Mesa-dev] [PATCH] gallium: improve selection of pixel format

Current selection of pixel format does not enforce the request of stencil or depth buffer if the color depth is not the same as requested. For instance, GLUT requests a 32-bit color buffer with an 8-bit stencil buffer, but because color buffers are only 24-bit, no priority is given to creating a

Re: [Mesa-dev] [PATCH 09/10] egl: enhance KHR_gl_image extensions checks

On Friday, 2017-06-30 12:15:19 +0100, Emil Velikov wrote: > From: Emil Velikov > > Drop the (duplicate) top-level check in dri2_create_image_khr() and add > the respective checks in dri2_create_image_khr_{texture,renderbuffer} > > Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 3/3] swr/rast: remove unused variables

--- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 -- src/gallium/drivers/swr/rasterizer/jitter/streamout_jit.cpp | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp

[Mesa-dev] [PATCH 1/3] swr/rast: _mm*_undefined_* implementations for gcc<4.9

Define these in terms of setzero for ancient gcc versions which don't have the undefined intrinsics. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/swr/rasterizer/common/os.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h

[Mesa-dev] [PATCH 2/3] swr/rast: don't use _mm256_fmsub_ps in AVX code

--- src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl b/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl index aec79e3..16eb521 100644

Re: [Mesa-dev] [RFC] travis: lower SWR requirement to GCC 4.8, aka std=c++11

On Jul 6, 2017, at 5:39 AM, Emil Velikov > wrote: On 5 July 2017 at 19:28, Rowley, Timothy O > wrote: On Jul 4, 2017, at 12:01 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 09/10] egl: enhance KHR_gl_image extensions checks

On 6 July 2017 at 15:45, Eric Engestrom wrote: > On Friday, 2017-06-30 12:15:19 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Drop the (duplicate) top-level check in dri2_create_image_khr() and add >> the respective checks in

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

https://bugs.freedesktop.org/show_bug.cgi?id=101709 Bug ID: 101709 Summary: [llvmpipe] piglit gl-1.0-scissor-offscreen regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH 2/2] anv/image: Disable CCS if the image doesn't support rendering

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index c84fc8ddea..df505ce8f0 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH 1/2] Revert "intel/isl: Only create a CCS buffer if the image supports rendering"

This reverts commit 8aaa13467dc289d35dc7900ab9fab9a7689c4178, which was based on an incorrect assumption. Unlike the restriction placed on image views in the Vulkan API, OpenGL allows you to render to texture views whose formats differ from the originals. Bugzilla:

Re: [Mesa-dev] [PATCH 16/20] nir: Add a ballot32 intrinsic

I've thought about this a little bit, and I think we'd rather just decrease the bitsize of the intrinsic rather than add a whole new one. The separate intrinsic isn't really buying you anything, I don't think it's going to make anything simpler. On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner

Re: [Mesa-dev] [PATCH 03/20] nir: Support lowering vote intrinsics

On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > ... trivially (as allowed by the spec!) by reusing the existing > nir_opt_intrinsics code. > --- > src/compiler/nir/nir.h| 4 > src/compiler/nir/nir_opt_intrinsics.c | 6 +++--- > 2 files changed, 7

[Mesa-dev] [PATCH] loader/dri3: Use dri3_find_back in loader_dri3_swap_buffers_msc

From: Thomas Hellstrom If the application hasn't done any drawing since the last call, we would reuse the same back buffer which was used for the previous swap, which may not have completed yet. This could result in various issues such as tearing or application hangs. In

[Mesa-dev] [PATCH 04/25] gallium: introduce memory object v2

From: Dave Airlie v2: fix comment regarding fd ownership, define pipe_memory_object --- src/gallium/drivers/ddebug/dd_screen.c | 40 ++ src/gallium/include/pipe/p_screen.h| 36 ++

[Mesa-dev] [PATCH 05/25] mesa/st: start adding memory object support v2

From: Dave Airlie v2: pass dedicated flag Signed-off-by: Andres Rodriguez --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_memoryobjects.c | 66

[Mesa-dev] [PATCH 01/25] mapi: add EXT_external_objects and EXT_external_objects_fd

Includes implementation stubs. Signed-off-by: Andres Rodriguez --- src/mapi/glapi/gen/EXT_external_objects.xml| 234 + src/mapi/glapi/gen/EXT_external_objects_fd.xml | 28 +++ src/mapi/glapi/gen/Makefile.am | 2 +

[Mesa-dev] [PATCH] Initial support for EXT_external_objects v2

This series is an initial step towards the implementation of EXT_external_objects. It implements the functionality under EXT_memory_object and EXT_memory_object_fd. This updated version of the series has the following changes: * Re-worked UUIDs to be provided by the gallium driver * Use a

[Mesa-dev] [PATCH 02/25] mesa: add support for memory object creation/import/delete

Used by EXT_external_objects and EXT_external_objects_fd Signed-off-by: Andres Rodriguez --- src/mesa/drivers/common/driverfuncs.c | 4 + src/mesa/main/dd.h| 36 + src/mesa/main/externalobjects.c | 145 +-

[Mesa-dev] [PATCH 03/25] mesa: add support for memory object parameters

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 54 - src/mesa/main/mtypes.h | 5 +++- 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/externalobjects.c

[Mesa-dev] [PATCH 20/25] mesa: hook up queries for NUM_TILING_TYPES and TILING_TYPES

These are just basic implementations. Signed-off-by: Andres Rodriguez --- src/mesa/main/formatquery.c | 17 + src/mesa/main/mtypes.h | 3 +++ src/mesa/main/texparam.c| 27 +++ 3 files changed, 47 insertions(+) diff --git

[Mesa-dev] [PATCH 22/25] radv: rename physical_device->uuid[] to cache_uuid[]

We have a few UUIDs, so lets be more specific. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_pipeline_cache.c | 4 ++-- src/amd/vulkan/radv_private.h| 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 21/25] mesa: fix error handling for memory objects

Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 63 + 1 file changed, 51 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index 919a81c..73c9d4b 100644

[Mesa-dev] [PATCH 18/25] ac/gpu: add driver/device UUID query helpers

We need vulkan and gl to produce the same UUIDs. Therefore we should keep the mechanism to compute these in a common location to guarantee they are updated in lockstep. Signed-off-by: Andres Rodriguez --- src/amd/common/ac_gpu_info.c | 27 +++

[Mesa-dev] [PATCH 19/25] radeonsi: hook up device/driver UUID queries

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index fd67d9a..c14d4eb 100644

[Mesa-dev] MRT rendering speed up from the pro driver

Hi, Hopefully someone in here can help with this, and maybe ask the internal Vulkan team how this works. I've been looking into a large perf cliff in radv vs pro when MRT rendering is enabled (I didn't know that was what I was looking for until today - about 2-3 weeks ago I was just digging

[Mesa-dev] [PATCH 23/25] radv: generate same device UUID as radeonsi v2

This is required for interop use cases. The same device must report identical UUIDs through the GL and Vulkan APIs so that users can identify when it is safe to perform a memory object import. v2: use ac helpers to calculate the uuid Signed-off-by: Andres Rodriguez ---

[Mesa-dev] [PATCH 16/25] gallium: introduce device/driver UUID queries

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_screen.c | 17 + src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include/pipe/p_screen.h| 13 + 3 files changed, 31 insertions(+) diff --git

[Mesa-dev] [PATCH 24/25] radv: generate the same driver UUID as radeonsi

These need to match for interop compatibility queries. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 9 - src/amd/vulkan/radv_private.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 25/25] radeonsi: enable support for EXT_memory_object

Signed-off-by: Andres Rodriguez --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index

  1   2   >