[Mesa-dev] [Bug 101941] Getting different output depending on attribute declaration order

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101941 Bug ID: 101941 Summary: Getting different output depending on attribute declaration order Product: Mesa Version: git Hardware: All OS: Linux (All)

[Mesa-dev] [Bug 101930] High memory usage in KDE

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101930 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH] radeonsi: update dirty_level_mask only when flushing or unbinding framebuffer

2017-07-26 Thread Marek Olšák
From: Marek Olšák This fixes corruption with bindless textures in Dawn Of War 3. The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask was only updated after the first draw call. The problem is bindless textures are checked for decompression every draw

[Mesa-dev] [PATCH 02/24] mesa: add support for memory object creation/import/delete

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Used by EXT_external_objects and EXT_external_objects_fd V2 (Timothy Arceri): - Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT() fails. - C99 tidy ups - remove void cast (Constantine Kharlamov) Signed-off-by: Andres Rodriguez

[Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Timothy Arceri
Hi all, Andres is not around at the moment so as well are reviewing the remaining patches I've rebased and added all Marek's suggestions. I've also made a few minor changes (see commit messages) and reworked some of the patches to reduce code churn. I thought I'd send it out one last time to

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Marek Olšák
On Wed, Jul 26, 2017 at 8:29 AM, Michel Dänzer wrote: > On 25/07/17 05:28 PM, Nicolai Hähnle wrote: >> On 22.07.2017 14:00, Daniel Stone wrote: >>> >>> I don't have any great solution off the top of my head, but I'd be >>> inclined to bundle stride in with placement. TTBOMK

Re: [Mesa-dev] [PATCH v2 2.5/5] radeonsi: make sure TCS main output VGPRs don't alias inputs

2017-07-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 26, 2017 at 1:56 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Avoids an unnecessary move introduce by "radeonsi/gfx9: always wrap GS > and TCS in an if-block (v2)" > --- >

Re: [Mesa-dev] [PATCH] ac/surface: fix hybrid graphics where APU=GFX9, dGPU=older

2017-07-26 Thread Nicolai Hähnle
On 25.07.2017 18:38, Marek Olšák wrote: From: Marek Olšák Cc: 17.2 Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_surface.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Nicolai Hähnle
On 26.07.2017 08:29, Michel Dänzer wrote: On 25/07/17 05:28 PM, Nicolai Hähnle wrote: On 22.07.2017 14:00, Daniel Stone wrote: I don't have any great solution off the top of my head, but I'd be inclined to bundle stride in with placement. TTBOMK (from having looked at radv), buffers shared

Re: [Mesa-dev] [PATCH] radeonsi: update dirty_level_mask only when flushing or unbinding framebuffer

2017-07-26 Thread Samuel Pitoiset
Thanks for the fix, it is better than mine. :-) Tested-by: Samuel Pitoiset On 07/26/2017 03:03 PM, Marek Olšák wrote: From: Marek Olšák This fixes corruption with bindless textures in Dawn Of War 3. The do_update_surf_dirtiness mechanism was

Re: [Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

2017-07-26 Thread Emil Velikov
On 26 July 2017 at 08:59, Grigori Goronzy wrote: > On 2017-07-19 23:51, Grigori Goronzy wrote: >> >> The check is too aggressive and might also fail if context flags >> appear after the no-error attribute in the context attribute list. >> >> Delay the check to after attribute

[Mesa-dev] [PATCH 24/24] radeonsi: enable support for EXT_memory_object

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez v2: fix an indentation error v3: don't enable for r600 Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák Reviewed-by: Timothy Arceri --- src/gallium/drivers/radeonsi/si_pipe.c |

[Mesa-dev] [PATCH 22/24] radv: generate same device UUID as radeonsi

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez This is required for interop use cases. The same device must report identical UUIDs through the GL and Vulkan APIs so that users can identify when it is safe to perform a memory object import. v2: use ac helpers to calculate the uuid Signed-off-by:

[Mesa-dev] [PATCH 17/24] gallium: introduce device/driver UUID queries

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez v2: remove unnecessary returns Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/ddebug/dd_screen.c | 17 + src/gallium/include/pipe/p_defines.h | 1 +

[Mesa-dev] [PATCH 21/24] mesa: hook up queries for NUM_TILING_TYPES and TILING_TYPES

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez These are just basic implementations. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/formatquery.c | 17 + src/mesa/main/mtypes.h | 3 +++

[Mesa-dev] [PATCH 23/24] radv: generate the same driver UUID as radeonsi

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez These need to match for interop compatibility queries. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/amd/vulkan/radv_device.c | 9 - src/amd/vulkan/radv_private.h | 1 + 2

[Mesa-dev] [PATCH v2 2/5] radeonsi/gfx9: always wrap GS and TCS in an if-block (v2)

2017-07-26 Thread Nicolai Hähnle
From: Nicolai Hähnle With merged ESGS shaders, the GS part of a wave may be empty, and the hardware gets confused if any GS messages are sent from that wave. Since S_SENDMSG is executed even when EXEC = 0, we have to wrap even non-monolithic GS shaders in an if-block, so

[Mesa-dev] [PATCH v2 2.5/5] radeonsi: make sure TCS main output VGPRs don't alias inputs

2017-07-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoids an unnecessary move introduce by "radeonsi/gfx9: always wrap GS and TCS in an if-block (v2)" --- src/gallium/drivers/radeonsi/si_shader.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 2/5] radeonsi/gfx9: always wrap GS and TCS in an if-block (v2)

2017-07-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 26, 2017 at 1:56 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > With merged ESGS shaders, the GS part of a wave may be empty, and the > hardware gets confused if any GS messages

[Mesa-dev] [PATCH 07/24] mesa: hook up memory object multisamples tex(ture)storage api

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/externalobjects.c | 52 src/mesa/main/teximage.c| 75

[Mesa-dev] [PATCH 09/24] mesa/st: implement memory objects as a backend for texture storage

2017-07-26 Thread Timothy Arceri
From: Dave Airlie Instead of allocating memory to back a texture, use the provided memory object. v2: split off extension exposure logic v3: de-duplicate code with st_AllocTextureStorage Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH 01/24] mapi: add EXT_external_objects and EXT_external_objects_fd

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Includes implementation stubs. Signed-off-by: Andres Rodriguez Acked-by: Timothy Arceri --- src/mapi/glapi/gen/EXT_external_objects.xml| 234 ++

[Mesa-dev] [PATCH 06/24] mesa: hook up memoryobject tex(ture)storage api

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez V2 (Timothy Arceri): - formating fixes Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h | 9 +++ src/mesa/main/externalobjects.c | 129

[Mesa-dev] [PATCH 15/24] mesa/st: expose EXT_memory_object and EXT_memory_object_fd

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez v2: use PIPE_CAP_MEMOBJ to guard the extension Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/extensions_table.h | 2 ++ src/mesa/main/mtypes.h | 2 ++

[Mesa-dev] [PATCH 13/24] mesa: hook up (Named)BufferStorageMem api

2017-07-26 Thread Timothy Arceri
Include no_error variants as well. v2 (Timothy Arceri): - reduced code churn by squashing some changes into previous commits Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/bufferobj.c | 62

[Mesa-dev] [PATCH 14/24] gallium: introduce PIPE_CAP_MEMOBJ

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez This can be used to guard support for EXT_memory_object and related extensions. v2: update gallium docs Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/docs/source/screen.rst

[Mesa-dev] [PATCH 20/24] radeonsi: hook up device/driver UUID queries

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez v2: move from r600_common to radeonsi Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[Mesa-dev] [PATCH 19/24] ac/gpu: add driver/device UUID query helpers

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez We need vulkan and gl to produce the same UUIDs. Therefore we should keep the mechanism to compute these in a common location to guarantee they are updated in lockstep. Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH 03/24] mesa: add support for memory object parameters

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez V2 (Timothy Arceri): - fix copy and paste error with error message Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/externalobjects.c | 52

[Mesa-dev] [PATCH 05/24] mesa/st: start adding memory object support

2017-07-26 Thread Timothy Arceri
From: Dave Airlie v2: pass dedicated flag Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_memoryobjects.c | 66

[Mesa-dev] [PATCH 04/24] gallium: introduce memory object

2017-07-26 Thread Timothy Arceri
From: Dave Airlie v2: fix comment regarding fd ownership, define pipe_memory_object v3: remove stray return Reviewed-by: Marek Olšák --- src/gallium/drivers/ddebug/dd_screen.c | 40 ++ src/gallium/include/pipe/p_screen.h

[Mesa-dev] [PATCH 12/24] mesa/st: implement memory objects as a backend for buffer objects

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Use a memory object instead of user memory. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h | 12 +

[Mesa-dev] [PATCH 11/24] radeonsi: add basic memory object support

2017-07-26 Thread Timothy Arceri
From: Dave Airlie v2: also consider gfx9 metadata v3: ref/unref memobj->buf v4: add refcount comment Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++

[Mesa-dev] [PATCH 08/24] mesa/st: factor out st_AllocTextureStorage into a helper

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Plumbing for using memory objects as texture storage. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_cb_texture.c |

[Mesa-dev] [PATCH 10/24] radeonsi: factor out metadata import

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez Plumbing for importing memobj backed textures. Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 63 ++- 1 file changed, 36

[Mesa-dev] [PATCH 16/24] mesa: implement glGetUnsignedByte{v|i_v}

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez These are used by EXT_external_objects to present UUIDs for the device and the driver. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/get.c | 177

[Mesa-dev] [PATCH 18/24] mesa: hook up UUID queries for driver and device

2017-07-26 Thread Timothy Arceri
From: Andres Rodriguez v2: respective changes for new gallium interface v3: fix UUID size asserts Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h | 15 +++

Re: [Mesa-dev] [PATCH] radv/ac: realign SI workaround with radeonsi.

2017-07-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 26, 2017 at 3:34 AM, Dave Airlie wrote: > From: Dave Airlie > > This ports: da7453666ae > radeonsi: don't apply the Z export bug workaround to Hainan > to radv. > > Just noticed in

Re: [Mesa-dev] [PATCH] radv/winsys: fix padding command stream for SI

2017-07-26 Thread Dave Airlie
On 26 Jul. 2017 17:25, "Bas Nieuwenhuizen" wrote: On Wed, Jul 26, 2017 at 4:29 AM, Dave Airlie wrote: > From: Dave Airlie > > We were adding pad to size after creating the object, so we could > submit a CS bigger than the bo

Re: [Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

2017-07-26 Thread Grigori Goronzy
On 2017-07-19 23:51, Grigori Goronzy wrote: The check is too aggressive and might also fail if context flags appear after the no-error attribute in the context attribute list. Delay the check to after attribute parsing to fix this. --- This was found by the piglit test I just sent to the piglit

Re: [Mesa-dev] [PATCH 066/101] mesa: add draw_buffers_error() helper

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 04:10 AM, Timothy Arceri wrote: On 22/07/17 03:40, Samuel Pitoiset wrote: And make draw_buffers() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 223 ++-- 1 file changed,

Re: [Mesa-dev] [PATCH] radv/winsys: fix padding command stream for SI

2017-07-26 Thread Bas Nieuwenhuizen
On Wed, Jul 26, 2017 at 4:29 AM, Dave Airlie wrote: > From: Dave Airlie > > We were adding pad to size after creating the object, so we could > submit a CS bigger than the bo created for it. So while this is indeed pedantically more correct, I wonder what

Re: [Mesa-dev] [PATCH] radv/winsys: fix padding command stream for SI

2017-07-26 Thread Bas Nieuwenhuizen
Fair enough. Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 26, 2017 at 9:43 AM, Dave Airlie wrote: > > > On 26 Jul. 2017 17:25, "Bas Nieuwenhuizen" wrote: > > On Wed, Jul 26, 2017 at 4:29 AM, Dave Airlie

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Michel Dänzer
On 25/07/17 05:28 PM, Nicolai Hähnle wrote: > On 22.07.2017 14:00, Daniel Stone wrote: >> >> I don't have any great solution off the top of my head, but I'd be >> inclined to bundle stride in with placement. TTBOMK (from having >> looked at radv), buffers shared cross-GPU also need to be allocated

Re: [Mesa-dev] [PATCH] radv: implement SI/CIK compute shader regalloc hang workaround.

2017-07-26 Thread Bas Nieuwenhuizen
Per the comment, the correct fix for radv should be to limit workgroup size to 256 for SI/BONAIRE/KABINI? On Wed, Jul 26, 2017 at 4:56 AM, Dave Airlie wrote: > From: Dave Airlie > > This ports the regalloc hang workaround from radeonsi, not 100% > sure if

Re: [Mesa-dev] [PATCH] radv/ac: port SI TC L1 write corruption fix.

2017-07-26 Thread Bas Nieuwenhuizen
On Wed, Jul 26, 2017 at 3:38 AM, Dave Airlie wrote: > From: Dave Airlie > > This ports 72e46c988 to radv. > radeonsi: apply a TC L1 write corruption workaround for SI > > Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver) >

Re: [Mesa-dev] [PATCH 2/3] mesa: check default buffer object creation was successful

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 03:11 AM, Timothy Arceri wrote: --- src/mesa/main/shared.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/shared.c b/src/mesa/main/shared.c index 4bc93a7..27e8094 100644 --- a/src/mesa/main/shared.c +++ b/src/mesa/main/shared.c @@ -44,6 +44,9 @@

[Mesa-dev] [PATCH v2 5/6] radeonsi: use slot indexes for bindless handles

2017-07-26 Thread Samuel Pitoiset
Using VRAM address as bindless handles is not a good idea because we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize because it has no information about the pointer. Instead, use slots indexes like the existing descriptors. Note that we use fixed 16-dword slots for both samplers and

[Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

2017-07-26 Thread Samuel Pitoiset
Currently, when the array is full it is resized but it can grow over and over because we don't try to re-use descriptor slots. The idea is to maintain two simple lists which keep track of which slots is used and which ones have been deleted. When the array is resized, previously deleted slots can

[Mesa-dev] [PATCH v2 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

2017-07-26 Thread Samuel Pitoiset
A new pair of user SGPR is needed for loading the bindless descriptors from shaders. Because the descriptors are global for all stages, there is no need to add separate indices for GFX9. v2: - fix declaring new bindless parameter Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v2 3/6] radeonsi: only initialize dirty_mask when CE is used

2017-07-26 Thread Samuel Pitoiset
Looks like it's useless to initialize that field when CE is unused. This will also allow to declare more than 64 elements for the array of bindless descriptors. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 7 --- 1 file

[Mesa-dev] [PATCH v2 2/6] radeonsi: make some si_descriptors fields 32-bit

2017-07-26 Thread Samuel Pitoiset
The number of bindless descriptors is dynamic and we definitely have to support more than 256 slots. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_state.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 4/6] radeonsi: add si_emit_graphics_shader_pointers() helper

2017-07-26 Thread Samuel Pitoiset
To share common code between rw buffers and bindless descriptors. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 57 +++ 1 file changed, 31 insertions(+), 26 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 04/24] gallium: introduce memory object

2017-07-26 Thread Samuel Pitoiset
Trace needs to be updated as well. On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Dave Airlie v2: fix comment regarding fd ownership, define pipe_memory_object v3: remove stray return Reviewed-by: Marek Olšák ---

Re: [Mesa-dev] [PATCH 12/24] mesa/st: implement memory objects as a backend for buffer objects

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez Use a memory object instead of user memory. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h |

Re: [Mesa-dev] [PATCH 17/24] gallium: introduce device/driver UUID queries

2017-07-26 Thread Samuel Pitoiset
Trace needs to be updated as well. On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez v2: remove unnecessary returns Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák ---

Re: [Mesa-dev] [PATCH 21/24] mesa: hook up queries for NUM_TILING_TYPES and TILING_TYPES

2017-07-26 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 07/26/2017 01:47 PM, Timothy Arceri wrote: From: Andres Rodriguez These are just basic implementations. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri ---

[Mesa-dev] [Bug 101930] High memory usage in KDE

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101930 --- Comment #1 from Emil Velikov --- There was a leak introduced with bbc29393d3beaf6344c7188547b4ff61b63946ae which was be resolved by 914f11e75b8ebe8a0faab76ce25fe185ab580eee. Can you give that a try? -- You are

Re: [Mesa-dev] [PATCH 2/2] radeonsi: decrease the number of compiler threads

2017-07-26 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 25.07.2017 18:34, Marek Olšák wrote: This will also go to stable. Marek On Tue, Jul 25, 2017 at 5:36 PM, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH 14/24] gallium: introduce PIPE_CAP_MEMOBJ

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez This can be used to guard support for EXT_memory_object and related extensions. v2: update gallium docs Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 03/24] mesa: add support for memory object parameters

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy Arceri): - fix copy and paste error with error message Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri ---

Re: [Mesa-dev] [PATCH] st/mesa: also clamp and quantize per-unit lod bias

2017-07-26 Thread Nicolai Hähnle
On 25.07.2017 18:51, Samuel Pitoiset wrote: This should probably go to stable too. It's not technically a bug, but I suppose it's fine. Either way, the patch is Reviewed-by: Nicolai Hähnle Reviewed-by: Samuel Pitoiset On 07/25/2017

Re: [Mesa-dev] [PATCH 01/24] mapi: add EXT_external_objects and EXT_external_objects_fd

2017-07-26 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez Includes implementation stubs. Signed-off-by: Andres Rodriguez Acked-by: Timothy Arceri ---

Re: [Mesa-dev] [PATCH 02/24] mesa: add support for memory object creation/import/delete

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez Used by EXT_external_objects and EXT_external_objects_fd V2 (Timothy Arceri): - Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT() fails. - C99 tidy ups - remove void cast (Constantine

Re: [Mesa-dev] [PATCH] st/mesa: fix unconditional return in st_framebuffer_iface_remove

2017-07-26 Thread Nicolai Hähnle
On 25.07.2017 18:30, Marek Olšák wrote: From: Marek Olšák Cc: 17.2 --- src/mesa/state_tracker/st_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c

Re: [Mesa-dev] [PATCH 07/24] mesa: hook up memory object multisamples tex(ture)storage api

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/externalobjects.c | 52 src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH 18/24] mesa: hook up UUID queries for driver and device

2017-07-26 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez v2: respective changes for new gallium interface v3: fix UUID size asserts Signed-off-by: Andres Rodriguez Reviewed-by:

[Mesa-dev] [Bug 101930] High memory usage in KDE

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101930 Bug ID: 101930 Summary: High memory usage in KDE Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

2017-07-26 Thread Nicolai Hähnle
On 25.07.2017 17:39, Marek Olšák wrote: From: Marek Olšák This fixes the black Feral launcher window. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- src/mesa/state_tracker/st_manager.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] radv: force compute flush at end of command stream.

2017-07-26 Thread Nicolai Hähnle
On 26.07.2017 05:42, Dave Airlie wrote: From: Dave Airlie This seems like a workaround, but we don't see the bug on CIK/VI. On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.* tests, when one tests complete, the first flush at the start of the next test

Re: [Mesa-dev] [PATCH 05/24] mesa/st: start adding memory object support

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Dave Airlie v2: pass dedicated flag Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 2 +

Re: [Mesa-dev] [PATCH 06/24] mesa: hook up memoryobject tex(ture)storage api

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy Arceri): - formating fixes Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h | 9 +++

Re: [Mesa-dev] [PATCH 16/24] mesa: implement glGetUnsignedByte{v|i_v}

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez These are used by EXT_external_objects to present UUIDs for the device and the driver. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri ---

Re: [Mesa-dev] [PATCH 13/24] mesa: hook up (Named)BufferStorageMem api

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: Include no_error variants as well. v2 (Timothy Arceri): - reduced code churn by squashing some changes into previous commits Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri ---

Re: [Mesa-dev] [PATCH 15/24] mesa/st: expose EXT_memory_object and EXT_memory_object_fd

2017-07-26 Thread Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote: From: Andres Rodriguez v2: use PIPE_CAP_MEMOBJ to guard the extension Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/extensions_table.h | 2

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-26 Thread Rob Herring
On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang wrote: > 2017-07-26 1:24 GMT+08:00 Rob Herring : >> On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov >> wrote: >>> On 25 July 2017 at 03:46, Chih-Wei Huang

Re: [Mesa-dev] [PATCH] st/mesa: also clamp and quantize per-unit lod bias

2017-07-26 Thread Nicolai Hähnle
On 25.07.2017 18:51, Samuel Pitoiset wrote: This should probably go to stable too. It's not strictly a bug fix, but I guess it's small enough for 17.2. Reviewed-by: Nicolai Hähnle Reviewed-by: Samuel Pitoiset On 07/25/2017 05:36 PM,

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Samuel Pitoiset
Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (especially for bisecting) Can you double check? - I don't see any piglit tests... or did I

[Mesa-dev] [Bug 101930] High memory usage in KDE

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101930 --- Comment #2 from network...@rkmail.ru --- (In reply to Emil Velikov from comment #1) > There was a leak introduced with bbc29393d3beaf6344c7188547b4ff61b63946ae > which was be resolved by 914f11e75b8ebe8a0faab76ce25fe185ab580eee. > > Can you

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Nicolai Hähnle
On 26.07.2017 19:42, Marek Olšák wrote: On Wed, Jul 26, 2017 at 7:05 PM, Alex Deucher wrote: On Wed, Jul 26, 2017 at 8:15 AM, Nicolai Hähnle wrote: On 26.07.2017 08:29, Michel Dänzer wrote: On 25/07/17 05:28 PM, Nicolai Hähnle wrote: On

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-07-26 Thread Zhang, Boyuan
The code looks good to me. I also did a few local vaapi-enc tests and confirmed that patch works fine. Regards, Boyuan -Original Message- From: Liu, Leo Sent: July-26-17 12:01 PM To: Andy Furniss; Koenig, Christian; Julien Isorce; mesa-dev@lists.freedesktop.org; Zhang, Boyuan Subject:

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-07-26 Thread Christian König
So that means Reviewed-and-tested-by: Zhang, Boyuan ? Christian. Am 26.07.2017 um 20:29 schrieb Zhang, Boyuan: The code looks good to me. I also did a few local vaapi-enc tests and confirmed that patch works fine. Regards, Boyuan -Original Message- From: Liu,

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Jason Ekstrand
On July 26, 2017 8:48:18 AM Samuel Pitoiset wrote: Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (especially for

[Mesa-dev] [Bug 101933] autotools: wayland-protocols used even if not found

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101933 --- Comment #1 from Martin Peres --- Indeed, we stumbled on this yesterday but got distracted with something else. Thanks for reporting the issue Dylan! -- You are receiving this mail because: You are the assignee for

[Mesa-dev] i965/miptree: Rework import offsets

2017-07-26 Thread Topi Pohjolainen
Offsets to tiled images consist of two parts: tile offset and intra-tile x,y coordinates giving the start position within the tile. Until now these have been split into different parts of miptree: intel_mipmap_tree::offset giving the tile offset and intel_mipmap_tree::level[0].level_x/y giving

[Mesa-dev] [PATCH 5/6] i965/blit: Let _intratile_offset_el() resolve image offset

2017-07-26 Thread Topi Pohjolainen
Image offset is really a triple: aligned byte offset, intra-tile x and intra-tile y. Taking intra-tile offsets into account in the caller side of emit_miptree_blit() and then applying tile-aligned byte offset in emit_miptree_blit() is confusing. Now both are handled in single location:

[Mesa-dev] [PATCH 4/6] i965/miptree: Use isl instead of local offset calculator

2017-07-26 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c| 20 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 38 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 --- 3 files changed, 19

[Mesa-dev] [PATCH 1/6] i965/miptree: Take import tile offset along with intra-tile x, y

2017-07-26 Thread Topi Pohjolainen
Imported miptrees represent single images in buffer objects that themselves may contain multiple images (full mipmaps or arrays). In such case there may be an offset which consists of pointer to a tile and x,y coordinates giving the start position within that tile. Until now callers got only the

[Mesa-dev] [PATCH 6/6] i965/miptree: Use isl_image_offset

2017-07-26 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c| 2 +- src/mesa/drivers/dri/i965/brw_context.c | 1 - src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 49

[Mesa-dev] [PATCH 3/6] i965/miptree: Use isl_image_offset in get_tile_offsets()

2017-07-26 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 54 ++-- src/mesa/drivers/dri/i965/intel_fbo.h| 14 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 28 ++--

[Mesa-dev] [PATCH 2/6] intel/isl: Introduce tiled image offset

2017-07-26 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/intel/blorp/blorp_blit.c | 19 -- src/intel/isl/isl.c| 44 +++ src/intel/isl/isl.h| 29 +++--

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

2017-07-26 Thread Jason Ekstrand
On July 25, 2017 8:16:42 PM "Mun, Gwan-gyeong" wrote: Hi Jason, You are right, as you commented, compilers can eliminate these redundancies easy. However I think we don't need to generate redundant codes. The approach we generally take with generators like this is to not

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

2017-07-26 Thread Emil Velikov
On 25 July 2017 at 16:39, Marek Olšák wrote: > From: Marek Olšák > > This fixes the black Feral launcher window. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 Marek, as you get to push this/similar patch please don't forget the

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-07-26 Thread Leo Liu
On 07/25/2017 06:04 PM, Andy Furniss wrote: Christian König wrote: Leo and Boyuan can you take a quick look as well? On first glance looks totally sane to me. This reminds me . I don't know what's special about my setup, but I haven't been able to use gst + vce properly since March.

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

2017-07-26 Thread Marek Olšák
On Wed, Jul 26, 2017 at 4:00 PM, Nicolai Hähnle wrote: > On 25.07.2017 17:39, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This fixes the black Feral launcher window. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 >> --- >>

[Mesa-dev] [Bug 101933] autotools: wayland-protocols used even if not found

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101933 Bug ID: 101933 Summary: autotools: wayland-protocols used even if not found Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Alex Deucher
On Wed, Jul 26, 2017 at 8:15 AM, Nicolai Hähnle wrote: > On 26.07.2017 08:29, Michel Dänzer wrote: >> >> On 25/07/17 05:28 PM, Nicolai Hähnle wrote: >>> >>> On 22.07.2017 14:00, Daniel Stone wrote: I don't have any great solution off the top of my head, but I'd

Re: [Mesa-dev] [PATCH 1/3] i965: Expose get_num_logical_layers outside of intel_mipmap_tree.c.

2017-07-26 Thread Lionel Landwerlin
Patches 1 & 2 are : Reviewed-by: Lionel Landwerlin I'm not knowledgeable enough for the last one :( On 26/07/17 00:34, Kenneth Graunke wrote: I want to use it in brw_clear.c. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 +-

Re: [Mesa-dev] [PATCH] radv: force compute flush at end of command stream.

2017-07-26 Thread Dave Airlie
On 27 July 2017 at 00:06, Nicolai Hähnle wrote: > On 26.07.2017 05:42, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This seems like a workaround, but we don't see the bug on CIK/VI. >> >> On SI with the

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2017-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 98239, which changed state. Bug 98239 Summary: saints row 3: performance is limited by flushes https://bugs.freedesktop.org/show_bug.cgi?id=98239 What|Removed |Added

  1   2   >