Re: [Mesa-dev] [PATCH] gallium/util: add new module that allocate "numbers"

2017-08-09 Thread Nicolai Hähnle
On 08.08.2017 18:57, Samuel Pitoiset wrote: Will be used for allocating bindless descriptor slots for RadeonSI. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_idalloc.h | 103

[Mesa-dev] [PATCH 4/7] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

2017-08-09 Thread Eric Anholt
I've been trying to get away without these conditionals in vc4, but it meant compiling extra unused code on x86, and build failing on ARMv6. --- Android.common.mk | 8 configure.ac | 24 2 files changed, 32 insertions(+) diff --git a/Android.common.mk

[Mesa-dev] [PATCH 6/7] broadcom/vc4: Port NEON-code to ARM64

2017-08-09 Thread Eric Anholt
From: Jonas Pfeil Changed all register and instruction names, works the same. v2: Rebase on build system changes (by anholt) Signed-off-by: Jonas Pfeil --- src/gallium/drivers/vc4/vc4_tiling_lt.c | 84 + 1 file changed, 84

[Mesa-dev] [PATCH 1/7] broadcom: Add missing libexpat cflags for the decoder.

2017-08-09 Thread Eric Anholt
The Raspbian ARMv6 cross compiler wasn't picking up my (amd64) system copy of the header the way that the system gcc and armhf cross-compile did. --- src/broadcom/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/broadcom/Makefile.am b/src/broadcom/Makefile.am index

[Mesa-dev] [PATCH 2/7] broadcom: Add v3d_xml.h to gitignore.

2017-08-09 Thread Eric Anholt
--- src/broadcom/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/src/broadcom/.gitignore b/src/broadcom/.gitignore index fcc603f0cf01..5442872127e1 100644 --- a/src/broadcom/.gitignore +++ b/src/broadcom/.gitignore @@ -1 +1,2 @@ +cle/v3d_xml.h cle/*_pack.h -- 2.13.3

[Mesa-dev] [PATCH 7/7] broadcom/vc4: Optimize vc4_load_utile/vc4_store_utile with sse for x86

2017-08-09 Thread Eric Anholt
From: Maxim Maslov Mesa vc4 drivers can be built for x86 in order to run hw accelerated graphics inside virtual machines (QEMU, Exagear) on Raspberry Pi. Improves playing intro videos on Diablo II inside Exagear to take 11% of CPU instead of 20%. v2: Runtime CPU detection

[Mesa-dev] [PATCH 5/7] broadcom/vc4: Build the vc4_tiling_lt_neon.c with -mfpu=neon on ARM.

2017-08-09 Thread Eric Anholt
If you don't pass this, the compiler refuses to compile the assembly for pre-v7 CPUs. This also keeps us from building identical, non-NEON code on aarch64 and x86. Fixes: a373f77662c5 ("vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.") --- src/gallium/drivers/vc4/Android.mk

[Mesa-dev] [PATCH 0/7] old-glibc backport, vc4 NEON improvements

2017-08-09 Thread Eric Anholt
I was trying to build Mesa with NEON support for Raspbian wheezy (gross), and found a couple of easy fixes. I'm hoping for an ack here on configure.ac/DEFINES changes and an Android test. Branch available at: https://github.com/anholt/mesa/commits/vc4-neon Eric Anholt (5): broadcom: Add

[Mesa-dev] [PATCH 3/7] util: Fix build on old glibc.

2017-08-09 Thread Eric Anholt
We need to link librt for u_thread.h's clock_gettime() call. Fixes: b822d9dd67b5 ("gallium/util: move u_queue.{c,h} to src/util") --- src/util/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/Makefile.am b/src/util/Makefile.am index

Re: [Mesa-dev] [PATCH 10/25] i965: Use separate enums for register vs immediate types

2017-08-09 Thread Matt Turner
On Tue, Aug 8, 2017 at 4:25 PM, Scott D Phillips wrote: >> + [BRW_HW_IMM_TYPE_UV] = 2, >> + [BRW_HW_IMM_TYPE_VF] = 4, >> + [BRW_HW_IMM_TYPE_V] = 2, > > Is this right? I see it was there before, and perhaps I'm being dense, > but it seems

[Mesa-dev] [PATCH] build: Fix up spirv_info.Plo

2017-08-09 Thread Matt Turner
spirv_info.c existed as a static file until commit 2dd4e2ece32f began generating it as part of the build process. autotools is incapable of coping, and so a build-tree from before this commit would then fail with it: [4]: *** No rule to make target

Re: [Mesa-dev] [PATCH 10/25] i965: Use separate enums for register vs immediate types

2017-08-09 Thread Scott D Phillips
Matt Turner writes: > On Tue, Aug 8, 2017 at 4:25 PM, Scott D Phillips > wrote: >>> + [BRW_HW_IMM_TYPE_UV] = 2, >>> + [BRW_HW_IMM_TYPE_VF] = 4, >>> + [BRW_HW_IMM_TYPE_V] = 2, >> >> Is this right? I see it was there

Re: [Mesa-dev] [PATCH v5 01/12] gallium: move pipe_screen destroy into pipe-loader

2017-08-09 Thread Marek Olšák
With Nicolai's comment addressed, patches 1-2 are: Reviewed-by: Marek Olšák Marek On Wed, Aug 9, 2017 at 6:47 PM, Nicolai Hähnle wrote: > On 08.08.2017 00:58, Rob Herring wrote: >> >> In preparation to add reference counting of pipe_screen in the >>

[Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-09 Thread Tomasz Figa
dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat) to fail due to an unexpected error and my loose interpretation of the EGL 1.5 specification

Re: [Mesa-dev] [PATCH 4/4] dri: Introduce SWAP_METHOD tokens

2017-08-09 Thread Thomas Hellstrom
On 08/10/2017 05:20 AM, Michel Dänzer wrote: On 09/08/17 06:53 PM, Thomas Hellstrom wrote: We shouldn't be using GLX tokens in the dri subsystem, so define dri SWAP_METHOD tokens and translate when necessary. Unfortunately the X server uses the dri swap method value untranslated as the GLX

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #80 from Paviluf --- It seem that will be "fixed" soon in chromium. They will disable compositing for tooltips on Linux. I still hope that the root of the bug will be fixed in mesa.

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-09 Thread Thomas Hellstrom
On 08/10/2017 05:20 AM, Michel Dänzer wrote: On 09/08/17 06:53 PM, Thomas Hellstrom wrote: The attribMap had two entries for this attribute, and driGetConfigAttribIndex didn't return a proper value for this attribute. Fix this, and also make sure we return SWAP_UNDEFINED for single-buffer

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #44 from John --- I've just tried on amd-staging 4.12, and without the hacky patch, and it still froze the same (still heavy I/O when it did, but nothing in dmesg this time). -- You are receiving this mail

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-09 Thread Tomasz Figa
On Wed, Aug 9, 2017 at 3:17 PM, Marathe, Yogesh wrote: > Tomasz, > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Tomasz Figa >> Sent: Tuesday, August 8, 2017 7:43 AM >> To: Marathe, Yogesh

Re: [Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

2017-08-09 Thread Thomas Helland
I thought I sent out a reply to this yesterday. Apparently I was too tired to remember... I was thinking a helper function to acquire the name would be nice, but there is not that many uses, so we probably should not bother. This patch is: Reviewed-by: Thomas Helland

Re: [Mesa-dev] [PATCH 1/2] Update TextureParameter* error for incompatible texture targets

2017-08-09 Thread Iago Toral
On Tue, 2017-08-08 at 12:12 -0700, Jordan Justen wrote: > On 2017-08-06 21:18:23, Iago Toral Quiroga wrote: > > The OpenGL 4.6 specs have been updated so that GetTextureParameter* > > with a texture object with an incompatible TEXTURE_TARGET should > > now > > report INVALID_OPERATION instead of

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-09 Thread Marathe, Yogesh
Tomasz, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tomasz Figa > Sent: Tuesday, August 8, 2017 7:43 AM > To: Marathe, Yogesh > On Mon, Aug 7, 2017 at 2:19 PM, Marathe, Yogesh >

Re: [Mesa-dev] [PATCH 2/2] dri3: Swapbuffer update

2017-08-09 Thread Michel Dänzer
Hi Thomas, first of all, would it be possible to split these patches up a bit further? At least patch 1 seems to contain several logical changes, which makes it a bit difficult to review. On 08/08/17 03:48 PM, Thomas Hellstrom wrote: > Implement back-to-fake-front flips, > Fix

Re: [Mesa-dev] [PATCH 2/2] dri3: Swapbuffer update

2017-08-09 Thread Thomas Hellstrom
Hi, Michel, On 08/09/2017 08:36 AM, Michel Dänzer wrote: Hi Thomas, first of all, would it be possible to split these patches up a bit further? At least patch 1 seems to contain several logical changes, which makes it a bit difficult to review. OK. I'll try to do that. On 08/08/17 03:48

[Mesa-dev] [Bug 102030] private memory overflow in openCL

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102030 --- Comment #4 from Janpieter Sollie --- I got it running on both pocl and clover. I will attach a working version with a built_hints.txt file included, which also includes debug information to debug memory

[Mesa-dev] [Bug 102030] private memory overflow in openCL

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102030 --- Comment #5 from Janpieter Sollie --- Created attachment 133403 --> https://bugs.freedesktop.org/attachment.cgi?id=133403=edit working program source the source contains the following modifications: -use of

[Mesa-dev] [PATCH] radv: force cs/ps/l2 flush at end of command stream. (v2)

2017-08-09 Thread Dave Airlie
From: Dave Airlie This seems like a workaround, but we don't see the bug on CIK/VI. On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.* tests, when one tests complete, the first flush at the start of the next test causes a VM fault as we've destroyed the

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #46 from John --- This patch only on master worked! Congratulations Dave, this is the first time I've passed the whole benchmark! I'll try a few other applications and wait on Marko's test before closing

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #45 from Dave Airlie --- https://patchwork.freedesktop.org/series/28535/ is a replacement for the cs flush, might be worth trying on master on its own. and possibly with the hack patch on top (it might not

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #47 from Marko --- That's great news then! I'm compiling as we speak on Suse OBS, but will able to try it out only this afternoon after I get home from work. Cheers, Marko -- You are receiving this

[Mesa-dev] [PATCH 2/4] glx: Work around X servers reporting bogus values of GLX_SWAP_METHOD_OML

2017-08-09 Thread Thomas Hellstrom
Due to the recently fixed bug where dri drivers didn't report a correct __DRI_ATTRIB_SWAP_METHOD value, and the fact that X servers just forward this incorrect value (from the AIGLX dri driver) untranslated as GLX_SWAP_METHOD_OML, the latter value might be undefined when old dri AIGLX values are

[Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-09 Thread Thomas Hellstrom
The attribMap had two entries for this attribute, and driGetConfigAttribIndex didn't return a proper value for this attribute. Fix this, and also make sure we return SWAP_UNDEFINED for single-buffer configs as required by the GLX_OML_swap_method spec. Finally bump the dri core extension version

Re: [Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-09 Thread Tapani Pälli
Yeah, _eglLookupDisplay seems to return NULL indeed in this case; Reviewed-by: Tapani Pälli On 08/08/2017 05:55 PM, Emil Velikov wrote: From: Emil Velikov If we have an invalid display fed into the functions, the display lookup will

Re: [Mesa-dev] [PATCH 8/8] glsl: use ralloc_str_append() rather than ralloc_asprintf_rewrite_tail()

2017-08-09 Thread Thomas Helland
This is a nice stopgap until I get the time to finish the stringbuffer tests and get that stuff merged. I think it should get us most of the way there, which your numbers suggest. Patch 7 and patch 8 are: Reviewed-by: Thomas Helland 2017-08-09 5:34 GMT+02:00 Timothy

[Mesa-dev] [PATCH 3/4] glx: Fix swap method config matching

2017-08-09 Thread Thomas Hellstrom
Due to bugs in dri swap method reporting, neither the fbconfigs received from the server nor the value reported from driconfigs were correct. Now that's been fixed and we can enable config swapmethod matching again. Signed-off-by: Thomas Hellstrom --- src/glx/dri_common.c

[Mesa-dev] [PATCH 4/4] dri: Introduce SWAP_METHOD tokens

2017-08-09 Thread Thomas Hellstrom
We shouldn't be using GLX tokens in the dri subsystem, so define dri SWAP_METHOD tokens and translate when necessary. Unfortunately the X server uses the dri swap method value untranslated as the GLX fbconfig swapMethod, so we can't enumerate these tokens arbitrarily, but rather need to make them

[Mesa-dev] [0/4] glx/dri: Attempt to fix GLX_OML_swap_method v2

2017-08-09 Thread Thomas Hellstrom
The current implementation was suffering from the following problems: 1) The driGetConfigAttribIndex function was not returning any value for the driconfig swapMethod. 2) The X server GLX code is using the value obtained from the AIGLX dri driver driGetConfigAttribIndex to populate its GLX

Re: [Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-09 Thread Eric Engestrom
On Tuesday, 2017-08-08 15:55:36 +0100, Emil Velikov wrote: > From: Emil Velikov > > If we have an invalid display fed into the functions, the display lookup > will return NULL. Thus as we attempt to get the platform type, we'll > deref. it leading to a crash. > >

[Mesa-dev] [PATCH] i965: Put freed but busy buffer to the head of the free list

2017-08-09 Thread Chris Wilson
We treat out free list as a rough LRU, at the tail we have active buffers to be allocated for rendering, and at the head we have the older, inactive buffers that we can allocate for use by the CPU. At the time of freeing, we can inspect the busyness of the buffer to decide if we should place it

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-09 Thread Eric Engestrom
On Wednesday, 2017-08-09 08:35:04 +0300, Tapani Pälli wrote: > On 08/08/2017 08:07 PM, Emil Velikov wrote: > > On 8 August 2017 at 16:10, Eric Engestrom wrote: > > > On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: > > > > From: Emil Velikov

[Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

2017-08-09 Thread Daniel Stone
When using dmabuf import, make sure that the modifier is actually allowed to add planes to the base format, as implied by the comment. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 38 +++--- 1 file changed, 19

Re: [Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

2017-08-09 Thread Daniel Stone
On 8 August 2017 at 09:48, Tapani Pälli wrote: > On 08/08/2017 10:37 AM, Philipp Zabel wrote: >> On Tue, 2017-08-08 at 07:29 +0300, Tapani Pälli wrote: Since this increments plane_n, Should a check be added that the corresponding DMABufPlanFds[i] is present? >>>

Re: [Mesa-dev] [PATCH 3/3] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

2017-08-09 Thread Nicolai Hähnle
On 04.08.2017 09:25, Timothy Arceri wrote: The cloning was introduced in f81ede469910d to fixed a problem with *to fix shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we reference a builtin lead to a significant reduction in the

Re: [Mesa-dev] [PATCH 2/3] glsl: clone builtin function constants

2017-08-09 Thread Nicolai Hähnle
On 04.08.2017 09:25, Timothy Arceri wrote: f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add support for hw atomics (v2)

2017-08-09 Thread Nicolai Hähnle
Hi Dave, Thanks for the update, I prefer this. Have you considered Marek's query about pipeline-wide atomic buffers? The issue I'm thinking about is what happens when multiple shaders access the same atomic counter. In a GDS/GWS-based implementation, those accesses must map to the same

Re: [Mesa-dev] [PATCH v5 03/12] gallium: add common pipe_screen reference counting functions

2017-08-09 Thread Marek Olšák
Hi Rob, This is not enough to do screen reference counting. There are primary FDs and render node FDs, and we want to have only one pipe_screen for all kinds of FDs pointing to the same device. Imagine someone creates a pipe_screen with a render node FD, and then creates another pipe_screen with

Re: [Mesa-dev] [PATCH v5 04/12] gallium: use pipe_screen_unreference to destroy screen in debug wrappers

2017-08-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote: > Use pipe_screen_unreference as it will call pipe_screen->destroy() when > the pipe_screen is no longer referenced. > > Signed-off-by: Rob Herring > --- >

Re: [Mesa-dev] [PATCH v5 03/12] gallium: add common pipe_screen reference counting functions

2017-08-09 Thread Marek Olšák
On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote: > In order to prevent multiple pipe_screens being created in the same > process, lookup of the DRM FD and reference counting of the pipe_screen > are needed. Several implementations of this exist in various gallium >

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 1:09 PM, Kenneth Graunke wrote: > Also, silence an obnoxious finishme that started occurring for all > GL applications which use stencil after the i965 ISL conversion. > --- > src/intel/isl/isl.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-09 Thread Marek Olšák
You already know I can't accept the amdgpu part. Anyway, I don't know if it's possible to keep the radeon part of the patch, because there is some shared code you would need to keep as well. Marek On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote: > Use the common pipe_screen

Re: [Mesa-dev] [PATCH v5 03/12] gallium: add common pipe_screen reference counting functions

2017-08-09 Thread Rob Herring
On Wed, Aug 9, 2017 at 2:18 PM, Marek Olšák wrote: > Hi Rob, > > This is not enough to do screen reference counting. There are primary > FDs and render node FDs, and we want to have only one pipe_screen for > all kinds of FDs pointing to the same device. > > Imagine someone

[Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-09 Thread Kenneth Graunke
Also, silence an obnoxious finishme that started occurring for all GL applications which use stencil after the i965 ISL conversion. --- src/intel/isl/isl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

Re: [Mesa-dev] [PATCH v5 03/12] gallium: add common pipe_screen reference counting functions

2017-08-09 Thread Marek Olšák
OK. This patch is: Reviewed-by: Marek Olšák Marek On Wed, Aug 9, 2017 at 9:53 PM, Rob Herring wrote: > On Wed, Aug 9, 2017 at 2:18 PM, Marek Olšák wrote: >> Hi Rob, >> >> This is not enough to do screen reference counting. There are

Re: [Mesa-dev] [PATCH 4/7] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

2017-08-09 Thread Rob Herring
On Tue, Aug 8, 2017 at 3:19 PM, Eric Anholt wrote: > I've been trying to get away without these conditionals in vc4, but it > meant compiling extra unused code on x86, and build failing on ARMv6. > --- > Android.common.mk | 8 > configure.ac | 24

Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-09 Thread Rob Herring
On Wed, Aug 9, 2017 at 3:19 PM, Marek Olšák wrote: > You already know I can't accept the amdgpu part. You don't agree with my explanation in the other patch? > Anyway, I don't know if it's possible to keep the radeon part of the > patch, because there is some shared code you

[Mesa-dev] [PATCH] ac: fail shader compilation if libelf is replaced by an incompatible version

2017-08-09 Thread Marek Olšák
From: Marek Olšák UE4Editor has this issue. This commit prevents hangs (release build) or assertion failures (debug build). Cc: 17.2 --- src/amd/common/ac_binary.c | 12 ++-- src/amd/common/ac_binary.h

Re: [Mesa-dev] [PATCH 5/7] broadcom/vc4: Build the vc4_tiling_lt_neon.c with -mfpu=neon on ARM.

2017-08-09 Thread Rob Herring
On Tue, Aug 8, 2017 at 3:19 PM, Eric Anholt wrote: > If you don't pass this, the compiler refuses to compile the assembly for > pre-v7 CPUs. This also keeps us from building identical, non-NEON code on > aarch64 and x86. > > Fixes: a373f77662c5 ("vc4: Use a wrapper file to set

[Mesa-dev] [Bug 102123] [llvmpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102123 --- Comment #1 from Roland Scheidegger --- If that's only softpipe/llvmpipe regressing, it is most likely due to only having fake msaa support. I'm a bit surprised the test result changed, but I suppose the test previously

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-09 Thread Tapani Pälli
On 08/09/2017 12:30 PM, Eric Engestrom wrote: On Wednesday, 2017-08-09 08:35:04 +0300, Tapani Pälli wrote: On 08/08/2017 08:07 PM, Emil Velikov wrote: On 8 August 2017 at 16:10, Eric Engestrom wrote: On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH v5 01/12] gallium: move pipe_screen destroy into pipe-loader

2017-08-09 Thread Nicolai Hähnle
On 08.08.2017 00:58, Rob Herring wrote: In preparation to add reference counting of pipe_screen in the pipe-loader, pipe_loader_release needs to destroy the pipe_screen instead of state trackers. Did you miss Nine? Cheers, Nicolai Signed-off-by: Rob Herring Cc: Emil

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #48 from Marko --- It's working! Today's pull + https://patchwork.freedesktop.org/series/28535/ + kernel 4.13-rc4. Doom and Dota2 both work with no freezing. I'll test (read-play) some more later but

[Mesa-dev] [PATCH] swr/rast: [rasterizer core] fix invalid casting for calls to Interlocked* functions

2017-08-09 Thread Tim Rowley
CID: 1416243, 1416244, 1416255 CC: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 2 +- src/gallium/drivers/swr/rasterizer/core/context.h | 8 src/gallium/drivers/swr/rasterizer/core/threads.cpp | 4 ++-- 3 files changed, 7 insertions(+), 7

[Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

2017-08-09 Thread Scott D Phillips
intel_miptree_texture_aux_usage() takes an isl_format, but we are passing a mesa_format. clang warns: brw_blorp.c:305:52: warning: implicit conversion from enumeration type 'mesa_format' to different enumeration type 'enum isl_format' [-Wenum-conversion]

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

2017-08-09 Thread Jason Ekstrand
oof... Have you run this through Jenkins? It should be ok, but it will be a functional change. It's a good change, but it is a change. Also, this should probably get CCd to stable. --Jason On Wed, Aug 9, 2017 at 3:52 PM, Scott D Phillips wrote: >

Re: [Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

2017-08-09 Thread Kenneth Graunke
On Tuesday, August 8, 2017 8:34:06 PM PDT Timothy Arceri wrote: > f81ede469910d fixed a problem with shaders including IR that was > owned by builtins. However the approach of cloning the whole > function each time we referenced it lead to a significant > reduction in the GLSL IR compiler

Re: [Mesa-dev] [PATCH] ac: fail shader compilation if libelf is replaced by an incompatible version

2017-08-09 Thread Michel Dänzer
On 10/08/17 05:34 AM, Marek Olšák wrote: > From: Marek Olšák > > UE4Editor has this issue. > > This commit prevents hangs (release build) or assertion failures (debug > build). > > Cc: 17.2 Can't this go to 17.1, assuming there will be

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-09 Thread Michel Dänzer
On 09/08/17 06:53 PM, Thomas Hellstrom wrote: > The attribMap had two entries for this attribute, and > driGetConfigAttribIndex didn't return a proper value for this attribute. > Fix this, and also make sure we return SWAP_UNDEFINED for single-buffer > configs as required by the

Re: [Mesa-dev] [PATCH 4/4] dri: Introduce SWAP_METHOD tokens

2017-08-09 Thread Michel Dänzer
On 09/08/17 06:53 PM, Thomas Hellstrom wrote: > We shouldn't be using GLX tokens in the dri subsystem, so define dri > SWAP_METHOD tokens and translate when necessary. Unfortunately the X server > uses the dri swap method value untranslated as the GLX fbconfig swapMethod, > so we can't enumerate

Re: [Mesa-dev] [PATCH 2/2] dri3: Swapbuffer update

2017-08-09 Thread Michel Dänzer
On 09/08/17 04:07 PM, Thomas Hellstrom wrote: > On 08/09/2017 08:36 AM, Michel Dänzer wrote: >> On 08/08/17 03:48 PM, Thomas Hellstrom wrote: >>> Implement back-to-fake-front flips, Fix EGL_BUFFER_PRESERVED >>> path. Implement dri3 support for GLX_SWAP_EXCHANGE_OML and >>> GLX_SWAP_COPY_OML. >>>

Re: [Mesa-dev] [PATCH 8/8] clover/llvm: Make __OPENCL_VERSION__ dynamic

2017-08-09 Thread Aaron Watry
On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote: > On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote: >> Signed-off-by: Aaron Watry >> CC: Jan Vesely >> >> v2: base it on the device version >> --- >>

Re: [Mesa-dev] [PATCH v2 0/2] glsl: interpolateAt*() fixes

2017-08-09 Thread Nicolai Hähnle
Thanks, Timothy. I'm going to make a respin that relaxes the rules only in desktop GL for now, and I guess we should separately raise this with the GLES WG. Cheers, Nicolai On 09.08.2017 02:30, Timothy Arceri wrote: Hi Nicolai, I put this series through Intels CI system and it hit a couple

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-08-09 Thread Lionel Landwerlin
Acked-by: Lionel Landwerlin I can see that it fixes the tests and it makes sense, but I'm failing to see how gl_attrib_wa_flags ends up being set from anv :/ Thanks a lot! On 21/07/17 09:26, Iago Toral Quiroga wrote: Mesa will map user defined vertex input

[Mesa-dev] [PATCH] radeonsi: update non-resident bindless descriptors if needed

2017-08-09 Thread Samuel Pitoiset
Only resident bindless descriptors are currently updated and re-uploaded, this makes sure that the non-resident ones are also updated. Signed-off-by: Samuel Pitoiset Cc: "17.2" --- src/gallium/drivers/radeonsi/si_descriptors.c | 85

Re: [Mesa-dev] [PATCH] st/dri2: fix kms_swrast driconf option handling

2017-08-09 Thread Nicolai Hähnle
On 08.08.2017 19:07, Rob Herring wrote: On Tue, Aug 8, 2017 at 11:56 AM, Ilia Mirkin wrote: On Tue, Aug 8, 2017 at 12:50 PM, Rob Herring wrote: Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader") moved the option cache to the

[Mesa-dev] [Bug 102030] private memory overflow in openCL

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102030 Janpieter Sollie changed: What|Removed |Added Resolution|--- |WONTFIX

[Mesa-dev] [Bug 102030] private memory overflow in openCL

2017-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102030 Jan Vesely changed: What|Removed |Added Resolution|WONTFIX |INVALID -- You

Re: [Mesa-dev] [0/4] glx/dri: Attempt to fix GLX_OML_swap_method v2

2017-08-09 Thread Brian Paul
Hi Thomas, The series looks good to me. One formatting nit: in one of the patches there's unneeded space around the conditional in some the "if (" code. Reviewed-by: Brian Paul On Wed, Aug 9, 2017 at 3:53 AM, Thomas Hellstrom wrote: > The current