That way, most of the debug code will be at the same place.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_debug.c | 26 +-
src/amd/vulkan/radv_debug.h | 3 ++-
src/amd/vulkan/radv_device.c | 11 +--
3 files changed, 28
For radv, in order to report VM faults when detected.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_debug.c | 109
src/amd/common/ac_debug.h | 4 ++
src/gallium/drivers/radeonsi/si_debug.c | 106
It's fairly simple for now, but this might be quite useful.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_debug.c | 13 +
src/amd/vulkan/radv_private.h | 3 +++
2 files changed, 16 insertions(+)
diff --git a/src/amd/vulkan/radv_debug.c
Otherwise radv_cmd_state_setup_attachments() will complain it has no
clearvalues,
when called via radv_process_depth_image_inplace().
v2: use LOAD/STORE instead of DONT_CARE, to preserve stencil values.
Signed-off-by: Xavier Bouchoux
---
Signed-off-by: Tapani Pälli
---
Android.common.mk | 3 ++
include/vulkan/vulkan_intel.h | 12 +
src/intel/Android.vulkan.mk | 4 +-
src/intel/Makefile.sources | 3 ++
src/intel/vulkan/anv_entrypoints_gen.py |
Hi;
Here's a rebased and fixed version of VK_ANDROID_native_buffer
extension implementation. I did a initial implementation of this
around 7 months ago here:
https://github.com/tpalli/external-mesa/tree/vulkan
For a number of reasons we decided for that code to live in our
Vulkan HAL
Reviewed-by: Marek Olšák
Marek
On Thu, Aug 31, 2017 at 11:43 AM, Samuel Pitoiset
wrote:
> For radv, in order to report VM faults when detected.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_debug.c
https://bugs.freedesktop.org/show_bug.cgi?id=102488
Bug ID: 102488
Summary: radv_handle_depth_image_transition() wrongly clearing
depth data when transitioning to htile.
Product: Mesa
Version: git
Hardware: Other
The sixth release candidate for Mesa 17.2.0 is now available.
Promotion to Mesa 17.2.0 (final) will happen in approximately 48 hours and
only crucial fixes will be accepted at this point.
Further fixes will have to wait for the 17.2.1 release.
Bas Nieuwenhuizen (5):
ac/nir: Cast sources
Just a quick update with 2 changes :
- I forgot to update the configs to register listing (some
registers are left to be programmed by the configs, not the
kernel anymore) in patch 3
- adding Coffeelake support (patch 7)
Cheers,
Lionel Landwerlin (7):
i965: perf: make
When making configs loadable from userspace in the kernel, we left to
userspace more responsability around programming some registers. In
particular one register we use to set directly in the driver has now
been moved into the configs.
Signed-off-by: Lionel Landwerlin
Signed-off-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_oa.py | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_oa.py
b/src/mesa/drivers/dri/i965/brw_oa.py
index
This provides a good way to verify we haven't broken using the perf
driver on older kernels (which don't have the oa config loading
mechanism).
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_debug.c | 1 +
This allows us to deploy new configurations without touching the
kernel.
v2: Detect loadable configs without creating one (Chris)
Signed-off-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_performance_query.c | 98 ++-
1 file changed,
This will be used in the next commit to build up register programming.
Signed-off-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_context.h | 1 +
src/mesa/drivers/dri/i965/brw_oa.py | 1 +
Signed-off-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_context.h | 15 ++
src/mesa/drivers/dri/i965/brw_oa.py | 51 +
2 files changed, 66 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
On Thursday, 2017-08-31 00:24:04 -0400, Louis-Francis Ratté-Boulianne wrote:
> From: Chad Versace
>
> Like anv_get_format(), but the returned format is not adjusted, not even
> for the aspect.
>
> Add anv_get_raw_isl_format() too, to match anv_get_isl_format().
> ---
>
Am 01.09.2017 um 02:32 schrieb Brian Paul:
> On 08/31/2017 05:53 PM, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> I think this is what the code was meant to do, albeit as far as I can
>> tell
>> the redundant initialization some analyzers complain about should
https://bugs.freedesktop.org/show_bug.cgi?id=102454
--- Comment #2 from Laurent carlier ---
Created attachment 133909
--> https://bugs.freedesktop.org/attachment.cgi?id=133909=edit
WIP patch
Work in progress patch
--
You are receiving this mail because:
You are the
On 08/29/2017 08:44 AM, Tapani Pälli wrote:
Patch adds required functionality for extension to manage a list of
application provided callbacks and handle debug reporting from driver
and application side.
v2: remove useless helper anv_debug_report_call
add locking around callbacks list
Sure
On August 31, 2017 00:10:49 Tapani Pälli wrote:
On 08/31/2017 10:08 AM, Jason Ekstrand wrote:
VK_NULL_HANDLE?
Sure, r-b with that?
On August 30, 2017 22:52:32 Tapani Pälli wrote:
error: incompatible pointer to integer conversion
https://bugs.freedesktop.org/show_bug.cgi?id=102454
--- Comment #4 from Eric Engestrom ---
(In reply to Laurent carlier from comment #2)
> Created attachment 133909 [details] [review]
> WIP patch
>
> Work in progress patch
Your patch checks for `locale_t`, but I don't
On Thu, 2017-08-31 at 11:41 -0400, Adam Jackson wrote:
> On Thu, 2017-08-03 at 20:07 +0200, Grigori Goronzy wrote:
> > @@ -981,6 +983,8 @@ XMesaContext XMesaCreateContext( XMesaVisual v,
> > XMesaContext share_list,
> >attribs.flags |= ST_CONTEXT_FLAG_DEBUG;
> > if (contextFlags &
Glibc 2.26 has dropped xlocale.h, but the functions needed (strtod_l()
and strdof_l()) can be found in stdlib.h.
Improve the detection method to allow newer builds to still make use of
the locale-setting.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102454
Cc: Laurent Carlier
On Thu, 2017-08-03 at 20:07 +0200, Grigori Goronzy wrote:
> diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c
> b/src/gallium/state_trackers/glx/xlib/xm_api.c
> index 828253b..508db5c 100644
> --- a/src/gallium/state_trackers/glx/xlib/xm_api.c
> +++
https://bugs.freedesktop.org/show_bug.cgi?id=102454
--- Comment #3 from Emil Velikov ---
The locale_t check does not seem like a good idea.
The struct is used by {new,free}locale API, which pulls locale.h.
Aka the struct may be available, even when strto{f,d}_l is not.
https://bugs.freedesktop.org/show_bug.cgi?id=102496
Bug ID: 102496
Summary: Frontbuffer rendering corruption on mesa master
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=102496
Bruce Cherniak changed:
What|Removed |Added
Keywords||bisected,
We can drop the meaningless "64" suffix - libdrm_intel originally had
an "offset" field that was an "unsigned long" which was the wrong size,
and we couldn't remove/alter that field without breaking ABI, so we had
to add a uint64_t "offset64" field.
"presumed_offset" is a bit more descriptive
This is dead code and hasn't been used in a long time.
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 +-
src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 +--
src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git
It's used in exactly one place these days, and not much simpler than
just calling intel_batchbuffer_data directly.
---
src/mesa/drivers/dri/i965/brw_state.h | 3 ---
src/mesa/drivers/dri/i965/brw_urb.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git
intel_batchbuffer_reset calls add_exec_bo on the batch right away,
which adds in the batch BO size.
Fixes: 29ba502a4e28 ("i965: Use I915_EXEC_BATCH_FIRST when available.")
---
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Here are some misc.
Reviewed-by: Bas Nieuwenhuizen
On Wed, Aug 30, 2017, at 15:12, Samuel Pitoiset wrote:
> Ported from RadeonSI (original patch by Marek).
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 13 -
> 1 file
Reviewed-by: Brian Paul
On 08/30/2017 11:20 PM, Charmaine Lee wrote:
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
On Wed, Aug 30, 2017, at 14:59, Ilia Mirkin wrote:
> On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
> wrote:
> > So as a random drive-by review, I think the risk in this implementation
> > is that apps just set maxdrawcount to some high value . If I'm reading
> >
On Thu, 2017-08-03 at 20:07 +0200, Grigori Goronzy wrote:
> @@ -592,4 +601,45 @@ dri2_convert_glx_attribs(unsigned num_attribs, const
> uint32_t *attribs,
> return true;
> }
>
> +_X_HIDDEN bool
> +dri2_check_no_error(uint32_t flags, struct glx_context *share_context,
> +
On Thu, Aug 31, 2017 at 1:45 PM, Bas Nieuwenhuizen
wrote:
>
>
> On Wed, Aug 30, 2017, at 14:59, Ilia Mirkin wrote:
>> On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
>> wrote:
>> > So as a random drive-by review, I think the risk in this
On Thu, Aug 31, 2017 at 11:54 AM, Eric Engestrom
wrote:
> Glibc 2.26 has dropped xlocale.h, but the functions needed (strtod_l()
> and strdof_l()) can be found in stdlib.h.
> Improve the detection method to allow newer builds to still make use of
> the locale-setting.
>
It's only used in one file.
---
src/mesa/drivers/dri/i965/brw_context.h | 1 -
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/mesa/drivers/dri/i965/brw_context.h
index
This fixes some crashes in the dEQP-VK.memory.requirements.core.* tests.
I'm not sure whether or not passing out-of-bound formats into the query
is supposed to be allowed but there's no harm in protecting ourselves
from it.
Bugzilla: https://bugs.freedesktop.org/101956
Cc:
Reviewed-by: Bas Nieuwenhuizen
On Mon, Aug 28, 2017, at 12:17, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
This series is
Reviewed-by: Bas Nieuwenhuizen
On Wed, Aug 30, 2017, at 15:12, Samuel Pitoiset wrote:
> This introduces a new separate option because the output can
> be quite verbose. If spirv-dis is not found in the path, this
> debug option is useless.
>
>
This series is:
Reviewed-by: Bas Nieuwenhuizen
Awesome to see this implemented!
On Thu, Aug 31, 2017, at 11:44, Samuel Pitoiset wrote:
> It's fairly simple for now, but this might be quite useful.
>
> Signed-off-by: Samuel Pitoiset
> ---
>
The automatic exec size inference can accidentally mess things up if
we're not careful. For instance, if we have
add(4)g38.2<4>Dg38.1<8,2,4>Dg38.2<8,2,4>D
then the destination register will end up having a width of 2 with a
horizontal stride of 4 and a vertical stride of 8. The EU
We have had a feature in codegen for some time that tries to
automatically infer the execution size of an instruction from the width
of its destination. For things such as fixed function GS, clipper, and
SF programs, this is very useful because they tend to have lots of
hand-rolled register setup
There doesn't seem to be a good reason for using EXECUTE_2 for JMPI and
brw_fs_generator manually stomps it to 1. This is a functional change
because it changes all of the clip and SF programs on gen4-5 to use
EXECUTE_1 for JMPI. Piglit says that this is ok.
---
src/intel/compiler/brw_eu_emit.c
---
src/intel/compiler/brw_fs.cpp | 2 +-
src/intel/compiler/brw_fs_generator.cpp | 8
src/intel/compiler/brw_fs_visitor.cpp | 7 +++
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index
---
src/intel/compiler/brw_eu_emit.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c
index 0e36544..7ed4fb8 100644
--- a/src/intel/compiler/brw_eu_emit.c
+++ b/src/intel/compiler/brw_eu_emit.c
@@ -1976,6 +1976,7 @@
Reviewed-by: Lionel Landwerlin
On 31/08/17 22:10, Jason Ekstrand wrote:
This fixes some crashes in the dEQP-VK.memory.requirements.core.* tests.
I'm not sure whether or not passing out-of-bound formats into the query
is supposed to be allowed but there's no harm
On Thu, Aug 31, 2017 at 2:25 PM, Jason Ekstrand wrote:
> There doesn't seem to be a good reason for using EXECUTE_2 for JMPI and
> brw_fs_generator manually stomps it to 1. This is a functional change
> because it changes all of the clip and SF programs on gen4-5 to use
>
From: Roland Scheidegger
I think this is what the code was meant to do, albeit as far as I can tell
the redundant initialization some analyzers complain about should work as
well just fine (only the first layer will be used, if the view contains one
or more layers doesn't
On 08/31/2017 05:53 PM, srol...@vmware.com wrote:
From: Roland Scheidegger
I think this is what the code was meant to do, albeit as far as I can tell
the redundant initialization some analyzers complain about should work as
well just fine (only the first layer will be used,
CentOS 6 and RHEL 6 have autoconf 2.63.
Fixes: e4b2b69e828c ("configure: Add and use AX_CHECK_COMPILE_FLAG")
Signed-off-by: Vinson Lee
---
m4/ax_check_compile_flag.m4 | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Reviewed-by: Matt Turner
I checked the revision history of this, and it changed between #serial
3 and 4 with a commit message saying it was "Modernizing" it [1]. Not
compelling enough.
[1]
https://bugs.freedesktop.org/show_bug.cgi?id=102502
Bug ID: 102502
Summary: [bisected] Kodi crashes since commit 707d2e8b -
gallium: fold u_trim_pipe_prim call from st/mesa to
drivers
Product: Mesa
Version: git
From: Marek Olšák
3 flags for primitive binning, 2 flags for out-of-order rasterization
(but that will be done some other time)
---
src/gallium/drivers/radeonsi/si_state.c | 17 +
src/gallium/drivers/radeonsi/si_state.h | 7 ++-
2 files changed, 23
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/drivers/radeonsi/si_state.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.h
b/src/gallium/drivers/radeonsi/si_pipe.h
index
From: Marek Olšák
This increases performance, but it was tuned for Raven, not Vega.
We don't know yet how Vega will perform, hopefully not worse.
---
src/gallium/drivers/radeon/r600_pipe_common.c | 2 +
src/gallium/drivers/radeon/r600_pipe_common.h | 2 +
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=99591
--- Comment #11 from Matias N. Goldberg ---
There is a similar ticket in
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1978
where they suggest export LD_BIND_NOW=1 and that has indeed fixed
We are looking up the execution type prior to checking how many sources
we have. This leads to looking for a type for src1 on MOV instructions
which is bogus. On BDW+, the src1 register type overlaps with the
64-bit immediate and causes us problems.
---
src/intel/compiler/brw_eu_validate.c | 6
https://bugs.freedesktop.org/show_bug.cgi?id=102502
Alexandre Demers changed:
What|Removed |Added
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=99591
--- Comment #12 from Michel Dänzer ---
This might be related to building LLVM with -DBUILD_SHARED_LIBS=ON. Does it
also happen when building LLVM with -DLLVM_BUILD_LLVM_DYLIB=ON instead?
--
You are receiving this mail
https://bugs.freedesktop.org/show_bug.cgi?id=100613
--- Comment #45 from Roland Scheidegger ---
(In reply to Ben Crocker from comment #44)
> By the way, draw-vertices-2101010 is failing across all architectures:
> X86 and PPC64LE as well as PPC64/S390x.
Yes, but this isn't
On Thu, Aug 31, 2017 at 2:18 AM, Marathe, Yogesh
wrote:
>> -Original Message-
>> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf
>> Of Emil Velikov
>> Sent: Wednesday, August 30, 2017 9:44 PM
>> To: Marathe, Yogesh
Tomasz,
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf
> Of Tomasz Figa
> Sent: Friday, September 1, 2017 9:53 AM
> To: Marathe, Yogesh
> Cc: Gao, Shuo ; Liu, Zhiquan ;
>
I'm not familiar with this driver so I'll give this an
Acked-by: Brian Paul
Roland gave me his R-b for the state tracker patch off-list.
I'll commit that and you can take care of this one. Feel free to close
the bug then.
-Brian
On 08/25/2017 01:59 PM, Bruce Cherniak
https://bugs.freedesktop.org/show_bug.cgi?id=102125
Brian Paul changed:
What|Removed |Added
Resolution|--- |FIXED
VK_NULL_HANDLE?
On August 30, 2017 22:52:32 Tapani Pälli wrote:
error: incompatible pointer to integer conversion initializing 'VkFence'
(aka 'unsigned long long') with an expression of type 'void *'
[-Werror,-Wint-conversion]
Signed-off-by: Tapani Pälli
Reviewed-by: Samuel Iglesias Gonsálvez
On Thu, 2017-08-31 at 08:52 +0300, Tapani Pälli wrote:
> error: incompatible pointer to integer conversion initializing
> 'VkFence'
> (aka 'unsigned long long') with an expression of type 'void *' [-
> Werror,-Wint-conversion]
>
>
On 08/31/2017 10:08 AM, Jason Ekstrand wrote:
VK_NULL_HANDLE?
Sure, r-b with that?
On August 30, 2017 22:52:32 Tapani Pälli wrote:
error: incompatible pointer to integer conversion initializing 'VkFence'
(aka 'unsigned long long') with an expression of type
71 matches
Mail list logo