[Mesa-dev] [Bug 102516] regression on glsl shaders on BE architecture mesa-17.2.0-rc6

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102516 --- Comment #3 from intermedi...@hotmail.com --- hi emil i can try but im not the best to this things . if you gave me an hand step by step i can try. for sure the issue come after rc4 that was for sure the last i was

[Mesa-dev] [Bug 101832] [PATCH][regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #14 from Emil Velikov --- (In reply to Bernhard Rosenkraenzer from comment #13) > Created attachment 133894 [details] [review] > Fix > > Here's a fix... Probably should (in addition to this) catch the

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-08 Thread Emil Velikov
On 8 September 2017 at 12:06, Tapani Pälli wrote: > Hi; > > Won't comment on the algorithm itself but coding style should be fixed to > follow style used in the rest of the file (some documentation on style > available here: https://www.mesa3d.org/codingstyle.html). > Even

Re: [Mesa-dev] Mesa (master): mesa/st/tests: Fix classic build regressions introduced with 7be6d8fe12

2017-09-08 Thread Gert Wollny
Am Freitag, den 08.09.2017, 11:19 +0200 schrieb Nicolai Hähnle: > > > Sorry about the slip-up, I thought you were building with both > patches. In any case, I made sure to test with the Travis build, so > it should be all good (not a guarantee of course, but it has pretty > good coverage).

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

2017-09-08 Thread Emil Velikov
On 7 September 2017 at 19:21, Kyle Brenneman wrote: > On 09/07/2017 11:56 AM, Emil Velikov wrote: >> >> On 7 September 2017 at 18:36, Kyle Brenneman >> wrote: >>> >>> On 09/07/2017 10:03 AM, Emil Velikov wrote: From: Emil Velikov

Re: [Mesa-dev] [PATCH 1/2] radv: add radv_vertex_elements data structure

2017-09-08 Thread Samuel Pitoiset
On 09/08/2017 03:31 PM, Bas Nieuwenhuizen wrote: On Fri, Sep 8, 2017 at 3:14 PM, Samuel Pitoiset wrote: In my opinion, this improves code readability. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 17

Re: [Mesa-dev] [PATCH 2/2] radv: do not update vertex descriptors if the allocation failed

2017-09-08 Thread Bas Nieuwenhuizen
While this is a fix, I'm not sure if it is a fix we want without more fixes. If we end up not finishing the flush_state, we could end up emitting a draw packet without having emitted the shader which sounds susceptible to hangs to me. On Fri, Sep 8, 2017 at 3:15 PM, Samuel Pitoiset

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-08 Thread Timothy Arceri
On 08/09/17 18:59, Kenneth Graunke wrote: On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: Hello together! Recently, we had a small discussion (off the list) about the NIR serialization, which was previously discussed in [RFC]

[Mesa-dev] [PATCH mesa 10/10] util/disk_cache: turn MESA_GLSL_CACHE_DISABLE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the docs and tests, use `DISABLE=true` instead of `DISABLE=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- docs/envvars.html| 2 +-

Re: [Mesa-dev] [PATCH mesa 03/10] egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean

2017-09-08 Thread Emil Velikov
Hi Eric, On 8 September 2017 at 13:40, Eric Engestrom wrote: > Instead of setting based on set/unset, allow users to use boolean values. > In the docs, use `ALWAYS=true` instead of `ALWAYS=1` as it's clearer IMO. > I'm a bit weary about this series. In the past we had

[Mesa-dev] [PATCH 1/2] radv: add radv_vertex_elements data structure

2017-09-08 Thread Samuel Pitoiset
In my opinion, this improves code readability. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 17 + src/amd/vulkan/radv_pipeline.c | 12 +++- src/amd/vulkan/radv_private.h| 15 ++- 3 files changed, 26

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-08 Thread Tapani Pälli
Hi; Won't comment on the algorithm itself but coding style should be fixed to follow style used in the rest of the file (some documentation on style available here: https://www.mesa3d.org/codingstyle.html). On 09/08/2017 11:11 AM, aravindan.muthuku...@intel.com wrote: From: Aravindan

Re: [Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

2017-09-08 Thread Chema Casanova
El 08/09/17 a las 11:06, Alejandro Piñeiro escribió: > On 08/09/17 02:50, Francisco Jerez wrote: >> Currently the liveness analysis pass would extend a live interval up >> to the top of the program when no unconditional and complete >> definition of the variable is found that dominates all of its

Re: [Mesa-dev] [PATCH 2/2] radv: do not update vertex descriptors if the allocation failed

2017-09-08 Thread Bas Nieuwenhuizen
On Fri, Sep 8, 2017 at 3:36 PM, Samuel Pitoiset wrote: > > > On 09/08/2017 03:33 PM, Bas Nieuwenhuizen wrote: >> >> While this is a fix, I'm not sure if it is a fix we want without more >> fixes. If we end up not finishing the flush_state, we could end up >> emitting a

[Mesa-dev] [PATCH mesa 01/10] gbm: turn GBM_ALWAYS_SOFTWARE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. Signed-off-by: Eric Engestrom --- src/gbm/Android.mk | 5 - src/gbm/Makefile.am| 1 + src/gbm/backends/dri/gbm_dri.c | 6 -- 3 files changed, 9 insertions(+), 3

[Mesa-dev] [PATCH mesa 04/10] glx: turn LIBGL_ALLOW_SOFTWARE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the help string, use `ALLOW=true` instead of `ALLOW=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- src/glx/apple/apple_visual.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH mesa 02/10] glx: turn LIBGL_DIAGNOSTIC into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. Signed-off-by: Eric Engestrom --- src/glx/Makefile.am | 1 + src/glx/SConscript| 1 + src/glx/apple/apple_glx_context.c | 4 +++- src/glx/apple/apple_glx_log.c

[Mesa-dev] [PATCH mesa 03/10] egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the docs, use `ALWAYS=true` instead of `ALWAYS=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- docs/envvars.html | 4 ++-- docs/releasing.html

[Mesa-dev] [PATCH mesa 00/10] make use of env_var_as_boolean()

2017-09-08 Thread Eric Engestrom
After fixing MESA_NO_ERROR=0 yesterday, I decided to have a look and do the same change with a bunch of other env vars. I also updated the docs to suggest setting true/false as it's usually clearer (what's LIBGL_DRI3_DISABLE=0? am I disabling or enabling? doesn't help that it used to do the same

[Mesa-dev] [Bug 102516] regression on glsl shaders on BE architecture mesa-17.2.0-rc6

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102516 --- Comment #4 from Eero Tamminen --- If you have a working Apitrace trace, ezBench could be used to automatically bisect which Mesa commits cause changes in rendering i.e. regresses it. ezBench is here:

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Marathe, Yogesh
Hello Folks, Sorry for late reply, I took quite some time to CTS up, comments below. > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Marathe, Yogesh > Sent: Friday, September 1, 2017 10:16 AM > To: Tomasz Figa >

[Mesa-dev] [Bug 102516] regression on glsl shaders on BE architecture mesa-17.2.0-rc6

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102516 --- Comment #2 from Emil Velikov --- Shader shown seems fine. Can you bisect mesa to track the offending commit? -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH 1/2] radv: add radv_vertex_elements data structure

2017-09-08 Thread Bas Nieuwenhuizen
On Fri, Sep 8, 2017 at 3:14 PM, Samuel Pitoiset wrote: > In my opinion, this improves code readability. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 17 + > src/amd/vulkan/radv_pipeline.c |

Re: [Mesa-dev] [PATCH 2/2] radv: do not update vertex descriptors if the allocation failed

2017-09-08 Thread Bas Nieuwenhuizen
On second thought, the application is not even supposed to submit a command buffer with an error, so we have no issues with hangs. r-b for the original patch. On Fri, Sep 8, 2017 at 3:36 PM, Samuel Pitoiset wrote: > > > On 09/08/2017 03:33 PM, Bas Nieuwenhuizen wrote:

[Mesa-dev] [PATCH mesa 06/10] egl+glx: turn LIBGL_DRI3_DISABLE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the docs, use `DISABLE=true` instead of `DISABLE=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- docs/envvars.html | 2 +- src/egl/drivers/dri2/platform_x11.c | 2

[Mesa-dev] [PATCH mesa 05/10] glx: turn LIBGL_ALWAYS_INDIRECT into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the docs, use `ALWAYS=true` instead of `ALWAYS=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- docs/envvars.html | 2 +- docs/libGL.txt| 2 +- src/glx/glxext.c | 2 +- 3 files

[Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

2017-09-08 Thread Samuel Pitoiset
when an application doesn't update the contents of a descriptor set object, it contains random values and this might end up with GPU VM faults if a shader tries to access that descriptor. The Vulkan spec doesn't state what a driver should do when a descriptor is unset, but zeroing the contents

[Mesa-dev] [PATCH mesa 08/10] glx: turn LIBGL_PROFILE_CORE into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. Signed-off-by: Eric Engestrom --- src/glx/apple/apple_visual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/apple/apple_visual.c b/src/glx/apple/apple_visual.c

[Mesa-dev] [PATCH mesa 07/10] glx: turn LIBGL_DUMP_VISUALID into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. Signed-off-by: Eric Engestrom --- src/glx/glxcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 44992f18cf..29b94b8810 100644

[Mesa-dev] [PATCH mesa 09/10] glx: turn LIBGL_NO_DRAWARRAYS into a boolean

2017-09-08 Thread Eric Engestrom
Instead of setting based on set/unset, allow users to use boolean values. In the docs, use `NO_DRAWARRAYS=true` instead of `NO_DRAWARRAYS=1` as it's clearer IMO. Signed-off-by: Eric Engestrom --- docs/envvars.html | 2 +- src/glx/indirect_glx.c | 6 +- 2

[Mesa-dev] [PATCH 2/2] radv: do not update vertex descriptors if the allocation failed

2017-09-08 Thread Samuel Pitoiset
A return code error is stored in the command buffer and should be returned to the user via EndCommandBuffer(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radv: do not update vertex descriptors if the allocation failed

2017-09-08 Thread Samuel Pitoiset
On 09/08/2017 03:33 PM, Bas Nieuwenhuizen wrote: While this is a fix, I'm not sure if it is a fix we want without more fixes. If we end up not finishing the flush_state, we could end up emitting a draw packet without having emitted the shader which sounds susceptible to hangs to me. That's

Re: [Mesa-dev] [PATCH 13/17] i965: Use a separate state buffer, but avoid changing flushing behavior.

2017-09-08 Thread Kenneth Graunke
On Wednesday, September 6, 2017 5:12:10 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 01:09:46) > > @@ -156,11 +158,14 @@ intel_batchbuffer_reset(struct intel_batchbuffer > > *batch, > > batch->map = brw_bo_map(NULL, batch->bo, MAP_READ | MAP_WRITE); > > batch->map_next

[Mesa-dev] [PATCH] radv: initialise slab_list

2017-09-08 Thread Timothy Arceri
It seems by luck master works fine but with an alternate compilation flow this is ends up causing a crash in radv_shader_variant_destroy(). --- src/amd/vulkan/radv_pipeline.c | 2 ++ src/amd/vulkan/radv_pipeline_cache.c | 1 + 2 files changed, 3 insertions(+) diff --git

[Mesa-dev] [Bug 101832] [PATCH][regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 Andreas Radke changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v2] i965/fs: Add remove_extra_rounding_modes optimization

2017-09-08 Thread Alejandro Piñeiro
On 08/09/17 01:58, Jason Ekstrand wrote: > On Tue, Aug 29, 2017 at 11:54 PM, Alejandro Piñeiro > > wrote: > > Although from SPIR-V point of view, rounding modes are attached to the > operation/destination, on i965 it is a status, so we

Re: [Mesa-dev] [PATCH 14/17] i965: Grow the batch/state buffers if we need space and can't flush.

2017-09-08 Thread Kenneth Graunke
On Wednesday, September 6, 2017 8:44:03 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 16:20:00) > > On Wednesday, September 6, 2017 3:08:44 AM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2017-09-06 01:09:47) [snip] > > > > +/* Don't exceed this - batchbuffers need to

Re: [Mesa-dev] Mesa (master): mesa/st/tests: Fix classic build regressions introduced with 7be6d8fe12

2017-09-08 Thread Nicolai Hähnle
On 08.09.2017 05:15, Michel Dänzer wrote: On 07/09/17 09:14 PM, Nicolai Hähnle wrote: Module: Mesa Branch: master Commit: ab16538b8353aadce97962b002730dd1a869dc99 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ab16538b8353aadce97962b002730dd1a869dc99 Author: Gert Wollny

Re: [Mesa-dev] [PATCH 1/2] radeonsi: set a per-buffer flag that disables inter-process sharing (v4)

2017-09-08 Thread Michel Dänzer
On 07/09/17 07:24 PM, Christian König wrote: > Am 07.09.2017 um 12:14 schrieb Marek Olšák: >> On Sep 7, 2017 12:08 PM, "Christian König" > > wrote: >> Am 07.09.2017 um 11:23 schrieb Michel Dänzer: >> On 01/09/17 07:40 PM,

Re: [Mesa-dev] [PATCH] radv: initialise slab_list

2017-09-08 Thread Samuel Pitoiset
Makes sense. Reviewed-by: Samuel Pitoiset On 09/08/2017 09:27 AM, Timothy Arceri wrote: It seems by luck master works fine but with an alternate compilation flow this is ends up causing a crash in radv_shader_variant_destroy(). --- src/amd/vulkan/radv_pipeline.c

[Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-08 Thread aravindan . muthukumar
From: Aravindan Muthukumar Avoiding the loop which was running with O(n) complexity. Now the complexity has been reduced to O(1) Tested with piglit. Slight performance improvement (~1%) in 3d mark. Change-Id: Id099f1cd24ad5b691a69070eda79b8f4e9be39a6

Re: [Mesa-dev] [PATCH] radv: initialise slab_list

2017-09-08 Thread Timothy Arceri
On 08/09/17 17:59, Bas Nieuwenhuizen wrote: On Fri, Sep 8, 2017 at 9:27 AM, Timothy Arceri wrote: It seems by luck master works fine but with an alternate compilation flow this is ends up causing a crash in radv_shader_variant_destroy(). ---

Re: [Mesa-dev] [PATCH 4/9] configure.ac: define WL_HIDE_DEPRECATED at global scale

2017-09-08 Thread Emil Velikov
On 8 September 2017 at 10:52, Pekka Paalanen wrote: > On Thu, 7 Sep 2017 19:05:01 +0100 > Emil Velikov wrote: > >> From: Emil Velikov >> >> Due to GCC feature described in previous commit, the expected >>

[Mesa-dev] [Bug 102318] Mesa3D Scons build - LLVM 5.0 not supported

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102318 --- Comment #2 from Alex Granni --- LLVM 5.0 is out: http://lists.llvm.org/pipermail/llvm-announce/2017-September/75.html -- You are receiving this mail because: You are the assignee for the bug. You are the QA

Re: [Mesa-dev] [PATCH] i965: do not fallback to linear tiling for depth/stencil surfaces

2017-09-08 Thread Kenneth Graunke
On Thursday, September 7, 2017 11:44:04 PM PDT Iago Toral Quiroga wrote: > It is not supported by the hardware and the driver assumes > W-tiling for stencil and Y-tiling for depth everywhere anyway. > > This fixes a regression in a CTS test introduced with commit > 4ea63fab77f0 that started

Re: [Mesa-dev] [PATCH] nir: put compact into bitfields in nir_variable_data

2017-09-08 Thread Kenneth Graunke
On Tuesday, September 5, 2017 8:19:57 PM PDT Dave Airlie wrote: > From: Dave Airlie > > This being declared bool means it won't get merged with the previous > bitfields, this seems like an oversight rather than deliberate. > > Noticed when running pahole. > > Signed-off-by:

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-08 Thread Kenneth Graunke
On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: > On 2017-09-06 14:12:41, Daniel Schürmann wrote: > > Hello together! > > Recently, we had a small discussion (off the list) about the NIR > > serialization, which was previously discussed in [RFC] ARB_gl_spirv and > > NIR

[Mesa-dev] [Bug 102597] [Regression] mpv, high rendering times (two to three times higher)

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102597 --- Comment #2 from Cris --- (In reply to Kenneth Graunke from comment #1) > We can't really look into this unless you tell us what hardware you're using. R9 280x, mpv git, linux 4.13. mpv-stats.lua is required to

Re: [Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

2017-09-08 Thread Alejandro Piñeiro
On 08/09/17 02:50, Francisco Jerez wrote: > Currently the liveness analysis pass would extend a live interval up > to the top of the program when no unconditional and complete > definition of the variable is found that dominates all of its uses. > > This can lead to a serious performance problem

Re: [Mesa-dev] [PATCH 17/17] i965: Disentangle batch and state buffer flushing.

2017-09-08 Thread Kenneth Graunke
On Wednesday, September 6, 2017 8:49:25 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-06 16:33:48) > > On Wednesday, September 6, 2017 5:26:10 AM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2017-09-06 01:09:50) > > > > We now flush the batch when either the batchbuffer

Re: [Mesa-dev] [PATCH] radv: Actually check for vm faults.

2017-09-08 Thread Samuel Pitoiset
I have something similar locally. :) Reviewed-by: Samuel Pitoiset On 09/07/2017 10:23 PM, Bas Nieuwenhuizen wrote: The code can check for vm faults having happened. If we only do it on a hang we don't know when the faults happened. This changes the behavior to when

Re: [Mesa-dev] [PATCH] i965: do not fallback to linear tiling for depth/stencil surfaces

2017-09-08 Thread Iago Toral
On Fri, 2017-09-08 at 00:34 -0700, Kenneth Graunke wrote: > On Thursday, September 7, 2017 11:44:04 PM PDT Iago Toral Quiroga > wrote: > > It is not supported by the hardware and the driver assumes > > W-tiling for stencil and Y-tiling for depth everywhere anyway. > > > > This fixes a regression

Re: [Mesa-dev] [PATCH] radv: initialise slab_list

2017-09-08 Thread Bas Nieuwenhuizen
On Fri, Sep 8, 2017 at 9:27 AM, Timothy Arceri wrote: > It seems by luck master works fine but with an alternate > compilation flow this is ends up causing a crash in > radv_shader_variant_destroy(). > --- > src/amd/vulkan/radv_pipeline.c | 2 ++ >

Re: [Mesa-dev] [PATCH] i965: do not fallback to linear tiling for depth/stencil surfaces

2017-09-08 Thread Pohjolainen, Topi
On Fri, Sep 08, 2017 at 09:41:11AM +0200, Iago Toral wrote: > On Fri, 2017-09-08 at 00:34 -0700, Kenneth Graunke wrote: > > On Thursday, September 7, 2017 11:44:04 PM PDT Iago Toral Quiroga > > wrote: > > > It is not supported by the hardware and the driver assumes > > > W-tiling for stencil and

Re: [Mesa-dev] [PATCH 14/17] i965: Grow the batch/state buffers if we need space and can't flush.

2017-09-08 Thread Chris Wilson
Quoting Kenneth Graunke (2017-09-08 08:19:03) > On Wednesday, September 6, 2017 8:44:03 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-09-06 16:20:00) > > > On Wednesday, September 6, 2017 3:08:44 AM PDT Chris Wilson wrote: > > > > Quoting Kenneth Graunke (2017-09-06 01:09:47) >

Re: [Mesa-dev] [PATCH] i965: do not fallback to linear tiling for depth/stencil surfaces

2017-09-08 Thread Iago Toral
On Fri, 2017-09-08 at 11:44 +0300, Pohjolainen, Topi wrote: > On Fri, Sep 08, 2017 at 09:41:11AM +0200, Iago Toral wrote: > > On Fri, 2017-09-08 at 00:34 -0700, Kenneth Graunke wrote: > > > On Thursday, September 7, 2017 11:44:04 PM PDT Iago Toral Quiroga > > > wrote: > > > > It is not supported

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-08 Thread Daniel Schürmann
The NIR->SPIRV->NIR round-trip was assumed to be completely lossless. But you are right, it would be risky to forget about some small pitfalls or to not have a total bijection. Also, it would make it much more difficult to make changes to NIR. Thanks for this really valid point. On

[Mesa-dev] [PATCH] radv: fix error code when initializing the push descriptors

2017-09-08 Thread Samuel Pitoiset
malloc() failures are unrelated to the device memory. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

Re: [Mesa-dev] [PATCH] gallivm: fix gather implementation a bit

2017-09-08 Thread Jose Fonseca
On 07/09/17 17:16, srol...@vmware.com wrote: From: Roland Scheidegger gather is defined in terms of bilinear filtering, just without the filtering part. However, there's actually some subtle differences required in our implementation, because we use some tricks to simplify

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

2017-09-08 Thread Bas Nieuwenhuizen
On Fri, Sep 8, 2017 at 4:30 PM, Samuel Pitoiset wrote: > > > On 09/08/2017 04:08 PM, Józef Kucia wrote: >> >> On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset >> wrote: >>> >>> when an application doesn't update the contents of a descriptor

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Marathe, Yogesh
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Friday, September 8, 2017 8:28 PM > To: Marathe, Yogesh > Cc: Tomasz Figa ; Antognolli, Rafael > ; Janes, Mark A

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

2017-09-08 Thread Samuel Pitoiset
On 09/08/2017 04:08 PM, Józef Kucia wrote: On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset wrote: when an application doesn't update the contents of a descriptor set object, it contains random values and this might end up with GPU VM faults if a shader tries to

Re: [Mesa-dev] [PATCH 2/2] llvmpipe, draw: improve shader cache debugging

2017-09-08 Thread Jose Fonseca
On 08/09/17 02:00, srol...@vmware.com wrote: From: Roland Scheidegger With GALLIVM_DEBUG=perf set, output the relevant stats for shader cache usage whenever we have to evict shader variants. Also add some output when shaders are deleted (but not with the perf setting to

Re: [Mesa-dev] [PATCH] radv: fix error code when initializing the push descriptors

2017-09-08 Thread Bas Nieuwenhuizen
r-b On Fri, Sep 8, 2017 at 4:09 PM, Samuel Pitoiset wrote: > malloc() failures are unrelated to the device memory. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Emil Velikov
On 8 September 2017 at 14:47, Marathe, Yogesh wrote: > Hello Folks, > > Sorry for late reply, I took quite some time to CTS up, comments below. > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Marathe,

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-08 Thread Jason Ekstrand
In general, I'm very concerned about how this handles rounding behavior. Almost everywhere, you round down when what you want to do is round up. Also, as I said on IRC, I'd like to see some asserts in add_bucket so that we are sure this calculation is correct. In particular, I'd like to see

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

2017-09-08 Thread Józef Kucia
On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset wrote: > when an application doesn't update the contents of a descriptor > set object, it contains random values and this might end up with > GPU VM faults if a shader tries to access that descriptor. > > The Vulkan spec

Re: [Mesa-dev] [PATCH mesa 03/10] egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean

2017-09-08 Thread Kenneth Graunke
On Friday, September 8, 2017 6:33:44 AM PDT Emil Velikov wrote: > Hi Eric, > > On 8 September 2017 at 13:40, Eric Engestrom > wrote: > > Instead of setting based on set/unset, allow users to use boolean values. > > In the docs, use `ALWAYS=true` instead of `ALWAYS=1`

Re: [Mesa-dev] [PATCH 4/9] configure.ac: define WL_HIDE_DEPRECATED at global scale

2017-09-08 Thread Pekka Paalanen
On Thu, 7 Sep 2017 19:05:01 +0100 Emil Velikov wrote: > From: Emil Velikov > > Due to GCC feature described in previous commit, the expected > deprecation warnings may be missing. > > Set the WL_HIDE_DEPRECATED macro which will omit the

Re: [Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

2017-09-08 Thread Connor Abbott
On Thu, Sep 7, 2017 at 9:30 PM, Jason Ekstrand wrote: > On Thu, Sep 7, 2017 at 5:50 PM, Francisco Jerez > wrote: >> >> Currently the liveness analysis pass would extend a live interval up >> to the top of the program when no unconditional and complete

[Mesa-dev] [PATCH 4/4] ac/surface: match Z and stencil tile config

2017-09-08 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes various piglit tests on Stoney, see the comment. Cc: mesa-sta...@lists.freedesktop.org --- src/amd/common/ac_surface.c | 49 ++--- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 1/4] ac/addrlib: relax an assertion

2017-09-08 Thread Nicolai Hähnle
From: Nicolai Hähnle This assertion is triggered on Stoney in Piglit ./bin/framebuffer-blit-levels {draw,read} stencil -auto -fbo and similar tests. It should be harmless -- just relax it until we can get internal clarification. --- src/amd/addrlib/r800/ciaddrlib.cpp |

[Mesa-dev] [PATCH 2/4] ac/addrlib: enable assertions in debug builds

2017-09-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/addrlib/core/addrcommon.h | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/amd/addrlib/core/addrcommon.h b/src/amd/addrlib/core/addrcommon.h index 66424a84ba9..8f5f1bfb374 100644 ---

[Mesa-dev] [PATCH 0/4] ac/surface: fix Stoney bugs by matching stencil tile

2017-09-08 Thread Nicolai Hähnle
Hi all, This series (the last patch, really) fixes a bunch of related bugs on Stoney by asking AddrLib to select a depth tiling for which there is a corresponding stencil tiling. This can lead to TC-compatible HTILE being deactivated, but it seems Stoney is one of the few (only?) chip affected,

[Mesa-dev] [PATCH 3/4] ac/surface: sanity-check that we got a TC-compatible HTILE if requested

2017-09-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 4edefc7c40a..0c24116c6ac 100644 --- a/src/amd/common/ac_surface.c +++

Re: [Mesa-dev] [PATCH 1/2] mesa: provide more info in some texture image error messages

2017-09-08 Thread Eric Anholt
Both patches are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] mesa: whitespace, formatting fixes in teximage.c

2017-09-08 Thread Brian Paul
--- src/mesa/main/teximage.c | 110 +++ 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 32ca172..d064205 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@

[Mesa-dev] [PATCH 1/2] mesa: provide more info in some texture image error messages

2017-09-08 Thread Brian Paul
--- src/mesa/main/teximage.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index e5dc469..32ca172 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -1133,7 +1133,8 @@

Re: [Mesa-dev] [PATCH mesa 03/10] egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean

2017-09-08 Thread Eric Engestrom
On Friday, 2017-09-08 08:13:54 -0700, Kenneth Graunke wrote: > On Friday, September 8, 2017 6:33:44 AM PDT Emil Velikov wrote: > > Hi Eric, > > > > On 8 September 2017 at 13:40, Eric Engestrom > > wrote: > > > Instead of setting based on set/unset, allow users to use

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Marathe, Yogesh
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Friday, September 8, 2017 11:03 PM > To: Antognolli, Rafael > >> > > Isn't this strange? Can someone please comment? > >> > > > >> > In all fairness there was a few wtf moments

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Rafael Antognolli
On Fri, Sep 08, 2017 at 08:32:05AM -0700, Marathe, Yogesh wrote: > > -Original Message- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Friday, September 8, 2017 8:28 PM > > To: Marathe, Yogesh > > Cc: Tomasz Figa ;

[Mesa-dev] [PATCH] st/glsl_to_tgsi: only the first (inner-most) array reference can be a 2D index

2017-09-08 Thread Nicolai Hähnle
From: Nicolai Hähnle Don't get distracted by record dereferences between array references. Fixes dEQP-GLES31.functional.tessellation.user_defined_io.per_vertex_block.* Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_indirect_parameters

2017-09-08 Thread Manolova, Plamena
Thank you for taking a look Jason! Sorry my bad, I'll make sure to add some comments to v2 at least. Hopefully it'll make editing this portion of the i965 drawing logic a bit easier. On Fri, Sep 8, 2017 at 4:48 AM, Jason Ekstrand wrote: > Hey Pam! > > A quick skim through

Re: [Mesa-dev] [PATCH] intel: Remove unused Kabylake pci id

2017-09-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

2017-09-08 Thread Emil Velikov
On 8 September 2017 at 17:54, Rafael Antognolli wrote: > On Fri, Sep 08, 2017 at 08:32:05AM -0700, Marathe, Yogesh wrote: >> > -Original Message- >> > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >> > Sent: Friday, September 8, 2017 8:28 PM >> > To:

[Mesa-dev] [PATCH 1/2] util: add util_vasprintf() for Windows

2017-09-08 Thread Brian Paul
We don't have vasprintf() on Windows so we need to implement it ourselves. Since we don't know the length of the final string, take a guess at 1 chars. --- src/util/u_string.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index

[Mesa-dev] [PATCH] st/mesa: don't call close() on Windows

2017-09-08 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_memoryobjects.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_memoryobjects.c b/src/mesa/state_tracker/st_cb_memoryobjects.c index a5764c3..7a43763 100644 --- a/src/mesa/state_tracker/st_cb_memoryobjects.c +++

[Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

2017-09-08 Thread Brian Paul
--- src/gallium/auxiliary/util/u_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_log.c b/src/gallium/auxiliary/util/u_log.c index 359b3e1..dacbe05 100644 --- a/src/gallium/auxiliary/util/u_log.c +++ b/src/gallium/auxiliary/util/u_log.c @@

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-08 Thread Marek Olšák
On Fri, Sep 8, 2017 at 2:09 AM, Rob Clark wrote: > On Thu, Sep 7, 2017 at 7:26 PM, Jordan Justen > wrote: >> On 2017-09-06 14:12:41, Daniel Schürmann wrote: >>> Hello together! >>> Recently, we had a small discussion (off the list) about the NIR

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: only the first (inner-most) array reference can be a 2D index

2017-09-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Sep 8, 2017 at 7:03 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Don't get distracted by record dereferences between array references. > > Fixes

Re: [Mesa-dev] [PATCH] st/mesa: don't call close() on Windows

2017-09-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Sep 9, 2017 at 12:54 AM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_memoryobjects.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/state_tracker/st_cb_memoryobjects.c >

[Mesa-dev] [Bug 102496] Frontbuffer rendering corruption on mesa master

2017-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102496 Bruce Cherniak changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

2017-09-08 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Sep 8, 2017 at 7:16 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes various piglit tests on Stoney, see the comment. > > Cc: mesa-sta...@lists.freedesktop.org >

[Mesa-dev] [ANNOUNCE] mesa 17.1.9

2017-09-08 Thread Andres Gomez
Mesa 17.1.9 is now available. In this release we have: In Mesa Core we include a fix for a rendering problem detected while using GoogleEarth with the VMware driver. The state tracker received a couples of patches, one for handling properly the vertex array double inputs and another for a

[Mesa-dev] [PATCH] i965: do not fallback to linear tiling for depth/stencil surfaces

2017-09-08 Thread Iago Toral Quiroga
It is not supported by the hardware and the driver assumes W-tiling for stencil and Y-tiling for depth everywhere anyway. This fixes a regression in a CTS test introduced with commit 4ea63fab77f0 that started applying re-tiling for these surfaces in certain scenarios. Fixes: